Author Topic: Code submission #2 (DIFF file again)  (Read 18482 times)

0 Members and 1 Guest are viewing this topic.

Offline necno

  • Core Developer
  • ******
  • Posts: 385
Re: Code submission #2 (DIFF file again)
« Reply #15 on: March 26, 2010, 05:47:00 PM »
I've noticed you created a branch in the SVN. Are you changes committed to that branch? If so I will merge anything relevant into the trunk. The reason I say relevant is that some things may be changed by the new jobs.
Click here to donate
After you do so please pm me the email address you used so I can add you to the donation forum.

Working on:
Whoremaster II (Official)
Birthright (Now a commercial rougelike)

Offline Dagoth

  • Administrator
  • *****
  • Posts: 617
Re: Code submission #2 (DIFF file again)
« Reply #16 on: March 26, 2010, 05:57:27 PM »
DocClox created that branch, but had trouble applying the patch. So the branch is currently empty, though he said he should be able to set it up by this weekend.

Offline myrikhan

  • Dev Team
  • *****
  • Posts: 23
Re: Code submission #2 (DIFF file again)
« Reply #17 on: March 26, 2010, 06:10:52 PM »
I've noticed you created a branch in the SVN. Are you changes committed to that branch? If so I will merge anything relevant into the trunk. The reason I say relevant is that some things may be changed by the new jobs.

I'm not on the dev team so I don't have write access to SVN.  The best I can do is submit a diff file here on the
boards.  If it helps, I can upload the source files (*.h *.cpp) here too. 

All of my changes are on revision 255 in the SVN repository.  I didn't do much in the job code as I knew you, the dev team, want to change it a lot.  (Catacomb exploration excepted.  It was rewritten and works now.)

Myrikhan

Offline GonDra

  • Full Member
  • ***
  • Posts: 154
Re: Code submission #2 (DIFF file again)
« Reply #18 on: March 26, 2010, 09:56:32 PM »
Ah before I forget it: if you get an error with sdl_gfx.dll or something when using my exe you will have to rename it to what he wants to have.
As I first got my hands on the Sourcecode I decided for some Armok-forsaken reason to compile that library myself...
« Last Edit: March 28, 2010, 09:45:31 AM by GonDra »

Offline Dagoth

  • Administrator
  • *****
  • Posts: 617
Re: Code submission #2 (DIFF file again)
« Reply #19 on: March 27, 2010, 12:25:36 AM »
I went ahead and updated myrikhan's branch on SVN with his diff 2 patch.

Offline fixet

  • Full Member
  • ***
  • Posts: 167
Re: Code submission #2 (DIFF file again)
« Reply #20 on: March 27, 2010, 07:09:59 AM »
Ah before I forget it: if u get an error with sdl_gfx.dll or something when using my exe you will have to rename it to what he wants to have.
As I first got my hands on the Sourcecode I decided for some Armok-forsaken reason to compile that library myself...
can you please attach your sdl_gfx.dll?
I must have downloaded a dozen builds and it always causes the .exe to crash, and I couldn't build my own to save my life

Offline GonDra

  • Full Member
  • ***
  • Posts: 154
Re: Code submission #2 (DIFF file again)
« Reply #21 on: March 27, 2010, 08:42:50 AM »
can you please attach your sdl_gfx.dll?
I must have downloaded a dozen builds and it always causes the .exe to crash, and I couldn't build my own to save my life
ok here it goes.
if the exe wants the sdl_gfx.dll just add the underscore yourself.

Offline fixet

  • Full Member
  • ***
  • Posts: 167
Re: Code submission #2 (DIFF file again)
« Reply #22 on: March 27, 2010, 11:35:10 AM »
thanks, man

Offline Uriel

  • Full Member
  • ***
  • Posts: 175
Re: Code submission #2 (DIFF file again)
« Reply #23 on: March 27, 2010, 03:25:36 PM »
How can i play with this patch? We got this compiled exe and all, what else i need to have?
Can't wait anymore, especially since i rad all the changes made by myrikhan.

And yep, i'm a newbie, you can see it in my status to the left of this message  ::)
« Last Edit: March 27, 2010, 03:31:51 PM by Uriel »

Offline sgb

  • Sr. Member
  • ****
  • Posts: 380
Re: Code submission #2 (DIFF file again)
« Reply #24 on: March 28, 2010, 03:47:58 PM »
I'm sure if they had a mostly stable release ready for the public, they'd have put it out a long time ago.  Be patient, it's been months since the devs have made such progress on the game so let them keep going while they're on a role.

Offline deimosmasque

  • Newbie
  • *
  • Posts: 2
Re: Code submission #2 (DIFF file again)
« Reply #25 on: March 29, 2010, 12:51:17 AM »
Okay I feel a little silly here as I've tried a couple times to make this work using the both provided exe files and I can't seem to get it working.  It loads up and crashes right away.

I'm using Windows Vista if that matters.

Offline LordJerle

  • Full Member
  • ***
  • Posts: 239
Re: Code submission #2 (DIFF file again)
« Reply #26 on: March 29, 2010, 08:37:35 PM »
Okay I feel a little silly here as I've tried a couple times to make this work using the both provided exe files and I can't seem to get it working.  It loads up and crashes right away.

I'm using Windows Vista if that matters.
Yes, use 7 or XP.  Vista sucks >.>

Offline delta224

  • Dev Team
  • *****
  • Posts: 577
Re: Code submission #2 (DIFF file again)
« Reply #27 on: March 29, 2010, 11:51:29 PM »
This is not a problem with vista, but most likely a dll issue.

Offline deimosmasque

  • Newbie
  • *
  • Posts: 2
Re: Code submission #2 (DIFF file again)
« Reply #28 on: March 30, 2010, 03:12:46 PM »
I did get some DLL errors at first but I found the missing dlls online and then registered them but the game is still crashing right after execution.

Offline z-master

  • Newbie
  • *
  • Posts: 14
Re: Code submission #2 (DIFF file again)
« Reply #29 on: March 30, 2010, 03:43:26 PM »
I had a crash too, but I found that it was caused by the .girlsx-files - they were 0 kb big. After I replaced them all worked properly. Maybe its the same problem with your version?