devolution

Author Topic: <-- Archived -->  (Read 113684 times)

0 Members and 3 Guests are viewing this topic.

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
When using some item:
Quote
  File "game/library/screens/pyt - screens - girlequipment.rpy", line 6, in script
  File "game/library/screens/pyt - screens - girlequipment.rpy", line 21, in python
  File "game/library/pyt - functions.rpy", line 185, in python
  File "game/library/pyt - classes.rpy", line 901, in python
  File "game/library/pyt - classes.rpy", line 1039, in python
Error: Stat: sex does not exist!
Really? You gotta be kidding me  ???

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
When using some item:Really? You gotta be kidding me  ???

Well, it does not, does it?

http://pinkpetal.org/index.php?topic=1291.msg18749;topicseen#msg18749

 ::)
« Last Edit: May 18, 2013, 02:55:51 PM by Xela »
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Ah yes, my mistake this time. Fortunately, autoreplacement will do the trick  :)

But I manage to find another mistake. Let's say we have an item with fields:
ctemp = '1'   
cmax = '29'   >
<mod charisma = '35' />
And Hinata has 30 charisma. On the next day she will have 0 charisma.

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Ah yes, my mistake this time. Fortunately, autoreplacement will do the trick  :)

But I manage to find another mistake. Let's say we have an item with fields:
ctemp = '1'   
cmax = '29'   >
<mod charisma = '35' />
And Hinata has 30 charisma. On the next day she will have 0 charisma.

Well, suggestion one would be not to make an item like that :)

It shouldn't work like that anyway, she should retain 30 charisma on the next day...

================================
Damn, I actually discovered huge structural flow in game design... I'll try to work something out. Any item raises the secondary layer of stat keeping, not a problem with equipable items, however that means that consumables do the same right now so if you keep giving her potions, stat will eventually be locked at max and never go down. I'll have to intercept effects from misc and consumable items...
« Last Edit: May 18, 2013, 03:18:50 PM by Xela »
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Well, say thanks to Booty Lube which I've used for testing cmax field  :D

Btw, how often the game refreshes the shop? Or better to say, does it refresh it at all now?
« Last Edit: May 18, 2013, 03:44:28 PM by DarkTl »

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Another typo, I guess. When eating Honeypuff Cookies (+joy and libido, adds Puffy Nipples trait):
Quote
  File "game/library/screens/pyt - screens - girlequipment.rpy", line 6, in script
  File "game/library/screens/pyt - screens - girlequipment.rpy", line 21, in python
  File "game/library/pyt - functions.rpy", line 185, in python
  File "game/library/pyt - classes.rpy", line 901, in python
  File "game/library/pyt - classes.rpy", line 1058, in python
AttributeError: 'Item' object has no attribute 'ctem'

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Well, say thanks to Booty Lube which I've used for testing cmax field  :D

Btw, how often the game refreshes the shop? Or better to say, does it refresh it at all now?

It should now... I've wrote a bit of new code for items so more testing is needed...

Another typo, I guess. When eating Honeypuff Cookies (+joy and libido, adds Puffy Nipples trait):

LoL

I did a search of the whole class file and found 5 more :)

Should be fixed now as well.
« Last Edit: May 18, 2013, 04:38:51 PM by Xela »
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Ok, so now it should work this way:

There are two layers of stats. One normal and one for items, that is supposed to prevent item that pushes girl above her max value, when unequipped, taking her stats away with it.

So All items added to that second layer, however since when we ask for stats value, we get normal + secondary, meaning that consumables and misc adding to secondary that is limitless would simply max the girl out, even when it comes to stats like health/fatigue/mp and those values could never go down unless second field was lowered by consumable items again.

Now it works differently:

All normal items still just add to secondary field unless stats are ['health', 'mp', 'fatigue', 'joy'] (to prevent immortality or tirelessness).

Consumable/Misc if temporary add to the first layer if stats are: ['health', 'mp', 'fatigue', 'joy'] (to prevent immortality or tirelessness) and to the secondary field if any other stat. If not temporary, it just adds to the first layer.

If it all works, it should solve most issues but we can keep trying to get this just perfect :) I guess it's a combination of code and items design working together.

 
« Last Edit: May 18, 2013, 05:33:50 PM by Xela »
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Regret to inform you that it doesn't. Still 0 charisma on the next day, and crash on the second day:
Quote
  File "game/library/screens/pyt - screens - nextday.rpy", line 6, in script
  File "game/library/screens/pyt - screens - nextday.rpy", line 46, in python
  File "game/library/pyt - classes.rpy", line 3346, in python
 UnboundLocalError: local variable 'brfamemod' referenced before assignment

Oh, and is it normal that infinite field does nothing right now?
« Last Edit: May 18, 2013, 05:55:24 PM by DarkTl »

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Regret to inform you that it doesn't. Still 0 charisma on the next day, and crash on the second day:

I need to try this myself to figure where it goes amiss.

Oh, and is it normal that infinite field does nothing right now?

It sets item to 100 in shop.
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Well, if you need my items for testing, I've uploaded current version of xml as "items (new)". Last one of them, a Cake, causes this crash.
« Last Edit: May 18, 2013, 06:08:33 PM by DarkTl »

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Well, if you need my items for testing, I've uploaded current version of xml as "items (new)". Last one of them, a Cake, causes this crash.

Ok, I'll try that and I think I've fixed the cmax field as well.

// Seems harmless to me, didn't crash anything when I tried it.
// That Error shouldn't happen because of an item, I'm unable to replicate it with any version of code. Maybe you've opened console at the wrong place or something.
« Last Edit: May 18, 2013, 06:36:13 PM by Xela »
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Went over some of the items code this morning, being a better shape than yesterday, I've managed to kill a couple more flaws in the code. cmax now only works for consumables and misc (as it is not need for anything else.)

Also note that cmax only applies to stats, it's not supposed to block any other effects item may have so you still need to be careful with the design so items are not overpowered.
« Last Edit: May 19, 2013, 05:09:42 AM by Xela »
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Well, it works properly now, so you probably have fixed it. I didn't try console yet after all  :)

Also note that cmax only applies to stats, it's not supposed to block any other effects item may have so you still need to be careful with the design so items are not overpowered.
If you see any overpowered items, then keep in mind that they should and will be in dangerous, remote locations with a small chance to obtain them.

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Btw, I don't see libido in girls stats, so can't test properly some items.