General Discussion

[Xela]

Code: [Select]

result = result.replace("[character.mc_ref]", character.mc_ref)
Best version I think... safe to use with all the other possible tags, fast and will work well.

[Xela]

We should prolly replace the cross that leads to previous screen with something simple along these lines:

https://www.google.bg/search?q=return+arrow+png&client=firefox-b&tbm=isch&tbo=u&source=univ&sa=X&ved=0ahUKEwiEhPWJqefMAhVIvhQKHV9hC8AQsAQIGg&biw=1920&bih=961#

I think that'll be more appropriate...

[DarkTl]

There is already back arrow button at some screens, like MC profile. There is no need in looking for other buttons, it's suitable for any screens.

Not really required because there should be no case where this fails cause you cover all the bases with choices. Also choice([]) is a crash so it would fail with a crash before that anyhow.

Well, it means that the function cannot be used for teams with more than 4 characters of the same MPTrait, because there won't be enough lines for them 
I don't think we'll even have more than 4 party members though, so it's probably fine.

[DarkTl]

I changed the algorithm a bit to make sure it correctly subtracts lists with different mc_ref, thus even lines with different mc_ref won't be repeated.

I added prebattle quotes inside BE, and they work. But now prebattle dissolve doesn't work...

[Xela]

Fixed the quotes. I've also set them to false, you usually want to set new stuff to None/False to make sure that new behavior doesn't occur everywhere.

[DarkTl]

Blue hair random pack just reminded me that generic battle sprite is needed for packs without one.
Better this than random non transparent picture.

Or this.

[DarkTl]

            "Kill her":
                "She stopped breathing. Serves her right."
                $ char.health = 0

  File "game/library/interactions/GM - negative.rpy", line 22, in script
    $ char.health = 0
  File "game/library/interactions/GM - negative.rpy", line 22, in <module>
    $ char.health = 0
  File "game/library/characters/classes - characters.rpy", line 3244, in __setattr__
    self.__dict__["stats"].mod_base_stat(key, value)
  File "game/library/characters/classes - characters.rpy", line 900, in mod_base_stat
    self.mod(key, value)
  File "game/library/characters/classes - characters.rpy", line 988, in mod
    hero.remove_girl(girl)
  File "game/library/characters/classes - characters.rpy", line 2601, in remove_girl
    if char in self._char:
  File "game/library/characters/classes - characters.rpy", line 1200, in __getattr__
    raise AttributeError(msg % (key, self.__class__.__name__))
AttributeError: '_char' is neither a gamestat nor an attribute of Player

[Xela]

I've pushed a small update that should fix this particular error. Just keep in mind that this system is in like pre-alpha stage and it will not remove anyone from Arena or Interactions or FG teams but it looks like it's rigged to remove chars from heros team and employment.

[DarkTl]

Nope, you haven't pushed it 

[Xela]

Git is acting up again...

[DarkTl]

  File "game/script.rpy", line 289, in script call
    call testing
  File "game/library/testing.rpy", line 2, in script
    python:
  File "game/library/testing.rpy", line 55, in <module>
    hero.add_girl(new_random_girl)
  File "game/library/characters/classes - characters.rpy", line 1200, in __getattr__
    raise AttributeError(msg % (key, self.__class__.__name__))
AttributeError: 'add_girl' is neither a gamestat nor an attribute of Player

I thought maybe I need a new testing file, but the link you provided some time ago now leads to test_cases.rpy, which is something completely different.

[Xela]

I thought maybe I need a new testing file, but the link you provided some time ago now leads to test_cases.rpy, which is something completely different.

https://www.dropbox.com/s/5uiox4ka1oisgu5/testing.rpy?dl=0

[DarkTl]

I can give items from MC to a free character and then take them away freely. But cannot take items from hinata for example.
Is it a normal behavior? Does the game track which item was given by MC or something?

[Xela]

Does the game track which item was given by MC or something?

Yeap, it does.

http://www.pinkpetal.org/index.php?topic=1291.msg30364#msg30364

Maybe one of these... you sprites are a nightmare to clean up. Or we need to keep searching for one...

[DarkTl]

Oh come on, the second one has a solid, easily removable background. Here.