Pages:  1 ... 576 577 [578] 579 580 ... 658

Author Topic: General Discussion  (Read 3821213 times)

0 Members and 33 Guests are viewing this topic.

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8655 on: October 21, 2016, 04:05:14 PM »
I think that you're supposed to jump to label girl_interactions_end...

That label is actually quite pointless... it should be fully encapsulated into GirlsMeets.end method. It should be doable just by copypasting the damn thing and "safe" argument will work properly, because it is useless right now as it doesn't do half of the things it is supposed to.
Logged
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8656 on: October 21, 2016, 04:06:57 PM »
Quote from: Xela on October 21, 2016, 04:05:14 PM
I think that you're supposed to jump to label girl_interactions_end...

That label is actually quite pointless... it should be fully encapsulated into GirlsMeets.end method. It should be doable just by copypasting the damn thing and "safe" argument will work properly, because it is useless right now as it doesn't do half of the things it is supposed to.

But you can use it for now, I'll encapsulate it later and leave the label at $ gm.end() :D
Logged
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: General Discussion
« Reply #8657 on: October 21, 2016, 04:13:51 PM »
No, I'm talking about situation when in
Quote
gm.start("girl_interactions", chars[char], chars[char].get_vnsprite(), place, background)
normally you return to place after interaction is over. But after picking a certain option you return to some another place.
Logged

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8658 on: October 21, 2016, 04:18:44 PM »
Which option? That's what I am talking about, there is likely an option that exits girlsmeets incorrectly.
Logged
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: General Discussion
« Reply #8659 on: October 21, 2016, 04:27:13 PM »
Well, a unique quest option which is available via event_to_interactions flag, if it means something in this case  :D
Of course it exits GMs incorrectly because I dunno how to do it correctly and jump to another location at the same time. I suppose it's not even possible with the current GMs.
Logged

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8660 on: October 21, 2016, 04:31:29 PM »
What the heck is "unique_to_interactions" flag? It will use whatever label you were on to return to but it may not always be desirable.
Logged
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8661 on: October 21, 2016, 04:33:50 PM »
Looks like github is back btw...
Logged
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: General Discussion
« Reply #8662 on: October 21, 2016, 04:38:30 PM »
You don't remember? It's the system you coded for interactions, when a character with set_flag("event_to_interactions_flag_name", value={"label": "...", "button_name": "...", "condition": "True"}) will have a unique option in dialogue which will be called button_name and will jump to label.

It doesn't matter though. The problem is, normally we create interactions via gm.start("girl_interactions", chars[char], chars[char].get_vnsprite(), place, background), and after they are over, we return to place. Jumping to label girl_interactions_end will return you to place too.
However, I wonder if it's possible to return to some other location.
« Last Edit: October 21, 2016, 04:42:59 PM by DarkTl »
Logged

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8663 on: October 21, 2016, 04:42:20 PM »
Pull my last push and use:

Code: [Select]
$ gm.end(safe=True)
jump any_location
Logged
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8664 on: October 21, 2016, 04:45:34 PM »
Oh, and inventory related stuff that I haven't fixed yet is prolly f*cked, so look out for bugz :)
Logged
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8665 on: October 21, 2016, 04:47:16 PM »
Oh, and we're missing item icons for good bait and ruby fish so it crashes when you get them in inventories.
Logged
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: General Discussion
« Reply #8666 on: October 21, 2016, 04:52:42 PM »
Traits panel looks a bit messed up.
https://www.dropbox.com/s/a9pbvtolbgapih2/3.jpg?dl=0
Logged

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8667 on: October 21, 2016, 04:55:54 PM »
Yeap, it got misaligned somehow... I am working on items transfter atm which is a mess, gonna fix this later.
Logged
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: General Discussion
« Reply #8668 on: October 21, 2016, 04:59:08 PM »
Don't forget about traits effects  :)
Since they are not even visible in gui, I suppose they are not added to characters despite having the needed traits.
Logged

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: General Discussion
« Reply #8669 on: October 21, 2016, 05:10:11 PM »
Quote from: DarkTl on October 21, 2016, 04:59:08 PM
Don't forget about traits effects  :)
Since they are not even visible in gui, I suppose they are not added to characters despite having the needed traits.

Prolly not tonight, items screen is completely f*cked... too many things go wrong, it's the least I had to change in past few refactoring efforts.
Logged
Like what we're doing?
Pages:  1 ... 576 577 [578] 579 580 ... 658