General Discussion

[DarkTl]

We already did, here. You didn't explain what do you mean exactly by hazards, but I figured there will be comments in the code anyway 

I only can show a screenshot from neptunia minigame again, that's how I imagine SE in work, with different interface of course. Maybe without detailed battle logs if it's too hard to add.
The team can find enemies, chests or events. Chests contain loot/gold and may have traps. Events lead to arbitrary label and can do anything to the team. Strictly speaking, all chests can be events too, since they just give items or activate traps.

By events in general I mean text events and a few python lines, like increase/decrease health or give an item. Or for example check if the team has a lockpick if they found a locked chest. Those events will be visible only in SE log.

[Xela]

We already did, here. You didn't explain what do you mean exactly by hazards, but I figured there will be comments in the code anyway 

Oki. I remembered most of that discussion even though I forgot the thread was there

It'll take some time as rewriting old code is slow... I've considered just writing new code before but decided not to.

[picobyte]

For better micromanagement I've adapted the char_list screen. Girls on page get a selection box that can also be manipulated with buttons 'These" (to toggle selection on page) 'All' to select all with current filters or 'None'. Filters are also diplayed differently.

Currently I've implemented one mass action: training, but I think it would be useful to add more, for instance
* equipment
* activity
* location
* control
* get rid

The implementation for a selection in training.rpy and training - classes.rpy is somewhat hackish, the required functions are now recursed in a case of a list. Maybe they should by modified to expect a list in any case, with at least one character.

BTW I removed the sprite editor commit from my branch for now. It has save/restore issues for instance, so it's not yet ready.

[Xela]

For better micromanagement I've adapted the char_list screen. Girls on page get a selection box that can also be manipulated with buttons 'These" (to toggle selection on page) 'All' to select all with current filters or 'None'. Filters are also diplayed differently.

Currently I've implemented one mass action: training, but I think it would be useful to add more, for instance
* equipment
* activity
* location
* control
* get rid

The implementation for a selection in training.rpy and training - classes.rpy is somewhat hackish, the required functions are now recursed in a case of a list. Maybe they should by modified to expect a list in any case, with at least one character.

Oki, So it is not possible to set multiple characters up for training?

BTW I removed the sprite editor commit from my branch for now. It has save/restore issues for instance, so it's not yet ready.

What do you mean by "sprite editor"?

[picobyte]

Oki, So it is not possible to set multiple characters up for training?

yes, it is.

What do you mean by "sprite editor"?

I added its code yesterday as a commit to my branch but removed it for now as I think I cannot merge it yet. It is from a renpy project I wrote earlier to compose a body, using multiple images, using layers and the renpy camera code, the former project wasn't published. I'll add the code in a development branch, but it requires art for which I used Akabur's witch trainer images combined with an old scarecrow kisekae set from the owl. I'm not sure want their art shared.

[Xela]

I added its code yesterday as a commit to my branch but removed it for now as I think I cannot merge it yet. It is from a renpy project I wrote earlier to compose a body, using multiple images, using layers and the renpy camera code, the former project wasn't published. I'll add the code in a development branch, but it requires art for which I used Akabur's witch trainer images combined with an old scarecrow kisekae set from the owl. I'm not sure want their art shared.

To use as NPC? I doubt that it would be possible to use something like that as a char without a lot of extra code to the show method, which is likely to create an extra mess we can do without.

I wrote something along those lines for another game we're working on. It loads sprites directly from images files to a UDD, handles gesture and closing and has a complicated system setup for expressions (main character has 470+ expressions (we're obviously not using all of them but still )).

We have 7 or 8 character with layers, expressions and clothing without a single image declaration except for their names.

[DarkTl]

For better micromanagement I've adapted the char_list screen. Girls on page get a selection box that can also be manipulated with buttons 'These" (to toggle selection on page) 'All' to select all with current filters or 'None'. Filters are also diplayed differently.

Huh? But I don't see anything new at the chars_list screen, even after force recompile...

[picobyte]

Sorry not pushed yet, I have done that now. please ignore the equipment button, I will remove that shortly.

Edit: actually I see I didn't push the equipment button yet. It is a local change to try to get it working.

[Xela]

Look good, there is less space for filters now, amount of which increases with businesses and available jobs but this one is definitely worth it.

Alignment breaks depending on if char is a slave or not. Also we have a "proper" empty check box icon (somewhere).

[picobyte]

The decreased space is to allow more mass actions except training. Equipment is a tough one. I'm thinking about creating a PytGroup class for this purpose.

* equipment
* activity
* location
* control
and maybe: get rid

[Xela]

Classes are usually an overkill for sorting/grouping, screens, label with a while loop intercepting ui.interact and maybe a couple of funcs are enough. But if you think that class can result in clearer, better readable code, knock yourself out

That weird thing longint did with sorting for chars list screen is a very old and confusing code in of itself. I tried cleaning it up a bit but there is always something else to work on so I left it for major refactoring effort after beta release.

Pyt are also old and weird naming style, you can call the class CharsGroup or SortingGroup or something along those lines if you decide to go with a class.

[Xela]

The decreased space is to allow more mass actions except training.

And yeah, I figured

But I am not going over new code after every push. I've tested old design with a lot of filters and there will be an overflow of space for filter option when player has loads of buildings and lot of jobs option. If there is a viewport there already or you put one in, this post is not relevant. If there is not, there should be one so we don't get a new bug (which we can take out now) that pops up when people start testing after beta release.

[Xela]

@Dark:

Did you delete the track we used to play during BE testing all the time? It was one of my favs and I can't find it anymore.

[DarkTl]

I deleted some tracks that cannot be easily looped, which led to awkward silence in the middle of battle. I think I deleted the one you talking about by mistake, it was already looped properly. If we taking about the same track, of course. I restored it.

[Xela]

I deleted some tracks that cannot be easily looped, which led to awkward silence in the middle of battle. I think I deleted the one you talking about by mistake, it was already looped properly. If we taking about the same track, of course. I restored it.

Yeap, that's the one I was talking about. There is at least another one of mine missing but we can do without it.

It all got to start somewhere :