General Discussion

[picobyte]

Code: [Select]

    $ i = 1
    while i < randint(3, 5):
        $ i += 1
        call city_tavern_thugs_fight
Not sure if it matters here, but this does probably not what you intend: The chance of breaking the loop is not equally distributed between 3 and 5. To show this try running the code below in a python console a few times with test(100):

Code: [Select]

def test(end):
   i=0
   while i < random.randint(1,end):
        i += 1
        print(str(i))
You'll notice that it almost never reaches 50.  The loop tends to stop earlier, since a new end is tested each iteration. It's better to define the end before the loop:

Code: [Select]

    $ i = 1
    $ end = randint(3, 5)
    while i < end:
        $ i += 1
        call city_tavern_thugs_fight
As to your original question, you figured out it was something different, but in contrast the code below can be an infinite loop:

Code: [Select]

    $ i = 1
    while i != randint(3, 5):
        $ i += 1
        call city_tavern_thugs_fight

[DarkTl]

BTW I never seem to get scrolls for Casters. They are present in game/content/db/items_scrolls.json, but it seems they are not yet loaded? probably a known issue..

I'm not sure yet how to handle them, or if we need them at all. There are a lot of them, they all look the same and do the same thing. Perhaps some kind of menu or a scripted item, like a book of spells, will be better.

You'll notice that it almost never reaches 50.  The loop tends to stop earlier, since a new end is tested each iteration. It's better to define the end before the loop

I see, thanks.

[picobyte]

I think I'll move on to auto_equip next. 0.05  secs to run to equip 1000 chars should be good enough.

And ehrm.. can I get a status upgrade, or will I be newbie forever?

[DarkTl]

It's up to you, status is based on the number of posts 
If I'm not mistaken, the second level requires 50, and the fifth level, Hero Member, requires 1000 posts.

[Xela]

Finally got my net back, now with a new shiny optical connection! I cannot mess with forum status, or I don't think that I can, it will update itself after required amount of posts is reached.

[lamoli]

Nice.. finally found a possible good inspiration source for Pytfall clothing..


https://chan.sankakucomplex.com/?tags=houtengeki


can you check if his work is alright for Pytfall clothing.. (from the 215 iv browsed so far it looks great)


Next up is action poses with expression only having 1 is a big problem and not happy until i find more..

[DarkTl]

Yeah, they are perfect.

[picobyte]

It's up to you, status is based on the number of posts 
If I'm not mistaken, the second level requires 50, and the fifth level, Hero Member, requires 1000 posts.

Ah haha, maybe I'll just post my patches here as well then, for review purposes, of course

[DarkTl]

I added a (free yet) dice minigame in tavern. While it works as intended, it could use cool renpy-based animations to show dices, which is beyond my capabilities.

[Xela]

I added a (free yet) dice minigame in tavern. While it works as intended, it could use cool renpy-based animations to show dices, which is beyond my capabilities.

Like what? Is this like black-jack with dice?

[DarkTl]

Yeap. Many big games these days have cards/dices minigames, sometimes with quite complex rules - like dice poker in Witcher.

For example, when new dice appears, dices that already are on the "table" could move to the left to free enough space for it, and the new dice will appear via zoomin or slideleft.

[Xela]

It may not be worth the effort for beta, position of each dice might have to be controlled with custom code. I'll try something simple(r) but it prolly not gonna work.

Edit: Scratch that, I keep forgetting that they keep improving sh!t

[picobyte]

I have a deep respect for whoever wrote the skill code. It must have required a lot of action points, multipliers and training.

[picobyte]

If I got this straight, for skills there are three multiplier, and 2 linear stats, multipliers are within bounds: 0.5 to 1.5. The first linear describes the 'action', the number of points for the stat, it has the first multiplier. the 2nd linear, determines the training: beyond where action points are going to weight only 1/3, withthe 2nd a multiplier. The third multiplier acts on the result: the action value up to the training threshold, plus the thirds beyond.
This is what you get when you call get_skill(), however, the multiplier is also applied for each new skill point that is added, and again there is another training threshold, but here, beyond, the addition is multiplied by the maximum of 0.1 and 1 - (training beyond / 3000).

Edit: strike last sentence as __setattr__ is not called on apply_item_effects()

[DarkTl]

Here Xela outlined his skills concept in general.