Pink Petal Games

Thanks for the error reports and comments.

@zenkls
I've tried to reporduce the error on my end, but so far without success.

@Fruitymate
It should definitely not be necessary to redo all the girlsx files (or, actually, add `images.xml`). While doing so would improve the image selection, the default based on file names should still be good enough. I've tested it with a few packs, and it seems to work. Maybe the gamelog can give some more info on what goes wrong in your setup. It produces some output related to image selection, generally prefixed by `INFO:    [image]`.
If you get two messages `Looking for image` in a row, without any `Selected image` inbetween, that means that for this particular lookup, fallback images were used.

If the problem occurs with a specific pack that is around here for download, I could also try to debug that pack.

"I also like to compile them in batches and and leave them in the characters folder but not in their own character folders." I'm not sure what you mean here.

Thanks, that was pretty fast and the problems seem fixed. Yeah, that last point about software development is definitely true a lot, lol. Speaking of reworking items, I just figured I'd let you know that misc. items haven't been properly applying their Skill, Stat, or Trait effects for a while now, so that may be something worth investigating when you do get around to items if you weren't aware already. They do still correctly apply any effects that specifically check for the item, such as the end of week events for the nightmare orb or the chrono bed.

Edit: Nevermind, I don't believe the first issue is completely fixed with how you modified the LevelUp function. While the original bug message does seem to be gone, I am instead getting variations similar to this new error message under the same conditions:
"Error when processing building Farm: basic_string::_M_construct null not valid"
I believe that it is likely that some of the functions that the gain_trait functions relies upon aren't able to handle the nullptr that your fix introduces, instead producing the new message because I can no longer reproduce the error if I once again adjust the random index range to not include the nullptr.

I believe I have found two bugs and a fix for one, although I don't have a github or discord. The first bug is likely caused by line 176 of "src/game/cGirls.cpp".
The line in question is in a function that handles girls leveling up and reads:
"int chance = g_Dice % 12;"
I believe that it is supposed to actually be:
"int chance = g_Dice % 11;"

The line is there to generate a random index for the statically created array on the line before. The array contains eleven fixed traits, meaning its indices range from 0 to 10, however the line as it is currently written can instead occasionally generate an index of 11. This makes the bug unreliable to reproduce, as it only happens when a girl levels up to a level divisible by five so she can gain a new trait, but even then only in a little more than one twelfth of the times. When encountered, this bug manifests as the player getting an error message that looks something like this, although substitute arena for any building the girl leveled up in:
"Error when processing building Arena: Could not find trait:" and then some random gibberish.
This is likely happening because the trait array is going out of bounds and trying to read this memory space as a trait, which will obviously not generally produce any meaningful text, nor anything usable to the gain_trait function a few lines down from it. The process buildings phase will then fail for that turn, and the girl will not get a trait for that level. I have reproduced the error for both the previous version, as well as the new version that was posted yesterday. It is hard to be absolutely certain that it fixes it due to the random nature of the bug, but I have not encountered the bug after compiling a version of the game with the above change.

The second bug is the one that I have not explored the cause of and is related to the UI. When the user selects a girl and then clicks the "girl details" button at the right of the screen, they enter into a menu with a button that reads "more details" on the left side of the screen. In older builds, clicking on the button would cycle through several different stats on the left half of the screen, before wrapping back to the original stats. Now, after clicking on it twice, it will produce an error message that reads: "Could not find trait". Then, bits of text from some scripts will show in place of the error text on the red box before finally kicking the user out of the "girl details" menu. The player will then be unable to enter the "girl details" menu again until restarting the game, with the player instead getting only the "Could not find trait" error message any time they try to enter the menu.

Anyway, thanks for the mod, it really improved the game's overall codebase, especially in a lot of ways that are really nice but invisible to the overall player.

Edit:
Alternatively, looking at the commit history for the first section it seems that part was originally supposed to be in a switch with a chance to not produce a trait when it rolled 0. If this original behavior was intended, the lines below can instead be modified by sticking them in an if statement that only runs if it didn't roll 11.