Poll

If you are reporting a bug, follow these steps to assist us in finding the cause of your bug

1. Delete the "gamelog.txt" file from your game folder to clear it.
2. Run the game as you normally would until it crashes.
3. Create a zip file with your savegame and your "gamelog.txt" files.
4. Post your bug report with details of how and when you get the crash.
5. Attach the zip file to your report.

Author Topic: Crazy and PP's mod bug thread  (Read 619291 times)

0 Members and 10 Guests are viewing this topic.

Offline babanathie

  • Newbie
  • *
  • Posts: 9
Re: Crazy and PP's mod bug thread
« Reply #750 on: February 14, 2015, 06:27:12 PM »
That type of thing is a long standing bug because human/nonhuman is in the code in so many different ways that fixing one breaks another.
I have gone through the code several times to try to normalize it but it is difficult.
If you can track it down that would be helpful.

I did a quick trace; determining whether the mom is a monster or a human is done by checking whether to girl can be gained from the catacombs.  If you can get a human from the catacombs, then the child will be a monster.  At least it seems that way from looking at the code.  I'll have to see if there is an alternate way of getting this fixed later.   

Offline Cursed_May

  • Newbie
  • *
  • Posts: 13
Re: Crazy and PP's mod bug thread
« Reply #751 on: February 14, 2015, 09:11:39 PM »
Is it possible to get a named girl again if she dies?

Offline babanathie

  • Newbie
  • *
  • Posts: 9
Re: Crazy and PP's mod bug thread
« Reply #752 on: February 15, 2015, 01:43:46 AM »
I did a quick trace; determining whether the mom is a monster or a human is done by checking whether to girl can be gained from the catacombs.  If you can get a human from the catacombs, then the child will be a monster.  At least it seems that way from looking at the code.  I'll have to see if there is an alternate way of getting this fixed later.

Well, I eliminated the mother causing the problem...  Despite the loose definition of "catacomb".  It has to be in the section for selecting a girl, which is, honestly, a very inefficient way of selecting a girl, or any item in a list.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #753 on: February 15, 2015, 02:03:40 PM »
Is it possible to get a named girl again if she dies?
If a named girl dies, she is removed from the game.
You can add her back if you edit the savegame file and remove her line from the <Girls_Files> section.
The next time you load the game, it will add her back to the game as an available girl.


I have added in a check so if a girl has a disease, if there is a matron in her building and a cure for her disease in the player's inventory, she will take it to cure her disease before the disease has a chance to hurt her.
« Last Edit: February 15, 2015, 03:11:40 PM by aevojoey »
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline babanathie

  • Newbie
  • *
  • Posts: 9
Re: Crazy and PP's mod bug thread
« Reply #754 on: February 15, 2015, 04:08:57 PM »
I did a quick trace; determining whether the mom is a monster or a human is done by checking whether to girl can be gained from the catacombs.  If you can get a human from the catacombs, then the child will be a monster.  At least it seems that way from looking at the code.  I'll have to see if there is an alternate way of getting this fixed later.

I tracked down the issue.  First, change !AllowNonHuman back to AllowNonHuman in the child_is_grown() of cGirls.  Second, remove the code:

         //  old code that doesn't seem to work properly ****************************************************************************************************
         //if (daughter)   // we are looking for a "Your Daughter" girl as the primary check
         //{
         //   if (current != 0 && current->m_YourDaughter)
         //   {
         //      break;
         //   }
         //}
         //else
         //{
         //   if (current != 0 && NonHuman == (current->m_Human == 1))            // test for humanity - or lack of it as the case may be
         //   {
         //      break;
         //   }
         //}
         /****************************************************************************************************************************************************/

in the CreateRandomGirl() in cGirls and replace it with:

         // New code that hopefully works...  We are checking to see if we are searching for your daughter and finding a human or non-human to fill that role
         if (daughter)
         {
            if (current != 0 && NonHuman == (current->m_Human == 1))
            {
               break;
            }
         }

The original code is making all random girls available, or nearly all of them, as a potential child.  It almost never checks for humanity. 

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #755 on: February 15, 2015, 06:21:55 PM »
I tracked down the issue.  First, change !AllowNonHuman back to AllowNonHuman in the child_is_grown() of cGirls.  Second, remove the code:
AllowNonHuman in the child_is_grown() is true if the mother is human.
In the CreateRandomGirl the input that AllowNonHuman goes to is false if the girl is human.
So the ! is required to pass the correct bool to the function.
I changed the "AllowNonHuman" to "MomIsMonster" to fix this.
I also added human check to the GetRandomYourDaughterGirl() function so it will check for either human (1), nonhuman (0) or both (-1).

I also changed NonHuman to Human0Monster1 in the CreateRandomGirl() function.

The original code is making all random girls available, or nearly all of them, as a potential child.  It almost never checks for humanity.
The problem then becomes if a player has no YourDaughter girls in their character folder, they will get a hard coded random girl as their daughter.

I am adding checks to count the various types of .rgirls that are available.
This will allow for better selection of girls for the random checks.

Now if you are looking for a your daughter girl, it will check for:
 - only humans for human mother
 - nonhuman for nonhuman mothers first
 - humans for nonhuman mothers if no nonhumans are found

After all that the normal random girl check takes place if no girl is found.
« Last Edit: February 15, 2015, 07:27:26 PM by aevojoey »
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Destont

  • Newbie
  • *
  • Posts: 43
  • Destont Tengoto - Tengu of Darkness and Sorrow
Re: Crazy and PP's mod bug thread
« Reply #756 on: February 17, 2015, 04:12:50 AM »
Alright not sure how much help this ill be since I have no clue what is causing the problem. But the game currently enjoys crashing whenever I try to go to the next week.

Also as a bit of an aside I would like to state that the game has trouble with the fact that matrons seem to not place non-whore girls back into their jobs after maternity leave.
« Last Edit: February 17, 2015, 04:17:35 AM by Destont »

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #757 on: February 17, 2015, 01:37:06 PM »
Alright not sure how much help this ill be since I have no clue what is causing the problem. But the game currently enjoys crashing whenever I try to go to the next week.
I was unable to get it to crash.
What version of the game are you running?
Do you have any special settings in your config.xml?


Also as a bit of an aside I would like to state that the game has trouble with the fact that matrons seem to not place non-whore girls back into their jobs after maternity leave.
This is an ongoing problem that I will fix as soon as I can figure out why it is happening.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Destont

  • Newbie
  • *
  • Posts: 43
  • Destont Tengoto - Tengu of Darkness and Sorrow
Re: Crazy and PP's mod bug thread
« Reply #758 on: February 17, 2015, 02:15:17 PM »
Alright it seems that it was having auto use poayer items checked that was causing it

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #759 on: February 17, 2015, 03:03:16 PM »
Alright it seems that it was having auto use poayer items checked that was causing it
I fixed it.
When I cleaned up the exp granting items after removing the exp limit, I did it wrong.
It was checking if you had the item but not storing where that item was.
It was then breaking when it tried to add item[-1] instead of item[itemnumber].
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline HuiBui

  • Full Member
  • ***
  • Posts: 148
Re: Crazy and PP's mod bug thread
« Reply #760 on: February 18, 2015, 01:58:26 AM »
I've found a little bug in the character editor ( checked in 0.8.21)

If you "UnZero Sex Skills", the footjob doesn't switch from 0.

Kind Regards,
HuiBui

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #761 on: February 18, 2015, 02:11:52 AM »
I've found a little bug in the character editor ( checked in 0.8.21)

If you "UnZero Sex Skills", the footjob doesn't switch from 0.

Kind Regards,
HuiBui
You couldn't have reported it 15 minutes earlier?  :P
I just pushed the new versions of everything.
I'll just remove the WME.8.22 and reupload it with the fix.
Its not a major bug so .06.01.05 will still have the uncorrected WME.8.22
« Last Edit: February 18, 2015, 02:21:29 AM by aevojoey »
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline HuiBui

  • Full Member
  • ***
  • Posts: 148
Re: Crazy and PP's mod bug thread
« Reply #762 on: February 18, 2015, 02:23:12 AM »
Yes I could have reported that , but each thing has its own time.  :P
By the way, I'm just changing 800 girls into the "latest" .girlsx format based on 0.8. 21
I've already finished that for more than 100gals. And at these moment you are popping up with an extra Stat and an additional skill ?
What happens with all these girls without strength =0 ?


Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #763 on: February 18, 2015, 02:28:45 AM »
Yes I could have reported that , but each thing has its own time.  :P
By the way, I'm just changing 800 girls into the "latest" .girlsx format based on 0.8. 21
I've already finished that for more than 100gals. And at these moment you are popping up with an extra Stat and an additional skill ?
What happens with all these girls without strength =0 ?
At the moment strength is only used for some farm jobs so 0 strength will have little to no effect on the game.
Those jobs that use strength, also increase it as does combat training.
By the time strength gets used in the game, most girls should have at least some points in it.

I don't see any need to add any more stats or skills to the game for a while.
If/when a new building gets added, then there may be some new ones but that will be a while off.
« Last Edit: February 18, 2015, 02:31:21 AM by aevojoey »
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline HuiBui

  • Full Member
  • ***
  • Posts: 148
Re: Crazy and PP's mod bug thread
« Reply #764 on: February 18, 2015, 03:47:14 AM »
Thanks aevojoey for the information.

I've just checked the current Editor 0.8.22

An error occurs while compiling an existing girl or when creating a new one.
For the first time I've got an error message , somelike how "empty line 1"