<-- Archived --> (Items Concept)

[DarkTl]

Hm, no, it doesn't seem right to sell stuff without a reason.
If you fire them, they CAN sell any unequipped items if they need money, but don't have to if they already have enough money to live. Yeah, it probably should be part of simulation too.

[Xela]

I doubt that we'll manage proper simulation before next release.

[DarkTl]

I'm aware of it 

I wonder how should I check general occupations inside autobuying. Cgo uses "for occ in char.traits", but inside autobuying we use self instead of char.

[Xela]

Normally:

PytCharacter.occupations is a set of all occupations, main, sub, general, doesn't matter... self.occupations if you check inside of the class. General strings like "Server" should be there as well.

[DarkTl]

            for i in pool:
                # This will make sure that girl will never buy more than 5 of any item!
                if i.id in self.inventory:
                    mod = self.inventory[i.id] * 20
                else:
                    mod = 0
                     
                if dice(100 - i.badness - mod) and self.take_money(i.price, "Items"):
                    self.inventory.append(i)
                    returns.append(i.id)
                    amount -= 1
               if not amount:
                    break

Doesn't it mean that if we send a character with low gold, she will keep wanting to buy random stuff but often will be unable to instead of focusing on cheap items she can afford?

[Xela]

Doesn't it mean that if we send a character with low gold, she will keep wanting to buy random stuff but often will be unable to instead of focusing on cheap items she can afford?

Which part? Code will run itself until amount of items requested is 0 or until all options run themselves out. You'll have to be more specific on what concerns you.

[DarkTl]

Let's say she has 50 gold, and we have like 200 items she cannot afford and 50 she can.

So we'll have a list of 250 items, and 200 of them will be useless to us from the beginning. Shouldn't we remove too expensive ones from the list after every purchase, or at least before the first purchase?

[Xela]

Let's say she has 50 gold, and we have like 200 items she cannot afford and 50 she can.

So we'll have a list of 250 items, and 200 of them will be useless to us from the beginning. Shouldn't we remove too expensive ones from the list after every purchase, or at least before the first purchase?

In the very beginning would be a nice optimization, would prolly speed things up a little bit. New list would have to be created with:

Code: [Select]

total_pool = [i for i in auto_buy_items if i.price <= self.gold]
or something like that. We'll work with total pool after that... maybe removing all bad trait items using extra check while building this list is a decent idea also...

Those methods have been optimized just once because my first version was really, really slow and faaaaar too complicated. Your proposal seems like a good step towards making it better/faster.

[DarkTl]

Should I use a new list every time? Or it's possible to do stuff like pool = [i for i in pool if i.price <= self.gold]?

[Xela]

Should I use a new list every time? Or it's possible to do stuff like pool = [i for i in pool if i.price <= self.gold]?

It's perfectly possible but not very useful since we're building new lists from total pool two or three times. I think my original suggestion of creating a total pool with all badtrait and too expensive items sorted out is best. Than we can use that instead of the global auto_buy_items or whatever that's called.