Author Topic: Combining the big mods aka crazy's mod .06 is out now  (Read 1025041 times)

0 Members and 7 Guests are viewing this topic.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1620 on: October 16, 2016, 01:58:43 PM »
Just a small typo I've found: in the "goodnews" warning telling you that the girl served her first customer, there is a missing spaces after the word "first".
I saw that and already fixed it for .37

By the way, I think that it would be nice to introduce the possibility to acquire the trait "Whore" after sleeping with a certain number of customer, since the description of the trait seems to suggest something like that. Moreover, there is no possibility to acquire the trait in any other ways.
A girl can get the Whore trait as a random effect of sex similar to how they get stds.
I will add it to the 500+ customer count where it is more logical.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline _rhetorik_

  • Jr. Member
  • **
  • Posts: 63
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1621 on: October 20, 2016, 10:45:57 PM »
Just to let joey know that I have submitted a new pull request.


 :)

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1622 on: October 21, 2016, 01:12:14 AM »
Just to let joey know that I have submitted a new pull request.
I have looked over it but there are a few problems;
The if statements are missing else statements so it could do nothing and break something.
You also need to add checks so you don't get divide by 0 errors.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline _rhetorik_

  • Jr. Member
  • **
  • Posts: 63
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1623 on: October 21, 2016, 07:26:56 AM »
I have looked over it but there are a few problems;
The if statements are missing else statements so it could do nothing and break something.
You also need to add checks so you don't get divide by 0 errors.


I've answered your comments on the PR.


1) There was no changes in the algorithm i 've just updated the way the scales are used and did a bit of code maintenance.
2) The ifs are fine. It is supposed to do nothing if they don't match. Those ifs are intended to correct the image size if the image don't match the display area. If they do .... no correction needed.




Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1624 on: October 21, 2016, 08:25:03 AM »
I've answered your comments on the PR.
1) There was no changes in the algorithm i 've just updated the way the scales are used and did a bit of code maintenance.
2) The ifs are fine. It is supposed to do nothing if they don't match. Those ifs are intended to correct the image size if the image don't match the display area. If they do .... no correction needed.
I guess I shouldn't answer posts right before bed, I didn't really look close enough at it.
Merged it in.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline toradrow777

  • Jr. Member
  • **
  • Posts: 57
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1625 on: November 22, 2016, 12:46:36 PM »
I know this has most likely been asked and answered a million times by now, but I just gotta know: When looking at job ratings, I noticed that some girls have a zero "0" instead of a letter, question mark, or exclamation mark in front of the job name, and the in-game help doesn't say what it means.  What does the zero mean?

Offline _rhetorik_

  • Jr. Member
  • **
  • Posts: 63
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1626 on: November 24, 2016, 06:01:31 PM »
Just made a pull request to Joey's repo with the following changes



- Fix an error when loading girls with custom scripts: missing path separator.
- Improve is_pregnant indicator to have more info when the girl isn't on preg cd or pregnant.
    - Vg.: Virgins, No+: Fertile, No++: Broodmother.
- Nerf clinic income (might need a bigger one).
- Minor boost to constitution on cleaning (brothel and house) jobs.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1627 on: November 27, 2016, 05:03:50 PM »
I know this has most likely been asked and answered a million times by now, but I just gotta know: When looking at job ratings, I noticed that some girls have a zero "0" instead of a letter, question mark, or exclamation mark in front of the job name, and the in-game help doesn't say what it means.  What does the zero mean?
0 just means the calculation resulted in exactly 0.

Just made a pull request to Joey's repo with the following changes
- Fix an error when loading girls with custom scripts: missing path separator.
- Improve is_pregnant indicator to have more info when the girl isn't on preg cd or pregnant.
    - Vg.: Virgins, No+: Fertile, No++: Broodmother.
- Nerf clinic income (might need a bigger one).
- Minor boost to constitution on cleaning (brothel and house) jobs.
I will get it in shortly.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline skriveavis

  • Newbie
  • *
  • Posts: 22
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1628 on: November 30, 2016, 12:12:35 PM »
Just made a couple of minor pull requests. This is my first time ever using github tho, so no idea if I'm doing this correctly.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1629 on: December 01, 2016, 08:27:43 PM »
Just made a couple of minor pull requests. This is my first time ever using github tho, so no idea if I'm doing this correctly.
Got them in.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
.06.02.40-49
« Reply #1630 on: December 01, 2016, 11:44:34 PM »
The Main thread is here - http://www.pinkpetal.org/index.php?topic=3446.msg27861#msg27861


You must start a new game when moving to .06
* If you find a bug, please report it on the bug thread - Crazy and PP's mod bug thread
* For discussion of the game, use Crazy's original thread - Combining the big mods aka crazy's mod
* For Items discussion or to submit your own Items - ITEMS - Help Wanted - also taking new items
* For Suggestions or Requests for new content (Not Girls) - Possible Add-Ons to the Game?

* Warnings For Version .06.02.00


Version: .06.02.40 - https://mega.nz/#!kABSAIbC!Q9V3i7hBjGW5dXhOARsCQfLRJ6JqcJ-bm_Uq-chMK9U
WME.8.32 included
* Changes made for .06.02.40 -
Merged 2 pull requests of a few text corrections by skriveavis.
Changed how config.xml files are loaded to hopefully fix a couple of problems.
Added several items to Jeweler job (more need to be added)


Version: .06.02.41 - https://mega.nz/#!NIYnwTib!OhchRB-l0E_xolVWekzI0Umw-js_VJPj3QG5EDNzuyc
WME.8.32 included
* Changes made for .06.02.41 -
Fixed a few typeos.
Fixed some column offsets in J_1024x768 interface
Updated gang missions:
 - Added "Masked Vigilante" to Pety Theft
 - Cleaned Grand Theft
 - Added Service skill to gangs
 - Added Service mission
 - Allow 1 to 15 gang members in training and service instead of the minimum 5. Shows yellow if <6 members
Added Player gold to gang screen
Added g_Brothels.GetRandomBrothel() function


Version: .06.02.42 - https://mega.nz/#!MQ4XmIzL!XJzvi7Kn5UBmgwPMbCKQKo1L1PllqWzkoHwexQJ1o10
WME.8.32 included
* Changes made for .06.02.42 -
Fixed a few more column offsets in J_1024x768 interface
Rewrote sell slaves from dungeon text to itemized list
Added Player Gold to many screens
config.xml in release used the testing numbers, changed it back to release numbers.
Fixed/added text in gang grand theft mission
Removed from the settings screen all the things that were not completed
 - Folders and Catacombs are working.
 - (Gang gets what is overridden by the savegame so is not really needed)


Version: .06.02.43 - https://mega.nz/#!RJo0yLLB!nbh2aETQ6irU7Ns5FdMba-I7qixn8nwvRDjxbN7myxA
WME.8.32 included
* Changes made for .06.02.43 -
Separated house jobs into main and training
Added Sexual Orientation training and Fake Orgasm training to the house
Fixed several "/n" to "\n" in texts
Added a bunch of items by Cavey


Version: .06.02.44 - https://mega.nz/#!hc4RHDhQ!MNEwLehWVGPLd7jtsiVfQixU-Haz4hy6MtSNOxqOrQ0
WME.8.32 included
* Changes made for .06.02.44 -
Updated WorkExploreCatacombs.cpp
 - fixed a few bad texts
 - allowed the control girl section to allow any girl to explore even if she can't fight.
 - Updated the uncontroled girl failed combat check text
Updated all calc_insemination functions to use g_Girls.GetBeast() instead of using a customer or the player
Fixed 4 bugs reported by blx
 - "Game crash when you deselect all girls on brothel screen by pressing Ctrl + LMB."
 - "On girl detail screen hotkey for list girls backward (left arrow "←") list girls forward."
 - "All progress on new "Sexual Orientation training" and "Fake Orgasm training" reset after game load."
 - "Messages about growing children stacks: second contains the first, third contains both previous."
Added a few texts to WorkFreetime.cpp by MuteDay
Added some texts to Sexual Orientation training and Fake Orgasm training


Version: .06.02.45 - https://mega.nz/#!kZhFEY4K!8g53bVLsfdUrjzqZFKM0DyVtYIh5nEVqixLsy3YWr4E
WME.8.32 included
* Changes made for .06.02.45 -
Fixed a bug in the arena with duplicate turn summary messages (my bad)
Added EVENT_WARNING when girls get taken off work by matrons
Fixed a crash in cGirls::AddInv() if no item is given
 - fixed item spelling in GirlFucks (Ring of the Hivemind)
Fixed a crash if a gang dies durring their mission.


Version: .06.02.46 - https://mega.nz/#!MYxBlDqb!jaCmLGN4_obCHrU2Ukstkggq1v50-mldLwBTzsdENAU
WME.8.32 included
* Changes made for .06.02.46 -
Updated Slave Market send to Brothel effects
Updated Sexual Orientation training and Fake Orgasm training numbers


Version: .06.02.47 - https://mega.nz/#!5AojlA5Q!H3xdgMU_iOKEJWqEtCTMqAeLHGvEMppgLVIny7eBEEI
WME.8.32 included
* Changes made for .06.02.47 -
Fixed a few typeos
Updated do_daily_items
Updated WorkFreetime.cpp with a couple of items
Fixed slave market no girl image
Fixed a few text items in clinic jobs
Added SO to girl lists
Updated Gang Service mission
 - Added cat/dog capture
 - Added cleaning of brothel in security check sub-mission


Version: .06.02.48 - https://mega.nz/#!pFAlmSoK!3C4NNns3VtY1SCv-Uu0Dv1NhLpDYC8oV0wgIxyS0FVU
WME.8.32 included
* Changes made for .06.02.48 -
Replaced most instances of HasTrait(girl, "Virgin") with CheckVirginity(girl)
Fixed SO and FOE pay
MuteDay updated cGold.cpp/h
Merged pull requests by skriveavis: a few typeo fixes
Added dark events to WorkFreetime by MuteDay
 - I added more variations to them
Rearranged WorkFreetime and added death message if needed


Version: .06.02.49 - https://mega.nz/#!1cg1BS6B!G3wwYULCssVLaC-yeKVuWJIF7op1k79qDror6uCllSs
WME.8.32 included
* Changes made for .06.02.49 -
Fixed Constructs not healing with item use
Updated SO and FOE
 - Added Tiredness, Exp and enjoy
 - Added improvement list
Added the list of girl folders that are used by the game to simple save .q file
Started Updateing WorkPersonalBedWarmer.cpp but got sidetracked
Added WorkCureDiseases.cpp (See http://www.pinkpetal.org/index.php?topic=3433.msg42732#msg42732 for info)
Added Panacea's Miracle Cure.itemsx by Cavey
« Last Edit: December 27, 2016, 02:21:45 AM by aevojoey »
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline KingofKings

  • Newbie
  • *
  • Posts: 32
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1631 on: December 02, 2016, 05:02:31 AM »
Version: .06.02.40 -
WME.8.30 included
* Changes made for .06.02.30 -
uhhh... whoops?

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1632 on: December 02, 2016, 08:44:50 AM »
uhhh... whoops?
:-[

Also I had forgotten to push to github so I did that now.
 
« Last Edit: December 02, 2016, 10:32:14 AM by aevojoey »
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline ertl

  • Newbie
  • *
  • Posts: 6
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1633 on: December 04, 2016, 10:58:35 AM »

One suggestion:

In the turn summary, for the bedwarmer job, you get a paragraph such as:


"You order the <number> slaves warming your bed to put on a show, blah blah blah".


If you have a large number of slaves, it's a little bit unrealistic to have something like 50 slaves putting a show in front of you. So, my suggestion would be either export to a settings variable the maximum number of slaves per show in your room (a default of 2 to 5 could be ok, I guess), that would be selected randomly from among those slaves ready to bedwarm you in that moment, or simply drop that number to that default 2 to 5. I think exporting that to a settings variable would be great.

Offline 790 Series Lusticon Operations Unit

  • Full Member
  • ***
  • Posts: 155
  • I worship His Shadow.
Re: Combining the big mods aka crazy's mod .06 is out now
« Reply #1634 on: December 04, 2016, 05:11:59 PM »
You ever stop and consider all the time, effort, passion and love that those 50 slaves put into learning and practicing a song and dance number just so that they could please their master?!
May His merciful Shadow fall upon you.