Couldn't duplicate that error after some quick tests.
Now on to some trivial stuff not worth your time.
I was still not having the goblin shaman show up in battles, so changed mobs.json file to have shgobl.png for shaman, decided to go through some more files and noticed some spelling errors.
In traits.xml If I were to change these would that break every reference to them? Or does it auto update all references? I added the comment bits...
<trait
id="Exhibitionnist" #Exhibitionist
<trait
id="Dependant" #Dependent(opposite of independent), dependant makes me think they are someones child/underage/someones responsibility.
Also - this description is incorrect.
<trait
id="Heavy Drinker" #Alcoholic? Needs alcohol to get through the day? The description seems to suggest they are a lightweight/cadbury.
desc="She just can't hold her liquor." #She drinks a lot/She loves a drink? Can't hold liquor means you get drunk easily, feel the effects easier.
temp='0'>
<trait
id="Edgy"
desc="This girl is very nervous and jumpy."
temp='0'>
Technically correct, but I associate edgy with being 'at the forefront of a trend; experimental or avant-garde.' Doing something different/controversial. Am I the only one?
How about one of these.
tense, nervous, on edge, highly strung, anxious, apprehensive, uneasy, ill at ease, unsettled, unstable;
excitable, twitchy, jumpy, keyed up, fidgety, restive, skittish, neurotic, brittle, hysterical;
sensitive, insecure;
irritable, touchy, tetchy, testy, crotchety, irascible, peevish, querulous, bad-tempered, short-tempered, hot-tempered, quick-tempered, temperamental, snappy, captious, crabbed, prickly;
nervy;
Nervous, Anxious, Insecure and Skittish look like a good fit. But perhaps Edgy is more common elsewhere than where I live.
If they were simple string spelling errors I would just change and merge/push...
I generally spot a mistake in game, then scramble about trying to find the right file to change. Still building up motivation to go through the folders systematically to fix spelling.
I sure am a nitpicky bastard, ha.
Spelling error, yes.
As far as dependant/dependent goes. It should be dependent, but technically both share the same overlaying definition.
as far as heavy drinker and the description goes, shouldn't it be more like:
id="Heavy Drinker" (or
Alcoholic w/e)desc="Can drink still the sun comes up."
id="Lightweight"
desc="She just can't hold her liquor."
but if the trait is pointing towards an addiction, then alcoholic should be used. Still not to be confused with 'wino'
Also, for 'edgy', the word closest what you are looking for is 'skittish'. if not enough people know this word, 'anxious' or 'nervous' are simple enough.
Well, we do have Fearless trait. I widely used Edgy as its antonym.
We also could use your Loner trait in the future, when it will make more sense due to relationships between girls.
If it's the opposite of fearless use 'coward' or 'cowardly'.