General Discussion

[DarkTl]

Now, now, it's too early to give up after just one single night. When I worked as a coder, I had weeks of sleepless nights before making stuff work perfectly 

 SimPy has a repo at bitbucket with issues and stuff, but I think you should ask PyTom why renpy doesn't work with it, since it clearly works in many other cases.
I believe no one ever tried to use them together, at the renpy forum the only "simpy" you can find is "simply" with a typo 

[Xela]

Well, I chatted with PyTom and Shadow yesterday, they both said the same thing (which I already knew): the generators cannot be pickled. I was hoping that it could be done after they are destroyed but that is not a case, not in Ren'Py anyway.

That means that we can use them for jobs exactly like I've coded them (and I wasn't crazy, they worked before somehow), I just need to figure out how these generators are leaking to store in the current code...

===
It will not be possible to code the SE as I planned, but there should be a workaround there as well.

[DarkTl]

Since I'm not sure about the level of quest system's adequacy right now, thus cannot make events, I'm going to learn some python via codeacademy.

[Xela]

Since I'm not sure about the level of quest system's adequacy right now, thus cannot make events, I'm going to learn some python via codeacademy.

Oki, have fun. I'll try to take a look at the quests tonight if I get a chance. I pushed a quickfix for the console/save thing. Seems to be working just like before. Gotta work now.

[lamoli]

Im back but i have a lot of work now.. so to advance on what i was working before i would need someone to give me concept art for the clothing (like the stuff you see online) but with your pick that would match Pytfall clothing ( or even if drawn by hand then scanned is good for me ) its just to get the idea on how if should look like.. front view is a minimum but if you have side and back as well ill replicate it perfectly and faster as well since i woulnd waste time on trial errors..

I did try to make those for a few days before i left for vacation but its going nowhere.. so with the little time i have now its best if someone provide me with the concept art and ill make it a wearable in game clothing.

Im after those clothing design first:

1 Prostitute ( dressed ) need a few concept on those.. maybe 3 to start
2 Strippers ( something else to remove till get to under wear ) somehow almost all the pics iv seen they are already in underwear >.<
3 Formal ( i still have no idea on how it should look like... )
4 Barmaid ( nothing there atm ) might need a difference from normal cafe and night club like for the waitress
5 Clothing while not working ( could go from normal outfit when going out to sleeping one ) how does normal looks like in Pytfall lol
6 gambling hall girls ( bunny / card handler like in the anime Rio? ) or something Pytfall like
7 Waitress ( i have some maid outfits i could color and add fabric patterns to make look like 1 ) then again a Pytfall concept art would be better (Also might be different if night club waitress)
8 Nurses ( i got the typical outfits you sell in most anime ) but might need something more Pytfall like
9 Maids ( i got a few common concept there ) but something more Pytfall like coulnd hurt as well as new ideas.

With a few concepts from 1-5 i could make random girls pack as other than clothing almost everything is ready.

[DarkTl]

You worry too much about matching clothes. Remember, people can make a pack for any character, thus there could be any clothes, even futuristic ones. Also when you make a pack, you cannot know for sure what kind of images the character will have, thus many types of clothes are acceptable for a tag.
Of course we should avoid futuristic stuff when possible, but other than that, there is no a certain, detailed and strict pattern.

1-2. Strippers and prostitutes don't have a certain uniform. They could use revealing clothes more freely, yeah, but they don't have a special, working clothes. When we show them at work, it means any pics with sex. Examples of revealing clothes from my last pack: one, two.

3. Formal are usually dress that is too fancy to wear it every day. More examples: one, two.

4. Barmaid pictures are so rare that in all my packs there are like 2 pictures that could be considered as barmaids. We used to have this tag, but eventually gave up and removed it. So even if you render barmaid pictures in your packs, pretty much all other packs won't have them anyway. And of course it also means that we don't have a decent examples to render it in the first place, so just give up on it.

5. Clothes that are normal = not formal, not revealing. In some cases they even could be unique, like maid or miko, if the character wears them 99% of the time.
You pretty much can take any clothes, from neptunia or deviantart for example, and call them normal for one single character pack. I'll say it again, we don't have a strict example that you must follow. In existing random packs many characters simply use schoolgirl uniform as normal one. Or similar clothes like this. Another example, and one more. As you can see, we take any casual clothes as normal ones, trying to avoid futuristic ones if possible.

6. Gambling tags are based on suitable background, ie casino with any clothes. When we don't have it, we begin to use bunny pictures. Another way is to add cards or casino chips to the picture.

7. Waitress is an action. It's not based on clothes, it means a girl (not nude or close to it) that works as a waitress. In many cases she also has maid dress, but not always, far from that in fact. Example in normal clothes.

8. No strict concept, but there is a difference between nurse and healing, I want to tell it just in case. Healing is something like this, ie she is not stripping or having sex or sleeping, etc.

9. Your maid clothes are perfect, there is no a "Pytfall concept". I can, however, give an example of night club waitress, basically revealing maid clothes.

[DarkTl]

Tagger update. I rewrote function that generates mask. Before it made masks like *tag1*tag2*, and in some cases it gave wrong images if first two tags in the mask formed an existing index. Now it makes masks like *-tag1*-tag2*, excluding matches with indexes.

[Xela]

Have you considered stereotypes for random girls? Like "Maid", "Miko", "Archer" and etc.? With the main difference of profile, vn, battle sprite and portrait being consistently stereotypical. Same with clothes ripped and undressing/stripping. Other clothing as sensible. That will be kinda cool... like in bunny black. Also it will be possible to create at least 70% of all randoms with correct patterns... other 30% at random just for the fun of it.

[DarkTl]

This part

        def next_day(self):
            """
            Fails quests that have no valid events.
            """
            garbage = list()
           
            # Find incomplete quests with no existing events
            for i in self.active:
                for j in pytfall.world_events.events_cache:
                    if j.quest == i.name:
                        break
               
                else:
                    if not i.manual: garbage.append(i)
           
            while len(garbage) > 0:
                devlog.warning("Garbage Quest found! \"%s\" was failed."%garbage[0].name)
                self.fail_quest(garbage.pop())

should be bad for existing quest structure because I don't use events since they are too tricky. However I never had that message about garbage quests, weird.
Yeap, quests become failed after next day, even though we don't see that in journal. Console shows it.
Meaning it's a double issue. We don't see them failed while they are, and they shouldn't be failed in the first place.

[DarkTl]

Yup, removing that system makes quests work as intended. I disabled that system, you will need to rewrite it if you want to use it somehow.

[Xela]

Noted, maybe there is a "manual" argument that we don't use... according to the code you posted, quests will not be thrown in garbage if manual returns some form of True.

===
I wanna try to wrap up and test menu extension today, it's a cool feature that is almost ready + some stuff about it is still in my head since last night. Once that's done, I'll cook up some testing testing code for quests and see what's what.

[Xela]

Yup, removing that system makes quests work as intended. I disabled that system, you will need to rewrite it if you want to use it somehow.

Code: [Select]

def __init__(self, name, auto=None, manual=None):

manual = Whether the quest will be manually updated, instead of by event. Prevents garbage failing.

Could you please try enabling that code and adding manual=True to quest registration?

[Xela]

@Dark

Another question, what do you think about the new interface brightness? Gismo changed most of the elements in GUI to make them darker with more vivid colors, to me it seems a bit of an overkill. We need another opinion (or two if anyone else reads this).

[DarkTl]

Yeap, manual=True worked too.
I'm totally fine with new dark gui. That's why I have "dark" in my account name 

I don't understand the difference between double quest functions, like register_quest and register_quest_in_label.
I mean, why would you want to register a quest in label when you can do it in init?

[Xela]

I don't understand the difference between double quest functions, like register_quest and register_quest_in_label.
I mean, why would you want to register a quest in label when you can do it in init?

Several reasons... Quests in init will not be added to the game but will be created every time you start Ren'Py... If you are expanding your quests and want to enable that addon without forcing everyone to start a new game, you can also do that only from labels. Loads of reasons I guess... I can't think of a few other reasons as well but it's not important, if you want to do that in init, do so