General Discussion

[Xela]

I need to access character inside def __init__(self), where you set self.disposition_threshold, in order to run checks there. Looks like normal means like char of self.worker don't work.

You can't do that, it's a constructor. You can write a separate method for checking and call it inside of a func instead of using threshold directly.

[DarkTl]

Ohhkey, for testing I did it like

def __init__(self):
...
    self.disposition_threshold = self.determine_disposition_level
....
def determine_disposition_level(self):
      disposition = 300
      return disposition

And it never appears in the job list regardless of disposition.

Seriously though, I mentioned that there will be checks, not just plain disposition level. And yet you code it in a way that gives me troubles with checks -_-

[Xela]

Seriously though, I mentioned that there will be checks, not just plain disposition level. And yet you code it in a way that gives me troubles with checks -_-

You misunderstood my proposal. I'll make a better code skeleton tonight.

[DarkTl]

Well? 

[Xela]

Well? 

My birthday party on Thursday turned out to be more fun than expected I am still recovering so I can't manage more than a couple of lines per day. You'll have a setup to work with tomorrow.

[DarkTl]

Happy birthday then! 

Mine is January 2, so I kinda kill two birds with one stone during the New Year.

[Xela]

Thanks

Setup is done, you can now either edit the general method for all jobs or add new specific method for individual jobs like:

Code: [Select]

class StripJob(...):
    bla bla bla...

    def is_valid_for(self, char):
        # bla bla bla

[DarkTl]

Yeah, looks like it works. Awesome.

[Xela]

I'll keep hacking at interface and it's functionality. Once that is done, we'll have a working system and I'll add guard and cleaning jobs which will be a lot simpler with SimPy (loads of complexity was added to those because we never had proper loops/order to work with before). After that is done, job events can be restored and we'll work towards improving that until we get sick of it and switch to SE/Arena/BE (again).

For me, main area of motivation atm is SE, I have loads of ideas for it and code should be a lot clearer and more awesome with Ren'Py.

[DarkTl]

What about free characters leaving with low disposition?

[Xela]

What about free characters leaving with low disposition?

I think that happens in the Char.next_day() method.

[DarkTl]

For some reason I don't see stripper job available, even for slaves which don't have any restrictions.

[DarkTl]

Service jobs are less ready for my lines than I thought. For a start some of them have their own check_occupation, and some don't. At the same time we have

    class ServiceJob(NewStyleJob):
        """The class that solves Bartending, Waitressing and Cleaning.
       
        TODO: Rewrite to work with SimPy! *Or this actually should prolly be split into three Jobs...
        """
        def __init__(self):
            """
            This is meant to pick a job that makes most sense out if Cleaning, Service and Bartending
            """

which has its own check_occupation.

Looks like you will need to clean service jobs a bit to make it as understandable and clear as whore and stripper parts.

[Xela]

For some reason I don't see stripper job available, even for slaves which don't have any restrictions.

I'll take a look...

Service jobs are less ready for my lines than I thought. For a start some of them have their own check_occupation, and some don't. At the same time we have which has its own check_occupation.

Looks like you will need to clean service jobs a bit to make it as understandable and clear as whore and stripper parts.

It will require new code practices, I'll prolly structure it as a SimPy Resource Process on request. They would have to be split I think, we'll see how it pens out...

===>>
We need to think about meaningful upgrades/matron mods/events for all jobs.

I am still hacking the interface one frame at a time due to lack of time but it is slowly moving forwards, I'll push a number of small fixes tonight/tomorrow.

[DarkTl]

We used to have upgrades. Not the best ones, but not the worst ones either, they would be a good food for thought. Atm I don't even see their tracks in the code.