General Discussion

[DarkTl]

    {
    "id": "Poison Immunity",
    "desc": "Cannot be poisoned.",
    "resist": ["poison"]
    },

Works against the initial damage. But the skill still poisons the target, and damage over time works as usual. Same for absorption.
It shouldn't apply the damage over time in the first place.

I also fixed a crash for all absorptions due to the new way of handling damage, when attack/defense in "resist = pow(attack/defense, .5)" was negative for absorbed elements leading to exception.

[DarkTl]

Everything that ends with a "bonus" expects a tuple, like:

Code: [Select]

"evasion_bonus": (2, 10, 100)
would mean that ev bonus is at least two at lower levels and 10 at level 100 and above.

Ok, so for items +10%=0.1 evasion bonus, but for traits +10%=10 evasion bonus? Make it consistent 

[Xela]

You mentioned that instead ofI could use "resist": ["magic"]. This is not true, the trait stops working.

No... this was before the update, I wrote that this will not work anymore. I'll take a look anyway.

I tested healing immunity, it doesn't work as intended. If you give it to one of the girls in battle team, both girls become immune to mass healing spells. I'm not really going to use it for characters, but it's probably true for mobs too.
I never tested it properly before, so I dunno if it started to act weirdly after rewrite or not

Gonna look into this right now.

Works against the initial damage. But the skill still poisons the target, and damage over time works as usual. Same for absorption.
It shouldn't apply the damage over time in the first place.

I also fixed a crash for all absorptions due to the new way of handling damage, when attack/defense in "resist = pow(attack/defense, .5)" was negative for absorbed elements leading to exception.

This is a bug, weird... I recall trying to prevent it. Gonna grab your changes and take a look as well.

Ok, so for items +10%=0.1 evasion bonus, but for traits +10%=10 evasion bonus? Make it consistent 

I thought it was consistent in a sense that everything that requires floats is called multipliers and everything that calls for ints is called bonuses. Do you want me to change multi to bonus for items as well?

[Xela]

No... this was before the update, I wrote that this will not work anymore. I'll take a look anyway.

This is very easy to add, but we need to be careful because for example magic immunity would also block healing. It's your call, I can make this work like before without a fuss.

[Xela]

Gonna look into this right now.

Dumbass mistake on my part, should be fixed with the next push.

[DarkTl]

I thought it was consistent in a sense that everything that requires floats is called multipliers and everything that calls for ints is called bonuses. Do you want me to change multi to bonus for items as well?

It is consistent in that sense, sure. But why do you use both floats and integers in different places for the very same stat? The only thing it achieves is makes my part harder 
I don't care which one it will be, but it should be only one.

This is very easy to add, but we need to be careful because for example magic immunity would also block healing. It's your call, I can make this work like before without a fuss.

I separated healing immunity from magic one to have more control, it's not needed any longer.

[Xela]

This is a bug, weird... I recall trying to prevent it. Gonna grab your changes and take a look as well.

I did try but poorly, should work now with resistance. I am not sure about absorption... I am prolly missing some obvious way of doing this.

[Xela]

It is consistent in that sense, sure. But why do you use both floats and integers in different places for the very same stat? The only thing it achieves is makes my part harder 
I don't care which one it will be, but it should be only one.

Ints are better here, I'll update the code and mass rename the fields with my next push.

[Xela]

I separated healing immunity from magic one to have more control, it's not needed any longer.

Oki, so we don't add it for now.

I have not renamed any item fields, heavy armor and weapons should prolly come with great evasion penalties too but this items stuff we'll prolly be working on for a looong time to come. Maybe someone will help out after the release...

Everything you mentioned should be fixed.

[Xela]

I've killed two BE issues and consolidated everything into one:

https://github.com/XelaPy/PyTFall/issues/168

Gonna go thought the rest of the issues to recall what else needs to be done and take something out from this BE checklist (if time permits).

[DarkTl]

Everything you mentioned should be fixed.

Yeah, except the poison absorption. I suppose you could rewrite the poison code to make it use poison element which will be absorbed every turn if you cannot simply disable poisoning.

heavy armor and weapons should prolly come with great evasion penalties too but this items stuff we'll prolly be working on for a looong time to come. Maybe someone will help out after the release...

That would require a way to show that an item reduces or increases evasion, otherwise we force people to read items descriptions all the time. I'm not talking about showing numbers, it could be items subclasses like light and heavy which are visible in the gui, or very small icons that indicate how item changes BE values.

[Xela]

Yeah, except the poison absorption. I suppose you could rewrite the poison code to make it use poison element which will be absorbed every turn if you cannot simply disable poisoning.

Right, I'll take a look now, try to figure out what's best.

That would require a way to show that an item reduces or increases evasion, otherwise we force people to read items descriptions all the time. I'm not talking about showing numbers, it could be items subclasses like light and heavy which are visible in the gui, or very small icons that indicate how item changes BE values.

I love when that happens, some hidden item effects that you'd expect and may or may not be hinted towards in the description!

=======>>>
I've killed some old Issues, consolidated a few others, still looking at them...

[DarkTl]

I love when that happens, some hidden item effects that you'd expect and may or may not be hinted towards in the description!

You propose almost every item to change evasion. At this point it's no longer a hidden effect, it's a routine mechanics.

[DarkTl]

The good news is physical "element" works as intended, now we'll have some decent high level undeads which cannot be easily or at all damaged by normal weapons 

[DarkTl]

Xela, you destroyed items evasion just now 

                        # Items bonuses:
                        temp = 0
                        for i in t.eq_items():
                            if hasattr(i, "evasion_bonus"):
                                m += i.evasion_bonus
                        ev += temp