General Discussion

[DarkTl]

Let's say we have "evasion_bonus": [-15, -10, 50] and level 10.
temp = max(-15, 10*(-10)/50) = max (-15, -2) = -2

So "evasion_bonus": [-15, -10, 50] gives -2 evasion at level 10. It's ridiculous.

[Xela]

You can still use fixed negatives like in my example. Do we really need to add if/else forks for this?

[DarkTl]

The idea was that characters learn to overcome their weaknesses a bit, but ok, we can live without it.

[DarkTl]

There is add_beskills field mentioned in your post about class traits, which should in theory add BE skills. In reality though it does nothing but exists in the code, and probably should be removed.

I'm also confused about the mod field for class traits. We actually almost removed it from normal traits because we have a much better one, mod_stats. It only remained for special stats like upkeep and disposition.
However when I see stuff like

        "mod": {
            "magic": 10,
            "upkeep": 5,
            "intelligence": 5
        },

in a class trait, I can't help but wounder how will it work, since the mod field used to apply 10% of stat every 5 levels when we used it for normal stats, thus rising upkeep infinitely.

Either way, there should be consistency in traits. If mod field only increases once special stats like upkeep for normal traits, then it should do the same thing for classes. If we have support for mod_stats for normal traits, classes should support it too.

[DarkTl]

For some reason I get

  File "game/library/be/labels.rpy", line 26, in script
    python:
  File "game/library/be/labels.rpy", line 68, in <module>
    battle.start_battle()
  File "game/library/be/core.rpy", line 169, in start_battle
    self.main_loop()
  File "game/library/be/core.rpy", line 117, in main_loop
    s(t=t)
  File "game/library/be/core.rpy", line 536, in __call__
    self.time_gfx(t, died)
  File "game/library/be/core.rpy", line 1244, in time_gfx
    self.timestamps[stamp]()
  File "game/library/be/core.rpy", line 1527, in show_target_damage_effect
    color = getattr(store, target.dmg_font)
AttributeError: 'StoreModule' object has no attribute '#7cfc00'

after trying mass heal in BE.

[Xela]

I'll take out the error soon. I wanted to leave traits to major refactoring, but if it pisses you off, I can take a look at them tonight as well, there are loose ends like that because we change concepts a lot in a very logically complex game.

[DarkTl]

It should be done before the beta. Because completely usable, working classes will be needed for it.

[Xela]

Ok, I'll take a look at traits. The healing spell crash is fixed, code is getting to vast for me to keep everything in check so there are increasingly more and more errors.

[DarkTl]

I think I'll put the old elements descriptions in the library location. That's exactly the place for stuff like this.

How do you set spells for arena fighters? The log is full of errors about missing spells at arena, do you use characters data files?

[Xela]

There is add_beskills field mentioned in your post about class traits, which should in theory add BE skills. In reality though it does nothing but exists in the code, and probably should be removed.

I'm also confused about the mod field for class traits. We actually almost removed it from normal traits because we have a much better one, mod_stats. It only remained for special stats like upkeep and disposition.
However when I see stuff like in a class trait, I can't help but wounder how will it work, since the mod field used to apply 10% of stat every 5 levels when we used it for normal stats, thus rising upkeep infinitely.

Either way, there should be consistency in traits. If mod field only increases once special stats like upkeep for normal traits, then it should do the same thing for classes. If we have support for mod_stats for normal traits, classes should support it too.

Ok... so I've removed add_beskills from the code, I am not going to update docs cause we will change stuff and it takes too long. I am getting rid of mod field completely, we will use mod_stats for upkeep and disposition as well but only first index will be used ONCE on trait application or removal and everything else will be ignored.

I am also looking into this stats_mod code really closely tight now, I think it may be completely fucked at the moment (as in not working as you'd expect it to, but I may be wrong, it's a complex and intertwined system)...

[Xela]

I think I'll put the old elements descriptions in the library location. That's exactly the place for stuff like this.

How do you set spells for arena fighters? The log is full of errors about missing spells at arena, do you use characters data files?

No, I hard code that stuff. Arena review is on our todo list.

[Xela]

Just pushed again. mod field is gone as well, index 0 from stats mod field will be used for upkeep and disposition ONCE on traits application, rest of the indexes are ignored. I've also worked out a nasty bug that would have created massive, hard to trace "snowball" effect if a trait that modded stats were to be applied at higher levels. I expect that a trait that had 3+ stats to mod would have turned any character into a freaking monster if applied at level 100+

[DarkTl]

Ohhkey, I added "upkeep": [1000] to mod_stats of one of the traits, and nothing happened in the game.

[Xela]

Ohhkey, I added "upkeep": [1000] to mod_stats of one of the traits, and nothing happened in the game.

I keep fucking up when changing old code. Try again...

[DarkTl]

Ok, I have "disposition": [1000], "upkeep":[1000] now. Disposition works. Upkeep doesn't.