General Discussion

[DarkTl]

My point still stands. Making items and traits work in different "layer", independently of characters maxes, will make everything simpler.

[Xela]

Not really... We have separated char stats from items and traits stats but I don't see how max/min dicts will benefit from the same arrangement. Problems that we had with them were along the lines of combinations of crazy items and traits lowering max below min or pushing min above max. It was also reported to GUI in a seriously messed up ways. Splitting them will not protect the system against that. Our safeguards seem to be doing ok for now and maybe I am offbase here... I have about an hour right now so I'll rename some stuff and look into how else stats code could be refactored.

[DarkTl]

There won't be need to check if bonuses provided by items are higher that character maxes, and there won't be need in double system of maxes, ie max and lvl_max. Although, it will make all items more powerful too.

As for min...
The min field is truly useful only in a few cases. Here it freezes joy at 50.

Code: [Select]

    {
    "id": "Mysterious Gray Ring",
    "desc": "«If early day, or late at night, it's not my problem, I'll be alright. No cause you name is worth the fight, but if I'm bored, then yeah, I might.»",
    "icon": "content/items/ring/gray_l.png",
    "price": 5000,
    "sex": "female",
    "chance": 1,
    "badness": 0,
    "eqchance": 5,
    "hidden": false,
    "infinite": false,
    "slot": "ring",
    "max": {"joy": -50, "magic": 150, "mp": 150},
    "mod": {"luck": 5, "defence": 100},
    "min": {"joy": 50},
    "evasion_bonus": 2,
    "damage_multiplier": 0.05,
    "defence_multiplier": {"melee": 0.1, "ranged": 0.05, "magic": 0.05},
    "locations": ["Exploration", "Fishing"],
    "goodtraits": ["Indifferent"]
    }And this one makes sure character will always have at least 5 mp.

Code: [Select]

    {
    "id": "Rune Staff",
    "desc": "This staff is constantly drawing energy from other planes of existence and channels it to its wielder.",
    "icon": "content/items/sweapon/rus.png",
    "price": 3000,
    "sex": "unisex",
    "chance": 10,
    "badness": 50,
    "eqchance": 50,
    "hidden": true,
    "infinite": false,
    "slot": "smallweapon",
    "type": "rod",
    "max": {"magic": 100, "mp": 100},
    "mod": {"magic": 40, "character": 50, "attack": -80},
    "min": {"mp": 5},
    "delivery_bonus": {"magic": 50},
    "delivery_multiplier": {"magic": 0.1},
    "locations": ["Exploration"]
    }In all other cases min field is almost cosmetic, because the chance of it being used is super low.

I suppose the staff could just restore mp every day. But since effects are ineffective against jobs and items, I can't really achieve the same result for the ring by using effects. We can get rid of all min fields entirely any time as long as you provide other means to freeze a stat reliably. Ie just to have a fixed stat value no matter what as long as an item or a trait is equipped.
Yeah, for traits too. We had to get rid of retarded trait because it didn't prevent intelligence from increasing, giving enough time, so it had little sense. But if it freezes intelligence at 10, then it works as it should.

[DarkTl]

Now maxes...
Even if we get rid of artificial bonuses to min values, there is still a possibility that negative max will bring stats to zero.

We cannot get rid of max penalties completely. Training and consumables can easily enough overcome simple penalties to current stat values, making them ineffective.
We could replace absolute negative penalties by relative ones. "max_penalty": ["agility" : 0.9] would mean current agility*0.9, max agility*0.9 and min agility*0.9.

[Xela]

So with other words "no"... we cannot try and make sure that stat limits don't get fucked by content and will have to keep trying normalize that on code level I got it.

I've been trying to improve code readability whereever possible in the stats system and to try and make sure that all calculations go through the same checks and routines. I believe code is getting more manageable, although slower that I would have liked.

[DarkTl]

I dunno what to do about max field yet...
But I bet that freezing stat is much easier than logic for min field.

[Xela]

I dunno what to do about max field yet...
But I bet that freezing stat is much easier than logic for min field.

Nothing... system is working at present, does it not? I can look into adding even more checks if we run into more crazy shit like a trait modding min joy to 50 and some item modding max joy to 40 and you'd get some crazy crap like 50/40 joy in GUI at some point, but for now I just want to clean up what we have at the moment before adding more if/else forks to it, especially before we get actual cases with issues.

[DarkTl]

No, there won't be such things, unless they will be added by players. Moreover, I like how joy becomes 0/0 after equipping two such rings, works as it should 
Should be the same for 50/40 cases, I think. If something breaks the logic, we make it 0/0. Or 1/1.

[DarkTl]

How about adding descriptions and tooltips for effects, just like traits have? Or you are against it?

[Xela]

Or you are against it?

Ofcourse not, you can just add them to the definition dicts as "desc": "description text". It's very easy to add them to interface.

[Xela]

We are now allowing traits for MC, I wonder if we should allow effects as well. Desc will now appear in girls profile if you add it.

[DarkTl]

Certainly. Food Poisoning and Caught a Cold, Poisoned effects are universal, and in fact already can be available for MC.

[Xela]

Certainly. Food Poisoning and Caught a Cold, Poisoned effects are universal, and in fact already can be available for MC.

Oki, I'll have to look into adding effects dict to mc and gui.

[DarkTl]

The game is not launching after our combined merges 

Code: [Select]

  File "game/script.rpy", line 110, in script
    python:
  File "game/script.rpy", line 116, in <module>
    chars = load_characters("chars", Char)
  File "game/library/functions - loading_data.rpy", line 138, in load_characters
    char.apply_trait(traits[trait])
  File "game/library/characters/classes - characters.rpy", line 2420, in apply_trait
    self.traits.apply(trait, truetrait=truetrait)
  File "game/library/characters/classes - characters.rpy", line 306, in apply
    char.disposition += trait.mod_stats.get("disposition", 0)
TypeError: unsupported operand type(s) for +=: 'float' and 'list'
In the "Stats update" push you replaced

Code: [Select]

                for key in trait.mod_stats:
                    # We prevent disposition from being changed by the traits or it will mess with girl_meets:
                    if key in ["disposition", 'upkeep']:
                        setattr(char, key, getattr(char, key) + trait.mod_stats[key][0])with

Code: [Select]

                if hasattr(char, "upkeep"):
                    char.upkeep += trait.mod_stats.get("upkeep", 0)
                if hasattr(char, "disposition"):
                    char.disposition += trait.mod_stats.get("disposition", 0)You probably don't have active characters with traits with bonuses to disposition, unlike me.

[Xela]

I see the error but why is the depositions mod a list again?