Pink Petal Games

Game Discussion => General Discussion & Download => Topic started by: Konata on May 07, 2011, 12:04:31 PM

Title: r635
Post by: Konata on May 07, 2011, 12:04:31 PM
Well, I'm not good in sources and stuff, but it seems that there is a r635 version in SVN. Does anybody know if it's playable and stable? And can it be used as the base for user modification? IMHO this game has the potential to become particularly anything, from economic strategy to non-linear RPG and VN.
Title: Re: r635
Post by: trex on May 08, 2011, 07:06:57 AM
It hasn't been compiled, so no, it's not a fully developed release, and as you can see, those few files worked on for r635 are from 3-4 months ago. As you know there's r612 that has been compiled and released, for those interested, it can be found here: http://pinkpetal.org/index.php?topic=773.0 (http://pinkpetal.org/index.php?topic=773.0)


That release fixes corruption in save games where you get close to having over 280 items in your item list. (The game limit is 300). Let us know if it has any other changes, or bugs!



The big hurdle for development, at least months ago was that the devs agreed a conversion to xml format (from the existing code) would make future modders jobs much easier, and that they would then make solid tools compatible for the new code. The conversion is a big task, and it hasn't, and may never be completed.


At this stage, if you're inclined to, creating scripts out of the tools we do have availabe would be a nice addition to the game as there are very few scripted events for the game, and I don't think it's likely now any modded scripts would be rendered broken by the xml conversion. (They would be if it does go ahead, but at this stage, it's more of a question IF now then WHEN)
Title: Re: r635
Post by: Konata on May 08, 2011, 09:48:45 AM
Good, r612 is still better than r593  :)
Of course, new scripts will be useful for game, but I thought about other changes too. For example, girls definetely need more various skills, stats and traits, and that can be implemented only through source code editing.
But if conversion to XML will be done soon, there is no point of making this changes, yes. If I understood you properly, all game configs will be converted from C++ to external XML files? I also heard rumors here about developers with no motivation to worf further.
Sorry, English is not my native language and expressing my ideas using it is not easy :)
Title: Re: r635
Post by: Konata on May 08, 2011, 04:37:47 PM
Update. r635 compiled, looks like it works properly. Without revision.h and its functions, though. I had problems with this include.
Title: Re: r635
Post by: trex on May 08, 2011, 07:01:27 PM
So with r635, what's different from r593?


I don't know how far along the conversion is, and if it will be completed, someone from the Dev team will have know more. It has been a long time, but it could still be a possibility that it will still be done. That's why I think scripts are a safe and less work intensive thing to add to the game. You could work on editing the source for more significant changes, but like you said, it could be incompatible.
Title: Re: r635
Post by: Konata on May 09, 2011, 04:52:43 PM
Full changelog from devs here:
Quote
Updated: 1st Feb 2011

### r596 - Depreciated ###

### 599 - docclox ###
* Some tweaks to get this to build under Linux once again.

### 600 - Dagoth ###
* Updated VC++ 2008 project files

### 612 - WD ###
- cPlayer
* Added function cPlayer::Scale200 to change behaviour for player stats: m_Suspicion,  m_Disposition and m_CustomerFear
* Added function cPlayer::SetToZero() to reset player stats
* Checked all reference to cPlayer:: functions and stats and changed to inline getter/setters as needed

- cEvents
* Moved cEvent::CONSTANTS to Constants.h
* Added new events EVENT_GANG, EVENT_BROTHEL
* Added LISTBOX_COLOURs to Constants.h
* Added variable in CEvent::m_Ordinal to use for sorting event order
* Updated IsUrgent(), IsDanger(), IsWarning() in CEvent
* Added new getter functions in CEvent:: TitleText() and ListBoxColour() to simplify Turnsummary() code
* Added new functions in cEvents::IsEmpty() to simplify Turnsummary() code
* Added functions cEvents::DoSort(), cEvents::MakeOrdinal() and CEvent::CmpEventPredicate() to allow sorting of the event vector
* checked all calls to CEvents:: and replaced magic numbers with event CONSTANTS

-InterfaceProcesses::TurnSummary()
* myrikhan code for girls applied to all catorgories
* Simplified code by using new Event getters.
   NOTE: Message Title text is set in CEvent::TitleText() and Listbox Colours in CEvent::ListBoxColour()
* Used new function cEvents::DoSort() to sort events so that the correct event details are displayed on selection.
* Added Dungeon Girls goto button code.
* Added new warning messages for girls in cBrothel:: and cDungeon:: for health and tiredness to take advantage of myrikhan's display code.

- New Torture Class
* Split CBrothel class ->> cPlayer, cBrothel, cDungeon
* Added cGirlTorture adn cGirlGangFight from doclox branch
* Updated VC++ project files only 2010 tested
* Moved all torture code to cGirlTorture, same code for both player torture and girl job torture

- new Config Options
* added TortureTraitWeekMod to Inital and LogTorture to debug in config.xml

- Bugfix
* cBrothelManager::suss_text() to use Susipicion not Disposition
   
### r613 - WD ###
- Bugfix
* Update return values in cJobManager::WorkExploreCatacombs() so summary messages for job refusal is not generated incorrectly.

### r614 - WD ###
* added this changlist

### r625 - WD ###
- Code cleanup / bughunting
* Consolidate all Stats, Skills and Statuses strings to sGirl:: using defined constants not magic numbers
* Added missing Status Map code
* Moved map code to existing unused function sGirl::setup_maps()

* Remove code from sEffect:: to reference sGirl::

* Replaced all enum GIRL_ to const unsigned int STATUS_

### r626 - WD ###
* added this changlist

### r628 - WD ###
- bugfix
* Bugfix cGirls::child_is_grown() as reported by chronos in http://pinkpetal.org/index.php?topic=416.msg11968#msg11968

### r631 - WD ###
- bugfix
* fixed error in sGirl::max_statuses giving size of skills not status (copy paste error)

### r634 - WD ###
* Tidy double if in cGirlTorture::DoTorture()



About conversion, I think that developing team should give a hint whether or not we should wait it. I mean, several motivated modders can do a lot of things instead of waiting new code.
Title: Re: r635
Post by: trex on May 10, 2011, 01:39:53 AM
So, this r635, does it have a d/l link like r612 did in ghen's post (here:http://pinkpetal.org/index.php?topic=773.0 (http://pinkpetal.org/index.php?topic=773.0))?


Or do you get the new files from the trunk and slot them into their respective places? (doesn't it need to be compiled/built though to integrate the changes?)
Title: Re: r635
Post by: Konata on May 10, 2011, 06:37:36 AM
Just downloaded the latest trunk directory and compiled it with Visual Studio 2010. Got new exe (obviously). Also, there is a code and file (.cpp) for new job, Fluffer (what?), but after built it didn't appear in game.
Title: Re: r635
Post by: trex on May 10, 2011, 06:51:52 AM
Ok, do you have a copy of r635 you could upload?


Fluffer was a job that was part of the Erotic Films jobs (there was a few, I think acting in, fluffing, and being part of the crew were the jobs needed to make a film) If you have a copy of 1.29 or older, you could make films and make good money off it. They made new jobs and made it more complex to make films in 1.30, but they never got it to work (always making serious bugs) so they disabled those jobs. That's why they still don't show up in-game.


A fluffer is a person who keeps the porno stars in films aroused when they are waiting for the crew to set up the next scene. Maybe you already knew, but if not, that's what a fluffer does.
Title: Re: r635
Post by: Konata on May 10, 2011, 07:03:20 AM
Uploading .exe will be enough?
Title: Re: r635
Post by: trex on May 10, 2011, 07:15:34 AM
Well I don't have software to build the version out of, so if you have a copy of the version you have compiled and upload it, that'd be perfect.
Title: Re: r635
Post by: Konata on May 10, 2011, 10:41:22 AM
Let's try! Here is compiled exe from r635.  Backup your original exe and overwrite with this one. If all goes ok, there will be new skill (Morality), just added by me for future, not implemented in game mechanics.


http://www.mediafire.com/?m6rtuss75ftbrhr
Title: Re: r635
Post by: trex on May 10, 2011, 05:38:55 PM
Thanks konata! I tried it out just now, it did work, but only when I started a new game. I did see the morality stat for the girls, so it was working.
I got 'something went wrong with cc.brothel name' when I loaded save games from previous versions (r593/r485 save games)
Title: Re: r635
Post by: Konata on May 10, 2011, 05:56:11 PM
There is nothing I can do with saving compatibility. Maybe, your problem apperas due to changing code elements, removing or merging includes. I didn't touch files with name "Brothel", that's for sure. BTW, what about idea of adding more skills? Even Slave Maker has a lot of them, but not enough, I think. Someone could try this, if interested. I could, but have no experience.
Title: Re: r635
Post by: recreation on May 11, 2011, 08:05:22 AM
@konata: how did you get that uncompiled 1? im just getting server-timeouts when i try to connect to the svn soucre.
Title: Re: r635
Post by: trex on May 11, 2011, 08:33:58 AM
Well with skills, girls will always cap them out in 2-3 years, unless you make them do basically nothing most of the time. They're important I guess early on, and if you vary your gameplay with self-imposed restrictions (eg. I will play with no gangs whatsoever ect)


If you want to, I'm sure other players would enjoy having more skills to add into their playing mix. Maybe you could make a skill that is important but quite hard to improve (and easy to lose points in, eg. libido is a bit annoying to mess around with all the time, but you can try to manage it if you like micromangement!)


I'll try ghen's r612 and see if I get the same problem with saves, otherwise it probably just is incompatibility with other files. Did you get your old save to work with just this exe?
Title: Re: r635
Post by: Konata on May 11, 2011, 07:00:30 PM
Unfortunately, I have no saves from previous versions.
About skills: In my point of view, they divided into 2 categories. First is 'annoying' skills, they require micromanagement and full-time control (obedience, libido, etc). And second category is skills that can be named 'bigger - better' (Intelligence, constitution, so on). Do not know, what people need most.
Title: Re: r635 ?
Post by: gogomgo on May 22, 2011, 12:53:18 PM
r635?... I only see  r593 ;
where can i download r635? I can't find it (..); otrher site? ;
Title: Re: r635
Post by: GonDra on May 22, 2011, 05:36:55 PM
r635?... I only see  r593 ;
where can i download r635? I can't find it (..); otrher site? ;
The r635 Downloads aren't official so use them with caution,
if you still wanna try it I have uploaded one version of r635 with a small additional patch here: http://pinkpetal.org/index.php?topic=394.msg12880#msg12880
Title: Re: r635
Post by: gogomgo on May 23, 2011, 06:23:35 AM
many thx ! :)
Title: Re: r635
Post by: sgb on May 24, 2011, 11:39:07 PM
Haven't run into any problems with r635, so people might as well use it for the whatever all those misc bug fixes mentioned in the changelog were.
Title: Re: r635
Post by: Anon21 on July 13, 2011, 04:54:34 AM
I'm trying to compile from r635 and I haven't got very far.

Code: [Select]
1>  SubWCRev : 'C:\Games\whoremaster635\Whoremaster\BrothelMaster' is not a working copy
1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5): error MSB3073: The command ""SubWCRev.exe" "C:\Games\whoremaster635\Whoremaster\BrothelMaster\." "C:\Games\whoremaster635\Whoremaster\BrothelMaster\Revision.wcrev" "C:\Games\whoremaster635\Whoremaster\BrothelMaster\Revision.h" -f
1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5): error MSB3073: :VCEnd" exited with code 6.

Any suggestions?

[EDIT] Never mind - I needed to disable prebuild event in project properties.