Pink Petal Games

Feedback => New Features => Topic started by: anondb on March 30, 2010, 04:54:22 PM

Title: Typos and UpdateEnjoyment Patch
Post by: anondb on March 30, 2010, 04:54:22 PM

Fixed all the typos I found, as well as created a new function UpdateEnjoyment, which basically takes
   girl->m_Enjoyment[ACTION_WORKBAR]--;
if(girl->m_Enjoyment[ACTION_WORKBAR] < -100)
girl->m_Enjoyment[ACTION_WORKBAR] = -100;
 
and makes it into
   g_Girls.UpdateEnjoyment(girl, ACTION_COMBAT, -1, true);

Title: Re: Typos and UpdateEnjoyment Patch
Post by: Dagoth on March 31, 2010, 12:59:54 AM

Cool, thanks for the submission.

Title: Re: Typos and UpdateEnjoyment Patch
Post by: DocClox on March 31, 2010, 03:29:32 AM

Looks good. I was a bit worried because your example. changes working at the bar into combat enjoyment - but looking at the patch, everything seems ok :)

I never could spell ... thanks for catching the typos.

Title: Re: Typos and UpdateEnjoyment Patch
Post by: necno on March 31, 2010, 05:25:07 PM

Just a thought, I'm thinking anondb should become a dev member. As he is certainly more active then we are able to be at present and then he would be able to apply his excellent work straight away.

Title: Re: Typos and UpdateEnjoyment Patch
Post by: anondb on March 31, 2010, 08:26:08 PM

I'll only be this free during spring break.

Title: Re: Typos and UpdateEnjoyment Patch
Post by: necno on March 31, 2010, 08:39:50 PM

Thats fine, I'm very rarely free and the other dev members have little time as well :D.

Title: Re: Typos and UpdateEnjoyment Patch
Post by: anondb on March 31, 2010, 11:17:14 PM

Actually it's even worse than that now.  I won't be able to do anything after this latest Dungeon Events patch.  I know you guys just signed me up and everything on the SVN, but I can't do any more, sorry.

Title: Re: Typos and UpdateEnjoyment Patch
Post by: DocClox on April 01, 2010, 03:24:04 AM

Don't worry about it - real life happens to us all.

Thanks for the code. If your circumstances change, you'll be welcome here :)

Title: Re: Typos and UpdateEnjoyment Patch
Post by: Midnight_Amratha on April 01, 2010, 09:56:46 AM

cudo's to anondb. every little step that gives a hand to the devs ensures the next release comes closer, i know i'm being much help but that doesn't prevent me from wanting to help :)

Title: Re: Typos and UpdateEnjoyment Patch
Post by: DocClox on April 01, 2010, 10:11:38 AM

Quote

i know i'm being much help but that doesn't prevent me from wanting to help

I must admit, I've been surprised by how many people there are wanting to pitch in, now that svn is open.

It would probably be a good idea to have a "developers: getting started" type thread stickied somewhere. Basic stuff, like how to access svn, where the SDL files need to go, what you need to install, basic program architecture and coding conventions ...

Title: Re: Typos and UpdateEnjoyment Patch
Post by: zodiac44 on April 01, 2010, 11:55:41 AM

I'd love a quick intro to what's going on inside.  Maybe a pointer to some of the easier code to work with, so I can get a feel for it.