Poll

If you are reporting a bug, follow these steps to assist us in finding the cause of your bug

1. Delete the "gamelog.txt" file from your game folder to clear it.
2. Run the game as you normally would until it crashes.
3. Create a zip file with your savegame and your "gamelog.txt" files.
4. Post your bug report with details of how and when you get the crash.
5. Attach the zip file to your report.

Author Topic: Crazy and PP's mod bug thread  (Read 619429 times)

0 Members and 3 Guests are viewing this topic.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #375 on: August 08, 2014, 01:30:10 PM »
I've been wondering, what's with the start time?  If you have a lot of girl packs added in, the time builds up so quickly.  Sometimes, the game crashes before you get the girls in....
First, if the game crashes, then there is a problem with one or more of your girls files.

The game has to load into memory all the girls files so it can access them without having to load them every time they are needed, this takes some time.
I will see what I can do to reduce the time.




I ran procmon on my game and found that I can probably reduce the time a few seconds by checking if the game should look for .ani files before trying to load them.
It currently tries to load every image.ani type even if there are none in a girl's folder.
By checking if any ani exist instead, it should save a few milliseconds per girl, possibly saving 5-7 seconds per 1000 girls files.
Its not much but every second saved will help.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Dr_Poke

  • Newbie
  • *
  • Posts: 23
Re: Crazy and PP's mod bug thread
« Reply #376 on: August 08, 2014, 09:32:24 PM »
First, if the game crashes, then there is a problem with one or more of your girls files.

The game has to load into memory all the girls files so it can access them without having to load them every time they are needed, this takes some time.
I will see what I can do to reduce the time.




I ran procmon on my game and found that I can probably reduce the time a few seconds by checking if the game should look for .ani files before trying to load them.
It currently tries to load every image.ani type even if there are none in a girl's folder.
By checking if any ani exist instead, it should save a few milliseconds per girl, possibly saving 5-7 seconds per 1000 girls files.
Its not much but every second saved will help.

I'm not a programmer so I dont know how much of this is practical, but the game likes to look for script trigger files.  Also, if a girl doesn't have a story quest line, wouldn't it be more efficient to load the girls into memory when they are bought/kidnapped/etc., rather than before they can even be encountered.  When beginning a game, you only have access to 1 or two girls and waiting for all 1000 girls to load just to only have access to a few is a bit annoying.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #377 on: August 09, 2014, 02:17:40 AM »
Also, if a girl doesn't have a story quest line, wouldn't it be more efficient to load the girls into memory when they are bought/kidnapped/etc., rather than before they can even be encountered.
While the initial loading of the girls when creating a new game or loading an existing game may take some time, once the game is running, there is no noticeable slowdown caused by the number of girls prepared.

Random girls are not loaded at the start of the game, they are loaded when they are needed, from them there is very little slow down.

The only real slowdown when the game is running is when you have a large number of girls in a building, depending on your computer.
A bug the I have not gotten to yet is when you sort the girls in the list, the game slows down a lot.
Unsort the girls list (the top right box above the scroll bar) and the game should speed back up.

Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Dr_Poke

  • Newbie
  • *
  • Posts: 23
Re: Crazy and PP's mod bug thread
« Reply #378 on: August 09, 2014, 05:10:48 AM »
Got to a point in the game where you hit next day -> Load... -> ... -> ... -> Whoremaster.exe has stopped loading

I have 17 girls, a few more girls in the dungeon, and about 5-6 gangs with 6k/10k  cash on hand/bank. 

Restarting doesn't really do anything.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #379 on: August 09, 2014, 12:39:14 PM »
Got to a point in the game where you hit next day -> Load... -> ... -> ... -> Whoremaster.exe has stopped loading

I have 17 girls, a few more girls in the dungeon, and about 5-6 gangs with 6k/10k  cash on hand/bank. 

Restarting doesn't really do anything.
The gamelog is of little help without the savegame file.
zip both together and reupload
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Dr_Poke

  • Newbie
  • *
  • Posts: 23
Re: Crazy and PP's mod bug thread
« Reply #380 on: August 09, 2014, 07:30:18 PM »
Derp, missed that in half asleep mode.  ::)

Here ya go.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #381 on: August 10, 2014, 11:36:46 AM »
Got to a point in the game where you hit next day -> Load... -> ... -> ... -> Whoremaster.exe has stopped loading
I have 17 girls, a few more girls in the dungeon, and about 5-6 gangs with 6k/10k  cash on hand/bank. 
Restarting doesn't really do anything.
The cause of your crash is the game requires at least 1 rgirlsx file.
Your objective to steal 2000 gold was completed and the reward for it is 1 random girl.
You have no rgirlsx files so the game can not create a random girl.
Code: [Select]
m_Dungeon.AddGirl(g_Girls.CreateRandomGirl(0, false, true, true, g_Dice%3==1), DUNGEON_NEWGIRL);
The code does not currently check if the "CreateRandomGirl" function actually returns a girl so the "m_Dungeon.AddGirl()" fails.

I will add in a default hard coded random girl to prevent this for .05t.
For now, just create an rgirlsx file.

:::edit:::
I went a little overboard with the "hard coded random girl" but it works
« Last Edit: August 10, 2014, 03:49:07 PM by aevojoey »
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Uriel

  • Full Member
  • ***
  • Posts: 175
Re: Crazy and PP's mod bug thread
« Reply #382 on: August 10, 2014, 02:25:34 PM »
Thanks for updating the game.
in .05s.05:
Girls keep unassigning. I think this happens after they give birth.
Could you please fix the positions in the lists yet again? It cycled between being fixed/broken for a long time, and stoped at broken.
What i mean is when you sell/transfer/use an item in the shop, the position in the item list resets everytime. Same thing happens in all the lists.
A repost, since it has gone unnoticed it seems.

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #383 on: August 10, 2014, 03:50:35 PM »
A repost, since it has gone unnoticed it seems.
That is on my list of things to fix but I have not gotten to it yet.
I will start it now though.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Dr_Poke

  • Newbie
  • *
  • Posts: 23
Re: Crazy and PP's mod bug thread
« Reply #384 on: August 11, 2014, 06:45:33 AM »
The cause of your crash is the game requires at least 1 rgirlsx file.
Your objective to steal 2000 gold was completed and the reward for it is 1 random girl.
You have no rgirlsx files so the game can not create a random girl.
Code: [Select]
m_Dungeon.AddGirl(g_Girls.CreateRandomGirl(0, false, true, true, g_Dice%3==1), DUNGEON_NEWGIRL);
The code does not currently check if the "CreateRandomGirl" function actually returns a girl so the "m_Dungeon.AddGirl()" fails.

I will add in a default hard coded random girl to prevent this for .05t.
For now, just create an rgirlsx file.

:::edit:::
I went a little overboard with the "hard coded random girl" but it works

Errr.... Cant you just recode it for a random girl we haven't obtained yet? I still haven't found a majority of my actual character list. 

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #385 on: August 11, 2014, 10:57:02 PM »
Girls keep unassigning. I think this happens after they give birth.
The girls were not getting put back on their old job after giving birth because the game was not setting their old job.
Fixed it for .05t.
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Uriel

  • Full Member
  • ***
  • Posts: 175
Re: Crazy and PP's mod bug thread
« Reply #386 on: August 12, 2014, 05:50:14 PM »
Thanks, i'll be able to continue playing then xD
It was not a big issue when i had like 10 girls. But in the late game...

Offline HuiBui

  • Full Member
  • ***
  • Posts: 148
Re: Crazy and PP's mod bug thread
« Reply #387 on: August 14, 2014, 04:48:02 PM »
Regarding the WM Editor : Game configuration : Display settings

Its impossible to add four digit numbers into the boxes for Screen Width and Height.

It should be possible to add four digit numbers.

Kind Regards HuiBui

Offline aevojoey

  • Hero Member
  • *****
  • Posts: 1413
  • Thats ok, I'm used to disappointment.
Re: Crazy and PP's mod bug thread
« Reply #388 on: August 14, 2014, 05:34:39 PM »
Regarding the WM Editor : Game configuration : Display settings
Its impossible to add four digit numbers into the boxes for Screen Width and Height.
It should be possible to add four digit numbers.
Sorry, I missed that.
Fixing it now.
Increased width and height boxes to 5 digits and interface name to 15.

I also forgot to add the screen scale to fix the 800x600 scale bug.
Added that.

While I was at it I fixed the fonts to allow them to be changed and made all the (%) things on the config only allow 0-100.
I also added a few more tool tips.

Push WME.8.07 - http://www.pinkpetal.org/index.php?topic=3456.msg28245#msg28245
« Last Edit: August 14, 2014, 07:11:22 PM by aevojoey »
Fixing the game is a better game than actually playing it.
Get the Current Version <|> Discuss the Game <|> Report a bug

Offline Uriel

  • Full Member
  • ***
  • Posts: 175
Re: Crazy and PP's mod bug thread
« Reply #389 on: August 16, 2014, 08:47:09 AM »
They keep unassigning in .05t.  :'(