Pink Petal Games

Feedback => Bugs and Game balancing => Topic started by: zodiac44 on November 30, 2009, 03:52:53 AM

Title: Bugs 1.29.3
Post by: zodiac44 on November 30, 2009, 03:52:53 AM
New bug thread!

Let's start off with XML.  Something is royally buggered in either the xml files or the parsing function (or wherever the parsing function sends the data, what the hell do I know?).  When you start a new game, the program throws a conniption and then crashes if there are any xml girls files.  If there is an xml items file, the second window (debug screen?) shows a whole crapload of errors (I'd paste some here, but for some reason it won't let me copy text from the window) - my guess is one error for each item in the file(s).  The game starts, but there are no items in the shop.  The gamelog file is of less than zero help, as it records none of the badness going on.

A second bug I noticed is that the save files now appear in the root directory as well as the save directory.  The .mast files are apparently gone, though I suppose someone might have decided that they are redundant, so it may not be a bug.
Title: Re: Bugs 1.29.3
Post by: DocClox on November 30, 2009, 04:43:50 AM
Let's start off with XML.  Something is royally buggered in either the xml files or the parsing function (or wherever the parsing function sends the data, what the hell do I know?). 

The parser is tinyxml, which is quite widely used. So it's probably not that. Which means it'll be my fault.

When you start a new game, the program throws a conniption and then crashes if there are any xml girls files. 

Yep, it does. Got a fix for that ready, so should be sorted soon :)

If there is an xml items file, the second window (debug screen?) shows a whole crapload of errors (I'd paste some here, but for some reason it won't let me copy text from the window) - my guess is one error for each item in the file(s).  The game starts, but there are no items in the shop.  The gamelog file is of less than zero help, as it records none of the badness going on.

Me being lazy. I've started making sure all errors go to the log file, but I still have some I need to retro-fit.

A second bug I noticed is that the save files now appear in the root directory as well as the save directory.  The .mast files are apparently gone, though I suppose someone might have decided that they are redundant, so it may not be a bug.

Odd. None of my changes made them reduant. I wonder if one of the save files is the .mast file with a borked name.

I'll get on these ASAP.
Title: Re: Bugs 1.29.3
Post by: zodiac44 on November 30, 2009, 05:29:18 AM
Odd. None of my changes made them reduant. I wonder if one of the save files is the .mast file with a borked name.

Looking into it, that's exactly what the problem is.  The .gam.mast file gets saved in the root directory without the .mast extension.
Title: Re: Bugs 1.29.3
Post by: DocClox on November 30, 2009, 06:06:57 AM
OK, that's easy fixed, at least :)
Title: Re: Bugs 1.29.3
Post by: delta224 on November 30, 2009, 08:34:14 AM
Yeah, this release was more a test of the xml before 1.30 is released.
Title: Re: Bugs 1.29.3
Post by: DocClox on November 30, 2009, 11:37:00 AM
Got the XML problem: I changed the capitalisation on some tags to try and be consistent in my naming conventions.  Easy fix.

[edit]

Meh, need to do the girl files too...
Title: Re: Bugs 1.29.3
Post by: sammeh on November 30, 2009, 02:15:01 PM
The brothel icons (red lips) are missing on the town screen.

But love the load time one this version, way faster.
Title: Re: Bugs 1.29.3
Post by: DocClox on November 30, 2009, 02:23:30 PM
That sounds like the icon name issue again. Try going into the resources folder and renaming BrothelOn0.png to BrothelOn.png and BrothelOff0.png to BrothelOff.png

Let me know if that fixes it :)
Title: Re: Bugs 1.29.3
Post by: Zeus on November 30, 2009, 03:19:32 PM
not ab bug, just a question i don't know where i post it else... what about these "accom" Boutton in the Girl Detail screen? what is this? ^^


someone could please write a new Manual with a view Screens? ... sry for the offtopic... ^^''


okay, i think now i got a bug, its like the same bug i got in 1.29.2 but don't think on it... if i klick on the 6 brothel Button on the map (Left corner) he ask me if i like to buy it... but i got it already?
and now in this game after i klick on the button for the sixth brothel and he ask me to buy it and i said no the game looks like to freeze... no button reaktin after... they turn a little grey if i point them but nothing else....
Title: Re: Bugs 1.29.3
Post by: zodiac44 on November 30, 2009, 03:34:12 PM
I noticed a couple of things on my first play through:

1) free girls default to poor accommodations when they used to default to adequate.  It's fine if the change was intentional, but players should note that it is now different.

2) free girls default to a house percentage of 0 instead of 60.  My guess is that they are now using the value from the "house" field in the .girls file, though I haven't messed around with it to confirm yet.

not ab bug, just a question i don't know where i post it else... what about these "accom" Boutton in the Girl Detail screen? what is this? ^^

The "Accom" buttons change the level of accommodations for the girl.  Higher accommodations cost more and are supposed to deliver benefits, though I haven't seen any need for setting them higher than "Adequate"
Title: Re: Bugs 1.29.3
Post by: DocClox on November 30, 2009, 03:43:39 PM
1) free girls default to poor accommodations when they used to default to adequate.  It's fine if the change was intentional, but players should note that it is now different.

2) free girls default to a house percentage of 0 instead of 60.  My guess is that they are now using the value from the "house" field in the .girls file, though I haven't messed around with it to confirm yet.

Sounds like a bug. I'll take a look.

someone could please write a new Manual with a view Screens? ... sry for the offtopic... ^^''

Anyone want to take a crack at it? I have a ton of coding to do, but I'll happily answer questions where things aren't clear.

okay, i think now i got a bug, its like the same bug i got in 1.29.2 but don't think on it... if i klick on the 6 brothel Button on the map (Left corner) he ask me if i like to buy it... but i got it already?

Yeah, sounds like the same bug.
Title: Re: Bugs 1.29.3
Post by: mbscout on November 30, 2009, 04:21:17 PM
I'm sure this bug has been posted before, but I'll restate it.
Trying to send Carrera (Monster girl) to the dungeon freezes the game.  I got her from walking around town. 
Also, I noticed that even with house % set to 60%, the end of week summery said I kept all the money.
Title: Re: Bugs 1.29.3
Post by: delta224 on November 30, 2009, 04:39:13 PM
The percent at end of the week is still fraked up, great. 
Title: Re: Bugs 1.29.3
Post by: Fstop on November 30, 2009, 05:14:59 PM
This is either a bug or proof on how badly balanced rivals are. I just "defeated" a rival on week 2 with by only placing my guards as Training=4 and Kidnapping Girl=4 even do I go 0 girls and everything >.<
Title: Re: Bugs 1.29.3
Post by: delta224 on November 30, 2009, 05:18:57 PM
proof, the gangs have not been touched, though one of other rivals could have done it though..
Title: Re: Bugs 1.29.3
Post by: sgb on November 30, 2009, 05:55:20 PM
It may just be rivals are occasional getting spawned with almost no money.  Thus they get attacked once right away, and lose.
Title: Re: Bugs 1.29.3
Post by: DocClox on November 30, 2009, 06:51:21 PM
That's a good point. Maybe I should set it up so that not only does the player not get attacked for a few weeks, but that no-one gets attacked for that period.

Might be fun to make an event of it - have the outbreak of Gang War as a news item.
Title: Re: Bugs 1.29.3
Post by: Fstop on November 30, 2009, 06:59:38 PM
It still not cool for 3 gangs to gang up on one finishing it off in 2 weeks
Title: Re: Bugs 1.29.3
Post by: Wispowill on November 30, 2009, 08:04:56 PM
A number of items are now showing up in the shop with a 0 price. Using the editor it looks like the values are still in the xml file. However, not all items have 0 price... just some of them. Haven't been able to determine yet what makes the difference.
Title: Re: Bugs 1.29.3
Post by: delta224 on November 30, 2009, 08:09:31 PM
Will look into when I have time, I am knee deep in other work at the moment, and probably will still be knee deep for the rest of the week. 
Title: Re: Bugs 1.29.3
Post by: DocClox on November 30, 2009, 08:14:47 PM
A number of items are now showing up in the shop with a 0 price. Using the editor it looks like the values are still in the xml file. However, not all items have 0 price... just some of them. Haven't been able to determine yet what makes the difference.

Looks like it's Badness. The price zero ones seem to have badness 0. the price 20 have badness 20 ... It's an easy enough fix. Thanks for pointing it out.

/me exits stage left, singing: "Badness, Badness, They call it Badness...")

Title: Re: Bugs 1.29.3
Post by: sgb on November 30, 2009, 11:02:42 PM
Okay, I can confirm item prices are being set to their 'badness' value.  It's not just a display error, everything actually costs 0-100 gold now.

On the plus side, I noticed random girls aren't being generated with supermodel looks every time now.  The values that get generated are now what I'd expect given the range of values I set.
Title: Re: Bugs 1.29.3
Post by: Nuller on November 30, 2009, 11:54:09 PM
It seems that every random girl (from both kidnapping, catacombs and the salve market) is age 18 and has the lolita trait. iirc the lolita trait is for when they were generated with an age<18, so I'm guessing something is borked with that, -ve maybe?
Also getting the contradictory messages of non-enjoyment in the act description followed by enjoyment after the customers enjoyment message.
Using the 1.29.4 linux binary, but reporting here since Doc mentioned it should be essentially the same as the current windows binary.
Title: Re: Bugs 1.29.3
Post by: Fstop on December 01, 2009, 02:23:26 AM
Is the game still corrupted when you have a child or are both my saves unlucky ?
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 01, 2009, 02:39:35 AM
I can load a game where one of my girls is pregnant, so that's no broken.  I don't know what happens after birth yet, though I'll run the game through to check.

[edit]
confirmed saves load after child birth.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 01, 2009, 06:44:32 AM
It seems that every random girl (from both kidnapping, catacombs and the salve market) is age 18 and has the lolita trait. iirc the lolita trait is for when they were generated with an age<18, so I'm guessing something is borked with that, -ve maybe?

Looking at RandomGirls.rgirlsx, the min and max ages for everyone seem to be zero. so it may be a bug in the perl script I used to convert the existing .rgirls files to the new format. Let me have a look...

Also getting the contradictory messages of non-enjoyment in the act description followed by enjoyment after the customers enjoyment message.
Using the 1.29.4 linux binary, but reporting here since Doc mentioned it should be essentially the same as the current windows binary.

I haven't looked at the enjoyment messages at all. As necno would say, "I'll add it to the list"

[edit]

Nope, I'm wrong. The ages were zero (min and max) in the original files as well. The age is being passed from the script handler, which uses an array of anonymous variables to handle everything, so it's hard to tell what's going on there. I'll have another look.
 
Title: Re: Bugs 1.29.3
Post by: Rose on December 01, 2009, 10:13:46 AM
Some girls just don't seem to appear in the game as they should for some reason. They're listed in the save file and the pack they're in is listed in the .mast (or rather, the file this version uses instead of a .mast), but they never seem to appear in the game...


Edit: This one cleared up after completely quitting and the game and then reloading the save.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 01, 2009, 11:27:01 AM
Is it the same girls, do you know?
Title: Re: Bugs 1.29.3
Post by: Midnight_Amratha on December 01, 2009, 11:28:34 AM
that may explain why i had a few of my girls turn up to be age 0 when they started.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 01, 2009, 11:37:50 AM
Someone do me a favour: make a subdirectory in Resources\Characters and move the girlsx and rgirlsx files into that.

After that, start a new game and see if the age bug is still there. If it is, then it's not the XML. I'd do it myself, but my non-xml loading is borked for O/S depenant reasons.
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 01, 2009, 12:24:37 PM
The following three bugs are still present in this version...

When a movie ends, not all the time slots clear correctly. This results in starting a new movie when accessing the girls detail screen in order to change the job that wasn't cleared to start with. It seems to have something to do with girls who work both day and night on the movie. The day shift will clear ok, but the night shift doesn't and appears as 0 weeks to go on the management screen.

Player inventory periodically disappears. I tend to save rare items I get from the catacombs just for special girls, but sometimes I'll find that my 20-30 items have all disappeared at some point.

When a girl gets busted for drugs the one that gets sent to town hall prison is always the very first girl in the first brothel.

And in the game logic department...
Generated characters can start with the MILF characteristic and still be virgin. I guess adopting children while still single must be popular in this dimension?  :)

Title: Re: Bugs 1.29.3
Post by: sgb on December 01, 2009, 01:10:29 PM
Quote
Looking at RandomGirls.rgirlsx, the min and max ages for everyone seemto be zero. so it may be a bug in the perl script I used to convert theexisting .rgirls files to the new format. Let me have a look...
This is how it worked before; the game just completely ignored the age variables of random girls and assigned something between 18 and 30something.  If you fixed this and it now actually uses the assigned age range, then Necro's original random girl file will need to be updated.  I'll test this later with my custom random girls and see if they're getting a proper age assigned.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 01, 2009, 01:16:28 PM
I haven't fixed it, although now I know it needs attention, I might :)

So that lets the XML loader off the hook for the age bug, but doesn't get us any further forward. hmmm...
Title: Re: Bugs 1.29.3
Post by: Rose on December 01, 2009, 01:58:56 PM
My save suddenly died for some reason. I could play fine, but when I tried to load the game, it crashed. Attached the save and the game log to the post.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 01, 2009, 02:12:16 PM
I think I fixed it. try the attached file

Note preg can still screw up the saves.
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 01, 2009, 02:19:31 PM
Teensy tiny minor bug (doesn't really affect game play at all): there is a math error in the house take computation.  Setting the house percentage to 95%, a girl who earns 100 on a job keeps 6 and gives 94 to the player.  At a guess, it looks like the kind of error you'd expect when working with floating point numbers, though the precision in this case seems far too small to see that effect.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 01, 2009, 03:40:09 PM
I just had a daughter reach maturity whose level is 15 and her mother was level 2. Am I just that high of a level?
Title: Re: Bugs 1.29.3
Post by: sgb on December 01, 2009, 04:56:10 PM
Quote
I haven't fixed it, although now I know it needs attention, I might (http://pinkpetal.org/Smileys/DarkB/smiley.gif)

So that lets the XML loader off the hook for the age bug, but doesn't get us any further forward. hmmm...
Okay, I've tested this some more:
-Unique girls are all getting set to age 0.
-Random girls without a defined age range (ie Necro's file with 0 min and max age) automatically get set to 18 - on another note, I thought the minimum age was supposed to be 17 now?  This was working in earlier versions but seems to have been reverted.
-Random girls with a defined age range are actually working like they are supposed to.  Apparently this bug DID get fixed somewhere along the line.

Point 1 needs to be looked at, but all that needs to be done about point 2 is to punch in some numbers for the ages in Necro's random girls file.
Edit: Confirmed.  I fixed Necro's file and the Slave Market girls are getting age ranges I specified.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 01, 2009, 05:06:12 PM
Well that's good news, anyway :) I suppose that's one of the benefits of the XML changeover is it makes it easier to check this sort of thing.

I'll look at the unique girls tomorrow morning. Should be simple enough to find.

[edit]

Decided to look at it tonight, instead. Odd thing: Ayanami Rei is 14 in the girlsx file, and 14 in the game, too. I'd have expected that to have been modified upward to 17. Definitely not getting 0 or 18. Alena is loading (correctly) as 20.

I think I'll try and compile up a new build of this tomorrow, unless solo or delta fancy doing one before then. Code is in tags/release_1.29.3/wmfix2, release r110
Title: Re: Bugs 1.29.3
Post by: Balmung60 on December 01, 2009, 08:24:41 PM
huh, for me Rei's age defaults to 17
Title: Re: Bugs 1.29.3
Post by: delta224 on December 01, 2009, 08:44:43 PM
Let me try to find an error that I thought I fixed and I will release a version later, this may relate to the buying the final brothel again as well.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 01, 2009, 09:07:55 PM
Cool :D
Title: Re: Bugs 1.29.3
Post by: sgb on December 01, 2009, 09:09:53 PM
Whatever you've done with the formula for calculating looks, it's definitely a lot more realistic now.  Characters that were coming in at ~90 in 1.29.2 are coming in at ~50 now, and 'lesser' characters in the low 30s now.  This is definitely a good step forward for improving difficulty.

Edit: It looks like it's exactly the average of Charisma and Beauty.  Before I think it was weighing mainly on Beauty alone, as +charisma items weren't seeing as much of a looks gain as a +beauty item.  This is something I'll take into account for balancing item prices.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 01, 2009, 09:17:06 PM
Currently, it seems as though there is no way to use items which have been created in the item creator to affect all girls temporarily. I give one to a girl, tell her to use it, and nothing happens. The item doesn't even go away.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 01, 2009, 09:19:09 PM
New build is up, but keep posting bugs.

I don't know what we've done with looks if anything.

The item issue is an outstanding bug that I have yet to figure out where it is.
Title: Re: Bugs 1.29.3
Post by: sgb on December 01, 2009, 09:50:01 PM
I think perhaps rather than having fixed some of the these bugs, the switch to XML is simply resolving a lot of older issues on its own.

As for the new version, item prices and unique character ages are working right again.  However random girls still have a minimum age of 18 no matter what values the editor is set to.  Maximum age is working as intended.  Brothel icones are still missing, though the fix DoxClox said to use on page 1 fixes it.

An older bug you may be able to fix easily is that the Dependent trait is still causing rebelliousness to drop to -100.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 01, 2009, 09:59:23 PM
Eh, I may have made the path wrong or something because I thought I included the images with the orginonal version of 1.29.3.  The dependent issue is not a bug, but is changeable.  I do agree that the xml resolved a old issues that we never saw.
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 01, 2009, 10:46:12 PM
Edit: It looks like it's exactly the average of Charisma and Beauty.  Before I think it was weighing mainly on Beauty alone, as +charisma items weren't seeing as much of a looks gain as a +beauty item.  This is something I'll take into account for balancing item prices.

It has always been an average of charisma and beauty (at least since I started playing anyway, back circa 1.25).  You probably weren't seeing much of a change from +charisma items, because charisma is trainable.  If you train it to 100, +charisma items won't have any effect at all.

Currently, it seems as though there is no way to use items which have been created in the item creator to affect all girls temporarily. I give one to a girl, tell her to use it, and nothing happens. The item doesn't even go away.

The "affect all girls temporarily" items have never worked to my knowledge.  I don't know if Necno implemented the system and it just doesn't work or if it's a "to do" thing.

[edit]

Another "not really a bug but should be fixed eventually" report: Some of the locations where money appears in the game are missing the currency unit (in this case, gold).  Locations I've found so far are:
[edit 2]

I have a screwed up save, which occurred just after my first daughter matured.  Save attached.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 02, 2009, 03:49:59 AM
Here's one for the record: torturing a girl doesn't set the "tortured" flag.
Title: Re: Bugs 1.29.3
Post by: Rose on December 02, 2009, 06:49:20 AM
I think I fixed it. try the attached file

Note preg can still screw up the saves.


The fixed file worked for a few weeks, after which it promply died again in exactly the same manner as before.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 02, 2009, 08:37:14 AM
Need to check a few things with preg.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 02, 2009, 08:44:20 AM
I'm beginning to wonder if I should XMLify the saved games:

Pro: It seems more reliable,
Pro: It's much easier to spot errors

Con: It's a lot of work spread over a lot of files
Con: I'm worried about breaking it further.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 02, 2009, 09:04:55 AM
Eh, I'd rather change the internals a bit than xml the save file for now.

Title: Re: Bugs 1.29.3
Post by: DocClox on December 02, 2009, 10:03:58 AM
Fine by me :) I'm still in bugfix mode on the release code anyway. Think I got the torture one I reported.

You working on the pregnancy issues?
Title: Re: Bugs 1.29.3
Post by: Alugere on December 02, 2009, 10:05:30 AM
There is still a major bug involved where the game crashes when someone is about to give birth as well.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 02, 2009, 10:44:41 AM
Will work on the preg issue.  When I have time
Title: Re: Bugs 1.29.3
Post by: sgb on December 02, 2009, 11:21:29 AM
Quote
It has always been an average of charisma and beauty (at least since Istarted playing anyway, back circa 1.25).  You probably weren't seeingmuch of a change from +charisma items, because charisma is trainable. If you train it to 100, +charisma items won't have any effect at all.
Actually, I've found the issue with starting looks being so much lower now: Traits that are supposed to boost charisma/beauty/looks aren't working right.  I tested it with a character with 30 charisma, 50 beauty and the Big Boobs trait.  Her looks were getting reported as exactly 40, but Big Boobs should be increasing that value.  It's not.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 02, 2009, 11:43:26 AM
I found the age 18 issue. Young girls were being set to age 17, and then set to 18 by the virginity check.

Also found the trait issue: there's an ApplyTraits call hidden in the middle of the legacy girl loader that I missed.

Fixed in the next release :)
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 02, 2009, 02:51:56 PM
Here are a few issues I didn't remember seeing in the 1.29.2 version:

Random girls are sometimes being tagged in red at the slave market.

A girl who has seen a number of customers still receives a "This girl is doing nothing" message after the other status messages for that shift.

Somtimes unequpping an item from a girl gives me back multiple numbers of the item I'm getting back, when I didn't have any of that item before, i.e. unequipping nipple rings and receiving 5 back instead of just 1.

For the 1.29.3.2 version, if the items.itemsx file isn't present the program no longer loads the old file properly. There will be one and only one item that ever displays.

Title: Re: Bugs 1.29.3
Post by: DocClox on December 02, 2009, 04:19:15 PM
I can definitely confirm that "affects all" does in fact to nothing.

Anyone know how it was supposed to work? Make the modifications for a turn, and then take them off again the at the end of it?
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 02, 2009, 04:50:55 PM
I don't know how it was supposed to work, but one turn seems awfully short.  How long do the single girl, temporary effects last?  If we stick with, say, half that time for now until we find something more balanced, we can at least test the items.  I'll start a thread in the features section to discuss temporary effect items.

[edit]

Found a bug: matrons "forget" what girls were doing before they were taken off duty to rest when you load a saved game.  Example: matron takes Kiki off brothel duty due to tiredness.  Save game.  Kiki rests until her tiredness reaches 0, and the matron puts her back on brothel duty (matron works properly).  Load saved game.  Kiki rests until her tiredness reaches 0, and the matron doesn't put her back on brothel duty (matron forgot what she was doing).
Title: Re: Bugs 1.29.3
Post by: delta224 on December 02, 2009, 05:13:40 PM
Zodiac44, I think the matron issue is due to the fact that the previous job is not saved.  For the temp items, I have no idea how it was supposed to work.
Title: Re: Bugs 1.29.3
Post by: sgb on December 02, 2009, 05:53:33 PM
I believe it was stated when it was first implemented that it was supposed to be 20 turns.  Of course this was when turns were one day.  20 WEEKS isn't very temporary.  I'm not sure there IS a way to implement them in a way that is both logical and balanced anymore (probably why Necro has given the matter no attention since first implementing it).  4 turns (a month) sounds logical for a temporary item, but I certainly wouldn't buy an item that works for only 4 turns.  It's also a nightmare to ever balance.  I mean if an item that gives +10 to two stats permenantly is worth 300 gold, then how much is an item that only does this for 20 turns worth?  50 gold?  Why even bother with the temporary one for the sake of 250 gold?

IMO, it was an interesting idea that doesn't translate well into gameplay.  Also, it causes a mess of programming.  I mean, what happens when you get into items that temporarily add or remove traits?  What if I equip an item that permenanty adds a trait, and the temporary one runs out?  What if I make a super powerful item that temporarily gives +100 to all sex stats for a month?  Does it get dropped to 0 after running out, even though that character had various values before using the items?  It's just a pain IMO.

I've taken all temp items out of my item pack because I never used any of them (even before knowing they didn't actually work right), and frankly think the whole thing should just be scrapped.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 02, 2009, 06:22:43 PM
It seems that every time I try to convert an old .rgirls file into a new .rgirlsx xml file, the girls' values all end up in the wrong place. I have girls whose looks range from 0-50% age ranging from 18-98 and sometimes being unknown for no reason. The rebelliousness also seems to like starting at around -100%.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 02, 2009, 06:25:10 PM
I can run it through my perl script and see if that sorts it out, if you like. (Or you can have the script if you can run perl)
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 02, 2009, 06:48:54 PM
I believe it was stated when it was first implemented that it was supposed to be 20 turns.  Of course this was when turns were one day.  20 WEEKS isn't very temporary.  I'm not sure there IS a way to implement them in a way that is both logical and balanced anymore (probably why Necro has given the matter no attention since first implementing it).  4 turns (a month) sounds logical for a temporary item, but I certainly wouldn't buy an item that works for only 4 turns.

Forget about days, weeks, months.  They are only arbitrary designations anyway.  The only reason we use weeks as the base unit now is so we can have a reasonable pregnancy period (of course, maturity is still hyper accelerated, though who wants to play through 18 years until your first child matures?).

Quote
It's also a nightmare to ever balance.  I mean if an item that gives +10 to two stats permenantly is worth 300 gold, then how much is an item that only does this for 20 turns worth?  50 gold?  Why even bother with the temporary one for the sake of 250 gold?

Pricing them will be difficult to an extent, though I could write a formula to take care of it automatically.

Quote
IMO, it was an interesting idea that doesn't translate well into gameplay.  Also, it causes a mess of programming.  I mean, what happens when you get into items that temporarily add or remove traits?  What if I equip an item that permenanty adds a trait, and the temporary one runs out?  What if I make a super powerful item that temporarily gives +100 to all sex stats for a month?  Does it get dropped to 0 after running out, even though that character had various values before using the items?  It's just a pain IMO.

I don't know how traits are handled, but you could ask the same question of permanent items.  What if I have one ring that adds the Tough trait and a second ring that removes it?  Does the girl have the Tough trait or not?  Does it depend on whether she had it to begin with or not?  I don't know.

As far as skills and stats go, I can answer that one.  Base skills and stats, permanent bonuses, and temporary bonuses are all tracked separately from one another.  So your super powerful temporary item would raise all skills to max and they would return to their previous value, plus whatever bonuses the girl got from working or training (which don't stop accumulating when your skills max out), when the effect expires.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 02, 2009, 07:10:47 PM
Here is how that trait example would work. If you gave here the ring that gives toughness first then the removal she would not have the trait.  If you gave her the ring that removes the trait then the ring that adds it she has the trait.  This gives us two states a- with the trait b-without the trait.  When you unequipped the rings I am not sure at the moment what happens but I think it will end up with the girl having the trait without any of the rings equipped.  It does not matter if she has the trait or not to begin with.

Title: Re: Bugs 1.29.3
Post by: Solo761 on December 02, 2009, 07:21:37 PM
Correct (original) description of these item behaviors was posted on old-old forum, but it's lost now, old-old forum is no more.

I think it was something like this. Default behavior is just that, default, you have item, you use it, it does it's thing and that's it. Other two are Affects all girls temporarily and Affects one girl temporarily. This temp effect was meant to last for 20 turns while diminishing every turn, to get to 0 at the end of these 20 turns. That makes it somewhat easy to not screw up original stats/skills. Simply add, let's say, 40 to that stat/skill and then subtract 2 points each turn for 20 turns. It would return to original value. And if that exact skill/stat is improved via some other way (like training) it won't matter, as this subtraction is set, and won't subtract more than 2x20 points.
Things get somewhat complicated if this temp item gets used twice so there's like another 40 points added 2 turns after first 40 points, at code side at least. But it could be made to work, even if it means making it so that girl can be under effect of only one temp item at a time so there is one thing less to worry about.

Although there could be conflicts here, trait management being the largest, if girl is given one trait via temp item will it be deleted after 20 turns even if she uses another item that gives her this trait permanently, and similar. One another potential problem could be max values for skills/stats. If girl has it at 80, and gets under effect of item that raises it for 40 how will that turn out? 100 is max, will she have 60 after 20 turns or will it decrease to correct 80.

Story wise temp items could have their use, like making some items that are otherwise very rare commoner in their temp form. Like cure for some diseases or addictions. If you can't have the real thing temp one would be good enough until permanent one is acquired. And this just gave me an idea how to "fix" trait conflict, and perhaps others also. If trait/skill/stat is under temp effect and permanent one is used, temp one is canceled and permanent gets into full effect. For traits this would be somewhat easy to do, it's simply on or off, for skills/stats this will be somewhat harder, it would probably mean that original (base) value would need to be stored somewhere, and probably added to if that stat/skill would get changed via training or like.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 02, 2009, 07:35:59 PM
Things get somewhat complicated if this temp item gets used twice so there's like another 40 points added 2 turns after first 40 points, at code side at least. But it could be made to work, even if it means making it so that girl can be under effect of only one temp item at a time so there is one thing less to worry about.

Well, there's code in already to remember temp changes from items, so most of that would be OK. The easiest thing to do about repeated uses of an item would be to refresh the effect back to full power. Might still need to be a bit clever about the countdown in case someone used the same item in two different places at different times, but sounds manageable.

Although there could be conflicts here, trait management being the largest, if girl is given one trait via temp item will it be deleted after 20 turns even if she uses another item that gives her this trait permanently, and similar.

Traits should be OK - they get remembered too. The temp vs. perm thing is already handled. (Just been looking at that code :)
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 02, 2009, 07:43:20 PM
Here is how that trait example would work. If you gave here the ringthat gives toughness first then the removal she would not have thetrait.  If you gave her the ring that removes the trait then the ringthat adds it she has the trait.  This gives us two states a- with thetrait b-without the trait.  When you unequipped the rings I am not sureat the moment what happens but I think it will end up with the girlhaving the trait without any of the rings equipped.  It does not matterif she has the trait or not to begin with.

Wow....that is really broken.

Things get somewhat complicated if this temp item gets used twice so there's like another 40 points added 2 turns after first 40 points, at code side at least.

I have no idea how the game handles temp effects from multiple concurrent items with different times to expiration on stats and skills.  I suspect that if there is a problem, the solution would be to store each effect, along with its time to expiry, separately.  That will be much easier to do if/when the save files get converted to XML.

Quote
One another potential problem could be max values for skills/stats. If girl has it at 80, and gets under effect of item that raises it for 40 how will that turn out? 100 is max, will she have 60 after 20 turns or will it decrease to correct 80.

I addressed that particular issue in my last post.  Temp bonuses and permanent bonuses are stored separately from the base stats and skills, so when a temp bonus bumps a skill up, the skill will return to its correct value when the temp bonus expires.  Example:

Asuka has a sex stat of 50, a ring that gives her a +30 permanent bonus to her sex skill, and just drank a potion which gives her a +40 temporary bonus.  Her skill is 120, capped at 100.  After 10 turns, the temp bonus is reduced to +20, leaving her with a skill of 100.  After 20 turns, the temp bonus expires.  If she didn't improve her sex skill in the 20 turn period, she has a net skill of 80.  If she received 10 points to her sex skill in that time, the temp effect would end and she would have a net skill of 90.

Unless someone has messed around with the system since I looked into it, it does work properly.

Well, there's code in already to remember temp changes from items, so most of that would be OK. The easiest thing to do about repeated uses of an item would be to refresh the effect back to full power. Might still need to be a bit clever about the countdown in case someone used the same item in two different places at different times, but sounds manageable.

That is fine for repeated uses of an item, but what about using two different items with overlapping effects?  eg: one potion gives +20 normal sex, +20 anal sex; another gives +10 normal sex, +10 BDSM.  If a girl takes the first potion in week 1 and the second potion in week 5, how would that work?  It doesn't seem right to me that the second potion should reset the timer for the first, even if only for the bonus to the normal sex skill.

Quote
Traits should be OK - they get remembered too. The temp vs. perm thing is already handled. (Just been looking at that code :)

Good to hear.
Title: Re: Bugs 1.29.3
Post by: sgb on December 02, 2009, 07:56:54 PM
As for traits, I know it doesn't keep checking item status every turn.  I have an item that adds Tough.  It's possible through random injury to get Fragile, which reverses Tough.  If you leave things as is, Fragile will stay forever.  You have to actually unequip, then re-equip the Tough item which will then overwrite Fragile with Tough once again.

As for the temp item thing, if Necro already has it programmed to account for the extra stats then I guess half the work is done there.  It may be worth salvaging, but I still don't see any real reason to use temp items over normal ones.  In a game like Slave Maker where you have ONE girl to manage, then I could see the point of using a temporary upgrade to trigger an event or enable an action.  When I have dozens, I simply can't see why I'd want to fuss over managing temporary boosts when I can just buy a permenant one and move on.

Quote
It seems that every time I try to convert an old .rgirls file into anew .rgirlsx xml file, the girls' values all end up in the wrong place.I have girls whose looks range from 0-50% age ranging from 18-98 andsometimes being unknown for no reason. The rebelliousness also seems tolike starting at around -100%.
Most of these are not conversion errors, but current bugs.  Some traits aren't being applied at the moment, so the maximum looks a girl can ever start with is 50 (if you had charisma and beauty start at 100).  Age I'm not sure on, but if you set it to be 0-100, you will get 18-unknown in-game (age 100+ is listed unknown).  As for the -100% thing, the Dependent trait is currently setting rebeliousness to -100%.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 02, 2009, 08:01:03 PM
Quote
That is fine for repeated uses of an item, but what about using twodifferent items with overlapping effects?  eg: one potion gives +20normal sex, +20 anal sex; another gives +10 normal sex, +10 BDSM.  If agirl takes the first potion in week 1 and the second potion in week 5,how would that work?  It doesn't seem right to me that the secondpotion should reset the timer for the first, even if only for the bonusto the normal sex skill.

That should be ok. The games memory maintains a slot for each item per girl. So if you have 10 items affecting a stat, ten separate countdowns would be remembered. I think so, anyway; I need to look at the code some more.

The main problem I foresee is if there are two instances of the same item counting down at different stages. The game seems to remember the effect of an item by keeping a pointer into the global items table. So if you had two different instances of one item, they'd both be the same, and would count down together. (and twice as fast). Probably.

Most of these are not conversion errors, but current bugs.  Some traits aren't being applied at the moment, so the maximum looks a girl can ever start with is 50 (if you had charisma and beauty start at 100).  Age I'm not sure on, but if you set it to be 0-100, you will get 18-unknown in-game (age 100+ is listed unknown).  As for the -100% thing, the Dependent trait is currently setting rebeliousness to -100%.

Traits aren't being at all to unique girls.  I've committed a change today that should fix that. Random girls should have been ok, since they get their traits applied outside the loading code, so my bug shouldn't have affected them.
Title: Re: Bugs 1.29.3
Post by: Solo761 on December 02, 2009, 08:40:07 PM
About that rgirls issue, it's not the editor as far as I can see. although format of what goes out of it is different then ones from DocClox (it uses quotes instead of apostrophes, and some other purely visual differences), content is absolutely the same. I used program called XMLSpy to be sure of that. It checks data within XML, not just the look/formatting.

I think that there's something else at the issue here. While experimenting around on some other stuff I also noticed that random girls have terrible stats, age from 18 to 75, and looks from 0% to 20%. Looks and age is what I noticed to be messed up. There was a girl with looks of 4%, 18 years and buy cost of 1300. But I wasn't able to replicate this. It's a freak occurrence, out of 15 tries it happened only once.
I also noticed something else with rgirls (and rgirlsx since they're made from original rgirls files), random girls that came with the game have both minimum and maximum age set to 0.

One other thing I noticed is with regular (unique) girls. It seems none of them can't be virgins any more, and also age is no longer limited to 18, I got Hana at 14 years and Amami Haruka at 16 years old.
This was with XML files. I tried with old files also, virgin thing is present, but didn't had the luck to get these young girls to show up. Youngest was 17, which I also think is not the way it's supposed to be.

One other thing is house percentage, as far as I could tell for old files it defaults to 60%, no matter what value is in House field, for XML this get's read as it's written. Example is Kos Mos, she has 0 in House field. When game uses old files she has house percentage of 60%, when I use XML files she has 0%.


P.S.

There's a typo when girl gets inseminated event message says insinenated.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 02, 2009, 09:27:30 PM
Most of these are not conversion errors, but current bugs.  Some traits aren't being applied at the moment, so the maximum looks a girl can ever start with is 50 (if you had charisma and beauty start at 100).  Age I'm not sure on, but if you set it to be 0-100, you will get 18-unknown in-game (age 100+ is listed unknown).  As for the -100% thing, the Dependent trait is currently setting rebeliousness to -100%.
I'm not converting custom girls, I'm converting the base .rgirls files that come with the main game. (The only girl pack I've downloaded is the monster girl pack)
Title: Re: Bugs 1.29.3
Post by: sgb on December 02, 2009, 09:33:44 PM
Hmm, I'm not having any issues with my XML random girls file.  All parameters are within the ranges I've specified.  Remember Necro's file needs to have ages inputted, as they are all 0-0 in his file.  As for the minimum age, Necro changed it in an earlier version to be 17 (it's there in the changelog somewhere).  It wasn't working for random girls (DocClox found the issue already).  After the XML change, the minimum age isn't being applied to unique girls anymore.  Frankly, I don't really see an issue with this as the age of consent is 16 or even lower in many first world countries (heck, here in Canada is was still 14 until recently).  But if that's against Necro's wishes, then I guess it should set it to 17 if the current age is lower.

I can confirm the unique girls not getting virgin status anymore as well.

Quote
I'm not converting custom girls, I'm converting the base .rgirls filesthat come with the main game. (The only girl pack I've downloaded isthe monster girl pack)
I know, everything I said applies to random girls as well.  You need to use the editor to fill in the age ranges or you will get a range of 18 to unknown.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 02, 2009, 10:24:38 PM
I have made it to where only the girls in this file are used. However, even after manually setting the ages, the girls range from 18-100.
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 02, 2009, 11:05:42 PM
I found an odd bug with house percentages: it seems they are being treated as an inherited stat.  I manually set the house percentage to 95% for each girl in my brothel, and their daughters mature with a house percentage from 50-75% (most of them at 69%).  I'm pretty sure that's not something that should be treated with the inheritance routines.  >;o)
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 02, 2009, 11:21:22 PM
There seems to be something wrong with the house percentages anyway. I just went through on the latest game I was playing and suddenly noticed that quite a number of the girls I had freed from slavery had house percentages of either 100% or 0%. The majority had the correct 60%. I haven't been changing the house percentage at all, so I'm pretty sure something went awry in the game routines.
Title: Re: Bugs 1.29.3
Post by: sgb on December 03, 2009, 12:36:40 AM
Quote
I have made it to where only the girls in this file are used. However,even after manually setting the ages, the girls range from 18-100.
I tried your file, and I'm not getting any problems; ages are all within the limits you set.  Are you certain you have the absolute newest version of the game?  The first version on 1.29.3 had this bug, but it was fixed with the latest exe update.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 03, 2009, 12:16:11 PM
I'm using the 1.29.3.2 full repack from the download thread, so I think I am.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 03, 2009, 12:21:40 PM
Most odd. What does it say in your title bar?
Title: Re: Bugs 1.29.3
Post by: Alugere on December 03, 2009, 12:39:29 PM
"Whore Master v1.29.3.2 Beta" Is what's in the title bar.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 03, 2009, 01:09:47 PM
So you have the right binary, and the xml file you're running works for other people. Very odd indeed.

I'll have another look over the code when I get done with this config file stuff.

[edit]

Nope, cannot reproduce. I've downloaded the full download and used that with the rgirlsx files that came with it, and got a range of ages. And I also used it with your adjuted files and no others, and got a range of ages with that, too.

So I'm not entirely sure what to suggest at this point.
Title: .Item file load errors
Post by: WonderDog on December 04, 2009, 12:49:58 AM
I have noticed that the original format item files is only loading first item correctly.  Using v1.29.3.2 BETA

Code: [Select]
    key = .\Resources\Data\Items
    path = .\Resources\Data\Items.items
        loading orig
Loading items from .\Resources\Data\Items.items
loading items from '.\Resources\Data\Items.items'
LoadItems: Simple Sheer Dress
LoadItems: 1 0 5
    key = .\Resources\Data\Magic Items
    path = .\Resources\Data\Magic Items.items
        loading orig
Loading items from .\Resources\Data\Magic Items.items
loading items from '.\Resources\Data\Magic Items.items'
LoadItems: Jelewed Wand
LoadItems: 0 1 3
    key = .\Resources\Data\More
    path = .\Resources\Data\More.items
        loading orig
Loading items from .\Resources\Data\More.items
loading items from '.\Resources\Data\More.items'
LoadItems: Home Impregnation Kit
LoadItems: 1 17 30
    key = .\Resources\Data\SGB Items
    path = .\Resources\Data\SGB Items.items
        loading orig
Loading items from .\Resources\Data\SGB Items.items
loading items from '.\Resources\Data\SGB Items.items'
LoadItems: Angels Ring
LoadItems: 0 1 25
LoadItems:  7 30
LoadItems:  21 -30
    key = .\Resources\Data\Special1
    path = .\Resources\Data\Special1.items
        loading orig
Loading items from .\Resources\Data\Special1.items
loading items from '.\Resources\Data\Special1.items'
LoadItems: Whip
LoadItems: 0 2 25
    key = .\Resources\Data\Special2
    path = .\Resources\Data\Special2.items
        loading orig
Loading items from .\Resources\Data\Special2.items
loading items from '.\Resources\Data\Special2.items'
LoadItems: Vira Seed
LoadItems: 3 8 1
    key = .\Resources\Data\WDItems
    path = .\Resources\Data\WDItems.items
        loading orig
Loading items from .\Resources\Data\WDItems.items
loading items from '.\Resources\Data\WDItems.items'
LoadItems: Lust Potion
LoadItems: 1 0 1
LoadItems:  20 5

With some testing with only one manually created item file it apears that the item is only read in up to number of effects - 1  (probably looping error) and the last trait/skill/stat/status line becomes the name of the next item.

If you test an item file with only one entry it game will load 2.
Title: Re: Bugs 1.29.3
Post by: ravenswinus on December 04, 2009, 02:32:39 AM
I've found a bug where items meant to break a girls will do not work.

I've put the necklace of control on two girls and their reb. stayed around 50.  I gave another girl the Armband of Control and she also stayed around 50.  I've left all three on the girls for six weeks and no change.

I'm running the latest version of the game.
Title: Re: .Item file load errors
Post by: DocClox on December 04, 2009, 03:18:46 AM
I have noticed that the original format item files is only loading first item correctly.  Using v1.29.3.2 BETA

Should be fixed in the next release.

It's worth pointing out that the pre-XML formats are going to be phased out before too much longer in any case.
Title: Re: Bugs 1.29.3
Post by: Midnight_Amratha on December 04, 2009, 07:05:17 AM
minor issue: spelling thing, when you mate a girl with monsters she seems to mate with mosters instead
also i seem to have trouble loading saved games when the titles are made up of multiple words, the autosave seems to work just fine the loading won't accept space in the title however
Title: Re: Bugs 1.29.3
Post by: DocClox on December 04, 2009, 08:40:29 AM
Fixed the spelling error. Can't replicate the loading problem.
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 04, 2009, 10:35:51 AM
For some reason not all of the daughters are receiving the daughter trait. My first and fifth daughters received the Your Daughter trait, but the second through fourth ones (as marked in the dungeon) did not.
(On a side note, all five daughters had less than 15% constitution.)

Small typo in the "x gold from x bussiness" message.. should be business (unless some other countries spell that differently.)

I ran a game for a few years yesterday without problems while saving, but this morning am finding it impossible to load the save files.

After a few weeks in on a new game I'm getting stuff added to my inventory from nowhere. I don't have anyone visiting the catacombs and haven't bought anything.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 04, 2009, 03:08:55 PM
On the daughter thing, while it's my oppinion your issue with them not being your daughter is that slaves that someone else impregnated were put into place between your daughters, I'll agree that constitution and levels in daughters seems to be messed up. Both my daughters and the daughters of my girls seem to be anywhere from level 10-20 and constitution is generally 10%-20%. I believe, currently, both issues are caused because they are included in the inherited stats and are thus set to be between 10% and 20% despite it being a bit odd for them to be so.
Title: Re: Bugs 1.29.3
Post by: sgb on December 04, 2009, 06:10:55 PM
I'd bet the issue is they are getting the inherited part of the constitution bonus (the 10-20%), but aren't getting their normally generated constitution.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 04, 2009, 08:56:27 PM
That sounds about like what it's doing for constitution. It still shouldn't make them a higher level than their mothers, though. (A level 2 giving birth to a level 17 has happened to me)
Title: Re: Bugs 1.29.3
Post by: delta224 on December 04, 2009, 09:01:02 PM
Blame the player/ customer having a set of stats to inherit from
Title: Re: Bugs 1.29.3
Post by: Bloodly on December 05, 2009, 01:12:27 PM
Recieving random crash outs with no warning or explanantion on hitting 'next turn'.  It's entirely random, occuring regardless of what girls I'm using, or my game situation.  The worst part is it also affects the auto-save.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 05, 2009, 01:26:28 PM
I know about that bug, and I wish I could fix it.  I had a chance but screwed it up and hit the wrong button and it happens to me so rarely it is hard to track. 
Title: Re: Bugs 1.29.3
Post by: sammeh on December 05, 2009, 06:38:50 PM
Getting impossible amounts of money reported when my girls have sex.

They'll have the breakdown of each visitor done correctly, usually around 50-100 when I'm starting out, but when it tallies the shifts totals it gives me numbers in the 10-30 thousands. I don't get that amount, I get what seems to be the regular amount, but it's just reporting that impossibly high amount fo the shifts totals.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 05, 2009, 06:45:31 PM
I'm basically rewriting the financial system right now. Not promising there will be no bugs, but it will be easier to maintain once I'm done.
Title: Re: Bugs 1.29.3
Post by: Midnight_Amratha on December 06, 2009, 10:35:13 AM
running game untill gamelog is 150k+ and savefile is 90k+ and i can't load anymore. no problems up untill gamelog 140k or savefile size 80k. any ideas?
Title: Re: Bugs 1.29.3
Post by: DocClox on December 06, 2009, 10:53:41 AM
running game untill gamelog is 150k+ and savefile is 90k+ and i can't load anymore. no problems up untill gamelog 140k or savefile size 80k. any ideas?

That should compress quite a bit if you zip it up.  I don't suppose you fancy doing that and uploading them somewhere?

I've been dropping a lot of debug chatter into the log lately, (must make sure it clears down when you start a new session) but it shouldn't stop a game from loading. In any event, I should be able to solve the "not loading" problem
Title: Re: Bugs 1.29.3
Post by: Zeus on December 06, 2009, 05:19:45 PM
hy Folks, don't now why, but my game is getting my hole Ram and freezing my PC if i try to load my best saved game... (same es i try to load the auto save...) 
i add the game log if this is helping... ^^
Title: Re: Bugs 1.29.3
Post by: DocClox on December 06, 2009, 05:39:01 PM
Nothing obvious there. Can you post the save?
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 06, 2009, 06:02:16 PM
I've been having problems with save files too. Was trying to determine a little better what might be causing it. At an undetermined point after my third brothel I've been consistently unable to load save files. Even though they seem to save fine, actually trying to load them causes everything to freeze up and the program eventually crashes. The result is the same even when closing the program out altogether and restarting it.

I hadn't thought about it being related to the actual file size before, but it could very well be that. Right now, though, all my save files seem to be loading at the moment and the one is at 96k.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 06, 2009, 06:13:50 PM
I think it is an error involving pregnancy, let me try something and upload a fixed version, lets hope it does not include any other errors.

edit-- the fix is up
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 07, 2009, 01:26:07 AM
For version 1.29.3.3 that was just posted, the Next and Previous buttons no longer seem to work off the Girls Details screen.

Since I depend pretty heavily on being able to cycle through screens from the Girls Detail mode, I don't think I'll be able to play enough to see if the original problem is fixed or not.
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 07, 2009, 02:09:33 AM
I'll run through a game quick just to test it.

[Edit]

1: The Sterile and/or Incorporial traits are not preventing girls from getting pregnant (see CC in first attached save file - autosave.gam).  Also note that CC was using anti-pregnancy potions at the time.  The anti-preg potions appear to work fine for everyone else.

2: Had many "next week" crashes.  Attached the game log file generated after one of them, if it helps.

3: The game progressed to a point, 51-53 weeks or so after the first daughter was born; I saved the game, advanced two turns and the game crashed.  The autosave file was corrupted, so I loaded the regular save, and advanced two turns when the game crashed.  Wash, rinse, repeat ad infinitum.  Loaded the save, advanced 1 turn, saved and the game crashed.  Save file is now corrupted (blah.gam attached).  Strangely enough, the autosave file is no longer corrupted, will attempt to continue from there.

[Edit 2]

The problem in part 3 is that at some point CC got inseminated by a monster, and the game was crashing on the due date.  Coat hanger should fix the crash.

[Edit 3]

For the first time ever in any of the games I've played, a girl got an STD.  Also, apparently the matrons are kinda bugged: mine just allowed two girls to work themselves to death.  Usually they take them off duty by the time the girls' health starts to drop - I've never seen them go to a second so-tired-it-hurts shift.

I can confirm that the new patch fixes the save/load problem for daughters who have come of age (proof is blah(2).gam file attached).  I can also confirm that the previous/next buttons on the girl management screen are borked.
Title: Re: Bugs 1.29.3
Post by: Bloodly on December 07, 2009, 03:25:24 AM
Usually they take them off duty by the time the girls' health starts to drop

How skilled was the Matron, how high were the Constitution scores of the girls, and were the girls Fragile?  Matron's Skill level is(As far as I'm aware) the % chance that they'll act.  Combine this with a low Con(Easily gains Tiredness/Fast dropping health) and/or Fragile(Increases Tiredness/Health loss again) and a girl can die real fast.
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 07, 2009, 05:23:43 AM
The matron's skill was about 80 or so, though I don't know exactly what the skill level does - it may very well be the percent chance that the matron acts correctly.  Neither girl had the fragile trait and both had a con of 100.  The statistical probability of the matron failing to take both of them off duty at the same time in enough consecutive turns to kill them both is exceedingly low.

Assume that skill level = % chance of acting, and a matron skill of 80.

Turn 1, both girls are tired enough to trigger the matron, but she fails to trigger both times (20% chance per event, combined chance is 4%)
Turn 2, girls health declines, matron fails to trigger on both (again, 4% chance of occurring, total chance of event = 0.16%)
Turn 3, ditto (combined event chance = 0.0064%)
Turn 4, ditto (combined event chance = 0.000256%)
Turn 5, dead if matron doesn't act (combined chance = 0.00001024%)

The chance of the matron failing to take 2 girls off duty enough consecutive times that they both die at the same time is a tad bit more than 1 one-hundred-thousandth of 1% (odds are 9,765,625 to 1 against).  I feel far more confident labeling it a bug than random happenstance.
Title: Re: Bugs 1.29.3
Post by: Midnight_Amratha on December 07, 2009, 08:19:52 AM
noticed something else on the fixed 1.29.3.3 when you try and buy girls from the slavebroker in town, first time you click on the girl the info doesn't appear, you have to click again to bring up the info.
 
also, you can no longer brand customers as slaves for retail sale.
 
dunno if this is a new bug: two slave brandings in a row will make the game crash and burn.
Title: Re: Bugs 1.29.3
Post by: Zeus on December 07, 2009, 09:51:01 AM
the Save and the Autosave..
I was used the v2.0 from the LS Item set (but after the fix to 2.29.3.2 i think alle Items from the LS items are disappiered...) and i think i was used every Girlpack in here ^^'''
Title: Re: Bugs 1.29.3
Post by: DocClox on December 07, 2009, 10:17:05 AM
Wow. That's a lot of girlpacks:

Code: [Select]
EESpecial.girls
EEpack.girls
EEpack2.girls
EEpack3.girls
EEpack4.girls
EEpack5.girls
FE girls.girls
Girls.girls
Girls.girlsx
GirlsAddon1.girls
GirlsAddon1.girlsx
Katara (Avatar).girls
Katt.girls
Megapack.girls
Mitsuru Kirijo.girls
Pack1.girls
Sakura Kasugano.girls
Supah 1.girls
Supah 2.girls
Supah SF.girls
Toph (Avatar).girls
chitosekarasuma.girls
milfuellesakuraba.GIRLS
mintblancmanche.girls
morestuff.girls
penny (gadget).girls
ranpharanboise.GIRLS
ty Lee (avatar).girls
vanillah.girls

Anyone finding the same problem with the standard girls? It's going to take quite a while to find and download all of these so I can test this.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 07, 2009, 10:21:12 AM
I knew I screwed something up let me do a few things and I will try to post a fixed version.
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 07, 2009, 11:12:20 AM
It's going to take quite a while to find and download all of these so I can test this.

Most of the girls listed can be easily gotten from the UserMod part of the forum. Exodia91 has links to a number of packs from the older forum. Several of the individual girl names were part of the Galaxy Angel pack. I'm not sure about the ones below though.

Code: [Select]
Katara (Avatar).girls
Katt.girls
Mitsuru Kirijo.girls
Toph (Avatar).girls
penny (gadget).girls
ty Lee (avatar).girls
Title: Re: Bugs 1.29.3
Post by: delta224 on December 07, 2009, 11:18:32 AM
Found the issue with the buttons on the girl detail screen, doc fault not mine.  This also might be related the issue with the girls on the slave screen.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 07, 2009, 11:20:53 AM
Did I not fix that one already? Maybe it's still to be merged.
Title: Re: Bugs 1.29.3
Post by: Zeus on December 07, 2009, 11:24:26 AM
the Avatar Girls and Penny from Gadget are from someone from the World-of-Hentai Board ^^ about the other two i'm not sure... i think... Katt is from here... but... um... yeah... XD
Title: Re: Bugs 1.29.3
Post by: delta224 on December 07, 2009, 11:38:56 AM
Could have been merged in with the gold changes which I refuse to touch at the moment.  I am trying to figure out why the trait data is not updating, with little luck.  The customer issue I will tackle.  The sterile issue I think I've fixed.  I plan to upload a fixed version once I fix the slave market issue.
Title: Re: Bugs 1.29.3
Post by: Command on December 07, 2009, 11:59:12 AM
I have a problem of game crashes when I try to brand or torture certain girls.
 
with the last verison I only had crashes when I tried to brand certain girls now it seems that it crashes when I try to brand or torture those certain girls.
 
one is from a mod of this side her name is Nina Williams.
 
I also had a problem doing the same to starfire.
 
Also would you mind mosting a link to those downloads on the mode section?
Title: Re: Bugs 1.29.3
Post by: delta224 on December 07, 2009, 12:10:30 PM
Let me take a look at the branding issue and I will report back to you.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 07, 2009, 12:43:15 PM
No idea why we were having issues with the branding.  Will need more info.

edit uploaded the fixes with the slave market and the buttons.  Lets hope I did not screw anything else up.
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 07, 2009, 01:38:21 PM
v 1.29.3.4

The Release button is now unavailable from the main Dungeon screen. The Release All still works and Release is available from the Girls Details screen.

Title: Re: Bugs 1.29.3
Post by: DocClox on December 07, 2009, 01:56:08 PM
Another one of mine - fixed in the version I'm editing. IIRC it's just a Enable/DisableButton mismatch.

Note to self - do not break the release branch again!
Title: Re: Bugs 1.29.3
Post by: delta224 on December 07, 2009, 02:02:33 PM
I've kind of been working on the tagged version, and no it was not a enable,disable mismatch.  It was that you forgot to enable it when selecting a girl.  Well off to work on my remake of hentaihighschool. 
Title: Re: Bugs 1.29.3
Post by: Midnight_Amratha on December 07, 2009, 03:45:48 PM
ver. 1.29.3.4 took care of the most problems but now the anti-preg pills are borken
Title: Re: Bugs 1.29.3
Post by: delta224 on December 07, 2009, 04:42:40 PM
I know the problem, going to go fix it, may release another build tommorrow.
Title: Re: Bugs 1.29.3
Post by: sgb on December 07, 2009, 07:05:19 PM
It would really help us testers if you continue to include changelogs with the versions.  For the developers benefit as well as ours.  There seem to be too many devs working on it at once, and so we don't know what changes were actually put into these minor updates and what to test/look for.
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 07, 2009, 07:06:19 PM
v 1.29.3.4

Something is broken in the way items are equipped. I was thinking that previously I could equip one item of each type on a girl. Right now I can only equip 1 item total on a girl. Sometimes I can convince it to use 2 items... So I can wear a dress and shoes, or a dress and necklace, but not a dress, shoes, and necklace.

Also, when you are qualified to buy the second brothel, if you bring up the script on the map screen, then choose not to buy the brothel, all the controls on the page become disabled and you are unable to either leave the map screen, nor do anything else. I had to force the program to exit and restart from the autosave.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 07, 2009, 07:19:50 PM
I though I fixed that issue with the brothel.
Title: Re: Bugs 1.29.3
Post by: sgb on December 07, 2009, 11:59:50 PM
I noticed random Slave Market girls are getting flagged 'lolita' at age 20 or lower now.  I really wouldn't consider 20 years old a 'lolita'.
Title: Re: Bugs 1.29.3
Post by: Mehzerz on December 08, 2009, 12:14:34 AM
Yeah well... the minimum age for the game is 17. So that's about as lolita as we're probably going to get.
Title: Re: Bugs 1.29.3
Post by: ohnonono on December 08, 2009, 12:44:30 AM
Crash with 1.29.4, probably pregnancy related because those first set of kids haven't shown up yet, and some of my girls are preparing to deliver their second batch of children.

Really looking forward to the XMLization of everything; I'd love to be able to help debug stuff like this but I don't have the free time to figure out the save file format then write a tool to represent it in a readable way.

Are you guys compiling this with debugging symbols enabled?  I'd be happy to upload core files too if it'll help you track down these bugs more easily.

Edit: Updated with gamelog; I actually didn't realize this had been added.  Sorry!
Title: Re: Bugs 1.29.3
Post by: delta224 on December 08, 2009, 12:52:21 AM
For the build we release to you guys no we do not compile with debugging symbols.  Also next time you have a crash post the gamelog, that has more info that the save file for finding issues.  Game log not change log.  Also I could not find anything wrong with your save file, also their is a very random crash that I had just and insight on why it might occur, let me do some next day mashing to see if it crashes. ;D
edit-- found the crash, now just to fix it, and I think I did, stupid preprocessor macro.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 08, 2009, 03:31:05 AM
Just to add, releasing debug builds can be a bad idea with visual studio, since they link with a whole different set of DLLs which aren't included in the runtime pack. The folks with a development environment set up are ok, but everyone else has problems running it.
Title: Re: Bugs 1.29.3
Post by: Command on December 08, 2009, 11:40:59 AM
No idea why we were having issues with the branding.  Will need more info.

edit uploaded the fixes with the slave market and the buttons.  Lets hope I did not screw anything else up.

Not exactly sure how to get more info the whole game freezes up and I either half to wait a while for it to give the don't send message to show up or click on the close button on that dos par on the player.
 
 
I just sent them back into the dungion and the branding worked.  I'm guessing it maybe random on the girls I'm not sure.  But this problem keeps happaning ccasionally.
Title: Re: Bugs 1.29.3
Post by: delta224 on December 08, 2009, 11:53:19 AM
That is all I need, thank you.   I know that the error off to see if I can fix it.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 08, 2009, 01:57:36 PM
I'm not sure if it's just because xml isn't compliant with Vista or something, but I still have problems when I try to convert girls to the xml format. I know there was talk earlier about removing non-xml format, but can that be left in until the compatibility problems are worked out?
Title: Re: Bugs 1.29.3
Post by: delta224 on December 08, 2009, 02:02:24 PM
Don't worry we will not remove the support for the old version for a few updates.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 08, 2009, 02:07:34 PM
Absolutely. That was the point of supporting them both:  to give ourselves a chance to iron out the wrinkles :)
Title: Re: Bugs 1.29.3
Post by: sgb on December 08, 2009, 05:40:58 PM
Quote
I'm not sure if it's just because xml isn't compliant with Vista orsomething, but I still have problems when I try to convert girls to thexml format. I know there was talk earlier about removing non-xmlformat, but can that be left in until the compatibility problems areworked out?
Definitely not a Vista issue.  Upload your .girls file and I will see if I can convert it for you.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 08, 2009, 06:29:19 PM
I uploaded it earlier and people said it worked fine for them, but I'll upload the old version and the xml version up to be looked at.
Title: Re: Bugs 1.29.3
Post by: sgb on December 08, 2009, 07:03:03 PM
Well, you're not crazy.  I tried the first file, it works fine.  Triedthe second, and max age is clearly being ignored along with several sexstat values.  Tried taking the first file, converting it then deleting the non-XML version.  Same problem; doesn't work right.  Here's a slightly modified version of the core randomgirl file in XML (I deleted several core girls I didn't like and use a second file with my own random characters).  This works as it should on mine.  Move your files to a different directory and try using this one and see what happenes.  If it works, I would suggest adding the missing character files back in to this one and going from there.  Very strange though.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 08, 2009, 07:43:48 PM
I seem to be having the same problem with your file. I'm going to upload your file back up so you can check to see if maybe it's somehow shifting about the .rgirlsx file when I try and use it in game.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 08, 2009, 07:45:33 PM
Try this one. I converted Alugere's .girls file using the perl script I used for the initial conversion. I gave it a quick test and didn't see any problems, but that doesn't mean they aren't there.

If this works, we need to figure out how it differs from Solo's generated files. If not, I'm going to add a ton of error checking and diagnostic chatter into the XML loader. Been on the todo list for a while anyway.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 08, 2009, 07:47:57 PM
Still acting odd after I use Doc's version.
Title: Re: Bugs 1.29.3
Post by: sgb on December 08, 2009, 07:55:22 PM
Okay, I've found the problem.  Or part of it anyway.  If you run whoremaster with no unique girl files (ie only random packs), the values are all fubar.  As long as you have some normal girls in there, the random girl values get loaded right.  Just tried it with my own files.  Remove all but the random, and I get the same errors as Alugere.  Put my unique character files back in there, everything is working again.  This only happens with the XML version.

Convert your standard girls file to XML as well and it should work for you again Alugere.
Title: Re: Bugs 1.29.3
Post by: Solo761 on December 08, 2009, 08:13:23 PM
I think there's something strange about how random girls work. In original files random girls have 0 for both minimum and maximum age. And yet, their age was around 18-30. Only case where I found then to be older was in case of kidnapping wife and daughters of non paying customer. Then age could get up to 60 (from my experience).

Could it be that age is hardcoded for random girls depending from where they're acquired? I don't know if XML loading method just fills the same structure as original one, but it seems logical. If they weren't hardcoded and it got read from the file you could get mother that is younger than her daughter.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 08, 2009, 08:20:45 PM
Could it be that age is hardcoded for random girls depending from where they're acquired?

There was something like that, and I fixed it. Although I'm not sure that code made it into the release.

I don't know if XML loading method just fills the same structure asoriginal one, but it seems logical. If they weren't hardcoded and itgot read from the file you could get mother that is younger than herdaughter.

It does, bugs permitting. :)
Title: Re: Bugs 1.29.3
Post by: sgb on December 08, 2009, 08:24:57 PM
Random Age field was being ignored a few versions ago.  It's working in the current version, beyond this strange bug.  IMO, the sooner everyone gets to the same file format the better.
Title: Re: Bugs 1.29.3
Post by: Alugere on December 08, 2009, 08:27:20 PM
Okay, I've found the problem.  Or part of it anyway.  If you run whoremaster with no unique girl files (ie only random packs), the values are all fubar.  As long as you have some normal girls in there, the random girl values get loaded right.  Just tried it with my own files.  Remove all but the random, and I get the same errors as Alugere.  Put my unique character files back in there, everything is working again.  This only happens with the XML version.

Convert your standard girls file to XML as well and it should work for you again Alugere.

That does make it work. Although, since I prefer using only random girls, it is a bit annoying.
Title: Re: Bugs 1.29.3
Post by: sgb on December 08, 2009, 08:35:35 PM
Quote
That does make it work. Although, since I prefer using only random girls, it is a bit annoying.
Try deleting all but one of them in the file, then throw that one in the dungeon forever.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 08, 2009, 08:37:26 PM
Give me a chance to finish this mamoth gold rewrite and I'll see if I can find the problem. I expect if you  hand edit the unique girl file, you can remove all but one of them and still have it work, which might minimise the annoyance factor.

If not, it'll be interesting to see which girls it needs.

[edit]

Too slow! :)
Title: Special Tag "AffectsAll"
Post by: WonderDog on December 09, 2009, 01:07:04 AM
On 1.29.3.v Beta there seems to be a missmatch with WMEdit

Item tag
Code: [Select]
Special="Affects All" as converted by WMEdit .64 and will generate an error in game and run as a normal item.

Manualy remove the space and
Code: [Select]
Special="AffectsAll"will run without errors.


Also seems that items that add Masochist trait increase Con +5 when equiped and apear to decrease con -50 when unequiped.
Title: Re: Bugs 1.29.3
Post by: sgb on December 09, 2009, 10:06:50 AM
You might want to bring that up in the WMeditor thread, as this is something Solo needs to see and change.

As for the stat thing, most stats are capped.  What was the characters CON before the trait was added?
Title: Re: Bugs 1.29.3
Post by: DocClox on December 09, 2009, 11:21:44 AM
Still sounds like a bug. If a girl has 90 CON and gets a 20 bonus, when it wears off, the con should revert to its permanent level of 90.
Title: Re: Bugs 1.29.3
Post by: Dirtyxmind on December 09, 2009, 03:19:49 PM
Hello all!

I am playing with the most current version (1.29.3.4) and i found the next problem:

- A girl (Bulma) got pregnant 2 times and gave birth 2 times. So far all is working OK.
- After 60 weeks (from her first birth) her son grow up and was sold. All is still OK.
- After 59 weeks (from her second birth) she gives birth again... without being pregnant... At the summary there's not a 'Birth' message but just a Danger mark... I checked her stats and found that she gave birth because a 'Can't get Pregnant for 4 weeks' message was there. The first weird thing so far.
- The next week after that, another son grow up and was sold... If i try to save or do anything i got an ERROR and the game just closes...

The worst part is that i tried to save and got the ERROR... The save file got a major cut and can't be used anymore... But the good part is that the autosave worked fine and wasn't affected, from the previous week before the ERROR. I did a backup and renamed the autosave and try to run again the game and all worked. Again, if i let run a Week, all is OK... but after that, the problem presents again...

Trying to find the cause for this, i checked the Cut save file and found that this file cuts exactly at the position of the data for the girl (Bulma). Here's the data:

Bulma
Bulma
Nagging and temperamental. She is intelligent and has a fierce determination to get what she wants, and can reckless in her pursuit of them.
0
15
Nerd
0
Quick Learner
0
Strong
0
Aggressive
0
Adventurer
0
Great Arse
0
Fearless
0
Perky Nipples
0
Lolita
0
Abnormally Large Boobs
0
Fast orgasms
0
Masochist
0
Tough
0
Broken Will
0
MILF
0
0
0
32
30 115 0 100 0 0 20 -12203 0 65 166 0 10 100 0 70 -90 0 0 0 0 10 90 0 0 20291 0 20 0 0 0 99 0 100 0 0 255 0 0 19 0 0 0 251 0 80 -908 0 60 140 0 0 0 0 100 0 0 0 -306 0 0 100347 0 0 -356 0
20 804 0 0 363 0 5 889 0 5 905 0 5 1010 0 20 379 0 0 973 0 30 3533 0 10 383 0 60 407 0
0
1
0
0
5
3 3
255 255
0
0
121 17 0
1628
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0
0
1
22 0 1 0
26 100 52 22 45 78 91 43 86 31 39 96 82 27 61 44 77 94 30 25 80 32
62 59 37 22 70 39 30 90 95 92
0 0 0 0
0 97 114 110 32 48 32 103 73 45 78 111 0 114 111 109 32 109 111 118 105 101
32 105 4 0 0 0 15 0 0 0

For references, here's the girl data part of the autosave file that works:

Bulma
Bulma
Nagging and temperamental. She is intelligent and has a fierce determination to get what she wants, and can reckless in her pursuit of them.
0
15
Nerd
0
Quick Learner
0
Strong
0
Aggressive
0
Adventurer
0
Great Arse
0
Fearless
0
Perky Nipples
0
Lolita
0
Abnormally Large Boobs
0
Fast orgasms
0
Masochist
0
Tough
0
Broken Will
0
MILF
0
0
0
32
30 115 0 100 0 0 20 -12203 0 65 166 0 10 100 0 70 -90 0 0 0 0 10 90 0 0 20291 0 20 0 0 0 78 0 100 0 0 255 0 0 19 0 0 0 251 0 80 -908 0 60 140 0 0 0 0 100 0 0 0 -306 0 0 100345 0 0 -354 0
20 804 0 0 363 0 5 889 0 5 905 0 5 1010 0 20 379 0 0 973 0 30 3533 0 10 383 0 60 407 0
0
1
0
0
5
3 3
255 255
0
0
120 16 0
1628
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0
0
2
21 0 1 0
26 100 52 22 45 78 91 43 86 31 39 96 82 27 61 44 77 94 30 25 80 32
62 59 37 22 70 39 30 90 95 92
59 1 0 0
60 60 60 60 60 60 60 73 60 60 60 60 60 60 60 60 60 60 60 60 60 60
10 10 10 10 10 10 10 10 10 41
0 0 0 100 102 0
0

From this, what i did, was to use again the autosave and sold the girl (Bulma) inmediatly and play normally... and after 10 weeks i didn't got the ERROR again...

Could someone check this, please?

Thank you for your kind attention!
Title: Re: Bugs 1.29.3
Post by: delta224 on December 09, 2009, 03:23:04 PM
Can I just say fuck, the pregnacy code as it is written.  :'(
Title: Re: Bugs 1.29.3
Post by: sammeh on December 09, 2009, 07:35:43 PM
keep getting this error when trying to open the slave market


Slave Maket called
... doing init
setting up slave market: genGirls = 0
Title: Re: Bugs 1.29.3
Post by: sammeh on December 09, 2009, 08:01:16 PM
keep getting this error when trying to open the slave market


Slave Maket called
... doing init
setting up slave market: genGirls = 0


NVM, fixed it myself.
Seems when i updated all the girl and rgirl files into the xgirl/xrgirl file all the random girls got taken of the slave market, fixed it though.
Title: Re: Bugs 1.29.3
Post by: Draka on December 10, 2009, 02:19:48 AM
having an issue with version 1.29.3.4 which basically is... custom items of mine listed as 'common' don't show up.. I have a shoe item, a dress item and a couple consumables... a couple consumables do show up... but the dress item, my shoe item (in fact no shoes of ~any~ sort show up in the shop), and so forth... reverting back to version 1.29.3.2 makes everything except simple sheer dress disappear out of the shop.... Any clue what's wrong, advice, etc?
Title: Re: Bugs 1.29.3
Post by: DocClox on December 10, 2009, 03:46:58 AM
can you post the items file?
Title: Re: Bugs 1.29.3
Post by: delta224 on December 10, 2009, 08:39:38 AM
It is something wrong with legacy loading of item not the file.  Do to how it has been changed, the effects are not loaded in which messes up the entire loading process.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 10, 2009, 08:53:57 AM
I think the legacy format problems stem from when I tried to fix them to work on linux last revision or so.

It might be easiest to haul in the legacy loading funcs from a version or two back. The original legacy funcs were the unaltered loading code, so they should work just fine

/me knocks on wood
Title: Re: Bugs 1.29.3
Post by: delta224 on December 10, 2009, 08:59:45 AM
It is an easy fix.  One easy way is to just resize the vector with the number of effects after the game loads that number.
Title: Re: Bugs 1.29.3
Post by: Dirtyxmind on December 10, 2009, 06:30:53 PM
Hello again all!

Is there any NEWs about the problem i submited at the Reply #153 (http://pinkpetal.org/index.php?topic=138.msg2726#msg2726) of this post?

Please let me know!

I want to recover the girl (Bulma)... but if i bought her back, the problem starts again...

Just let me know if i need to edit a value (from her data) to recover her and let the problem fade away.

Thank you again for your kind attention!
Title: Re: Bugs 1.29.3
Post by: delta224 on December 10, 2009, 06:54:15 PM
fixing it at the moment is a matter of changing in this part of the save
Code: [Select]
1
22 0 1 0
26 100 52 22 45 78 91 43 86 31 39 96 82 27 61 44 77 94 30 25 80 32
62 59 37 22 70 39 30 90 95 92
0 0 0 0
0 97 114 110 32 48 32 103 73 45 78 111 0 114 111 109 32
to just 0
 
edit-- changed the fix slightly to start over with the kids
Title: Rgirlsx have no trait Bonus / Penalty
Post by: WonderDog on December 11, 2009, 07:18:32 AM
I think I saw this mentioned previously but I can't find it.

I have been looking at save files and have noticed that random Girls don't seem to have any bonus or penalties for any traits that they have when they are created.  Gaining or losing traits during play seems to be working correctly.

I think this is because Random girls are created as needed and Custom girls are only created at the start of a new game so it may be diffrent code during generation.

Also a number of Random girls will have broken stats and skills all zero. This is not evey time that girl but probably happens every 10-20 girls


Charisma        0
Happiness        100
Libido            0
Constitution    0
Intelligence    0
Confidence        0
Mana            0
Agility            0
Fame            0
Level            0
Ask Price        0
% Charge        100
XP                0
Age                17
Obedience        20
Spirit            0
Beauty            0
Tiredness        0
Health            100
PC Fear            0
PC Love            0
PC Hate            0

Anal Sex        ??  Random value
Magic            0
BDSM Sex        0
Normal Sex        0
Bestiality Sex    0
Group Sex        0
Lesbian Sex        0
Service Skills    0
Stripping Sex    0
Combat            0


I have seen this repeted for many turns.  No errors in the gamelog.

I do have many custom girlsx loaded as well.

Also girls listed after one of these often have weird (random) stats.
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 11, 2009, 01:14:00 PM
I found a problem in the function that loads girls' skills.  It seems that in some cases the NormalSex skill is being assigned a random value.  I attached the .girlsx file I used to run a test recently along with 3 saved games that show different starting values for the skill for several girls (notably Asuka, who I gave maxed out stats to for the purposes of the test).
Title: Re: Bugs 1.29.3
Post by: elementalforce on December 11, 2009, 05:12:41 PM
Maybe not a bug but something  I noticed. I tortured a custom girl in my dungeon. Then I branded her, but since her health was to low and she struggled she died. Just for fun I tried to sell her (the dead body anyway ;-)) and it worked. I am not sure how much I got for her though. A few weeks later the slave trader offered her as a slave. I bought her and she was sent to my brothel, but when I looked in the brothel she was still dead. Maybe you can change it, so that you can`t sell dead girls or so.
BTW awesome work so far guys.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 11, 2009, 05:38:14 PM
Aye, both of them bugs: the selling dead bodies one, and the not getting feedback on how much they sold for.

Title: Re: Bugs 1.29.3
Post by: Fstop on December 11, 2009, 06:53:30 PM
Just a question is there any plan to fix the shop reload inventory exploit or are you just going to leave it for ppl who dont mind reloading 100x time for a item NOW
Title: Re: Bugs 1.29.3
Post by: DocClox on December 11, 2009, 06:59:36 PM
The plan is to fix everything - but I must admit that one's not been high on the todo list of late.
Title: Re: Bugs 1.29.3
Post by: sgb on December 11, 2009, 07:02:53 PM
Why bother?  If you want to cheat, there are plenty of other ways.  You can just edit the save file modify whatever it was you wanted the item to do directly.  Dumping the current shop list into the save file actually just makes it EASIER to cheat, as now you can edit the store list itself.
Title: Re: Bugs 1.29.3
Post by: Fstop on December 11, 2009, 07:32:20 PM
Haven't read the other bug post but the new girlx files don't get auto re-aged to over 17 (not that I really mind but necno added that just in case so he wont get in trouble)
Title: Re: Bugs 1.29.3
Post by: sgb on December 11, 2009, 08:28:42 PM
It's in one of the official changelogs (Necro's) that it was lowered to 17.  It just wasn't actually working until DocClox fixed it.
Title: Re: Bugs 1.29.3
Post by: Draka on December 11, 2009, 09:51:05 PM
Still having issues with my items.... I removed them from the items list, put into a seperate file, then moved that file out of the WM folder... starting a new game with just the basic items included with the game shows major issues still... let's see if it attached right.. trying to include the base items file... if someone could help me, it'd be appreciated.
Title: Re: Bugs 1.29.3
Post by: sgb on December 11, 2009, 10:04:22 PM
Get the latest WMeditor and convert it to XML.  The current version of WM doesn't seem to like the old format anymore, and the old version will be getting phased out soon enough anyway.
Title: Re: Bugs 1.29.3
Post by: Fstop on December 12, 2009, 06:39:18 AM
but I got the latest version and I got a 11yearold character o.o
Title: Re: Bugs 1.29.3
Post by: redle on December 12, 2009, 07:06:23 AM
Save and load don't seem to work at all for me.  I've seen an issue or two regarding saves discussed, but none that seem to talk about no file being created at all.

I've tried with:
1.23_Beta
-> 1.29
-> 1.29.3 (with fix)
-> 1.29.3.2
-> 1.29.3.4

1.29.3.2_Beta (the redistribution)
-> 1.29.3.4

Of all 7 variants, the only one that created a new file anywhere I could find was the 1.29.3...  Even then, the .gam file that was created only had 2 lines of text in it:

Girls.girlsx
GirlsAddon1.girlsx

Nothing ever shows up in the load window.  I created my own saved game file from a copy/paste of a post somewhere around here, as well as downloading a saved game file that someone had posted.  Granted, I was not nearly as thorough with it, but neither of them showed up in the few different versions I did check them against (placing the files in the root WM directory).

I notice no errors in the log file.  It ends with

Slave Maket called
... checking buttons
... checking arrows
************* saving dungeon data *****************
Saving Customers
*********** Saving rivals *************
saving rival: Black
saving rival: Shaolin
saving rival: Land
saving rival: North Coast
************ Saving players inventory **********
************ Saving brothels **********
Saving brothel: theName
Saving girl: Tsuzune
Saving girl: Kazumi
Saving girl: Hamano
Shutting Down
Title: Re: Bugs 1.29.3
Post by: DocClox on December 12, 2009, 07:21:21 AM
There should be a folder called saves in the game root. That's where the save files would be under normal circumstances.
Title: Re: Bugs 1.29.3
Post by: Fstop on December 12, 2009, 09:25:06 AM
proof of broken age system
(http://img300.imageshack.us/img300/1221/dsadasdas.th.jpg) (http://img300.imageshack.us/i/dsadasdas.jpg/)

(http://img405.imageshack.us/img405/5982/unti2tled.th.jpg) (http://img405.imageshack.us/i/unti2tled.jpg/)

(http://img215.imageshack.us/img215/2723/84336700.th.jpg) (http://img215.imageshack.us/i/84336700.jpg/)

if you try to alter the age it fixes itself to 17 years old (youth potion etc.)
Title: Re: Bugs 1.29.3
Post by: DocClox on December 12, 2009, 09:42:54 AM
I believe you. Not sure what's happening, but I'll take a look at the code, just as soon as I get this config file mod stable. I'm checking every price in the game at the moment and trying to make sure it's both adjusted properly by the config file and also displayed correctly.

Once I get that done and merged into the code, I'll be in a position to start looking seriously at some of these bugs again. 
Title: Re: Bugs 1.29.3
Post by: Fstop on December 12, 2009, 09:47:04 AM
Its all cool I was just making sure everyone knew what I was trying to say

(time to kill some DEMOMEN in TF2 for the patriots)
Title: Re: Bugs 1.29.3
Post by: redle on December 12, 2009, 06:24:25 PM
Thanks DocClox.  I had tried spreading various save folders about but was missing the trailing s from saves.  Never the less, I will comment that adding the folder to the distribution or having the code create the non-existent directory would be a nice addition...

Oh, and yep that seems to have fixed it.

Title: Re: Bugs 1.29.3
Post by: DocClox on December 12, 2009, 06:49:09 PM
It should be there - I'll add it to our new bug tracking system.
Title: Re: Bugs 1.29.3
Post by: Draka on December 12, 2009, 07:41:56 PM
sgb...thanks a bunch. I dled the newest WM editor and coverted things over to xml and it works fine now.  ;D
Title: Re: Bugs 1.29.3
Post by: DocClox on December 13, 2009, 05:21:33 AM
Is anyone else finding that the gambling chance isn't reported on the upgrades screen? I've been assuming it's just me, but I don't seem to have tinkered with that bit of code yet, so maybe not ...

Never mind, I got it. The interface ID isn't being set - could well be down to me.
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 13, 2009, 06:09:00 PM
I think I have a partial clue into my disappearing inventory problem... On my current game the inventory disappears whenever I sell a slave or fire a girl. However, starting up a new game doesn't produce the same results right away, so there must be still some other factor(s) involved.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 13, 2009, 06:17:38 PM
were any of the missing items at one time in the girl's possession? It sounds like the game is trying to clear down her inventory and getting it wrong. If they'd been owned by the girl, there's a chance the girl still has a pointer to the item, and consequently the destruction process is deleting the items.

mmm... let me see if I can replicate that.
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 13, 2009, 06:44:04 PM
On the game that the bug is happening on, I can have stuff that I've never given to anyone at anytime disappear. What you suggested was actually one of my first thoughts as well, but, again, I couldn't replicate the process on a brand new game right away. It always spites me a bit when the game clears out my inventory after getting a Super Cream of Healing, Venus necklace, or some other rare item that I'm trying to save for some specific girl.

Sometimes when I unequip a girl I get back multiple items of the item I'm trying to unequipp. Even stranger yet, last night I saw a Pearl Necklace I unequipped turn into a "Hand mirror" , added separately from the 4 "Hand Mirror" that were already in inventory. Note the difference in capitalization. I sold the abberrant item to the store right away because I was afraid it was going to bug my inventory again, and the item promptly vanished into the ether somewhere. (I've customized my items list to make "A hand mirror" to be "Hand Mirror". I can't begin to imagine where the game pulled that "Hand mirror" description from.)

Maybe it's just my imagination, but it seems I have quite a bit more inventory problems after I've started raiding the catacombs. Whatever is the actual catalyst, once the problem starts it keeps on going.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 14, 2009, 03:42:12 AM
Which girl packs are you using? If there's not too many of them, and you've got a save where this is happening, that could be very useful. Doubly so if you can replicate it with just the standard girls.
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 14, 2009, 02:55:32 PM
Which girl packs are you using? If there's not too many of them, and you've got a save where this is happening, that could be very useful. Doubly so if you can replicate it with just the standard girls.

The game I was currently having problems with used EternalEquinox packs 1-5+Tenchi Muyo,Vandread pack, Supah SF. I plan to use more packs in the future, but wanted to look closer at the characters before adding them. I'll try to see if I can replicate the problem using just the normal girls.

On a different note, I started a game where I ran 8 gangs kidnapping girls from the very start and am noticing that at least half of my girls are being added with house percentage set to 0. And once in awhile one is added with percentage of 100, despite not being a slave. Most of the non standard ones are 0 though.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 14, 2009, 03:44:56 PM
Added that to the tracker. We have a last 1.29 release coming up. Once that gets done, I'll be able to take a little time for bug fixing
Title: Re: Bugs 1.29.3
Post by: Wispowill on December 14, 2009, 07:18:57 PM
On a different note, I started a game where I ran 8 gangs kidnapping girls from the very start and am noticing that at least half of my girls are being added with house percentage set to 0. And once in awhile one is added with percentage of 100, despite not being a slave. Most of the non standard ones are 0 though.

I was looking at something else in the girls.girlsx file and suddenly realized that these girls with 0% were set like this in the config file. I had thought that the game itself set the default value for this so I guess I misunderstood how the game was suppose to work here.  Although having to check the value everytime a girl is added is a bit cumbersome in my lone opinion.
Title: Re: Bugs 1.29.3
Post by: DocClox on December 14, 2009, 07:30:20 PM
Interesting. So we can probably fix the issue by setting the House percentages to 100% or 60% depending on whether the girl is a slave or not.

Question is: what should the game do with that field? Possibilities are to use it as the girl's default house percentage when free (which apparently it does at the moment) or to ignore it and set all girls to 100% if slaves or 60% if free. Ignoring it seems to make more sense.

Anyone have any arguments to the contrary?
Title: Re: Bugs 1.29.3
Post by: zodiac44 on December 14, 2009, 09:45:33 PM
I think the default values should be configurable in the config file, with 60% and 100% being a good starting place.  We could possibly have it ignore the defaults if the house percentage in the .girlsx file is non-zero, though I think that would be more of a nuisance than anything (I typically set all my girls to the same house percentage and would be rather irritated to discover some of them were using values other than the default).

If we ever implement either a system where the girls negotiate their percentage take, then the value in the .girlsx file could represent the minimum commission rate they are willing to accept.