Author Topic: Reporting Errors:  (Read 352718 times)

0 Members and 11 Guests are viewing this topic.

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: Reporting Errors:
« Reply #600 on: March 01, 2015, 10:16:01 AM »
Ok, here is another one. I just uploaded adventurer random pack. All random adventurers that I create have Imouto main personality trait, even though I don't even have this trait in adventurer json at all.
Then I created 10 random angels, all of them had Deredere, even though the chance of it is quite low.

Created some dark elves. All of them are Imouto again  ::)
Created a dryad. Yandere main trait. But there was no yandere in her json (now it is there, because it looks like a good idea).
 
« Last Edit: March 01, 2015, 10:43:16 AM by DarkTl »

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: Reporting Errors:
« Reply #601 on: March 02, 2015, 11:01:02 AM »
Yeah, even random girls created without console commands might have a wrong main personality trait that they should never have according to jsons.

Offline silvermistshadow

  • Newbie
  • *
  • Posts: 3
Re: Reporting Errors:
« Reply #602 on: March 02, 2015, 06:19:47 PM »
I updated the game today with the usual method (tortoisehg). Things are generally working fairly well, but I have encountered one thing. Whenever I equip things to my character and then leave that screen, it pops up with this error, which also appears any time I try to open my character's menu again at all and prevents me from seeing my equipment or adding anyone to my personal team (besides methods I'm unaware of).

A similar thing has happened with some girls after equipping them and required reloading an earlier save, but I don't have the traceback here right now.

Code: [Select]
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/library/screens/pyt - screens - heroprofile.rpy", line 11, in script
    $ pytfall.hp.screen_loop()
  File "game/library/screens/pyt - screens - heroprofile.rpy", line 11, in <module>
    $ pytfall.hp.screen_loop()
  File "game/library/classes - support.rpy", line 1126, in screen_loop
    result = ui.interact()
TypeError: 'int' object is not iterable

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: Reporting Errors:
« Reply #603 on: March 03, 2015, 06:28:16 AM »
I'll take a look at both issues tonight.
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: Reporting Errors:
« Reply #604 on: March 03, 2015, 08:44:08 PM »
...

I couldn't replicate this, no matter what I tried. Error means that something code tried to iterate over gets changed to or was miscoded as integer instead of an iterable.

Yeah, even random girls created without console commands might have a wrong main personality trait that they should never have according to jsons.

I figured out what's wrong, how do we want this to work? I don't remember if we discussed json syntax for personality traits for rgirls. Right now for some reason blueprint girl has traits and personality trait, I am going to take a look at that.

Like what we're doing?

Offline silvermistshadow

  • Newbie
  • *
  • Posts: 3
Re: Reporting Errors:
« Reply #605 on: March 03, 2015, 09:44:56 PM »
I couldn't replicate this, no matter what I tried. Error means that something code tried to iterate over gets changed to or was miscoded as integer instead of an iterable.
Indeed, I figured. Here's the rest of the traceback, if it matters. (cleaned references to folder name choices on my drive, because of reasons. In short: not telling the entire internet where I keep my stash.)

Code: [Select]
Full traceback:
  File "game/library/screens/pyt - screens - heroprofile.rpy", line 11, in script
    $ pytfall.hp.screen_loop()
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\ast.py", line 785, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\python.py", line 1382, in py_exec_bytecode
    exec bytecode in globals, locals
  File "game/library/screens/pyt - screens - heroprofile.rpy", line 11, in <module>
    $ pytfall.hp.screen_loop()
  File "game/library/classes - support.rpy", line 1126, in screen_loop
    result = ui.interact()
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\ui.py", line 247, in interact
    rv = renpy.game.interface.interact(roll_forward=roll_forward, **kwargs)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\core.py", line 2149, in interact
    repeat, rv = self.interact_core(preloads=preloads, **kwargs)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\core.py", line 2478, in interact_core
    self.draw_screen(root_widget, fullscreen_video, (not fullscreen_video) or video_frame_drawn)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\core.py", line 1677, in draw_screen
    renpy.config.screen_height,
  File "render.pyx", line 363, in renpy.display.render.render_screen (gen\renpy.display.render.c:5330)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\layout.py", line 618, in render
    surf = render(child, width, height, cst, cat)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\transition.py", line 362, in render
    top = render(self.new_widget, width, height, st, at)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\layout.py", line 618, in render
    surf = render(child, width, height, cst, cat)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\layout.py", line 618, in render
    surf = render(child, width, height, cst, cat)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\screen.py", line 598, in render
    child = renpy.display.render.render(self.child, w, h, st, at)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\layout.py", line 618, in render
    surf = render(child, width, height, cst, cat)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\sl2\sldisplayables.py", line 70, in render
    cr = renpy.display.render.render(self.child, width, height, st, at)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\layout.py", line 618, in render
    surf = render(child, width, height, cst, cat)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File ".\Pytfall\code\renpy\renpy-6.18.3-sdk\renpy\display\layout.py", line 964, in render
    st, at)
  File "render.pyx", line 98, in renpy.display.render.render (gen\renpy.display.render.c:2849)
  File "render.pyx", line 174, in renpy.display.render.render (gen\renpy.display.render.c:2537)
  File "accelerator.pyx", line 106, in renpy.display.accelerator.transform_render (gen\renpy.display.accelerator.c:1880)
TypeError: 'int' object is not iterable

Windows-7-6.1.7601-SP1
Ren'Py 6.18.3.761
PyTFall 0.51 Slaver's Bay

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: Reporting Errors:
« Reply #606 on: March 03, 2015, 09:52:26 PM »
Nah, I need more detailed instructions to replicate. That bit of code might have been relevant if there was an issue with framework instead of the game.
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: Reporting Errors:
« Reply #607 on: March 03, 2015, 10:03:27 PM »
Yeah, even random girls created without console commands might have a wrong main personality trait that they should never have according to jsons.

Ok, I figured out how you wanted it to work. It should be ok now.
Like what we're doing?

Offline silvermistshadow

  • Newbie
  • *
  • Posts: 3
Re: Reporting Errors:
« Reply #608 on: March 03, 2015, 10:18:31 PM »
Nah, I need more detailed instructions to replicate. That bit of code might have been relevant if there was an issue with framework instead of the game.
Alright. The steps I preformed were more or less as such:
Start new game (picked the top option, for a level 1 person, caravan guard with the uh, money thing)
Went into the menu for the main character.
(Note: following step is included only as a just in case measure, who knows, it could actually be the trigger since I did both on the same visit!)

Used the team thing (I'll edit this when I next run the game so I can use less ambiguous language), modified personal team name to Logarithmic Z (don't ask)

Entered equipment menu, equipped the following: body (mithril), head (imperial leather), rings (protection or some such), weapon (archmage staff), amulet (the mana-increasing one), feet (probably mithril here too), hands (the concentration gloves or something), cloak (wizard's cloak), perhaps some other things.

If it's possible to use IRC, Skype or some other method of fast communication (I saw a reference to an IRC chat in one of the main threads, but no details), I can attempt to get a more precise list.

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: Reporting Errors:
« Reply #609 on: March 04, 2015, 09:30:11 AM »
Ok, I figured out how you wanted it to work. It should be ok now.
I hope so. I don't see any difference between main personality traits and any other traits in terms of json syntax.
If we have     
Quote
["Kuudere", 25],
["Bokukko", 35],
["Deredere", 100]...
It means 25% chance of kuudere, if not then 35% chance of bokukko, if not then 100% chance of deredere. I'm surprised it didn't worked like that, actually.

Btw, we could use default settings for main traits. There always should be Slim, Average Boobs and Deredere traits unless specified otherwise.

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: Reporting Errors:
« Reply #610 on: March 04, 2015, 10:05:48 AM »
I hope so. I don't see any difference between main personality traits and any other traits in terms of json syntax.
If we have     It means 25% chance of kuudere, if not then 35% chance of bokukko, if not then 100% chance of deredere. I'm surprised it didn't worked like that, actually.

Btw, we could use default settings for main traits. There always should be Slim, Average Boobs and Deredere traits unless specified otherwise.

Well, it did work, but it set the traits to the blueprint girl. It's an old badly written function that confused me a bit when I was adding the code for personality traits. It should be noted that if you do not add 100 percent personality trait, one will be picked randomly if they all fail.
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: Reporting Errors:
« Reply #611 on: March 04, 2015, 06:15:34 PM »
..

I can't replicate this and there is always a chance this is something on your end... irc might still be up but we usually communicate thought forums.

There is a small issue of not being able to equip more that one of the same ring, I'll look into that.
Like what we're doing?

Offline DarkTl

  • Hero Member
  • *****
  • Posts: 4737
Re: Reporting Errors:
« Reply #612 on: March 18, 2015, 12:53:22 PM »
Items bugs time!

I pushed miscs json, you can see how items are supposed to work.
1) Attitude Reajustor doesn't add Serious trait.
2) From time to time, without any skills related items equipped.

Quote
  File "game/library/screens/pyt - screens - nextday.rpy", line 12, in script
    python:
  File "game/library/screens/pyt - screens - nextday.rpy", line 47, in <module>
    Rest(girl, brothel, resting)
  File "game/library/classes - jobs.rpy", line 1011, in __init__
    self.after_rest()
  File "game/library/classes - jobs.rpy", line 1270, in after_rest
    equip_for(self.girl, self.girl.action)
  File "game/library/functions.rpy", line 1011, in equip_for
    girl.equip_for("Service")
  File "game/library/classes - characters.rpy", line 1008, in equip_for
    returns.extend(self.auto_equip(["service"], ["charisma"], exclude_on_stats=["charisma", "health", "vitality", "mp", "joy"], exclude_on_skills=["service"], slot=slot))
  File "game/library/classes - characters.rpy", line 1222, in auto_equip
    if self.get_skill(skill) < item.skillmax:
UnboundLocalError: local variable 'skill' referenced before assignment

3) Mind Balancer works well (I'm surprised), but if you don't assign a new main personality trait after removing it, there will be error. It's not actually a bug, more like a vulnerability.

I can't really test other stuff when there is that error with autoequipment every 5-10 turns...


Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: Reporting Errors:
« Reply #613 on: March 18, 2015, 02:09:35 PM »
I'll take a look but at least one of the errors shouldn't be possible. My repo is corrupted so I'll have to reclone the whole thing tonight.
Like what we're doing?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6893
  • "It's like hunting cows"
Re: Reporting Errors:
« Reply #614 on: March 18, 2015, 04:30:14 PM »
1) Attitude Reajustor doesn't add Serious trait.

It does for me,  more likely is that you've tried to apply to a girl with Serious blocked.

2) From time to time, without any skills related items equipped.

Should now be fixed, was a whole bunch of errors there.

3) Mind Balancer works well (I'm surprised), but if you don't assign a new main personality.

No it doesn't, we discussed this. There should be no items in the game that can change girls personality. Only events, all other personality traits are being automatically added to absolute blocks, there is no code in the game that can apply a new trait under normal operations.
Like what we're doing?