Pink Petal Games

Feedback => Bugs and Game balancing => Topic started by: DocClox on May 05, 2010, 12:52:40 PM

Title: Bugs: 1.30 Alpha
Post by: DocClox on May 05, 2010, 12:52:40 PM
Let's try and keep the bugs for a release to the one thread, folks.

Just to get things started: the images on the slave market (and elsewhere I believe) are losing their aspect ratio when they get scaled. This leads to some unflattering distortions.
Title: Re: Bugs: 1.30 Alpha
Post by: mbscout on May 05, 2010, 03:00:57 PM
When in the dungeon, selecting any of the column header causes the game to crash.  There was only one girl in the dungeon at the time.  Once there were more then one , the game does not crash.  After the column been sorted (with multiple girls in the dungeon), the game wont crash even if there is just one girl the dungeon.
Title: Re: Bugs: 1.30 Alpha
Post by: Shinteo on May 05, 2010, 03:52:50 PM
During the turn summary, clicking on the dungeon tab will cause it to crash too.
Title: Re: Bugs: 1.30 Alpha
Post by: Adamwest69 on May 05, 2010, 06:07:18 PM
If you impregnate a girl, it doesn't count down the days to birth, rather it says "38 Weeks to Birth". I just checked the window that lists the command lines and it keeps saying 38 weeks to birth too, so I don't think pregnancy is working correctly.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 05, 2010, 09:54:26 PM
A few bugs I've noticed during some quick test:
-New girls seem to refuse to work in the brothel regardless of rebelliousness, even slave girls.  It seems to take a few months before they will actually start doing their jobs.
-Gangs can generate with almost no members, yet cost the same as fully manned gangs. EDIT: I see this is in the config file.  I have no idea why anyone would want starting gangs to not start full.
-I was just using the default packs with the game, and noticed someone forgot to input age variables for all the random characters.  Now that this field actually matters, this results in everyone being 17.
-House% formula is still messed up.  From 51% to 69% offers no rebelliousness change.  Going from 51% to 50% suddenly gives you a huge rebelliousness drop, while going lower than that actually starts to increase rebeliousness with 0% being the same as 69%.
-I cannot confirm Adamwest's problem.  Pregnancy is working fine for me, and the 'Your Daughter' and 'Incest' traits are finally working too!
-Dependent trait still giving an automatic -100 rebeliousness and Charismatic/Charming traits still give game breaking stat boosts.
-Not a big deal, but I noticed that the special script for Cammy White is no longer triggering.

UI Note:
-I don't like the new auto-fit for images.  A lot of smaller images look terrible when stretched, and it just gets worse if you set the game resolution above 800x600.
-For future changes, group duplicate items in the store.  Another nice change would be for items to be colour-coded based on rarity so you can quickly skim through for special items.
Title: Re: Bugs: 1.30 Alpha
Post by: GBCliff on May 05, 2010, 11:59:00 PM
Might be statistical anomaly, but mind-fucked, broken will, and masochist appear to occur much more frequently in 1.30 than 1.29. might be by design.

Agree with above comments on auto-fit of images.

Turn Summary dungeon crashing is not occuring in my game, may be linked to specific conditions.

Loving the new dungeon and brothel interface. More stats = more control, better feel for whats happening.

Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 03:39:23 AM
Just to get things started: the images on the slave market (and elsewhere I believe) are losing their aspect ratio when they get scaled. This leads to some unflattering distortions.
I don't really like it either. It was changed in one of Nec's latest commits, though whether it was intentional or not I don't know.

When in the dungeon, selecting any of the column header causes the game to crash.  There was only one girl in the dungeon at the time.
Confirmed. Strange, it didn't crash earlier when I was testing it, though. Will investigate and fix.

During the turn summary, clicking on the dungeon tab will cause it to crash too.
Took a bit of testing, but I duplicated this by starting a new game, going straight to the next week, clicking the Dungeon listing, clicking the Brothel listing, and then clicking back on the Dungeon listing. Will investigate and hopefully fix.

If you impregnate a girl, it doesn't count down the days to birth, rather it says "38 Weeks to Birth". I just checked the window that lists the command lines and it keeps saying 38 weeks to birth too, so I don't think pregnancy is working correctly.
If you're referring to the debug window, I've noticed it outputting that "38 weeks to birth" message on every girl, whether pregnant or not. I haven't looked into it, but I don't think that message is any real indication towards how long the pregnancy really has to go. I will do a bit of pregnancy testing at some point, though.

-New girls seem to refuse to work in the brothel regardless of rebelliousness, even slave girls.  It seems to take a few months before they will actually start doing their jobs.
I hadn't noticed that problem from my own brief testing, but the code to determine whether a girl refuses any particular job was completely overhauled, so there are bound to be issues there. Necno might be working on that at some point here, or I might look into it later.

 
  -Gangs can generate with almost no members, yet cost the same as fully manned gangs. EDIT: I see this is in the config file.  I have no idea why anyone would want starting gangs to not start full.
  This is intentional. The gangs don't start out at full strength, which I think is sensible with them being "on the market". They're looking for a patron to support them and provide funds to recruit more members.
As you say though, it is indeed an option in the config file.

  -I was just using the default packs with the game, and noticed someone forgot to input age variables for all the random characters.  Now that this field actually matters, this results in everyone being 17.
I'll look into it.
 
  -House% formula is still messed up.  From 51% to 69% offers no rebelliousness change.  Going from 51% to 50% suddenly gives you a huge rebelliousness drop, while going lower than that actually starts to increase rebeliousness with 0% being the same as 69%.
  I'll look into this as well.

  -Dependent trait still giving an automatic -100 rebeliousness and Charismatic/Charming traits still give game breaking stat boosts.
  As above.

  -Not a big deal, but I noticed that the special script for Cammy White is no longer triggering.
  True, I noticed this earlier myself. Not sure if I'll be able to fix it, but I do plan to look into it.

  -For future changes, group duplicate items in the store.  Another nice change would be for items to be colour-coded based on rarity so you can quickly skim through for special items.
I might give item grouping and sorting a shot after some bugfixing. For colors, it's a bit cumbersome to come up with many background colors for listbox items; changing the text color is certainly a possibility, though. Necno is about to work on the font rendering system, so I'm not going to do anything there for the time being.

Might be statistical anomaly, but mind-fucked, broken will, and masochist appear to occur much more frequently in 1.30 than 1.29. might be by design.
Not sure whether that's intentional or not. I'll check into the responsible code and possibly tone down the frequency if it seems too excessive.
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 06, 2010, 05:37:46 AM
UI Note:
-I don't like the new auto-fit for images.  A lot of smaller images look terrible when stretched, and it just gets worse if you set the game resolution above 800x600.

I'm thinking about adding some options to the XML to allow some control over how an image is scaled. A preserve aspect ratio flag would be nice, and possibly a max size as well. (in which case I'll probably need to add alignment flags - I'm reinventing javascript here...)
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 06:07:14 AM
I'm thinking about adding some options to the XML to allow some control over how an image is scaled. A preserve aspect ratio flag would be nice, and possibly a max size as well. (in which case I'll probably need to add alignment flags - I'm reinventing javascript here...)
Sounds good, if maybe a bit overkill. ;)


OK, a few fixes done and committed so far.
* When in the dungeon with exactly one girl listed, selecting any of the column header caused the game to crash.
--    fixed
* Age variables for all the random characters were set to 0 min and max. This resulted in all random girls being 17.
--    fixed (game currently limits max age to 25, so you'll get an age range of 17-25)
* During the turn summary, clicking on the Dungeon listing will cause it to crash if there are no girls in the dungeon.
--    fixed
  * "config.weeks_preg: 38" message given on debug window when viewing any girl, pregnant or not.
--    message now only shown when girl is pregnant
  * Dependent trait still giving an automatic -100 rebeliousness
--    changed obedience boost from +90 to +50
* Charismatic/Charming traits still give game breaking stat boosts.
--    halved charisma boost for each

Checked:
* Might be statistical anomaly, but mind-fucked, broken will, and masochist appear to occur much more frequently in 1.30 than 1.29. might be by design.
--    Seems fine in the code. For reference... Broken Will: with girl health < 20 and spirit < 20, only 5% chance per torture. Masochist: BDSM skill > 30, 10% chance. Mind Fucked: health < 10, 5% chance.

I checked the problem with Cammy's "meet" script not working, and it appears it's not ever being added. I put a breakpoint in the AddTrigger function and monitored it, and only the global triggers were ever added. The trigger-related code is something I've not touched before, so I'm not sure what's up beyond that. I suppose I could dig around further, but it would probably take quite a while for me to find the root of the problem... Doc? Necno? Any ideas on this one?
Title: Re: Bugs: 1.30 Alpha
Post by: GBCliff on May 06, 2010, 08:48:31 AM
Purchased brothel number 5 from the Town screen. The script asking for a name appeared, then the starting game script in grey text box. I was in a completely default game with that brothel name. All other brothels, girls, and gangs were gone.

Iron will trait does not seem to affect torture behavior. Rebel drops at same rate as other girls.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 09:14:57 AM
Purchased brothel number 5 from the Town screen. The script asking for a name appeared, then the starting game script in grey text box. I was in a completely default game with that brothel name. All other brothels, girls, and gangs were gone.

Iron will trait does not seem to affect torture behavior. Rebel drops at same rate as other girls.
Are you sure you're playing the 1.30 alpha build (http://pinkpetal.org/index.php?topic=351.0)? That bug with buying the last brothel was fixed long ago. I just now double-checked the code and it appears fine, and I then tested it myself with modified purchase requirements and was able to safely buy every brothel.
Title: Re: Bugs: 1.30 Alpha
Post by: James on May 06, 2010, 12:25:41 PM
some jobs, may or may not be working, and ignoring the prohibit section, since i had a girl work as a stripper, yet on the new day thing it said she had sex with a beast. (which i prohibited)
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 06, 2010, 03:00:03 PM
I'm running windows vista x32, and the game crashes instantly upon being run. I fiddled with the config in wordpad and added my own girlpack. I only changed some of the pregnancy settings, and boosted gang starting members to minimum of 9. I've run it as admin and without, in XP compatibility and without, crashes exactly the same way every time. The commandline window opens, then the main window comes up as all black, then the game instantly crashes.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 03:17:47 PM
I'm running windows vista x32, and the game crashes instantly upon being run. I fiddled with the config in wordpad and added my own girlpack. I only changed some of the pregnancy settings, and boosted gang starting members to minimum of 9. I've run it as admin and without, in XP compatibility and without, crashes exactly the same way every time. The commandline window opens, then the main window comes up as all black, then the game instantly crashes.
Try running an unmodified copy of it (no config changes or extra girl pack) and see if that crashes. If it does still crash, please reply back and attach the "gamelog.txt" file to you post from the game folder.
If an unmodified copy doesn't crash, I guess you can try each change/addition to find which one causes the crash.

some jobs, may or may not be working, and ignoring the prohibit section, since i had a girl work as a stripper, yet on the new day thing it said she had sex with a beast. (which i prohibited)
Yeah, strippers who chose to have sex with customers currently don't check to see what's prohibited. This should be fixed at some point.
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 06, 2010, 03:40:12 PM
it does crash with a clean copy as well.
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on May 06, 2010, 03:57:38 PM
I just had a quick look. The weekly report for the first girl in the list keeps saying that she finished the customers that like her despite the fact that afterward she works.
Last day example:
finished customers
met customer
finished
met
finished
met
met
report says she met 4 customers
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 06, 2010, 03:58:34 PM
it does crash with a clean copy as well.

Crashes during graphics initialisation from the look of it.

Code: [Select]
configration variables from '.\Resources\Data\config.xml'^M
calling init^M
Initializing Graphics^M
SDL_RWFromFile(): No file or no mode specified

That's the full file, right there. Googling doesn't help much.

Any other Vista users? With or without this problem?
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 03:59:57 PM
EDIT: Doc sort of beat me to it, but:
it does crash with a clean copy as well.
So the error you're getting in gamelog.txt is this:
Code: [Select]
SDL_RWFromFile(): No file or no mode specifiedI toyed around with removing necessary files on a clean copy myself, and was able to duplicate that error only in one particular instance: when I removed the \Resources\Interface\Font.txt file. Is that file intact on your copy?

I just had a quick look. The weekly report for the first girl in the list keeps saying that she finished the customers that like her despite the fact that afterward she works.
I noticed that myself, but haven't looked into it. It's one of the job-related issues which will need to be fixed.


EDIT: thinking about it, why is it even using Font.txt for anything now? It should be using whatever font is defined in config.xml instead. I'll see about fixing that.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 05:28:08 PM
More fixes committed:
* girl images were being stretched to fit the area, losing aspect ratio (made image class default to maintaining aspect ratio)
* unique girls were incorrectly starting with 100% normal sex skill (stored in XML as "NormalSex", game was looking for "normalSex")
* some unique girls had odd starting "house percentage" values, such as 0 and 100; normalized to all starting at the default of 60

- also, Font.txt is no longer needed or checked; instead, font definition in config.xml is used for everything

I've gone ahead and released an update (http://pinkpetal.org/index.php?topic=351.msg6423#msg6423) with all the fixes so far.
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 06, 2010, 05:34:28 PM
font.txt is intact on my copy. Game still crashes even updated, trying an updated clean copy now, heres the info dump windows gives if it helps

Problem signature:
  Problem Event Name:    APPCRASH
  Application Name:    Whore Master.exe
  Application Version:    0.0.0.0
  Application Timestamp:    4be33243
  Fault Module Name:    SDL.dll
  Fault Module Version:    1.2.13.0
  Fault Module Timestamp:    4778182e
  Exception Code:    c0000005
  Exception Offset:    00028ab6
  OS Version:    6.0.6001.2.1.0.768.2
  Locale ID:    1033
  Additional Information 1:    0211
  Additional Information 2:    04e1e558b6d8e874e7e0984368daaa7d
  Additional Information 3:    516a
  Additional Information 4:    64afe5328e4aa9df51fe01ff1e5db93e


Doesn't work on clean updated copy either. attached new gamelog
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 05:45:37 PM
Hmm. When I was testing earlier, I did get a crash log with the same contents of your latest gamelog.txt if the \Resources\Images\ folder was moved or had files removed.
So, it seems like it's not able to properly locate files in \Resources\ for some reason on your system. As to why that might be, I admit I'm at a loss. Anyone else having this problem?

EDIT: out of curiosity, did you install it to a permission restrictive location like in you Program Files directory?
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 06, 2010, 06:05:19 PM
Nope, I just threw it on my desktop.

wait.. old whoremaster doesn't work anymore either.. odd it used to work   perfectly. It must be a problem with my computer....
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 06, 2010, 06:10:15 PM
Great, I can finally add Charasmatic, Charming, and Dependent back onto my characters for fluff purposes!  Some more feedback for you:

-The new advertisting method is a bit flawed.  Before, you had a straight forward slider.  Pay more, get more.  Now you have to set someone to build up your advertising, which is fine.  However, you cannot decrease your advertising level anymore.  If you set a girl to advertising and forget about it for a while, you could end up paying 1000 gold a month for the rest of the game.  This could lead to problems early game if someone runs into financial trouble, as you cannot stop this investment.  Consider changing it back to a sliding bar, but with the maximum limit 'locked' until you've had someone run your advertising campaign to the needed level.

-You cannot transfer items directly from the store to a girl.  You have to give them to yourself, then move them to the girl.

-Not a bug, but a little guide as to what the new jobs (at least the ones that are working) are doing for you would help.  Cleaning and Advertising might be straightforward, but what does setting a girl to Matron duty or Security exactly do for me?  Would help testers know what to look for and help test/balance jobs that are considered 'completed'.

Otherwise this is great work from the devs!  My interest in this game has been totally renewed with 1.30.
Title: Re: Bugs: 1.30 Alpha
Post by: FurryFanatic on May 06, 2010, 06:47:21 PM
From what I've been seeing with security and matron, the security job allows you to hire a slave/non-slave girl to do the job that the gangs used to take up and the matron job allows you to use one of your non-slave girls to watch out for the other girls.  When choosing a girl for the matron job, I've always picked a girl with attributes that I would want a caretaker to have when watching over my girls and their health.  I love putting the warrior girls on security duty because they're usually packed with bouncer traits: tough, manly, merciless, aggressive, strong, etc.  I could be wrong, but so far I haven't had any trouble with the girls as security or as the matron.  Guessing security decreases chances of rape and matron is the same as before you could assign a non-slave to the job: watch the girls health and take them off duty when their health gets too low.  ;)
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 06:55:17 PM
-You cannot transfer items directly from the store to a girl.  You have to give them to yourself, then move them to the girl.
Confirmed, working on fixing it now.
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 06, 2010, 07:27:51 PM
does this need like a specific .net framework version to run or something? the only thing I can think of that might have broken it for me is like I upgraded to a beta or uninstalled or something like that
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 06, 2010, 07:44:32 PM
does this need like a specific .net framework version to run or something? the only thing I can think of that might have broken it for me is like I upgraded to a beta or uninstalled or something like that

It could well be something like that, try these from the 1.29 release post:
If you get the error message "This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem." Then you need to Download these files (http://www.microsoft.com/DOWNLOADS/details.aspx?FamilyID=9b2da534-3e03-4391-8a4d-074b9f2bc1bf&displaylang=en)
If you have further problems starting then install these (http://www.microsoft.com/downloads/details.aspx?familyid=32BC1BEE-A3F9-4C13-9C99-220B62A191EE&displaylang=en) and these (http://www.microsoft.com/downloads/details.aspx?FamilyID=200B2FD9-AE1A-4A14-984D-389C36F85647&displaylang=en) files
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 06, 2010, 07:45:02 PM
nope, there's no managed component at all

you might try re-running the VC redistributable installers linked from the "official" download thread. It's possible your C++ runtime got corrupted somehow

[edit]

What HE said...
Title: Re: Bugs: 1.30 Alpha
Post by: Fstop on May 06, 2010, 07:57:14 PM
If you currently have negative money (In my case -10k or so  from advertising with my first few characters) you can hit deposit all in the bank giving you 0 money witch is kinda cool =p
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 06, 2010, 08:08:25 PM
If you currently have negative money (In my case -10k or so  from advertising with my first few characters) you can hit deposit all in the bank giving you 0 money witch is kinda cool =p
Not a bug, as this is apparently how it works with big businesses in the real world   :D
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 06, 2010, 08:23:54 PM
They didn't do crap, what the hell. I can't think of anything else that would cause Both this AND 1.29 to both stop working in exactly the same manner.
Title: Re: Bugs: 1.30 Alpha
Post by: Fstop on May 06, 2010, 08:33:19 PM
Not a bug, as this is apparently how it works with big businesses in the real world   :D

I dont think a 1 girl operation counts as a "big" business =p
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 07, 2010, 01:30:36 AM
More changes committed to SVN, all related to the Item Management screen. Maybe got a little carried away. ;)
Fixed:
* You cannot transfer items directly from the store to a girl.  You have to give them to yourself, then move them to the girl.
--    the item transferring code was a bit wonky and was separate for transferring either way; I consolidated and cleane up the code, fixing it in the process

New:
* Item lists on Item Management screen are now sorted alphabetically
* When viewing player or girl inventory item, it shows "Value: x  Sell For: y" instead of "Cost: x"
* Items listed on the item management screen now have differing font colors according to rarity. Items purchaseable in the shops are blue, the brighter the rarer. Green items are only found on the catacombs (dark green) or by scripts or objective rewards (a bit lighter green). "Common" items should be plain black, but there seems to be very little in that category currently. The rarity colors are configurable in config.xml.

Will continue with some more bugfixes before releasing another update.
Title: Re: Bugs: 1.30 Alpha
Post by: Zazael on May 07, 2010, 04:47:55 AM
I played a few month and none of my girls used anti-preg. Nevertheless none of them got pregnant.

Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 07, 2010, 05:17:38 AM
A couple more done, and a couple more helpfully provided by WonderDog.
Fixed:
* If you had negative money you could hit "deposit all" in the bank, which would reset you to 0 money
* Girls could be inseminated when using fake beasts
* Random girl traits were not properly applying skill changes... ex. pigtail girl started with lesbian trait, 0% lesbian skill
--  This fix was courtesy of WonderDog - thanks!
* Big Boobs and Abnormally Large Boobs weren't properly improving customer happiness
--  This fix also courtesy of WonderDog

Will continue tomorrow some time.


I played a few month and none of my girls used anti-preg. Nevertheless none of them got pregnant.
What do you mean, exactly? You had no anti-preg potions, or you had the girls set not to use them, or you had the potions and had girls set to use them but the number of potions never decreased, or what?
Actually, I've gotten plenty of pregnant and inseminated girls when I didn't have any anti-preg potions and had the girls working in the brothel, so I'm guessing it's B or C.
Title: Re: Bugs: 1.30 Alpha
Post by: Zazael on May 07, 2010, 06:08:07 AM
I had the potions, but the girls weren't set to use them. Don't know why they weren't inseminated or pregnant
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 07, 2010, 06:43:18 AM
I had the potions, but the girls weren't set to use them. Don't know why they weren't inseminated or pregnant
OK, I'll check on that.
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on May 07, 2010, 11:24:47 AM
well don't forget the chance of getting pregnant starts off at 8% so it can take a long time for the girls to get pregnant. (I haven't run into this problem, my get pregnant (as they're supposed to) even though I have 100 pots, which never changes)
Title: Re: Bugs: 1.30 Alpha
Post by: WonderDog on May 07, 2010, 12:13:53 PM
The bug for Cammy White trigger is looking for MeetGirl.script and a search of scripts, Cammy White folders of my alpha game folder has no script of that name. My 1v29 has that script in the Cammy White folder. You may want to add the script to the trunk.

Had poke around in the cGirls file today and found a couple of issues.

Sanity checking for traits is done in AddTrait() which is not called during girl initialisation which goes straight to ApplyTraits().  Also Sanity checks allready in ApplyTraits() and UnApplyTraits() not the same as in  AddTrait().  So I have moved the checks to  ApplyTraits() & UnApplyTraits().

A quick check using Test mode now shows traits properly applying to the girls.  Looking at the save game file there are remembered traits in the starter girls.   

This means that the the traits that appear later in the girlsx file remove the earlier incompatiable ones.

The Curretnt trait compatiablities are
Code: [Select]
Manly         &     Elegant
MILF          &     Lolita
Quick Learner &     Slow Learner
Small Boobs   &     Big Boobs        &     Abnormally Large Boobs
Iron Will     &     Broken Will
Slow Orgasms  &     Fast Orgasms     &     Fake orgasm expert
Aggressive    &     Meek
Fearless      &     Meek, Dependant or Nervous
Optimist      &     Pessimist
Tough         &     Fragile
One Eye       &     Eye Patch         &     Different Colored Eyes

Inherited traits test was looping 30 times instead of the number of traits that the mum had.  This may resolve that issue where a child has many more traits than the parent.

Tided up the InheritTrait() fn, added a test for traits not to be inherited  and added an 30% chance that an unlisted trait can be inherited.

Added a test to ignore age changes on girls with unknown ages (age > 99).
Title: Re: Bugs: 1.30 Alpha
Post by: ShadowMage on May 07, 2010, 12:55:15 PM
There's a bug in the dungeon which causes rebelliousness to keep increasing even after you've got it a bit lower.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 07, 2010, 05:51:47 PM
That's because PCfear and hate keep increasing while in the dungeon.  It's actually better not to use the dungeon unless the girl has really, really high rebelliousness.
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on May 07, 2010, 05:57:26 PM
I just wanted to say, I think the age limit (minimum part) doesn't seem to be working, for some reason I have a 14 year old girl (aegis).
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 07, 2010, 06:20:48 PM
Quote
The bug for Cammy White trigger is looking for MeetGirl.script and a   search of scripts, Cammy White folders of my alpha game folder has no   script of that name. My 1v29 has that script in the Cammy White folder.   You may want to add the script to the trunk.
I tried moving the scripts to where it was in 1.29, and it still doesn't fire in 1.30.  It doesn't seem to be looking for it anymore.

Quote
I just wanted to say, I think the age limit (minimum part) doesn't seem   to be working, for some reason I have a 14 year old girl (aegis).
Old 'bug'.  Not really an issue IMO seeing as none of the default girls have problematic ages.  If you want to add younger characters to your own game, that should be your business.  The legal age for girls in many other countries is lower than in the US.
Title: Re: Bugs: 1.30 Alpha
Post by: xorgroth on May 07, 2010, 08:32:53 PM
Wrong thread...whoops
Title: Re: Bugs: 1.30 Alpha
Post by: James on May 07, 2010, 10:03:18 PM
not sure if its a bug or not, but the matron can take herself off work, and will not put herself back on. (i find it weird she gets tired at all, or is ment to have two seperate matron one for day and one for night?)
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on May 07, 2010, 10:19:03 PM
I don't think it was, since on my game she was automaticly put on matron for both shifts (I believe, I might be wrong).
Title: Re: Bugs: 1.30 Alpha
Post by: James on May 07, 2010, 10:28:09 PM
thats my point, my problem is not that she is working two shifts, but she cant rest, at least make it so her tiredness dosent go up.
 
also sorry if its been mentioned, but you can hire gambling and bar staff, with out actually having the upgrades since there is no strip bar, or gambling hall upgrade icons, and have the girls work there. (might be overlooked not sure)
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 07, 2010, 10:45:01 PM
Characters with low enough constitution will get tired even doing easy jobs.  Put someone tougher on if you want them to do both shifts without resting, or depending on what item pack you're using you can buy something to raise CON.

Edit: Did the change to Dependent not go through?  I had a girl with 42 rebeliousness and used an item that adds Dependent.  She went to -100 rebeliousness.
Title: Re: Bugs: 1.30 Alpha
Post by: ShadowMage on May 08, 2010, 07:21:05 AM
That's because PCfear and hate keep increasing while in the dungeon.  It's actually better not to use the dungeon unless the girl has really, really high rebelliousness.

I had the same result with girls with really, really high rebelliousness.

Another bug when it comes to the income. It keeps showing that I lost money when I actually made quite a lot.
Title: Re: Bugs: 1.30 Alpha
Post by: sablecaballero on May 08, 2010, 08:17:10 AM
Dont' know if this was intended or not, but I no longer find unique girls in the slave market. Has this been changed from old version?

ps. I'm using Tf's big ass combo pack
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 08, 2010, 09:28:10 AM
Edit: Did the change to Dependent not go through?  I had a girl with 42 rebeliousness and used an item that adds Dependent.  She went to -100 rebeliousness.
The change went through, but there may be other problems related to it. What item did you use, so I can better try to duplicate the problem?

Another   bug when it comes to the income. It keeps showing that I lost money   when I actually made quite a lot.
  I haven't looked into how the game tracks monetary gains and losses, but yeah... I might try looking into this one, but it's lower priority for now.

Dont' know if this was intended or not, but I no longer find unique girls in the slave market. Has this been changed from old version?

ps. I'm using Tf's big ass combo pack
None of the default unique girls are set where they could start in the slave market, so I don't know. If you brand a unique girl as a slave and sell her, she'll show up in the market. Haven't checked in a few versions, though.


While investigating the Cammy meeting script not working, I've found that scripts in general were completely borked. It wasn't even properly storing the script file name for each script when reading them from XML, so none of them would ever work. I have the town meeting script working again after fixing that, but the "you lose" from low money script (-5000 money) is further messed up and I need to check the others.
EDIT: I now have the losing due to low money script fixed. Checking into the others.
Title: Re: Bugs: 1.30 Alpha
Post by: Zeus on May 08, 2010, 10:04:20 AM
mh i don't know if someone tell the bugs befor: 1. Bug: if i click in the Turn Summery on "Dungeon" games crashes.
2. Bug: When i Hire a Bar Staff the Fire Button fade out, (only if i hover with the mouse he is visible...)


3. Same at the ... ouff... it whas one of the Button on the Dungeon page... but i forget which one and i can't find it anymore... (another save ... when i found it i didn't save... and a few turns later my game says goodbye again...)


and another thing... after starting a new game click a little around and go to turn summery (without making a turn) an let the game chrashing for clicking on Dungeon in Turn Summery, after loading the auto first save of "Sleipnir" (yes, thors Hammer) every girl on the market got every thing on 30% (just anal sex was various...)


um... i hope you understand what i try to say... i think my english getting every day more worst.... sorry guys^^'
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 08, 2010, 11:17:10 AM
... after loading the auto first save of "Sleipnir" (yes, thors Hammer)

*** Engaging Pedant Mode ***

Actually, Sleipnir was Odin's eight legged horse. Thor's hammer was named Mjöllnir.

*** Pedant Mode Disengage ***

... although "Sleipnir" apparently means "slippy" in Old Norse, so it's quite apt as a name for a brothel ;)
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on May 08, 2010, 12:51:52 PM
Unique girls as slaves work fine for me.

For me the game crashes when I quit, or rather after the game window closes the debug window doesn't close and crashes after a few seconds. It happened sometimes with 1.29 too.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 08, 2010, 01:34:22 PM
mh i don't know if someone tell the bugs befor: 1. Bug: if i click in the Turn Summery on "Dungeon" games crashes.
2. Bug: When i Hire a Bar Staff the Fire Button fade out, (only if i hover with the mouse he is visible...)
  Hmm. Couldn't duplicate in the Debug build, but tested with Release build 342 and got a similar issue where the Hire button's hover image was blank for the bar. The casino one and both Fire buttons were fine.
Found this in the log:
ERROR - Colored surface null: '.\Resources\Buttons\HireOn.png'
Bizarre. I'll try to look into it.

3. Same at the ... ouff... it whas one of the Button on the Dungeon page... but i forget which one and i can't find it anymore... (another save ... when i found it i didn't save... and a few turns later my game says goodbye again...)
  Strange, that should be fixed now that it checks whether there are girls in your dungeon before trying to list them there. However, after you posted that I had the same thing happen exactly once. I'd had a girl in the dungeon that turn and moved her out, and my best guess is that the reported number of dungeon girls was wrong for some reason.
I don't see any reason after glancing over the code, so I'm leaving this one be for now.

and another thing... after starting a new game click a little around and go to turn summery (without making a turn) an let the game chrashing for clicking on Dungeon in Turn Summery, after loading the auto first save of "Sleipnir" (yes, thors Hammer) every girl on the market got every thing on 30% (just anal sex was various...)
I noticed this one myself, it's on my list of things to check into.

For me the game crashes when I quit, or rather after the game window closes the debug window doesn't close and crashes after a few seconds. It happened sometimes with 1.29 too.
Does it consistently crash every time, or just occasionally?


EDIT: for the button image missing issue, I think I have it handled by commenting out a bit of sanity checking for Necno's added animated surface functionality, which somehow was interfering with the regular image code even though it doesn't appear it should have been able to.  :-[
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 08, 2010, 03:44:04 PM
Quote
The change went through, but there may be other problems related to it.   What item did you use, so I can better try to duplicate the problem?
It's just an item that adds Dependent, with some other minor stat changes.  As soon as that trait is added, rebelliousness stays at -100 forever.  Even setting house take to 100% at that point won't increase it.  Also, any girl with the Dependent trait from the start will be -100 rebeliousness regardless of starting Obedience and Spirit values.

And while it's probably already been fixed for the next patch, the 'traits not being applied' bug occurs with daughters as well.

Quote
I had the same result with girls with really, really high   rebelliousness.
Ah, I meant that using the dungeon to train girls in general doesn't seem to be useful unless the girl has such high rebelliousness she's pretty much useless.  It's something worth discussing in another thread, as at the moment I don't see the point of the dungeon (beyond those who enjoy it for the BDSM play) and just buy items to deal with girls who will never work.  It's not like there's a shortage of girls to use at this point, so why bother sending months training the angry ones?
Title: Re: Bugs: 1.30 Alpha
Post by: tlib on May 08, 2010, 04:36:48 PM
Quote
    The change went through, but there may be other problems related to it.   What item did you use, so I can better try to duplicate the problem?
Quote
It's just an item that adds Dependent, with some other minor stat changes.  As soon as that trait is added, rebelliousness stays at -100 forever.  Even setting house take to 100% at that point won't increase it.  Also, any girl with the Dependent trait from the start will be -100 rebeliousness regardless of starting Obedience and Spirit values.

Reason Rebelliousness is always -100 is because in cGirls.cpp GetRebelValue function is the code
Code: [Select]
if(HasTrait(girl, "Dependant") || HasTrait(girl, "Mind Fucked") || HasTrait(girl, "Broken Will"))
return -100;

This may need to be changed


Tlib
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 08, 2010, 08:49:24 PM
Reason Rebelliousness is always -100 is because in cGirls.cpp GetRebelValue function is the code
Code: [Select]
   if(HasTrait(girl, "Dependant") || HasTrait(girl, "Mind Fucked") || HasTrait(girl, "Broken Will"))
      return -100;

This may need to be changed

Tlib
Ah, thanks, that explains it. So... do we really want guaranteed -100 rebelliousness for all three? Perhaps we should guarantee something like at least -50 for "Dependant" and at least -75 for "Mind Fucked" (both able to go lower, of course)? Or maybe just guarantee -50 for both?

EDIT: actually, after a little thought, I'd say -40 for Dependant and -50 for Mind Fucked.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 08, 2010, 09:11:50 PM
If it was up to me, I'd put Dependant at -25 (she doesn't feel safe if she doesn't have someone to make decisions for her but otherwise she's generally sensible), Broken Will at -50 (she's been broken and not likely to refuse anything, but she's not outright insane either), and Mind Fucked at -75 (at least some of her higher thought functions are deficient and her sense of self-preservation is basically nil).

The exact details are just the way I see things, but I think there's some value in having at least marginal difference between the three.

edit: Ooops, I didn't see the edit up there. Well, it does seem reasonable to me.
Title: Re: Bugs: 1.30 Alpha
Post by: FurryFanatic on May 08, 2010, 09:46:31 PM
Just a quick question, because I keep seeing a common error appearing in the command line, but has anyone else been getting the "Error: line 0, col 0: Failed to open file...can't load .\Resources\Characters\(character's name here)\triggers.txt"? I always seem to get my game to crash because apparently I need triggers for certain girls or my game blows up and I have to hope I can get to the next week w/o it blowing up again.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 08, 2010, 09:58:37 PM
Just a quick question, because I keep seeing a common error appearing in the command line, but has anyone else been getting the "Error: line 0, col 0: Failed to open file...can't load .\Resources\Characters\(character's name here)\triggers.txt"? I always seem to get my game to crash because apparently I need triggers for certain girls or my game blows up and I have to hope I can get to the next week w/o it blowing up again.
That's normal. It checks every girl's folder to see if she has special triggers; only Cammy does at the moment. It would be better if it just quietly ignored the trigger file not being there, I suppose.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 08, 2010, 10:11:52 PM
More changes committed to SVN.
Fixed:
* Script functionality was completely borked in several ways; all scripts are now working
* When sabotaging, if rival had no gangs it could cause a crash
* work report for brothel girls kept saying she "ran out of customers who like her"; disabled that erroneous message for now
* GetRandomShopItem could return out-of-bounds (+1 over) item num, leading to crash
* Girls were losing "Incest" and "Your Daughter" trait after a while, as they were incorrectly set as temporary
--  this fix courtesy of tlib, thanks!
* There were a few further trait handling problems, and "unknown" age girls could have their age messed up
--  these fixes courtesy of WonderDog, thanks!
* Random girl name generation could go out of bounds
* customer display in dungeon was slightly off
* a specific semi-random image on the release build would fail to load for a bizarre reason; fixed by commenting out a hopefully unnecessary extra bit of animated image sanity checking

Modified:
* job enjoyment text (shown in Girl Details by More button): fixed and added in support for showing enjoyment level for all current major task types, but "indifferent" ones are omitted
* when a girl captures beasts, it now indicates how many
* number of owned beasts is now shown on brothel screen
* rearranged job and job type lists on girl management screen a tad bit
* Girls with "Dependant" trait or "Mind Fucked" trait no longer have guaranteed -100 rebelliousness, it's now guaranteed -40 and -50 respectively
--  thanks to tlib for finding the root of this one

Since I just uploaded the r349 update, I'll repeat the earlier changes which show up in it:
Fixed:
* You could not generally transfer items directly from the store to a girl.
--    the item transferring code was a bit wonky and was separate for transferring either way; I consolidated and cleane up the code, fixing it in the process

New:
* Item lists on Item Management screen are now sorted alphabetically
* When viewing player or girl inventory item, it shows "Value: x  Sell For: y" instead of "Cost: x"
* Items listed on the item management screen now have differing font colors according to rarity. Items purchaseable in the shops are blue, the brighter the rarer. Green items are only found on the catacombs (dark green) or by scripts or objective rewards (a bit lighter green). "Common" items should be plain black, but there seems to be very little in that category currently. The rarity colors are configurable in config.xml.
Fixed:
* If you had negative money you could hit "deposit all" in the bank, which would reset you to 0 money
* Girls could be inseminated when using fake beasts
* Random girl traits were not properly applying skill changes... ex. pigtail girl started with lesbian trait, 0% lesbian skill
--  This fix was courtesy of WonderDog - thanks!
* Big Boobs and Abnormally Large Boobs weren't properly improving customer happiness
--  This fix also courtesy of WonderDog


The r349 update with the above changes is available here (http://pinkpetal.org/index.php?topic=351.msg6512#msg6512).
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 08, 2010, 10:43:09 PM
Very nice.  Tried out the Cammy script and it's working again.  Item colours and sorting are awesome.  And apparently I need to adjust my custom random girls now that traits are working right, as there's a lot of supermodels in the market now  :D .

But seriously, thanks for everyone's work as I'm sure you had more fun things to do than bugfix code on the weekend.

So apparently Depedent fixes rebeliousness at -40 regardless of other stats.  I can work with that, though removing the fixing completely and just having it give the +50 obedience makes sense too.  There's nothing wrong with doing it this way, I just don't like something completely overriding two stats unless it's more serious, like Mind Fucked and Broken Will (Unless I'm mistaken, obedience and spirit no longer matter for anything once one of these three traits are applied.  If they still influence other actions, then it's all good.)
Title: Re: Bugs: 1.30 Alpha
Post by: RyRain on May 09, 2010, 09:12:31 AM
I've run into something kind of odd. Whenever I start a new game and name my character, the dos prompt gives a message that it failed to load a bunch of the girl's script files. I'd think it's because none of the ones it tried to load HAVE any script files since I have allot of extras from the add-on packs, but should it be TRYING to load them?

Sample from the prompt:

Error: line 0, col 0: Failed to open file
can't load .\Resources\Characters\Masaki Ayeka Jurai\triggers.xml
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 09, 2010, 11:50:46 AM
Pretty sure it has to check each character file to see if the triggers.xml is there for any of them to work.  You can actually make a unique Meetgirl.script for every character using the script editor, it's just that there's so many characters at this point it would take many tedious hours for most people to do so.  I've played around and made a few using this version and they worked fine.
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on May 09, 2010, 12:29:46 PM
 
Quote   from: Nalkyr Maloth on May 08, 2010, 11:51:52 AM (http://pinkpetal.org/index.php?topic=352.msg6497#msg6497)<blockquote>For me the game crashes when I quit, or   rather after the game window closes the debug window doesn't close and   crashes after a few seconds. It happened sometimes with 1.29 too.
</blockquote>Does it   consistently crash every time, or just occasionally?



It crashes every time, but I haven't tried version 349 yet
Title: Re: Bugs: 1.30 Alpha
Post by: FurryFanatic on May 09, 2010, 02:21:08 PM
I've created an item in WM that tests the mind-fucked trait, but when I use it the girls suddenly become sterile.  I'll check my items file, but I didn't see anything in the item's effects line that should have caused this.
Title: Re: Bugs: 1.30 Alpha
Post by: jacq2e on May 09, 2010, 06:58:50 PM
I just dowloaded and played 1.3 349.


I found that when a girl trained in the morning and was working in the street during the night, she KEEP training during her night shift. But takes client if she work in the brothel. However, this bug seems to happen only for the first girl in the list and if you have 1 or 2 girls. With more girls, the bug seems to appear at random. The summary screen also seems to give the description of the day shift twice when the bug occurs.


-- After check-up : The first bug don't always happen, but the girl trains twice during the day shift.


When a girl is training alone, the summary is blank and don't say anything.


You can have a girl working in the gambling hall or bar even if you don't have one [probably just not implemented yet]


When you manage your brothel and prohibit certains job (beastiality), the girls keeps doing it.
That bug was already reported, just wanted to be sure that it was not forgotten.


From time to time, the game crash when getting a girl after taking a walk. (First action in the game, first girl. Haven't noted which one triggered the bug)


When restarting a new game, the picture of tha last selected girl appear in the girl management window.




Gambling Hall : What is the difference between a Whore working there and a whore in the brothel? What is the diffecence between the whore and the XXX Entertainer?


Bar : What is the difference with a girl whoring there, in the gambling hall or in the brothel? (Mainly, what advantages does it offer for the bar or the gambling hall.)


When whoring somewhere, the girls description shows what she does, not where. (Same in the summary)

Title: Re: Bugs: 1.30 Alpha
Post by: James on May 09, 2010, 08:36:31 PM
not sure how exacly i made the bug, but i started a new game since i downlaoded a few packs, and when i made a new game, it carried over the number of beasts.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 09, 2010, 09:04:43 PM
Not really a bug, but more of an unwanted feautre; When you sell/fire a girl they can be acquired again on walks, even random ones. Generally speaking, if the player gets rid of girl like this they probably don't ever want them back. The only way to truely get rid of them is the kill them in the dungeon.  It would be nice if selling/firing deleted the girl, as once the player has businesses you get a stready steam of free random girls from deadbeat customers that you likely won't want after a certain point.  Searching the catacombs also gives you a lot of generally unwanted random monsters girls that I'd like removed from the game after selling.

-On a similar topic, now that scripts are working again the 'deadbeat customer' script seems to trigger a bit too often.  It's not at all unusual to see it every other week.
-If a girl dies in the dungeon, it 'kills' her twice.  Once on the day she dies, and again next week when she is removed.
-Odd bug in my game; all random girls are generating with all 30's in every stat (adjusted for trait bonuses).  Starting a new game is normal; not sure what went wrong. EDIT: Even stranger: if I load my game, quit to the main menu, then load it again things are back to normal. I can provide my save if you want to have a look at it, but I suspect something just went FUBAR with the save file.
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on May 09, 2010, 10:01:57 PM
I've thought of that before (someone else might have suggested this), but one option for getting rid of unwanted girls would be to sell them to foreign traders/merchants to take with them.
Title: Re: Bugs: 1.30 Alpha
Post by: morbriner on May 09, 2010, 10:48:27 PM
May not be a bug but the girl working as matron still gives a percent of her 300 gold fee to you the house even though the house is paying her.
Title: Re: Bugs: 1.30 Alpha
Post by: WonderDog on May 09, 2010, 11:02:23 PM
I can get the game to crash every time if I send winclose signal (Alt-F4) click the X or use a script to sent the signal.  I get no exception if I close through the in game quit button.

The change in the jobs manager for whore work has stuffed up the working girls.  The old code generated all the customers in a linked list and each girl removed their  customers from list and rejected customers would be available to the next girl. I think that there was a small chance for a serviced customer to stay on the list and have another go.

The new code just seems to run off the number of customers and generate customers on the fly for the girls and counts the number of serviced customers and the number rejected customers.  The rejected customers are NOT available for any other girl.

That was also why there was so many rejected messages in the previous alpha build it was showing all the customers being added  to the customer count.

Great whores (lots of fetishes, 100% looks) will only reject 10% - 30% while poor girls will reject 90%

This means if there are a few low stat girl to working before a stunner she will probably get only 1 or 2 customers

To make a reasonable game I use the transfer screen to put my best girls who are my working girls at the top of the list as they will only reject 4 or 5 great girls and a few in training (earning exp.) will service all the customers world famous 20 girl brothel.

Is the street work worth it as I don't seem to get any more customers but its hard to tell with the randomness of customer generation.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 10, 2010, 02:19:53 AM
I've created an item in WM that tests the mind-fucked trait, but when I use it the girls suddenly become sterile.  I'll check my items file, but I didn't see anything in the item's effects line that should have caused this.
It seems there are some remaining trait issues. WonderDog has sent me another patch which may take care of this. I haven't checked it yet.

I found that when a girl trained in the morning and was working in the street during the night, she KEEP training during her night shift. But takes client if she work in the brothel. However, this bug seems to happen only for the first girl in the list and if you have 1 or 2 girls. With more girls, the bug seems to appear at random. The summary screen also seems to give the description of the day shift twice when the bug occurs.
-- After check-up : The first bug don't always happen, but the girl trains twice during the day shift.

When a girl is training alone, the summary is blank and don't say anything.
  I'll try to check into this one.

  You can have a girl working in the gambling hall or bar even if you don't have one [probably just not implemented yet]

  Gambling Hall : What is the difference between a Whore working there and   a whore in the brothel? What is the diffecence between the whore and   the XXX Entertainer?
 
  Bar : What is the difference with a girl whoring there, in the gambling   hall or in the brothel? (Mainly, what advantages does it offer for the   bar or the gambling hall.)
 
When you manage your brothel and prohibit certains job (beastiality),   the girls keeps doing it.
  That bug was already reported, just wanted to be sure that it was not   forgotten.
 
  It is assumed currently that you just have the bar and gambling hall. It's planned to require you to buy certain rooms for those and other tasks once the building management aspect is fully implemented, but that's not in yet. Whoring is pretty much the same under any category, it's just listed for various categories (which will be restricted once room management is in).
The current actual difference in different whoring tasks is that any such task other than "whore in brothel" does not properly follow the sex type restrictions you have set. I think it's intention for whoring on the street, but not the others; I plan to take care of the others at some point.
 
  From time to time, the game crash when getting a girl after taking a walk. (First action in the game, first girl. Haven't noted which one triggered the bug)
  If you have this happen again, please note exactly where it crashes and any other such details, and check the gamelog.txt.

  When restarting a new game, the picture of tha last selected girl appear in the girl management window.
  I'll update it to have it clear that out each time.

    When whoring somewhere, the girls description shows what she does, not where. (Same in the summary)
What do you mean, "where"? Like "on the street" vs. "in the brothel" or something?


-On a similar topic, now that scripts are working again the 'deadbeat customer' script seems to trigger a bit too often.  It's not at all unusual to see it every other week.
  How many girls do you have whoring? I haven't checked on this one, but I think it fully depends on that. With just a few girls whoring, I agree it shouldn't show up as often as once every other week.

  -If a girl dies in the dungeon, it 'kills' her twice.  Once on the day she dies, and again next week when she is removed.
  I'll try to check on this one.

  -Odd bug in my game; all random girls are generating with all 30's in every stat (adjusted for trait bonuses).  Starting a new game is normal; not sure what went wrong. EDIT: Even stranger: if I load my game, quit to the main menu, then load it again things are back to normal. I can provide my save if you want to have a look at it, but I suspect something just went FUBAR with the save file.
Already reported a couple of times, and I have it fixed as of yesterday. Haven't committed the code yet.

May not be a bug but the girl working as matron still gives a percent of her 300 gold fee to you the house even though the house is paying her.
Yeah, the way the matron and other jobs are paid and have you take your percentage does seem odd. I hadn't marked it down to look into though, so I'll add that to the list.

WonderDog: yeah, from the sound of it, the customer tracking could do with another overhaul. I've never even looked at it except in passing.
Last I saw, street work is indeed not worth it. I think it might even draw from the same customers for the time being.
Title: Re: Bugs: 1.30 Alpha
Post by: xorgroth on May 10, 2010, 04:37:29 AM
Not sure if this just an error in my girls.girlsx file or not. Runs for a bit then crashes after hitting next week. Though oddly I can load the autosave game and continue until I hit next week. This is also with the r349 of the alpha...

Title: Re: Bugs: 1.30 Alpha
Post by: xorgroth on May 10, 2010, 04:51:01 AM
And 10 minutes later I find out that it was...plus wrong save game attached as well. Should probably go to bed, wasn't correctly reading my randomgirls.rgirlsx file. Since I merged the Randomgirls and Randomgirlsaddon together. Was unable to read the end tag </Girls> for some reason. No other close tags for girls either, strange but fixed.
Title: Re: Bugs: 1.30 Alpha
Post by: RyRain on May 10, 2010, 05:24:33 AM
Not sure if this has been reported or not but there's a glitch with the beast capture job. I set a girl to beast capture, and she caught two. Then I set her to beast cartaker (she's my only girl atm) and the turn summery says she enjoyed playing with the bests but every subsequent day I have 2 more.
Title: WorkWhoring
Post by: WonderDog on May 10, 2010, 06:34:08 AM
Ok I Looked at the code for Whoring job and fixed a few things and made a few assumptions plugin in the numbers.

If deadbeat customers are still too high we need change the divisors.

If Whoring on the streets  still too much we either need to drop income more or number of customers

Code: [Select]
    /*
     *    WD:    Modified to fix customer service problems.. I hope :)
     *
     *    Change logic as original code is based on linked list of customers
     *    not random generation for each call to GetCustomer()
     *
     *    Pricing issues seem to be resolved with getting lots of money
     *    from customer that cant pay
     *
     *    The numbers I have added need to be tested
     *
     *    Limit number customers a girl can fuck to 10 max
     *
     *    Limit the number of customers a girl can see if they will
     *    fuck her from 5 to Max Customers * 2
     *
     *    Redid the code for deadbeat customers
     *
     *    % Chance of customers without any money getting service is
     *  100 - (CUST_INT * 3), ZERO chance if int > 33
     *
     *    % Chance of customer refusing to pay despite haying funds is
     *    (100 - CUST_HAPPINESS]) / 10
     *
     *    Only decrement filithniess when service is performed in brothel
     *
     *    Street Work will not decrement number customers
     *  Street work will only service 66% number of customers
     *    Street Work will only generate 66% of brothel income   
     *    Street Work Really needs its own NumCustomers() counter
     *
     *    Rival gangs can damage girls doing Street Work
     *  % Chance of destroying rival gang is depended on best of
     *    max(SKILL_COMBAT, SKILL_MAGIC) / 3
     *
     *    Changed message for rival gangs attacking street girls to give
     *    EVENT_WARNING
     *
     *  Fixed end of shift messages
     *   
     */
Title: Re: WorkWhoring
Post by: DocClox on May 10, 2010, 06:51:41 AM
If deadbeat customers are still too high we need change the divisors.

If Whoring on the streets  still too much we either need to drop income more or number of customers

Possibly worth adding the factors to the config file? If nothing else, it's easier to fiddle with them then.
Title: Re: WorkWhoring
Post by: WonderDog on May 10, 2010, 09:32:08 AM
Possibly worth adding the factors to the config file? If nothing else, it's easier to fiddle with them then.

Ok good Idea,  Who is looking after the config file?



Ok slight error in previous patch  ;D .  Said a Max of 10 customers I actually programmed = 10

New patch WorkWhore for build 352
Title: Re: WorkWhoring
Post by: DocClox on May 10, 2010, 09:34:09 AM
Ok good Idea,  Who is looking after the config file?

I can do it. It's mainly a case of cut and paste anyway.

What divisors did you have in mind?
Title: Re: Bugs: 1.30 Alpha
Post by: Adamwest69 on May 10, 2010, 09:49:43 AM
I think the pregnancy issue may have to do with items causing/forcing a girl to become pregnant. I tested it again in a new game (with the most recent updates) and after 40 weeks, the girls that I impregnated using an item still haven't given birth.
 
I confirmed this... I tested it by getting a girl pregnant normally and it works, using a device that changes the statistic, causes the countdown to freeze.

AW69
Title: Re: WorkWhoring
Post by: WonderDog on May 10, 2010, 10:02:51 AM
I can do it. It's mainly a case of cut and paste anyway.

What divisors did you have in mind?

I will send you the details in the next few days. 

Off the top of my head..

MaxCustomers              =  10
WorkStreetIncome       =  0.66
WorkStreetCustomer   = 0.66
NopayINTdivisor           =  30
NopayHAPPYdivisor      =  30
RivalGangChance         = 5

Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 10, 2010, 11:37:30 AM
I think the pregnancy issue may have to do with items causing/forcing a girl to become pregnant. I tested it again in a new game (with the most recent updates) and after 40 weeks, the girls that I impregnated using an item still haven't given birth.
 
I confirmed this... I tested it by getting a girl pregnant normally and it works, using a device that changes the statistic, causes the countdown to freeze.

AW69
I'll mark it down. Do you have an example item definition I could use to test it?


Anyway, stuff I've done since the last progress report:
* Random girls would quite often default to 30 in all skills; value name lookup table was not being initialized correctly
* changed debug output from failure to load trigger file to better indicate it's not a problem ("Assuming this is a girl with no special triggers")
* the picture of the last selected girl in the girl management window would sometimes be shown when no girl was selected (or existed for that matter)
* Shift-selecting items in listboxes which support multiselect was hit-and-miss; rewrote that code so that it should respond exactly as expected


EDIT: by the way, if you're curious about how to add in new config variables yourself, you could use this commit as an example.
Additions to config.xml (http://pinkpetal.org:9053/whm_trac/changeset/345#file1)
Changes to sConfig.cpp (http://pinkpetal.org:9053/whm_trac/changeset/345#file10)
Changes to sConfig.h (http://pinkpetal.org:9053/whm_trac/changeset/345#file11)
  And an example of referencing the config data, in case you need it, is near the top of the changes here (http://pinkpetal.org:9053/whm_trac/changeset/345#file8).
Title: Re: Bugs: 1.30 Alpha
Post by: FurryFanatic on May 10, 2010, 04:03:39 PM
Anyone else notice that when your advertising level gets to a certain level it resets back to zero?
Title: Re: Bugs: 1.30 Alpha
Post by: jacq2e on May 10, 2010, 04:59:20 PM
When whoring somewhere, the girls description shows what she does, not where. (Same in the summary)



What do you mean, "where"? Like "on the street" vs. "in the brothel" or something?



I mean there is no difference in the management screen and the summary's screen when a girl is whoring inside the bar or the gambling hall.
This might be an useless info right now, but it can pinpoint where the girl is working (or give bonus) more easily.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 10, 2010, 05:28:21 PM
I've had a fairly repeatable crash occur in Manage Inventory.  If you transfer from the shop directly to a girl, there's about a 25% chance on any transfer that it crashes for me.  This does not seem to occur when going from the shop to player, or player to girl.

Quote
  How many girls do you have whoring? I haven't checked on this one, but   I think it fully depends on that. With just a few girls whoring, I   agree it shouldn't show up as often as once every other week.
Even with only about 8 girls whoring, it was popping up once every three weeks or so.  With 40 girls, it's near constant.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 10, 2010, 06:28:34 PM
I've had a fairly repeatable crash occur in Manage Inventory.  If you transfer from the shop directly to a girl, there's about a 25% chance on any transfer that it crashes for me.  This does not seem to occur when going from the shop to player, or player to girl.

I just noticed something similar while testing my pack. Items with a non-zero "How bad is it" stat crash the game 100% of the time when going directly from the store inventory to a girl's inventory. Buying to the player's inventory then transferring to a girl is still fine.

Also, there's an old issue pointed out in my pack's thread some time ago that I'm not sure has been noted lately: the make-up items I made, which are simple temporary beauty boosts, screw up the girl's pictures something fierce. Sometimes the "profile" category is literally obliterated from the gallery and the picture reverts to the default "girl with yellow jacket and panties", sometimes no picture shows up anymore and the game tends to crash, maybe not right away but when it does stuff related to that girl, like displaying the weekly report. This seems to happen both with my old 3.0 item pack and with the new default items which includes them. The perfumes work fine, even though they are almost identical items (they apply to charisma instead of beauty), and the permanent beauty increasers work without problems, so my uninformed guess is that something is wrong with temporary beauty increases specifically.
Title: Re: Bugs: 1.30 Alpha
Post by: Wispowill on May 11, 2010, 04:44:43 PM
Finally back home and played r349 on Vista x64.

As the cost for everything has gone up considerably I couldn't make any money without some rather extreme micro-management. There also seems to be something the game isn't reporting properly that is causing major cash hemorhaging if playing for extended periods of time. For the very first game it took nearly 8 hrs to reach a point I could buy the first house at which point the game was subtracting around 450 gold a turn AFTER reporting what my overall profit was. After buying the second house this figure went up to around 3000-3500 gold a turn after the report and after several more weeks it reached a point that made it impossible to go any further. This was 3000 cash on hand +1800 overall profit =automatic game over (below -5000).  This is a 10K difference between what was reported and what the game was thinking.  My first thought was that something is either not clearing a variable somewhere or subtracting something it should be adding, but after reading through the other bug reports perhaps it has something to do with advertising since I was doing a lot of that.

My second game I started the micro-management from the very beginning, but once again after obtaining the first house I was hemorhaging around -4500 gold a day after reports. (This was about two years or so of game time.) I was also having days where I was losing -1500 to -2500 even on the reports themselves despite that fact that the girls seem to be in full production when double-checking through all of the events on the screen. At one point during this I saw that one girl, not very experienced, had "made" 3K with only six customers. After several weeks she only had 2K herself. The game was reporting the average paying customer for her was 69 gold or something like that. Also noted that this average paying customer field seems capped at 100, although some of my more productive girls seemed to be actually making 120 or 150 per customer.

The read me file (yes, a few of us actually do look at those) says that ALL girls are 18+. Despite this disclaimer there are quite a few 14-17 year olds running around. There really isn't any point in having the disclaimer at all if the game clearly marks the girls otherwise.

I was fairly certain from the 1.29 line that sons matured faster than daughters, and this seems to be true for the 1.30 line as well. I was able to play long enough for several sons to be sold, but not long enough for any of the daughters to appear. Come to think of it, I could probably double-check this by changing the config file to something smaller, but not inclined to play much more until the cash hemorhaging problem is fixed. Even if it's something legitimate, like advertising expense, it should be added in BEFORE the overall profit screen is displayed. I really don't like being told I made 2.8K today just to find that I'm really 3.6K in debt.

It's possible for more than 1 matron to be in a house by forcing a matron to rest and reassigning another girl to be matron. When the first girl is through resting she auto-magically becomes matron again resulting in two matrons. Also, matrons occasionally have problems over and over and over again "comforting" a tired girl when she needs instead to be taken off-line to rest.

Had extreme problems with the "filth" on my first game. In a house of 20 girls, 6 of them were cleaing both morning and evening and I was still accumulating 100 pts a day. It was 1500 when I obtained my second house and moved all the girls to the second house. I left three girls there in the first house to clean full time and it took 4 turns to clean up.

My second game I was able to control the filth with just three girls cleaing just one shift a day, so I don't know what was going on the first time.

I had the game crash once, when moving a girl with 0 happiness from the dungeon, but the auto-save game loaded in like a charm.

Had 1 girl take out a full 15-man squad of 100-100-100 trained goons while trying to escape branding. Given the length of time it takes to train squads this did not please me much.

When applying magic makeup to a girl her pictures automatically changed to the defaults for all classes except anal and pregnency. This continued until I got rid of the girl. The pictures had been correct until applying the magic makeup item.

I also like the old picture handler a bit better than the current one. The aspect ratios for some of the pictures look rather wierd right now, although this is just as much the fault of the pictures as well.  I did see that support for animated pictures is being added to the game which I look forward to being implemented.

Concerning girls coming back after firing, I'm of a mixed mind for this. Sometimes I sell the girl because I just can't afford everyone at the moment. But more often, I don't wan't a girl that's come in and don't want her back. Since the starvation routines only drop 5 health now, instead of 10 like an earlier version I saw, it takes a long time to starve a girl to death. And for Incorporeal enabled girls, you can't starve them either. I don't like monster girls, but like the rare items one sometimes finds in the catacombs, which can easily result in a couple of hundred monster girls flooding the slave market if I don't starve them off.

There might have been some other things but I wasn't taking notes this time like some other times.
Title: Re: Bugs: 1.30 Alpha
Post by: Zeus on May 11, 2010, 05:33:47 PM
i don't realy know if this is the Problem: When i say a Girl to do a Job for the Movies (i told in first One girl to do the Fluffer job) The Games Crashed when i click on the next week button (same after i told 2 girls to be fluffing), i don't tried with any other Movie job...


woaaa... Late Night here and my english is getting Worst >-<... i think next time i try the f*** google translator... (i hate those things... i know how things sound when you translate english to german... i think its not better when translating german to english...)
so ... Good Night Folks
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 11, 2010, 05:57:48 PM
Odd, I've played about three test games past two years since 1.30 I have never seen any of the crazy difficulty you encountered.  While starting out is a little slower now, the game still quickly gets to the point where money is irrelevent.  Cleaning is a non-issue as well.  2 cleaners (or one high CON girl going two shifts) is sufficient to maintain a 0 filth level with eight girls whoring (more than that seems pointless as there aren't enough customers, even with level 10 advertising).  It SAYS 250-300 customers came, but there are girls only getting 3 clients at that point, so I assume assigning more would serve no further benefit and it's time to open another brothel.  How many gangs to you buy at the start?  I just buy the two boosted gangs, leave one on guard and one on training.  I never add more until I'm consistantly making over 1000 gold a turn.  Which usually doesn't take more 20 turns or so.  The only time I run into trouble is if my first few girls are extremely rebellious.

I fully agree training gangs is too slow.  Even the starting gangs with 50's in all stats take nearly a year to max out.  That's 52+ game turns of that gang doing nothing but suck up money.  They should, at a minimum, be going up +2 per stat per week.  That would still require at least 30-35 turns to train your average starting gang, but that's about twice as fast as it seems to take now.  I'm sure not about the girl wiping the gang.  On one hand there needs to be some way to lose maxed gangs late game or there's no way to lose (sabotage never seems to result in casulties).  Many girls in the game are anime/video game protagonists who can and should be wiping the floor with mooks.  On the other hand, as you say the time investment to get a fully trained gang back is excessive right now.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 11, 2010, 06:39:35 PM
More changes done.

Fixed:
* Starting a new game was not clearing out number of beasts owned from a previously loaded game
* Items with a non-zero "How bad is it" stat crash the game 100% of the time when going directly from the store inventory to a girl's inventory. Buying to the player's inventory then transferring to a girl is still fine.
* using make-up items or any other items which provided a temporary stat boost (not skill boost) was bugged
* items which were set to impregnate or inseminate did not work correctly; now, it uses the "Amount" value as a multiplier for the chances.
    So, assuming the default config of 8% chance each for pregnancy, player pregnancy, and insemination, these item effects would have 80% chance of success (8% * 10):
    <Effect What="GirlStatus" Name="Pregnant By Player" Amount="10" />
    <Effect What="GirlStatus" Name="Pregnant" Amount="10" />
    <Effect What="GirlStatus" Name="Inseminated" Amount="10" />
    An "Amount" of 0 still removes any of the above, that hasn't been changed.

* When transferring an item on the Item Management screen, the selection is much better maintained and tracked (transferred items are selected in target inventory)
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 11, 2010, 07:02:02 PM
OK, answering some reports.

There also seems to be something the game isn't reporting properly that is causing major cash hemorhaging if playing for extended periods of time.
  Quite possibly. At some point we probably need to do a serious accounting of how all money-related actions at end-of-turn work. Hey, it's an alpha.

The read me file (yes, a few of us actually do look at those) says that ALL girls are 18+. Despite this disclaimer there are quite a few 14-17 year olds running around. There really isn't any point in having the disclaimer at all if the game clearly marks the girls otherwise.
With the default girls (no additional packs), you should be seeing them aged as low as 17. The readme should indeed be updated. As for 14 year olds, that is possible with unique girls if you're using an additional girl pack or something; the age isn't as limited for them for whatever reason.
 
I was fairly certain from the 1.29 line that sons matured faster than daughters, and this seems to be true for the 1.30 line as well. I was able to play long enough for several sons to be sold, but not long enough for any of the daughters to appear.
  I've tested pregnancy pretty extensively a few days ago (pregnancy and maturation values set to 2 weeks) and did not find this to be true. Boys and girls matured at the exact same rate.

It's possible for more than 1 matron to be in a house by forcing a matron to rest and reassigning another girl to be matron. When the first girl is through resting she auto-magically becomes matron again resulting in two matrons. Also, matrons occasionally have problems over and over and over again "comforting" a tired girl when she needs instead to be taken off-line to rest.
  Thanks, I'll note that down.

Had extreme problems with the "filth" on my first game. In a house of 20 girls, 6 of them were cleaing both morning and evening and I was still accumulating 100 pts a day. It was 1500 when I obtained my second house and moved all the girls to the second house. I left three girls there in the first house to clean full time and it took 4 turns to clean up.

My second game I was able to control the filth with just three girls cleaing just one shift a day, so I don't know what was going on the first time.
  Filth removal rates could probably be increased a bit.

I had the game crash once, when moving a girl with 0 happiness from the dungeon, but the auto-save game loaded in like a charm.
I just tested this and couldn't reproduce it.
  If you have this happen and have a save from before it happens, and it's reproducible, please pass the save on to us.

I also like the old picture handler a bit better than the current one. The aspect ratios for some of the pictures look rather wierd right now, although this is just as much the fault of the pictures as well.  I did see that support for animated pictures is being added to the game which I look forward to being implemented.
Are you sure you're using r349? The aspect ratio should be perfectly standard, as it was with 1.29, though an older 1.30 alpha did have stretched aspect ratios.

i don't realy know if this is the Problem: When i say a Girl to do a Job for the Movies (i told in first One girl to do the Fluffer job) The Games Crashed when i click on the next week button (same after i told 2 girls to be fluffing), i don't tried with any other Movie job...
Like the release thread says, Movie related jobs do not currently work. I guess I could just remove them from the job list for now.


I fully agree training gangs is too slow.  Even the starting gangs with 50's in all stats take nearly a year to max out.  That's 52+ game turns of that gang doing nothing but suck up money.  They should, at a minimum, be going up +2 per stat per week.  That would still require at least 30-35 turns to train your average starting gang, but that's about twice as fast as it seems to take now.  I'm sure not about the girl wiping the gang.  On one hand there needs to be some way to lose maxed gangs late game or there's no way to lose (sabotage never seems to result in casulties).  Many girls in the game are anime/video game protagonists who can and should be wiping the floor with mooks.  On the other hand, as you say the time investment to get a fully trained gang back is excessive right now.
It could be increased a bit. However... it is entirely optional how much training you give or how many gangs you choose train up to 100 in everything. I don't think getting 100 in every stat should be easy at all (super-gangs!), and gangs can certainly function very well with all stats around 50.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 11, 2010, 07:15:42 PM
Learning could be on a curve, so that taking a gang to 50-60 is faster than it is now (so you can invest in crappy gangs if that's all you have to work with and not feel like you're entirely throwing your money away), but it'd slow down gradually after that, so 90-100 could take a very long time. That way in the early-to-mid game you can put a less skilled gang or two on training and have some visible returns on your money, and perfect gangs are still something you'd have to work on for several months at least.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 11, 2010, 09:33:27 PM
Well, there's two issues main with gangs from a gameplay point of view.  One is that gangs cost money regardless of their success rate.  I'm not paying to have rookie gangs go steal if they're going to fail 80% of the time.  The other problem is that gangs do not improve except when training.  This leads to a situation where the only sensible strategy is to have them train until the success rate is maxed out, THEN start actually using them.  If gangs saw improvement while on other duties, the slow training wouldn't seem so bad.  It would simply be there as a 'safe' training option.

Another issue is that there's no real pressure on the player, thus you don't NEED gangs until you're ready to mass-acquire land or finish off all the rivals.  At which point you might as well have them fully trained.  One super-gang on guard duty seems to sufficient to hold off everything by themselves.  The income from thieving is small-time compared to whoring, and the risks greater (increased chances of getting raided), and so no worth bothering with.  It's even worse now that girl can run the catacombs, further reducing the usefulness of gangs.  Every game I just wait until I have enough income from the brothel to hire the full number of gangs, train them to 100%, and then send all but one to acquire/sabotage.  Raids from other gangs should be more frequent, to the point where you have to choose between having large number of guards or start pulling off more girls for security.

These are difficultly/balance related things that can wait until the bugs are dealt with, but I feel gangs should be addressed sooner than later as right now the whole gang mechanic is just kind of there when you need new brothels.  There's no real way to 'lose' at Whore Master once you get stabalized early game, and the whole gang war thing is the key to making things more interesting IMO.  If people don't like that, consider making a 'difficultly' modifier in the config file, with hard requiring the player to put much more effort into survival.

Alternatively maybe just phase them out entirely and have girls take over all their functions.  They already provide security and can explore the catacombs.  It would be a small step to have the girls lead raids and threaten businesses, with stealing just dropped entirely.  It would make +combat items actually useful, and give more uses for all those extra random girls you pick up late game from customers and monster girls.
Title: Re: Bugs: 1.30 Alpha
Post by: RyRain on May 12, 2010, 02:31:03 AM
Actually I disagree. I think the gang training is perfectly balanced, and to be perfectly honest, I think it almost get's too easy when you have them maxed out.

What I usually do:

I like breaking girls either through torture or items before I start out so I don't have to deal with the hassle of them refusing to work (Yes I'm an evil bastard and most of my girls get branded at slaves except a couple I keep in the new version for matron and torturer, but I still break them to keep from having obedience/I wanna quit issues) and usually have my gangs either searching catacombs, or stealing (or if I feel I've built up enough to survive for a bit capturing neutral territories) in the mean time with at least one with a combat rating over 50 guarding at all times. I won't get rich off of it, but it's enough to cover my expenses and keep my head above water until I can start using the girls without much hassle. When I can start getting a decent income from my brothel I set half of them to training and the other half to guarding/making money for me via the previously mentioned methods. As one set maxes I switch them. To be honest, early game is the only time I have even the slightest chance of losing. Once I reach the point in which all my gangs are at 100% across the board, I just set a couple to guarding, and the rest to taking territories and watch the money roll in, occasionally checking to make sure I don't have to set one of them to recruiting.

The game is really meant to be played over a long period. If you could trounce all of your rivals in the first year it would be too easy.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 12, 2010, 04:49:54 AM
A few more fixes done (not committed yet though):
* removed availability of movie job types for now, since they were indeed entirely broken
* Whore jobs in Bar and Gambling Hall renamed to reflect location
* It was possible for more than 1 matron to be in a house by forcing a matron to rest and reassigning another girl to be matron. When the first girl was through resting she auto-magically became matron again resulting in two matrons.
* People who were consistently getting a crash immediately on running the game can now play
Title: Re: Bugs: 1.30 Alpha
Post by: Midnight_Amratha on May 12, 2010, 07:01:54 AM
not sure this is the right place to report but here goes:
Whore Master Editor 0.66 (the game one) refuse to load item list from resources, all i get is error parsing EntityName line 4511 position 199
Title: Re: Bugs: 1.30 Alpha
Post by: HuiBui on May 12, 2010, 01:04:53 PM
I have found a bug about earning money as whores in brothel .

The girls suddenly, dont see any customer , so they earn no money.
But the brothel has , at the same time , each week : "65524 customers visited the building"
Title: Re: Bugs: 1.30 Alpha
Post by: Wispowill on May 12, 2010, 02:20:20 PM
Concerning girls ages.... My very first game I only used the games default pack, and Rei Ayanami showed up as a 14 year old. During my second game when I used other girl packs, she showed up as 17. I had a bit of time this afternoon and double checking the default girlsaddon.girlsx file Rei is indeed listed as a 14 year old. Looking further, Kiki is 13,  Kooh is 11, Hanah is 14 (Not listing the 16 and 17). These ages are right from the xml files in the default pack. I don't really have the time to play another full fledge-game, but it seems to me that the game is sometimes going by the xml file rather than whatever filters you may have in the game engine itself.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 12, 2010, 05:59:36 PM
Concerning girls ages.... My very first game I only used the games default pack, and Rei Ayanami showed up as a 14 year old. During my second game when I used other girl packs, she showed up as 17. I had a bit of time this afternoon and double checking the default girlsaddon.girlsx file Rei is indeed listed as a 14 year old. Looking further, Kiki is 13,  Kooh is 11, Hanah is 14 (Not listing the 16 and 17). These ages are right from the xml files in the default pack. I don't really have the time to play another full fledge-game, but it seems to me that the game is sometimes going by the xml file rather than whatever filters you may have in the game engine itself.
I just tested this with the current build and haven't been able to reproduce it.  All unique girls are generated with the correct ages.  Are you sure the default girl files weren't edited in one of the bugfix patches to make them all 17?

Quote
Actually I disagree. I think the gang training is perfectly balanced,   and to be perfectly honest, I think it almost get's too easy when you   have them maxed out.
That's part of the problem I expanded on in my other post.  The game is still way too easy.  Making training easier, but making maxed gangs less godlike would be anothe way of fixing this.
Title: Re: Bugs: 1.30 Alpha
Post by: Wispowill on May 12, 2010, 07:06:20 PM
I checked again to make sure, and the XML files I'm looking at are from the r349. As the base package is r327 with the r349 to be copied over it, I can't speak to any other releases. These files with r349 are from 5-6-2010 and GirlsAddon1.girlsx with CRC B99D2CE9 and Girls.girlsx with CRC 44E674E3. The problem may be sporadic, which as a technician myself, I know are the hardest types to troubleshoot. However, as someone who owns a car over 20-years old, I also know the frustration of taking a vehicle to the mechanic four or five times before he is able to see the problem himself.  :)

With the pregnancy rates I did a real quick-like game with four pregnancies with the pregnancy set at 10 weeks and the maturity rate set at 5 weeks. The son and two of the girls were player induced with the last girl induced by customer. These were my results:

 (Used Windows calendar to determine weeks)
03-04-09 Reimu - Pregnant
26-06-09 Reimu - Son sold into slavery (Did not show when born)(12weeks)
10-07-09 Hiiragi - Pregnant
20-09-09 Hiiragi - Birth Girl (10 weeks)
02-11-09 Hiiragi - Girl appears (16 weeks)
10-07-09 Helena - Pregnant
20-09-09 Helena - Birth Girl (10 weeks)
02-11-09 Helena - Girl appears (16 weeks)
24-07-09 Lum - Pregnant
04-10-09 Lum - Girl (10 weeks)
16-11-09 Lum - Girl appears (16 weeks)

As you can see, the son was 3 weeks early and the girls were all 1 week late.  I wish I had the time to redo this with a greater sample for sons, but even if only once, this clearly shows that at least some of the time the sons are short circuiting their time routines. Without a greater son sample I can't tell if the result may be from the pregnancy, rather than maturity, routines. The majority of the time I do get birth messages for the sons (I think) so am not sure why I didn't on this one. I think I still have the game log and save game for this if those would be helpful.

Other things I noticed:
Practice skills don't work at all unless at least two girls are set.

Girls provisions are set to very poor when being sent to the dungeon from the management screen, but not returned to adequate or whatever when released from the dungeon.

Selling slaves or withdrawing money from the bank is included in profits for next day. This probably isn't really a bug, so much as game design. Still, from an accounting view, withdrawing 20K from the bank isn't the same as generating 20K income from an ongoing concern.

Title: Re: Bugs: 1.30 Alpha
Post by: James on May 12, 2010, 07:47:52 PM
i think its just chance, duno about the new version but one verson down, i had a girl then a boy. lol i even resetted a few times on the boy to see if the gender stat was determined befor or after then birth.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 12, 2010, 09:27:06 PM
As for inconsistant bugs, I've noticed starting house% isn't initiallized correctly some of the time.  Sometimes it's 0, other times 60.
Title: Re: Bugs: 1.30 Alpha
Post by: Shinteo on May 13, 2010, 12:41:06 AM
Regarding age of girls, what I notice is that on a new game, the age would follow the xml files. After saving and then reloading, they would then change to 17. Game code seems to support this, as there are several places where the age stat would be changed to 17 if below.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 13, 2010, 01:59:15 AM
not sure this is the right place to report but here goes:
Whore Master Editor 0.66 (the game one) refuse to load item list from resources, all i get is error parsing EntityName line 4511 position 199
That should be fixed in the next release.


I have found a bug about earning money as whores in brothel .

The girls suddenly, dont see any customer , so they earn no money.
But the brothel has , at the same time , each week : "65524 customers visited the building"
Please attach your save file to a post here so I can take a look at it.


Concerning girls ages.... My very first game I only used the games default pack, and Rei Ayanami showed up as a 14 year old. During my second game when I used other girl packs, she showed up as 17. I had a bit of time this afternoon and double checking the default girlsaddon.girlsx file Rei is indeed listed as a 14 year old. Looking further, Kiki is 13,  Kooh is 11, Hanah is 14 (Not listing the 16 and 17). These ages are right from the xml files in the default pack. I don't really have the time to play another full fledge-game, but it seems to me that the game is sometimes going by the xml file rather than whatever filters you may have in the game engine itself.
Regarding age of girls, what I notice is that on a new game, the age would follow the xml files. After saving and then reloading, they would then change to 17. Game code seems to support this, as there are several places where the age stat would be changed to 17 if below.
Ah, that explains it. I'll update the unique girl ages in XML and see why the age isn't being corrected initially when the unique girls load.


With the pregnancy rates I did a real quick-like game with four pregnancies with the pregnancy set at 10 weeks and the maturity rate set at 5 weeks. The son and two of the girls were player induced with the last girl induced by customer. These were my results:

 (Used Windows calendar to determine weeks)
03-04-09 Reimu - Pregnant
26-06-09 Reimu - Son sold into slavery (Did not show when born)(12weeks)
10-07-09 Hiiragi - Pregnant
20-09-09 Hiiragi - Birth Girl (10 weeks)
02-11-09 Hiiragi - Girl appears (16 weeks)
10-07-09 Helena - Pregnant
20-09-09 Helena - Birth Girl (10 weeks)
02-11-09 Helena - Girl appears (16 weeks)
24-07-09 Lum - Pregnant
04-10-09 Lum - Girl (10 weeks)
16-11-09 Lum - Girl appears (16 weeks)

As you can see, the son was 3 weeks early and the girls were all 1 week late.  I wish I had the time to redo this with a greater sample for sons, but even if only once, this clearly shows that at least some of the time the sons are short circuiting their time routines. Without a greater son sample I can't tell if the result may be from the pregnancy, rather than maturity, routines. The majority of the time I do get birth messages for the sons (I think) so am not sure why I didn't on this one. I think I still have the game log and save game for this if those would be helpful.
  Hmm, I'll try to look into this further at some point.


  Practice skills don't work at all unless at least two girls are set.
  Part of a larger problem with training, already noted but not fixed yet.


    Girls provisions are set to very poor when being sent to the dungeon from the management screen, but not returned to adequate or whatever when released from the dungeon.

Selling slaves or withdrawing money from the bank is included in profits for next day. This probably isn't really a bug, so much as game design. Still, from an accounting view, withdrawing 20K from the bank isn't the same as generating 20K income from an ongoing concern.
I'll note these down.


As for inconsistant bugs, I've noticed starting house% isn't initiallized correctly some of the time.  Sometimes it's 0, other times 60.
Are you sure this is with a game started in r349? If the game was started in an earlier version which had that problem, it will have been retained. Which girl(s), anyway?
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 13, 2010, 07:19:48 AM
One more fixed:
* Unique girls showing up underage (< 17) should be taken care of
     
Also, of course, WonderDog has further worked quite a bit on fixing how traits are handled, extensively fixing and improving how whore jobs work in many ways, and fixed the items file (duplicate "Sword of Forever" item and unencoded "&" character which kept Solo's item editor from working).

Since I'm releasing r372, here are the other included changes since the last release (r349):
Fixed:
* Random girls would quite often default to 30 in all skills; value name   lookup table was not being initialized correctly
* changed debug   output from failure to load trigger file to better indicate it's not a   problem ("Assuming this is a girl with no special triggers")
* the   picture of the last selected girl in the girl management window would   sometimes be shown when no girl was selected (or existed for that   matter)
* Shift-selecting items in listboxes which support   multiselect was hit-and-miss; rewrote that code so that it should   respond exactly as expected
Fixed:
*   Starting a new game was not clearing out number of beasts owned from a   previously loaded game
* Items with a non-zero "How bad is it" stat   crash the game 100% of the time when going directly from the store   inventory to a girl's inventory. Buying to the player's inventory then   transferring to a girl is still fine.
* using make-up items or any   other items which provided a temporary stat boost (not skill boost) was   bugged
* items which were set to impregnate or inseminate did not   work correctly; now, it uses the "Amount" value as a multiplier for the   chances.
    So, assuming the default config of 8% chance each for   pregnancy, player pregnancy, and insemination, these item effects would   have 80% chance of success (8% * 10):
    <Effect   What="GirlStatus" Name="Pregnant By Player" Amount="10" />
    <Effect What="GirlStatus" Name="Pregnant" Amount="10" />
    <Effect What="GirlStatus" Name="Inseminated" Amount="10" />
    An "Amount" of 0 still removes any of the above, that hasn't been   changed.
 
* When transferring an item on the Item Management   screen, the selection is much better maintained and tracked (transferred   items are selected in target inventory)
more   fixes:
* removed availability of movie job types for now, since they   were indeed entirely broken
* Whore jobs in Bar and Gambling Hall   renamed to reflect location
* It was possible for more than 1 matron   to be in a house by forcing a matron to rest and reassigning another   girl to be matron. When the first girl was through resting she   auto-magically became matron again resulting in two matrons.
* People   who were consistently getting a crash immediately on running the game   can now play

The r372 update with the above changes is available here (http://pinkpetal.org/index.php?topic=351.msg6684#msg6684).
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 13, 2010, 02:19:32 PM
More changes committed:
* switching between day and night on Girl Management screen no longer rebuilds the girl list, maintaining multi-select
* on Girl Management screen, "Fire", Sell", and "Free" buttons now work on multi-selected girls (it properly ignores slaves for "Fire", and ignores non-slaves for "Sell" and "Free")
* Selling or releasing multi-selected girls and/or customers from the Dungeon screen could cause crash

* You're now told how much gold you got when you sell girls directly from the dungeon
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 13, 2010, 06:44:11 PM
And a bit more.

Fixed:
* girl working as matron now gets full pay (you get no house perc) and the money is deducted from you; her pay is now 200-400, depending on service skill (200+(service*2))
* jobs which do not gain money externally (from customers, exploring, whatever) now have wages deducted from you; you do still get your house percent back, though

Modified:
* Updated job enjoyment changes, very slight decrease for whoring but major increase for all other jobs (+1/-1 to +3/-3)
* girls exploring the catacombs now list each gained item in turn summary
* girls doing beast care and beast capture gain a bit of bestiality skill
* girls who do the Torturer job can sometimes become Sadistic or even Merciless if they enjoy their job enough
* girls who do the Matron job can sometimes become Charismatic or even Psychic if they enjoy their job enough
* girls exploring the Catacombs or Capturing Beasts can sometimes gain the traits Adventurer, Tough, and Aggressive if they enjoy combat enough
* girls defeated in the Catacombs might end up with one of the 3 types of Scars, or even rarely One Eye or Eye Patch
* bestiality now only has a chance to harm your beasts if the girl has lower than 50 skill in bestiality; it ranges from 50% chance at 0 skill to 1% chance at 49 skill; chance was 25% regardless before
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 13, 2010, 07:31:17 PM
I really like the skill additions there.  Some other suggestions there:
-Cleaning can eventually add Elegant.
-Security can eventually add Tough or Aggressive.
-Advertising can eventually add Charming.
-Entertainer can eventually add Optimist (nobody wants to watch a depressed entertainer).
Title: Re: Bugs: 1.30 Alpha
Post by: Zeus on May 14, 2010, 12:26:17 AM
i don't know it's a Bug... Do the Beast got a Limited Lifetime? cuz, i got once 14 beast... a few turns later just only 8... (set 2 girls to Beast Carer...)
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 14, 2010, 01:49:43 AM
If you have girls doing bestiality who are unskilled, they could be harming (and thus removing) some of your beasts. You can see for sure in the turn summary. Beyond that and the possibility of girls doing beast care having problems with them ("The animals were restless and disobedient"), the number of beasts shouldn't be dropping. I haven't specifically monitored it though.
Title: Re: Bugs: 1.30 Alpha
Post by: Zeus on May 14, 2010, 02:10:57 AM
a okay, big thanks ^^
Title: Re: Bugs: 1.30 Alpha
Post by: HuiBui on May 14, 2010, 05:41:16 AM
"I have found a bug about earning money as whores in brothel .

The   girls suddenly, dont see any customer , so they earn no money.
But   the brothel has , at the same time , each week : "65524 customers   visited the building"

Attached comes the save file.
Title: Re: Bugs: 1.30 Alpha
Post by: RyRain on May 14, 2010, 09:36:47 AM
Found a crash glitch. For some reason my current save has a high chance of crashing if I go to the next day. Just try next day a couple times and it should happen. Save attached. Didn't know if I just needed the base file or the master file so both are there.
Title: Re: Bugs: 1.30 Alpha
Post by: Wispowill on May 14, 2010, 01:17:43 PM
For r376:

Matron tends to come back on line in the evening shift but doesn't change the morning shift while doing so. This seems to leave her in a "stuck" non-functional state until I change it back manually.

Early in the game the matron chose to "help a girl relax" instead of taking her off-line. From then on the matron would do absolutely nothing at all in the game but "help a girl relax", allowing a number of girls to reach near death before I intervened and started management myself. I tried both taking the matron offline and letting her rest, as well as switching the matron job to another girl. This went on for several game years until I finally made a girl matron who had under 10% health. The turn the matron should have died she finally decided to "help girl heal" as well as "help girl relax" and after that things returned to their normal state. (When I reported about this before I had said the matron "comforts" a girl. This was an error on my part. It was "help girl relax" before as well.)

Not bug:
One game mission rewarded me with 32K and another with 109K. This seems a bit, erm... excessive.

Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 14, 2010, 03:42:56 PM
I think the missions in general need to be looked at, at some point.  Early game missions are often impossible (steal X money when there's no way you could have enough trained gangs to do so in time), while some handed out later give requirements you've already met (have X monster girls, when X is a number you already have or are only 1 off).  Some checking should be put in place to insure given missions aren't too easy, and that rewards are appropriate for the requirements.

I'd also like to suggest adding a new flag in the girl stats: Reward Only.  It would be like catacombs only, but she's only be given randomly as a mission reward.
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 14, 2010, 10:16:33 PM
I finally fired up the game to play, but after an hour of walks and checking the slavemarket, not one of my girls has shown up in either, only random girls and girls that come packaged with the game. The commandline window does bitch about none of them having trigger files, if that has anything to do with it.

Edit: I think running it in admin and starting a new game fixed it. Or I was incredibly unlucky for an hour straight.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 15, 2010, 12:43:10 AM
Checking out some income issues in the latest version.  There's definitely some mystery factor not being calculated in the end of turn statement.  Supposed profits of 100-300 gold early on are resulting in small net losses or very small gains the next turn.

Here's a complete rundown of a end of turn  I just tried:
-Gold before End Turn = 106
-Taxed 54, laundered 172
-Overall profit of 184
-Gold at the start of the next turn = 26

Calulating everything going on, I have:
-Two gangs, one guarding, one training (-150)
-Level 5 advertising (-500)
-Bar Staff and Casino Staff (-70)
-Tax (-54)
-Girl A trains and cleans, apparently earning 25 gold at 50% house% (+12.5)
-Girl B trains and cleans, earning 25 gold at 50% house% (+12.5)
-Girl C whores and rests, earning 500 gold at 100% house% (+500)
-Girl D whores and rests, earning 249 gold at 100% house% (+249)
-Girl E is on security and refuses night duties, earning 70 gold at 50% house% (+35)
-Girl F whores and rests, earning 264 gold at 100% house% (+264)

This should leave me with a profit of 299 gold.  Looking in the config file, training costs 1 gold per day.  That's 297 gold.  Pregnancy potions are on auto-buy, so assuming every single sex act that week required one,  that would be 11 x 2 gold.  Down to 275 gold.  I'll assume security and cleaning detail cost money that isn't being shown to get to 184 profit.  So how did I LOSE money?  Casino losses not being reported?

Edit: Nope, fired both the bar and casino staff and tried again.  I still netted less money than it reported.  There's ~250 gold somewhere being lost somewhere that isn't being reported.
Title: Re: Bugs: 1.30 Alpha
Post by: TF on May 15, 2010, 01:10:58 AM
I'd noticed the inconsistency before... I always chalked it up to housing. I don't think the girls' lodging gets factored into the summary, but still gets taken out of the player's money pool.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 15, 2010, 01:31:45 AM
HuiBui and RyRain, I'll check on your saves in a little bit.

Matron tends to come back on line in the evening shift but doesn't change the morning shift while doing so. This seems to leave her in a "stuck" non-functional state until I change it back manually.
That should be a simple fix for the next release.

Early in the game the matron chose to "help a girl relax" instead of taking her off-line. From then on the matron would do absolutely nothing at all in the game but "help a girl relax", allowing a number of girls to reach near death before I intervened and started management myself. I tried both taking the matron offline and letting her rest, as well as switching the matron job to another girl. This went on for several game years until I finally made a girl matron who had under 10% health. The turn the matron should have died she finally decided to "help girl heal" as well as "help girl relax" and after that things returned to their normal state. (When I reported about this before I had said the matron "comforts" a girl. This was an error on my part. It was "help girl relax" before as well.)
Thanks, I'll add those details to the earlier report. It should help me track down the problem, though I haven't encountered it myself yet.

I finally fired up the game to play, but after an hour of walks and checking the slavemarket, not one of my girls has shown up in either, only random girls and girls that come packaged with the game. The commandline window does bitch about none of them having trigger files, if that has anything to do with it.

Edit: I think running it in admin and starting a new game fixed it. Or I was incredibly unlucky for an hour straight.
If you look in the save file at the top you should see the available girls. If your new girls are listed there with the original ones, they should presumably show up the same. I've tested briefly with a couple of girl packs now in Win7 x64 and the girls were added to the save file, and I then had one of them show up in game.
The lack of trigger files is of course fine, as the only original girl with one is Cammy.
So, you were probably just unlucky.


As for the income issues, at some point I plan to rework the Turn Summary screen a bit (while switching it to XML layout), and include a bit more detailed accounting info somewhere there. I doubt I'll look any further into money accounting issues before then.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 15, 2010, 03:26:00 AM
I'll assume security and cleaning detail cost money that isn't being shown to get to 184 profit.

There's a mystery 40 gold that goes away every week; if you do nothing at all in an empty house (like in the beginning of the game) you lose that amount no matter what. That's been there for a long time, but I've always assumed it was the player's living expenses and I've never thought twice about it. Also, just having a girl in a room costs money depending on her accomodation (girls in the dungeon are free). A brothel with one completely idle girl on "adequate" accomodations and nothing else loses a total of 118 gold per week.

These expenses seem to be included correctly in the weekly profit  report, or at least they are in the beginning... but unless you've put the six girls in your example on "very poor" accomodations your overhead should probably be bigger than your 275 -> 184 calculation, so there still might be something weird going on.
Title: Re: Bugs: 1.30 Alpha
Post by: xorgroth on May 15, 2010, 03:45:08 AM
Unsure if this has been reported as of yet but in r372. Unable to interact with girls or at least the dialog doesn't show up after hitting it. Does however eventually go gray after about 10 clicks.

Edit: Jumped a couple rev releases. :P
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 15, 2010, 06:33:08 AM
Unsure if this has been reported as of yet but in r372. Unable to interact with girls or at least the dialog doesn't show up after hitting it. Does however eventually go gray after about 10 clicks.
Anyone else having this problem? I can't reproduce it. I just extracted a fresh copy of r327 and extracted the r372 update over it, started a new Test (cheat) game, got Alena from walking around town, and chatted with her in the brothel.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 15, 2010, 08:21:05 AM
Committed a couple more.

Fixed:
* a bug prevented girls on their free time from buying things from the shop; it's back to functional again
* girl fights can now end in draw if still going after 1000 attacks rather than potentially getting stuck in an infinite loop
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 15, 2010, 08:50:01 AM
"I   have found a bug about earning money as whores in brothel .

The girls suddenly, dont see any customer , so they earn no money.
But the brothel has , at the same time , each week : "65524 customers visited the building"
OK, nailed this one down. The number of customers was actually in the negative, causing it to display the wrong number. I've fixed it so the number of customers can't go into the negative. I've also adjusted the filthiness to lost customers ratio to be a little more forgiving in general, but to have no cap on how many customers can be lost that way (it was capped at 50 customers and was figured as filthiness/3, now it is uncapped and is filthiness/10).
As for why you had no customers, your brothel's filthiness was too high and  no customers wanted to wade through the nastiness. Set a girl or two to do cleaning.


Found a crash glitch. For some reason my current save has a high chance of crashing if I go to the next day. Just try next day a couple times and it should happen. Save attached. Didn't know if I just needed the base file or the master file so both are there.
I can't duplicate this one; I tried clicking Next Week about 10 times, and reloading the save twice more and going through ~10 more weeks each.


EDIT: also, I've just added a turn summary message for brothels to show you how many customers are lost due to brothel filthiness.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 15, 2010, 01:24:34 PM
More committed.

Fixed:
* number of customers could go into the negatives due to high filthiness; added a check to set number of customers to 0 if it's in the negative
* girls now properly train in groups of up to 4 girls. The grouping of girls is now randomized, and the turn summary report indicates which girls trained with which. Also, training can no longer give negative gains ("+-1" indeed :P).
* girls who train alone (only possible if you have only 1 girl training) now have 50% chance to gain 1-3 points in a random stat, instead of 10% chance to gain 1 point; also, turn summary output for it is updated

* number of customers lost due to filthiness is now reported in the turn summary for each brothel


EDIT: and:
* Matron was still a bit bugged; should work perfectly now. Also, the Matron can put herself back to work (if she took herself off duty due to getting too tired or whatever).
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 15, 2010, 05:08:52 PM
Since I'm releasing r385, here are the major included changes since the last release (r372):

* switching between day and night on Girl Management screen no longer rebuilds the girl list, maintaining multi-select
* on Girl Management screen, "Fire", Sell", and "Free" buttons now work on multi-selected girls (it properly ignores slaves for "Fire", and ignores non-slaves for "Sell" and "Free")
* Selling or releasing multi-selected girls and/or customers from the Dungeon screen could cause crash

* You're now told how much gold you got when you sell girls directly from the dungeon
Fixed:
* girl working as matron now gets full pay (you get no house perc) and the money is deducted from you; her pay is now 200-400, depending on service skill (200+(service*2))
* jobs which do not gain money externally (from customers, exploring, whatever) now have wages deducted from you; you do still get your house percent back, though

Modified:
* Updated job enjoyment changes, very slight decrease for whoring but major increase for all other jobs (+1/-1 to +3/-3)
* girls exploring the catacombs now list each gained item in turn summary
* girls doing beast care and beast capture gain a bit of bestiality skill
* girls who do the Torturer job can sometimes become Sadistic or even Merciless if they enjoy their job enough
* girls who do the Matron job can sometimes become Charismatic or even Psychic if they enjoy their job enough
* girls exploring the Catacombs or Capturing Beasts can sometimes gain the traits Adventurer, Tough, and Aggressive if they enjoy combat enough
* girls defeated in the Catacombs might end up with one of the 3 types of Scars, or even rarely One Eye or Eye Patch
* bestiality now only has a chance to harm your beasts if the girl has lower than 50 skill in bestiality; it ranges from 50% chance at 0 skill to 1% chance at 49 skill; chance was 25% regardless before
Fixed:
* a bug prevented girls on their free time from buying things from the shop; it's back to functional again
* girl fights can now end in draw if still going after 1000 attacks rather than potentially getting stuck in an infinite loop
Fixed:
* number of customers could go into the negatives due to high filthiness; added a check to set number of customers to 0 if it's in the negative
* girls now properly train in groups of up to 4 girls. The grouping of girls is now randomized, and the turn summary report indicates which girls trained with which. Also, training can no longer give negative gains ("+-1" indeed :P).
* girls who train alone (only possible if you have only 1 girl training) now have 50% chance to gain 1-3 points in a random stat, instead of 10% chance to gain 1 point; also, turn summary output for it is updated
* Matron was still a bit bugged; should work perfectly now. Also, the Matron can put herself back to work (if she took herself off duty due to getting too tired or whatever).

* number of customers lost due to filthiness is now reported in the turn summary for each brothel

The r385 update with the above changes is available here (http://pinkpetal.org/index.php?topic=351.msg6745#msg6745).
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 15, 2010, 08:16:45 PM
Huh. I just tried it again to be sure, and for an empty brothel's first few weeks of complete inactivity, I go from 4000 to 3960 to 3920 to 3880 gold. So's I don't know what's goin' on.  :o
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 15, 2010, 08:39:38 PM
Okay, I just tried it 5 more times (quitting out entirely each time) and it's just taking away -40.  I don't get it either, but I'll report if I can get it to take away extra gold again.

EDIT: Okay, I've found the mystery.  A) Gang fees aren't being included in the weekly report and B) sometimes when you quit to main menu and start a new game, it doesn't initialize the gangs and gang item auto-buy settings. You can end up with 'ghost gangs' repeating the last action in the old game with no way to turn them off.  The easiest way to check for this is to start a new game, buy some gangs, turn on potion and net auto-buy, quit, and start a new game.  If the auto-buy is still checked on, it's failed to initialize and you'll lose extra money every turn for the 'fake' gangs.  It also doesn't seem to initialize the two 'boosted gangs' if you buy them, quit to the main menu and start again.

I wouldn't worry to much about this one, as the only reason I even ran into it is because I keep quitting and restarting games to quickly test things.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 15, 2010, 10:12:29 PM
EDIT: Okay, I've found the mystery.  A) Gang fees aren't being included in the weekly report and B) sometimes when you quit to main menu and start a new game, it doesn't initialize the gangs and gang item auto-buy settings.
The auto-buy settings for healing potions and nets were indeed not being reset on "new game". However, everything else (including gangs and by extension gang missions) is properly reset, so I don't know what sort of problems you were actually having there.

It also doesn't seem to initialize the two 'boosted gangs' if you buy them, quit to the main menu and start again.
What do you mean? When you start a new game, buy the two boosted gangs, and then quit and start a new game without exiting, the boosted gangs are not showing up? If so, I can't duplicate that.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 15, 2010, 11:06:59 PM
The "Items with a non-zero "How bad is it" stat crash the game 100% of the  time when going directly from the store inventory to a girl's  inventory." bug is back. It was definitely fixed in 372, but it's happening on 385 again.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 15, 2010, 11:49:49 PM
The auto-buy settings for healing potions and nets were indeed not being reset on "new game". However, everything else (including gangs and by extension gang missions) is properly reset, so I don't know what sort of problems you were actually having there.
What do you mean? When you start a new game, buy the two boosted gangs, and then quit and start a new game without exiting, the boosted gangs are not showing up? If so, I can't duplicate that.
Yeah, the boosted gangs wouldn't show up when this bug occured.  It seems to happen rarely actually, it just happened to occur for me when I happened to be watching it closely.  Like I said, unless more people notice this I wouldn't worry about it will only be factor for people who keep starting new games without exiting the program.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 15, 2010, 11:59:50 PM
The "Items with a non-zero "How bad is it" stat crash the game 100% of the  time when going directly from the store inventory to a girl's  inventory." bug is back. It was definitely fixed in 372, but it's happening on 385 again.
I can't duplicate this now in r385 (tried with Slave Band, Shackles of the Mundane, Ritual of Domination) and the affected code hasn't been changed since then. Are you sure it's not something else causing the crash?
Also, can you provide a save file in which it seems to consistently happen with a specific girl?


Yeah, the boosted gangs wouldn't show up when this bug occured.  It seems to happen rarely actually, it just happened to occur for me when I happened to be watching it closely.  Like I said, unless more people notice this I wouldn't worry about it will only be factor for people who keep starting new games without exiting the program.
Very strange. Every time you start a new game, it runs the Gangs.Free() routine which first deletes the gangs linked list and recruitable gangs linked list and then sets them to 0, no possibility of failure. The New Game process then later explicitly generates the new recruitable gangs based on the numbers set in the config file; there's nothing which should be able to tamper with those stored config values, so... it's beyond me what could possibly cause that to happen.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 16, 2010, 12:12:51 AM
Has something been changed with the calculations in the number of customers that a girl sees?  I've been genuinely stuggling to get started with the current build as girls generally only see 1 or 2 customers a shift now.  I've actually gone broke twice now even with 4-5 girls all working as I simply don't make enough money.  Once you add a cleaner, your reported income WILL go in the negatives.  Using gangs to steal early on is out of the question, as a gang with ~70% in all stats got completely wiped trying a pretty theft.  If this an attempt to increase the difficultly, that's good.  But this is a little overboard at the moment.  Girls need to see at least 3 customers or they aren't even making their housing costs back.

Edit: Seems to be based very heavily on Looks.  A couple random girls who generated with 90+ looks are getting 4-5 customers.  Girls with < 75 are only getting 1-2.  Fetish categories don't seem to impact it much or at all.  While this makes some logical sense, there's no guarentee the player can get enough 'supermodel' girls to stabilize and buy items to buff the rest.  A more fair guideline would be something like:
< 50 looks - 1 customer
50-59 looks - 2 customers
60-75 looks - 3 customers
76-89 looks - 4 customers
90+ looks - 5 customers

And regarding the 'bad for you' crash, I haven't been able to duplicate it with the current build either.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 16, 2010, 02:15:43 AM
I can't duplicate this now in r385 (tried with Slave Band, Shackles of the Mundane, Ritual of Domination) and the affected code hasn't been changed since then. Are you sure it's not something else causing the crash?
Also, can you provide a save file in which it seems to consistently happen with a specific girl?

Okay, I've done a lot of tests and followed a bunch of false leads, so apparently it's either more or less complicated than I thought. The "LS" attachment below is a save game with one girl, on a fresh install, everything default. I start the program, load the game, go to town, to the shop, then get her, say, Fairy Dust, Lace Lingerie or a Leash, and the game crashes, always. It might not be entirely related to the badness stat, because I can get her, say, a Brothel Gown and get away with it; however all the items I've seen cause a crash so far have had a non-zero badness.

The same thing happens when I start a new game, basically; this isn't just that specific save. However, "Test" brothels work fine and don't crash. If I start the program, load the "Test" game attached below, then go to the shop, I can buy the girl any item I want without problems.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 16, 2010, 03:17:31 AM
Okay, I've done a lot of tests and followed a bunch of false leads, so apparently it's either more or less complicated than I thought. The "LS" attachment below is a save game with one girl, on a fresh install, everything default. I start the program, load the game, go to town, to the shop, then get her, say, Fairy Dust, Lace Lingerie or a Leash, and the game crashes, always. It might not be entirely related to the badness stat, because I can get her, say, a Brothel Gown and get away with it; however all the items I've seen cause a crash so far have had a non-zero badness.

The same thing happens when I start a new game, basically; this isn't just that specific save. However, "Test" brothels work fine and don't crash. If I start the program, load the "Test" game attached below, then go to the shop, I can buy the girl any item I want without problems.
Aha, thanks. I've duplicated it and pinned it down with the help of that LS save. It was when the badness was 20 or higher, and was crashing since it was incorrectly checking the player inventory item of that same index number for a couple of the comparisons. With the large Test inventory, those checks went through fine in that case. So it was a rather old leftover which had just been missed so far. It should be fixed in the next release.
Title: Re: Bugs: 1.30 Alpha
Post by: TF on May 16, 2010, 06:36:21 AM
I don't know if it's meant to be this way or not, but money taken out of the bank appears to be taxed as income. Seems like a bug to me, but if it's not, with the interest rate at the bank being what it is, it seems as though it's not worthwhile to put money into the bank in the first place.
Title: Re: Bugs: 1.30 Alpha
Post by: FurryFanatic on May 16, 2010, 10:53:09 AM
Dagoth, when I first put the update into the game I was able to get to the next week with no crashing.  However, when I tried to continue to the following week, it crashed again and still will not push through.  Posting my save.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 16, 2010, 05:55:03 PM
Aha, thanks. I've duplicated it and pinned it down with the help of that LS save. It was when the badness was 20 or higher, and was crashing since it was incorrectly checking the player inventory item of that same index number for a couple of the comparisons. With the large Test inventory, those checks went through fine in that case. So it was a rather old leftover which had just been missed so far. It should be fixed in the next release.

Heheh, sometimes I wish I wasn't so obsessed with making sure the problem isn't on my end, that would have saved me a lot of time. (Though I guess it can be kind of a good thing sometimes.) Good work tracking that one down!
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 16, 2010, 11:53:59 PM
I don't know if it's meant to be this way or not, but money taken out of the bank appears to be taxed as income. Seems like a bug to me, but if it's not, with the interest rate at the bank being what it is, it seems as though it's not worthwhile to put money into the bank in the first place.
Yeah, that doesn't sound right. I'll mark it down to look into.

Dagoth, when I first put the update into the game I was able to get to the next week with no crashing.  However, when I tried to continue to the following week, it crashed again and still will not push through.  Posting my save.
I'll check it later and post back.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 17, 2010, 03:49:06 AM
Dagoth, when I first put the update into the game I was able to get to the next week with no crashing.  However, when I tried to continue to the following week, it crashed again and still will not push through.  Posting my save.
Are you sure you're running r385? It should say in the top bar. I ask because r385 should fix the problem you were having, where endless fights would cause the game to hang.

I loaded up your game and went through maybe 15 weeks or so without incident in the current debug mode, then again with a Release copy of r385. I can't duplicate your crash/hang.
Title: Re: Bugs: 1.30 Alpha
Post by: FurryFanatic on May 17, 2010, 01:52:15 PM
Yup, the version is 385.  I even tried putting the 385 files in and running straight through without altering anything, but it instantly crashes when I try to go to the next week.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 17, 2010, 02:07:02 PM
In that case, I don't think your current crashing is due to anything in the core game. It might be due to an item or script added, or something similar.

Have you tried extracting out a new unmodified game folder (no new items or girls or whatever) and plopping your savegame into it, then trying to load it up and go to the next week? The girls won't have their pictures, but it should otherwise work.
Title: Re: Bugs: 1.30 Alpha
Post by: ElvisLives on May 17, 2010, 04:46:48 PM
Sorry if this one has already been posted:

Bug involving traits, pregnancy, and birth.

Version r385 (edit: originally said 349)

Girls in my brothels seem to be picking up semi-random traits upon giving birth. These traits include nymphomania, incest, and your daughter. A complicating matter: I'm giving the girls the sterile trait between conception and birth, could that be the issue?
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 17, 2010, 05:07:13 PM
There was a bug in the older versions with the random girl file not initializing properly.  Upgrade to the newest patch and test it again.
Title: Re: Bugs: 1.30 Alpha
Post by: ElvisLives on May 17, 2010, 06:27:32 PM
Sorry, forgot to mention that these are non-random girls. Also I just checked and I wrote the wrong version. I do have r385 not r349 like I had originally posted.
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 17, 2010, 08:48:05 PM
In the summary screen the girl summaries say she enjoyed it a lot at the bottom of every sex act, even if it said she didn't enjoy it or marginally enjoyed it above. Running latest version.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 17, 2010, 10:51:02 PM
Sorry if this one has already been posted:

Bug involving traits, pregnancy, and birth.

Version r385 (edit: originally said 349)

Girls in my brothels seem to be picking up semi-random traits upon giving birth. These traits include nymphomania, incest, and your daughter. A complicating matter: I'm giving the girls the sterile trait between conception and birth, could that be the issue?

Can you post a save which consistently shows this behaviour?


In the summary screen the girl summaries say she enjoyed it a lot at the bottom of every sex act, even if it said she didn't enjoy it or marginally enjoyed it above. Running latest version.

Yeah, that discrepancy is indeed odd. I'll mark it down.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 17, 2010, 10:59:16 PM
Another commit, while I have it stable.

Fixed:
* auto-buy healing potions and nets options were not reset on "new game"
* bank withdrawals should no longer be taxed; by extension, money taken from girls or given by scripts is no longer taxed
* bad items sent directly from the shop to a girl's inventory could still cause a crash

* not a change as such, but a note: since girls now buy things in their free time (r385), they will sometimes buy and use an item which gives an abortion, so if you see a girl you thought was pregnant/inseminated is no longer pregnant... you now have a good idea why.
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 18, 2010, 04:03:04 AM
If this is stable, are we ready to call it "Beta"?

If so we should tag it before something breaks again. And then I'll use that to start merging in some of the Lua stuff I've been working on :)
Title: Re: Bugs: 1.30 Alpha
Post by: Sigfried666 on May 18, 2010, 08:03:49 AM
I was doing a lot of quitting-reloading, so it is probably a file corruption, but...
I had two pregnant girls suddenly not being pregannt anymore. Ok, perhaps they had abortions, could be.
But instead, they ended up giving birth to monsters, as if they were inseminated, while they had no pregnancy/inseminated status anymore.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 18, 2010, 09:41:21 AM
If this is stable, are we ready to call it "Beta"?

If so we should tag it before something breaks again. And then I'll use that to start merging in some of the Lua stuff I've been working on :)
Well, I was referring to "stable" as in no extra half-worked fixes or changes started (I prefer to commit tested working code only), but... yeah, I'd say it is probably stable enough to tag as beta now.


I was doing a lot of quitting-reloading, so it is probably a file corruption, but...
I had two pregnant girls suddenly not being pregannt anymore. Ok, perhaps they had abortions, could be.
But instead, they ended up giving birth to monsters, as if they were inseminated, while they had no pregnancy/inseminated status anymore.
OK, that definitely sounds bizarre. I know it's not likely, but do you have a save from before that?
Title: Re: Bugs: 1.30 Alpha
Post by: Sigfried666 on May 18, 2010, 10:24:01 AM
OK, that definitely sounds bizarre. I know it's not likely, but do you have a save from before that?
Unfortunately, no. It happened to two girls at once, but never again...
Title: Re: Bugs: 1.30 Alpha
Post by: csp87 on May 18, 2010, 11:29:17 AM
Hi

two bugs to report and two minor suggestions to make:

- at least for me the "Go to selected"-button in turn summary does not work for girls in the dungeon.
- dead slaves in the dungeon can still be sold, i think it is even possible to brand a dead girl as a slave and then sell her. (Or is this intended?  ;) )

- when branding multiple girls in the dungeon at once the multi-selection vanishes afterwards, so in order to sell them directly you have to select them again.
- sorting the lists in girl management or dungeon can not be undone (Or i did not figure out how except quiting the program). How about changing the switiching between ascending/descending when clicking to a sequence ascending/descending/unsorted?
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 18, 2010, 12:57:57 PM
- at least for me the "Go to selected"-button in turn summary does not work for girls in the dungeon.
You're right it, doesn't. That'll be something for the eventual turn summary screen overhaul.

- dead slaves in the dungeon can still be sold, i think it is even possible to brand a dead girl as a slave and then sell her. (Or is this intended?  ;) )
I'll note it down.

- when branding multiple girls in the dungeon at once the multi-selection vanishes afterwards, so in order to sell them directly you have to select them again.
Yeah, that's due to it currently rebuilding the list after the branding is complete, the process of which will always remove a multi-select. The rebuilding is necessary since girls can end up escaping. I might look into additional multi-select tracking for that.

- sorting the lists in girl management or dungeon can not be undone (Or i did not figure out how except quiting the program). How about changing the switiching between ascending/descending when clicking to a sequence ascending/descending/unsorted?
Already planned as an additional clickable bit of header in the upper right corner (pushing the scrollbar down) which removes any sorting.
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on May 18, 2010, 04:36:52 PM

- dead slaves in the dungeon can still be sold, i think it is even possible to brand a dead girl as a slave and then sell her. (Or is this intended?  ;) )
did you have to point that out ... I've been using that to my advantage...;) lol.

also on this point you can buy back your dead girls because they have the anoying habit of reapearing in the slave shop.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 19, 2010, 09:52:17 PM
One balance issue/exploit I've noticed regarding matrons; Now that their fee goes into their personal gold amount, this means that you can easily take it back from them anytime.  Since they never get free time, they never get to use any of their gold either.  If you picked a matron that's unlikely to fight back, there is almost zero drawback to simply taking back all your money every so often.  While it's realistic that the matron's wages are kept by the matron, I think it needs to go back to their wages simply being costs.  This applies to all jobs, though it's far more noticable with matrons since their high fee quickly results in thousands of gold after a few months.  Failing that, then there needs to be a much more drastic penalty for taking a girls money.  Like a high chance for 'I quit/run away' and removed from the game (they would logically never trust you enough to work for you again) drastic if you take over X gold from a girl.
Title: Re: Bugs: 1.30 Alpha
Post by: Sigfried666 on May 20, 2010, 01:33:42 AM
I did a quick search but ended up still unsure about this...
Did that problem with the trait "your daughter" being only temporary get dealt with?
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 20, 2010, 04:19:56 AM
I did a quick search but ended up still unsure about this...
Did that problem with the trait "your daughter" being only temporary get dealt with?
Yes, it was fixed a few revisions ago.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 20, 2010, 05:57:47 PM
Fixed:
* dead girls can no longer be enslaved or sold in the dungeon
* multi-select should now be maintained when doing actions in the dungeon
* Girl sex enjoyment messages updated a bit
 
Title: Re: Bugs: 1.30 Alpha
Post by: Sigfried666 on May 20, 2010, 07:35:21 PM
Well. The "yout daughter" trait disappeared from my daughters yet again, on r385.
I am going to download the full and the update again from the other thread and try once more.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 20, 2010, 07:56:18 PM
It's not just you, I checked my recent r385 game and Your Daughter is no longer on two girls who had it.  If it's not the same bug, there's something else causing it to be applied only temporarily.  Looking through the save file, a new girl with Your Daughter has a '10' under the trait meaning it is indeed being applied temporary.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 20, 2010, 08:09:32 PM
Updated:
* new clickable area on far right of listbox header which un-sorts the list back to the order the elements were originally added in; scrollbar and scroll up button are moved down to make room whenever it's shown


Well. The "yout daughter" trait disappeared from my daughters yet again, on r385.
I am going to download the full and the update again from the other thread and try once more.
Ermm... what can I say, it was fixed. I just checked the current source and it's no longer fixed.

It should be fixed again in the next release. :D
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 21, 2010, 05:44:56 AM
Updated:
* On Girl Details screen, sort order for previous/next girl functionality now matches the girl list sort order of the screen that called it (Girl Management or Dungeon)... so, you can sort the girls based on a specific stat and then view their details in that same order
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on May 22, 2010, 12:07:28 PM
Ok, it's probably been reported somewhere before, but there probably is a bug somewhere in the pregnancy code (unless it's meant to be this way). In my latest play with v.385 I had two girls give birth to beasts even if they had the pregnant by player tag.

Also one one my pregnant girls went shopping and got an item that gives sterile. She remained pregnant and gave birth normally. Just thought you might want to consider the correct game reaction in a similar case.
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 22, 2010, 01:51:26 PM
Yeah, can you add like an option to the girl stat screen to ban them from buying items? Cause it can be really annoying when your girl who's deeply in love with you and pregnant with your child goes and gets an abortion item.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 22, 2010, 02:25:30 PM
Edit the items file and crank up the 'badness' of undesirable items.  AFAIK there's no actual penalty for giving a girl a 'bad' item beyond what the item does.  I had to go in and make various changes to my items file after the recent patch due to girls buying items again.  Basically anything that has just as many drawbacks as bonuses got tweaked in my game.  While I'm using my own item file and don't care, I know the official item list is Lordshame's list.  Someone may need to make some balance changes to account for girls buying things on their own again, and also for the seemingly harder initial difficulty.

Another measure that would help is preventing girls from auto-using items.  They love buying 'cure for X' items, but will drink them for no reason.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 22, 2010, 05:31:18 PM
One thing I'm planning to add is an extra optional value for items to manually indicate the chance of girls buying the item or not (if not specified, they'll just go by item badness with 0% or 100% chance). So, I'd have it override items like "brainwashing oil" or "disguised slave band" to indicate that girls should not buy them.  :P
For that matter, you could have a high badness item which girls do buy for themselves for whatever reason. Maybe have a small chance of them buying a drug when not currently addicted?
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 22, 2010, 08:19:38 PM
A yes/no buy flag would certainly solve most of the problems.  Stop them from buying healing potions and relaxers, and using them at random at any rate.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 22, 2010, 08:58:16 PM
Fixed:
* polished the "new rival" texts a bit

* gang training now works on a curve where they gain less the higher the skill/stat (but more at lower levels); however, they'll tend to focus training in what they're good at as well, so they should hopefully end up being better at certain skills and stats
* gang missions and combat will slightly boost appropriate gang stats/skills (not as much as training, though)
* all 6 important gang stats are now listed on the Gang Management screen; in other words, added Agility, Toughness (Constitution), and Charisma
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 22, 2010, 09:00:14 PM
* all 6 important gang stats are now listed on the Gang Management   screen; in other words, added Agility, Toughness (Constitution), and   Charisma

Wait, so was this part of how they worked all along or is this new?
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 22, 2010, 09:23:54 PM
Also fixed:
* inventory lists had lost their sorting due to the new "un-sort" list functionality; fixed


* all 6 important gang stats are now listed on the Gang Management   screen; in other words, added Agility, Toughness (Constitution), and   Charisma

Wait, so was this part of how they worked all along or is this new?
When I was working on the improved training skill/stat boost I ran through gang activities to make sure the major 3 were all that were used, and found that the above 3 are also used. Agility and Constitution are used in combat, and Charisma is used by the gang to convince girls to work for you instead of having to actually kidnap them.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 22, 2010, 09:32:52 PM
While I'm using my own item file and don't care, I know the official item list is Lordshame's list.  Someone may need to make some balance changes to account for girls buying things on their own again, and also for the seemingly harder initial difficulty.

Yeah, I'm going to make a big version 4 before long. At first I was going to wait until a relatively feature-complete release, but a lot of things do need at least some rebalancing right away. Plus the new stuff has given me many ideas for new items!

One thing I'm planning to add is an extra optional value for items to manually indicate the chance of girls buying the item or not (if not specified, they'll just go by item badness with 0% or 100% chance). So, I'd have it override items like "brainwashing oil" or "disguised slave band" to indicate that girls should not buy them.  :P
For that matter, you could have a high badness item which girls do buy for themselves for whatever reason. Maybe have a small chance of them buying a drug when not currently addicted?

That'd be awesome! It'd also do away with some of the odder things like girls buying flowers for themselves somehow loving the player more. It'd give me an opportunity to flesh out happiness items like sweets vs romantic items like flowers or rings.

There's a related minor issue with girls buying weapons and armor for themselves, since the heavier ones come with a severe charisma penalty and having your star girl suddenly show up to work decked out in plate mail can cost you a lot of money. I think a good solution would be to let them buy combat gear if they want, but not let them equip it on their own. (Maybe with a happiness check somewhere so they'll still put it on if they're trying to run away or something.) Plus, even if there were no charisma penalty, from an in-universe perspective a brothel is not a place for a working girl to carry weapons around unsupervised, unless it's specifically her job to.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 22, 2010, 10:02:04 PM
Yeah, I'm going to make a big version 4 before long. At first I was going to wait until a relatively feature-complete release, but a lot of things do need at least some rebalancing right away. Plus the new stuff has given me many ideas for new items!

That'd be awesome! It'd also do away with some of the odder things like girls buying flowers for themselves somehow loving the player more. It'd give me an opportunity to flesh out happiness items like sweets vs romantic items like flowers or rings.

Cool. If you wanted to, you could get started by adding this to the appropriate items in Items.itemsx:
Code: [Select]
GirlBuyChance = "0%"That's the name I'll be using for it. You can of course go ahead and use whatever % you think is appropriate. For any items it's not specified on, it will treat them as before where <20 badness gives 100% chance of them buying it and >=20 badness gives 0% chance; so, no need to specify it for every item.
Title: Re: Bugs: 1.30 Alpha
Post by: NeliaHawk on May 22, 2010, 10:12:07 PM
can it be that the bar girl texts are a bit messed up?
i mean, girls that are set to "barmaid+barmaid" somehow do get waitress or stripper messages at the turn summary.
it seem to happen with all jobs (barmaid, waitress, singer atleast) exept the stripper. (not sure about the whore in bar... but she seem to be busy with customers as she should).
i think stripper are the only ones that do what they should do most of the time. atleast i havent seen them getting waitress or barmaid messages.

another thing i noticed a bit is, that when a girl is pregnant (human or beast, i think i have seen it with both) and gets an abortion and gets pregnant again by the player that turn, the pregnancy timer is the same as it was before the abortion.

i think currently pregnancies are 38 weeks? atleast most of the time... i think i saw some shorter/longer ones too somehow as the counter went down slower or faster... (i liked that btw, that it was not always 38 weeks... atleast its a magical fantasy world... demons might breed quicker? or the girl is influenced somehow that it just goes quicker then normal...  maybe even items (but i guess there are none like that atm))


and when you prohibit all sex actions in the brothel screen, you get some weird turn summary messages with the girls when they "would do a customer" when you press "next week".
as they are not allowed to do any "sex actions" but still "would do sex actions somehow for the message"
(also related to that is somehow this suggestion here: -> http://pinkpetal.org/index.php?topic=376.0)
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on May 23, 2010, 02:01:48 PM
Something else popped up. When you have a customer not paying and somebody that dies in the dungeon the game first tells you tha the customer can't pay, then tells you of the death\s and then prompts you for what to do with the customer. This happens at least about 9 times out of 10
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on May 23, 2010, 02:45:20 PM
I've set girls to strip in the bar and they do whore jobs, or at least that's how the text displays.
Title: Re: Bugs: 1.30 Alpha
Post by: ShadowMage on May 24, 2010, 12:33:10 PM
You're correct exodia91, I have seen it as well when setting girls to do the same thing. Not to mention seeing girls do BDSM when you've prohibited it
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 25, 2010, 11:26:16 PM
Fixed:
* even if user had config set to 0% chance of any one or more types of pregnancy, virgins would still have 10% chance of getting pregnant; the (somewhat odd) 10% chance boost for virgins is left alone for any chance over 0%, though
* girl details next/prev cycle order was not properly updating IDs when a girl was removed, resulting in a crash on moving on to the last girl
* when a girl becomes pregnant or inseminated, it now makes sure to clear any leftover pregnancy data (from abortions or what-not, pregnancy countdown and unborn child data)

I'll go ahead and make another release very shortly here.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 25, 2010, 11:48:45 PM
Since I'm releasing r397, here are the major included changes since the last release (r385):

* auto-buy healing potions and nets options were not reset on "new game"
* bank withdrawals should no longer be taxed; by extension, money taken from girls or given by scripts is no longer taxed
* bad items sent directly from the shop to a girl's inventory could still cause a crash
* dead girls can no longer be enslaved or sold in the dungeon
* multi-select should now be maintained when doing actions in the dungeon
* Girl sex enjoyment messages updated a bit
Updated:
* new clickable area on far right of listbox header which un-sorts the list back to the order the elements were originally added in; scrollbar and scroll up button are moved down to make room whenever it's shown
Updated:
* On Girl Details screen, sort order for previous/next girl functionality now matches the girl list sort order of the screen that called it (Girl Management or Dungeon)... so, you can sort the girls based on a specific stat and then view their details in that same order
Fixed:
* polished the "new rival" texts a bit for spacing and fixed he/she type gender indicators

Updated:
* gang training now works on a curve where they gain less the higher the skill/stat (but more at lower levels); however, they'll tend to focus training in what they're good at as well, so they should hopefully end up being better at certain skills and stats
* gang missions and combat will slightly boost appropriate gang stats/skills (not as much as training, though)
* all 6 important gang stats are now listed on the Gang Management screen; in other words, added Agility, Toughness (Constitution), and Charisma
Fixed:
* even if user had config set to 0% chance of any one or more types of pregnancy, virgins would still have 10% chance of getting pregnant; the (somewhat odd) 10% chance boost for virgins is left alone for any chance over 0%, though
* girl details next/prev cycle order was not properly updating IDs when a girl was removed, resulting in a crash on moving on to the last girl
* when a girl becomes pregnant or inseminated, it now makes sure to clear any leftover pregnancy data (from abortions or what-not, pregnancy countdown and unborn child data)

The r397 update with the above changes is available here (http://pinkpetal.org/index.php?topic=351.msg6965#msg6965).
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 26, 2010, 05:27:07 AM
Some more updates for the next release:
* girls should no longer automatically use consumables unless the item does something which seems useful to her at the time or makes her happy (no health potion when fully healthy, no "cure for X disease" when she doesn't have "X disease", etc.); they do still buys such items, though
* girls will now unequip all armor and weapon(s) before doing most mundane jobs like whoring, customer service, cleaning, etc.; however, girls with the following traits might refuse to do so: Aggressive, Yandere, Twisted, Retarded
* girls will likewise now equip their best (most expensive) armor and weapon(s) before doing "dangerous" jobs, such as exploring catacombs, capturing beasts, or providing security; however, Retarded girls might refuse to do so
* Items.itemsx now parses new optional GirlBuyChance % value [if not specified, chance now defaults to (100% - (badness level * 5)), so 20 or more badness is 0% chance, 5 badness is 75% chance, etc.]
    This GirlBuyChance % value is checked when a girl is on free time and shopping, and has looked at a random shop item, instead of it just checking the Badness value as it used to.
So, example item (no, the chance shown for this particular item isn't sensible):
    <Item
        Name="Basic Makeup"
        Desc="This common makeup kit allows a girl to make herself prettier, though the options it offers are limited. (+8 Bea, temporary)"
        Type="Food"
        Badness="0"
        Special="Temporary"
        Cost="75"
        Rarity="Shop05"
        GirlBuyChance="60"
        Infinite="false">
        <Effect
            What="Stat"
            Name="Beauty"
            Amount="8" />
    </Item>
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 26, 2010, 05:47:11 AM
Nice. Does the calculation take account of whether she already has 5 boxes of basic makeup? (or one suit of generic chainmail, I suppose?)

I'd check myself, but I'm at work, and can't access pinkpetal SVN from here.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 26, 2010, 06:21:06 AM
Nice. Does the calculation take account of whether she already has 5 boxes of basic makeup? (or one suit of generic chainmail, I suppose?)

I'd check myself, but I'm at work, and can't access pinkpetal SVN from here.

For checking on whether she uses consumables, it checks each item individually based on her current stats; a few stat increases result in her using it whether it helps or not, though, like happiness and beauty (as the notes in the code indicate, call it vanity or greed or whatever you like; 100 happiness? so what, she still wants to eat that chocolate), while others will have her react more sensibly (health, mana, constitution, etc.). Of note though, if any one of the item effects is something she wants, she'll choose to use the item; it doesn't matter if there were a bunch of more important effects the item was actually focused on. Still, from my brief testing it seems to work nicely.
As for buying such items, I haven't changed anything there other than the switching the basic Badness check (>20 = no, <=20 yes) for the new GirlBuyChance value.

For unequipping combat items, they just scan through their inventory and unequip any weapons or armor present.
For equipping combat items, they scan through their inventory and find the best armor item and best weapons (up to 2 weapons, of course) based on the item costs (more expensive must be better, right? right? eh), and equips those.
Title: Re: Bugs: 1.30 Alpha
Post by: TF on May 26, 2010, 07:00:02 AM
Noticed something a bit funky... It seems that the pregnancy countdown only works if a girl is under my control. This means that if I get a girl pregnant and sell her, the pregnancy is, in effect, put on hold. I don't know if children reaching maturity works the same way since it's much harder to track, but I presume so.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 26, 2010, 07:39:05 AM
Noticed something a bit funky... It seems that the pregnancy countdown only works if a girl is under my control. This means that if I get a girl pregnant and sell her, the pregnancy is, in effect, put on hold. I don't know if children reaching maturity works the same way since it's much harder to track, but I presume so.

Yeah, thinking about it, it does only do the pregnancy-related checks for girls you control. I'll see about having it update other girls outside of your control, but no promises; I recall at least a few places in the pregnancy monitoring code where it clearly assumes you control the girl, so it might be a real pain to take care of.
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 26, 2010, 07:47:34 AM
could do something like have an infinite, invisible brothel that gets no customers, but holds all the girls that the player doesn't employ. Then you could process the NPC brothel at the end of each turn, and the girls would be included in the update loop.

Of course, this has other potential pitfalls, since it would also progress diseases and addictions. Girls would die and turn up the player's dungeon. So would player daughters when they came of age, as well. That might be fair enough if she gives birth to them before being sold.
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on May 26, 2010, 07:34:29 PM
well one solution is to just assume that she either got an abortion or gave birth when you sell a girl and have it dump the pregnancy at that point, myself I'd assume abortion, to make it simpler, no extra scripting to add milf to a girl you might never use again. you also wouldn't have to detect if it was a child by player (though  hat would create interesting script events) and then keep track of it, and all the other stuff involved.
Title: Re: Bugs: 1.30 Alpha
Post by: FurryFanatic on May 26, 2010, 07:42:57 PM
An interesting scripted event from selling a girl who happens to be pregnant at the time would be to attach the rival event that states the rival comes from you raping his/her mother and then discarding her.  I would almost say to put it as a possibility of creating several rivals showing up at the end of one turn instead of just one every so often.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 26, 2010, 08:45:57 PM
Quote
* girls will now unequip all armor and weapon(s) before doing most   mundane jobs like whoring, customer service, cleaning, etc.; however,   girls with the following traits might refuse to do so: Aggressive,   Yandere, Twisted, Retarded

One small problem here: Underwear items are currently being used under armour since a) This allows you to combine it with dresses (clothing) and b) Misc. lets you stack multiples of the same item.  We may need a new item slot type here for undergarments.
Title: Re: Bugs: 1.30 Alpha
Post by: crazy on May 26, 2010, 08:58:12 PM
could do something like have an infinite, invisible brothel that gets no customers, but holds all the girls that the player doesn't employ. Then you could process the NPC brothel at the end of each turn, and the girls would be included in the update loop.

Of course, this has other potential pitfalls, since it would also progress diseases and addictions. Girls would die and turn up the player's dungeon. So would player daughters when they came of age, as well. That might be fair enough if she gives birth to them before being sold.

The girls you sell could go to a different slave market maybe.  Idk how the slave market is coded but that would keep the randoms girls you sold from showing back up in the normal slave market.  And if the stuff had to progress atleast it woudnt do it to girls you didn't sell..  just a thought might not work
Title: Re: Bugs: 1.30 Alpha
Post by: RyRain on May 27, 2010, 02:39:46 AM
Noticed an interesting bug. Sometimes if I ask to do something with a girl, it won't increase the related skill if that skill is currently at 0 despite the girl agreeing to it. If I force and get the skill to 1% though, it will start increasing by asking.
Title: Re: Bugs: 1.30 Alpha
Post by: James on May 27, 2010, 08:38:53 PM
dont know if this is intentional or not, but using a L incense of serenity (tiredness-100) on a construct girl, might only lower it by like 4.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 27, 2010, 10:05:38 PM
Odd bug in this version; if you transfer an item from the store directly to a girl, it doesn't deplete stock.  Things behave normally if you transfer from the store to the player.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 28, 2010, 01:58:41 AM
dont know if this is intentional or not, but using a L incense of serenity (tiredness-100) on a construct girl, might only lower it by like 4.

I'm not sure if that amount is really appropriate, but I believe the difference for Construct girls is intended.


Odd bug in this version; if you transfer an item from the store directly to a girl, it doesn't deplete stock.  Things behave normally if you transfer from the store to the player.

Confirmed and fixed.


Fixes and updates committed:
* girls shouldn't buy things like brainwashing oil and disguised slave collars for themselves any more, among other things; thanks to LordShame for updating all appropriate items
* updated WMEdit supporting new GirlBuyChance value provided by Solo761
* non-unique girls who are sold or fired are now simply removed from the game, though unique girls are still kept
* items bought from shop directly into a girls inventory were not depleting shop stock properly
* pregnant girls not controlled by player (should only be uniques, sold/fired by player) have their pregnancies handled just like girls controlled by the player; there are of course no announcements though and nothing gained by the player, and grown daughters are added to the buyable/recruitable girls
Title: Re: Bugs: 1.30 Alpha
Post by: vanpett on May 28, 2010, 06:53:39 AM
Some bugs I noticed (version r397):

- When you have girls with similar names in the same brothel, all item effects disappear from all but the latest girl. This includes stats and traits (e. g. "cute" from the bunny slippers).

- If a girl's inventory is full, you can only remove items via the shop menu, not the girl details menu. (Message "Inventory is already full" or something like that.) This is only a minor inconvenience.

Oh, and one request (I know this isn't really a bug, it's just bugging me ::) ): It would be really great if either the "Transfer Girls"-List could be sorted alphabetically or if it would be possible to transfer a girl directly via the girl details menu. It's quite annoying to look for a specific girl in an unsorted list with 200+ names with a lot of those names being similar.

Thanks in advance!
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 28, 2010, 08:32:15 PM
One thing I've noticed that I'm not sure if it's a bug or intended; if a character is missing a certain type of image, it just pulls up a random image from that character's folder. In older versions, it used to grab an image from the correct category in the default folder.  I don't really care either way, but just throwing it out there in case this wasn't an intended change.
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on May 28, 2010, 09:11:12 PM
Oh, and one request (I know this isn't really a bug, it's just bugging me ::) ): It would be really great if either the "Transfer Girls"-List could be sorted alphabetically or if it would be possible to transfer a girl directly via the girl details menu. It's quite annoying to look for a specific girl in an unsorted list with 200+ names with a lot of those names being similar.

Thanks in advance!
ya, that would be nice. maybe they could have a "relocate" button, instead of "send to dungeon". or something like that. then it askes where you want to send her, giving the list of brothels you have and the dungeon, and a never mind option. I know I've accidently sent a *few* girls to the dungeon through a miss click or two.
Title: Re: Bugs: 1.30 Alpha
Post by: dalmedya on May 28, 2010, 10:30:58 PM
Clicking on the Quit button quits, when it should ask if you want to quit.
And yes I did just lose 15 minutes of micromanagement because I missed the Save button.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 29, 2010, 06:17:07 AM
- When you have girls with similar names in the same brothel, all item effects disappear from all but the latest girl. This includes stats and traits (e. g. "cute" from the bunny slippers).

Similar names, or the exact same name? Can you provide a savegame exhibiting the problem?
 

- If a girl's inventory is full, you can only remove items via the shop menu, not the girl details menu. (Message "Inventory is already full" or something like that.) This is only a minor inconvenience.

  The Item Management screen is the same whether accessed from the shop in town or through the Girl Details screen, the only difference should be which inventories (player, shop, girls) are initially selected. Again, can you provide a savegame? I might be able to reproduce this one myself with a little work, but having a savegame of it would be easier.


Oh, and one request (I know this isn't really a bug, it's just bugging me ::) ): It would be really great if either the "Transfer Girls"-List could be sorted alphabetically or if it would be possible to transfer a girl directly via the girl details menu. It's quite annoying to look for a specific girl in an unsorted list with 200+ names with a lot of those names being similar.

Thanks in advance!

That'll come up whenever I get back to converting the last few screens over to XML layout. Not sure when that'll be, though.


One thing I've noticed that I'm not sure if it's a bug or intended; if a character is missing a certain type of image, it just pulls up a random image from that character's folder. In older versions, it used to grab an image from the correct category in the default folder.  I don't really care either way, but just throwing it out there in case this wasn't an intended change.

If you're talking about sex-related images, it's always been that way; for any missing specific sex type images, it will use the standard sex images instead. If you're talking about something like the "this girl has gotten pregnant" Turn Summary image, those still are giving the default pregnant image from what I've seen.


ya, that would be nice. maybe they could have a "relocate" button, instead of "send to dungeon". or something like that. then it askes where you want to send her, giving the list of brothels you have and the dungeon, and a never mind option. I know I've accidently sent a *few* girls to the dungeon through a miss click or two.

Not a bad idea. I might see about doing that, but no promises; it could turn out being more work than I'd feel like sinking into it.


Clicking on the Quit button quits, when it should ask if you want to quit.
And yes I did just lose 15 minutes of micromanagement because I missed the Save button.

Heh, fair enough. I'll see about adding an "Are you sure you really want to quit? y/n" message there.
Title: Re: Bugs: 1.30 Alpha
Post by: vanpett on May 29, 2010, 10:32:23 AM
Similar names, or the exact same name? Can you provide a savegame exhibiting the problem?
 

I meant the exact same name. But upon further examination it seems the problem is not that the stats are not altered anymore, but that the items of the latest girl with the given name are shown in the inventory of every girl with this name.

A save game is attached. I've filled the inventory of the top girl in my first brothel ("Hana") for you to reproduce what I meant. If you go to this girls detail screen, you can't access her inventory. But as I already said: This is only a minor inconvenience.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 30, 2010, 02:25:43 PM
I meant the exact same name. But upon further examination it seems the problem is not that the stats are not altered anymore, but that the items of the latest girl with the given name are shown in the inventory of every girl with this name.

A save game is attached. I've filled the inventory of the top girl in my first brothel ("Hana") for you to reproduce what I meant. If you go to this girls detail screen, you can't access her inventory. But as I already said: This is only a minor inconvenience.

Thanks, I'll check it out.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 30, 2010, 06:42:27 PM
Fixed:
* Girl Details screen wouldn't let you go to manage a girl's inventory if it was full
* When going to Inventory Management from Girl Details screen, it would select the girl based on the name, so it could choose incorrectly if you had any girls with identical names
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 30, 2010, 09:00:58 PM
Fixed:
* animated images would get stuck on the image surface, where it couldn't then be changed to a non-animated one
* new girl packs were not being imported properly when loading a saved game, though the .gam.mast file was being updated
    as a result, for older savegames, you'll need to manually edit the .gam.mast file to delete out any files which you know aren't really loaded in order to get them to actually import at this point; new savegames should have no problem
Title: Re: Bugs: 1.30 Alpha
Post by: crazy on May 30, 2010, 09:45:01 PM
Ive actually had time to play the game the past few nights and i noticed one thing customer happiness in my brothels never goes above low.  Was the requirements to get it up changed or is it a bug?  If anyone is getting there up to high maybe they can tell me how so i can do that i have a girl on every job but as i said it never goes above low.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 30, 2010, 09:52:50 PM
Ive actually had time to play the game the past few nights and i noticed one thing customer happiness in my brothels never goes above low.  Was the requirements to get it up changed or is it a bug?  If anyone is getting there up to high maybe they can tell me how so i can do that i have a girl on every job but as i said it never goes above low.
Not sure. I was planning to eventually look into that, but I think WonderDog did something on that front along with fame so I took it off my list. I guess I should still look into it at some point.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 31, 2010, 12:06:13 AM
Yeah, I can confirm I've never seen it have a value beyond 'low' in 1.30.  I recall it going to higher values in 1.29, but even then it was VERY difficult and seemingly random to accomplish this.  And even then, it usually dropped by the next couple turns.  I think there might simply be too many variables pushing it down, and not enough pushing it up.  It might not be worth looking into until the bar and gambling hall jobs get fleshed out more.
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 31, 2010, 12:17:10 AM
Alright, here's a tiny, ridiculously inoffensive one that I'm mentioning only for the principle of the thing: when a girl is pregnant, the profile section in the gallery shows the images from the pregnant section instead of the regular profile pics.

Earth-shattering, isn't it?
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 31, 2010, 01:54:34 AM
That one's always bugged me, too... Give me ten minutes ...

[edit]

/me fiddles with gallery code
/me introduces nasty bug that hangs the game

talk amongst yourselves for a while ...

[edit]

Fixed in svn
Title: Re: Bugs: 1.30 Alpha
Post by: dalmedya on May 31, 2010, 05:44:35 AM
Gangs seem to recruit for other gangs. If you have 3 gangs with less-than-max members, and one recruits, all 3 might go up.

Not exactly bugs, but certainly things that really should be included:

If a girl is pregnant (and I assume inseminated as well) and buys an abortion item, she'll use it right away. Perhaps abortion items should be excluded from automatic usage?
Turn summary doesn't list what items the girl bought, only that she went shopping.
Currently, 'ageless' girls are set up to use an age of 100 = 'Unknown'. Perhaps it should be a trait instead, so those nasty age-changing items don't break things?
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on May 31, 2010, 05:49:09 AM
The stop feeding button never toggles into the start feeding button. Once you stop their food, the only way to start is to release them from the dungeon.
Title: Re: Bugs: 1.30 Alpha
Post by: Sigfried666 on May 31, 2010, 10:13:43 AM
Alright, here's a tiny, ridiculously inoffensive one that I'm mentioning only for the principle of the thing: when a girl is pregnant, the profile section in the gallery shows the images from the pregnant section instead of the regular profile pics.

I always tought that was simply because pregnancy is a visible thing, and you should be able to notice she is preganant by looking at her...
Title: Re: Bugs: 1.30 Alpha
Post by: LordShame on May 31, 2010, 10:48:20 AM
Of course, it's normal for the preg images to be seen on the main girl details screen, but we're talking about the gallery screen where all of the girl's pics are available at all times. I don't think you have anything to worry about.  ;)
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on May 31, 2010, 12:01:48 PM
Gangs seem to recruit for other gangs. If you have 3 gangs with less-than-max members, and one recruits, all 3 might go up.
   
When doing non-stressful activities, I think gangs normally regain 1 lost member per week. Of course, if you set them to recruit they gain something like 3 per week. I expect that's what you saw.


If a girl is pregnant (and I assume inseminated as well) and buys an abortion item, she'll use it right away. Perhaps abortion items should be excluded from automatic usage?
   
This is already taken care of in the upcoming patch; abortion items are no longer directly bought by girls themselves, among other things.


Turn summary doesn't list what items the girl bought, only that she went shopping.
 
I've thought about that before, but it slipped my mind before I noted it down. I'll go ahead and note it.


  Currently, 'ageless' girls are set up to use an age of 100 = 'Unknown'. Perhaps it should be a trait instead, so those nasty age-changing items don't break things?

Might work better that way, yeah. It seems to work fine currently, though, so I'm not too inclined to mess with it any time soon.


The stop feeding button never toggles into the start feeding button. Once you stop their food, the only way to start is to release them from the dungeon.

It's the "Allow Food" button just below the "Stop Feeding" button. They're separate so you can multi-select and easily choose one or the other.
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on May 31, 2010, 02:06:49 PM
Does a girl hunting beasts have a small chance to get a monster girl? Because I had one pop up in my dungeon and I had no one in the catacombs. When it happened other times I just thought it might be a bug with the catacombs girl not reporting the right amount of girls captured but after this I think it's related with beast hunting.

Just a small idea I had could it be possible for the girls that go in the catacombs to keep some of the items if they feel they need them?
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on May 31, 2010, 10:20:22 PM
Found a new bug: If you give a girl an item that will kill her (ie reduces health to 0 or less) the game will crash.
Title: Re: Bugs: 1.30 Alpha
Post by: HuiBui on June 01, 2010, 08:14:47 AM
Are these bugs ?

For the very first time i've sent a girl into the catacombs ( i thougt well equipped ) but was getting back raped , without money , cool scars .....
similar i sent a gang inzo catacombs . They got back only with money. BUT... in my dungeon suddenly i found two monster girls ????

Another thing for what i'm not shure : some girls i told to work in the bar : Barmaid , stripper etc... But they don't do what I have told them. The stripper works as a barmaid , the barmaid sometimes as a waitress...

attached my latest saving file
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 01, 2010, 08:28:43 AM
Yeah, the bar jobs are basically a stub. Which job a girl actually does is purely random, and only the whoring is developed in any detail as yet.

Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 01, 2010, 10:59:31 AM
Found a new bug: If you give a girl an item that will kill her (ie reduces health to 0 or less) the game will crash.

Can you provide a savegame?
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on June 01, 2010, 05:46:59 PM
the game will also crash if you're veiwing the profiles and it goes to switch to the dead girl's profile(I was in the dungeon, sorting out girls and she was the only girl left).
Title: Re: Bugs: 1.30 Alpha
Post by: exodia91 on June 01, 2010, 06:28:12 PM
I was under the impression that pregnant sex act pictures were implemented, however I just noticed I have never seen my girls use one, ever, they always default to their usual sex pics.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on June 01, 2010, 07:37:58 PM
Can you provide a savegame?
Savegame not needed, instead here's the item list I use with my game.  Just start a game in test mode and have a girl use the Death Potion item I was testing (only effect is -100 health) to 'delete' unwanted girls until the next build fixes that issue.  It won't crash right away, but as soon as you try to leave the manage items screen it will every time.

Quote
the game will also crash if you're veiwing the profiles and it goes to   switch to the dead girl's profile(I was in the dungeon, sorting out   girls and she was the only girl left).
This is probably the actual cause of the bug then.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 02, 2010, 05:23:47 AM
Savegame not needed, instead here's the item list I use with my game.  Just start a game in test mode and have a girl use the Death Potion item I was testing (only effect is -100 health) to 'delete' unwanted girls until the next build fixes that issue.  It won't crash right away, but as soon as you try to leave the manage items screen it will every time.
This is probably the actual cause of the bug then.

Ah, this one appears to have already been fixed then.


Updates committed:
* girls get the week off when they give birth
* injury system reworked slightly; injuries can now potentially result in unintended abortion if pregnant, which is distressing for the girl in question
* when girls buy stuff in their free time, it now indicates everything they bought in their Turn Summary info


I'll go ahead and post a new version shortly.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 02, 2010, 05:38:31 AM
Since I'm releasing r415, here are the major included changes since the last release (r397):

* girls should no longer automatically use consumables unless the item does something which seems useful to her at the time or makes her happy (no health potion when fully healthy, no "cure for X disease" when she doesn't have "X disease", etc.); they do still buys such items, though
* girls will now unequip all armor and weapon(s) before doing most mundane jobs like whoring, customer service, cleaning, etc.; however, girls with the following traits might refuse to do so: Aggressive, Yandere, Twisted, Retarded
* girls will likewise now equip their best (most expensive) armor and weapon(s) before doing "dangerous" jobs, such as exploring catacombs, capturing beasts, or providing security; however, Retarded girls might refuse to do so
* Items.itemsx now parses new optional GirlBuyChance % value [if not specified, chance now defaults to (100% - (badness level * 5)), so 20 or more badness is 0% chance, 5 badness is 75% chance, etc.]
    This GirlBuyChance % value is checked when a girl is on free time and shopping, and has looked at a random shop item, instead of it just checking the Badness value as it used to.
So, example item (no, the chance shown for this particular item isn't sensible):
    <Item
        Name="Basic Makeup"
        Desc="This common makeup kit allows a girl to make herself prettier, though the options it offers are limited. (+8 Bea, temporary)"
        Type="Food"
        Badness="0"
        Special="Temporary"
        Cost="75"
        Rarity="Shop05"
        GirlBuyChance="60"
        Infinite="false">
        <Effect
            What="Stat"
            Name="Beauty"
            Amount="8" />
    </Item>
* girls shouldn't buy things like brainwashing oil and disguised slave collars for themselves any more, among other things; thanks to LordShame for updating all appropriate items
* updated WMEdit supporting new GirlBuyChance value provided by Solo761
* non-unique girls who are sold or fired are now simply removed from the game, though unique girls are still kept
* items bought from shop directly into a girls inventory were not depleting shop stock properly
* pregnant girls not controlled by player (should only be uniques, sold/fired by player) have their pregnancies handled just like girls controlled by the player; there are of course no announcements though and nothing gained by the player, and grown daughters are added to the buyable/recruitable girls
Fixed:
* Girl Details screen wouldn't let you go to manage a girl's inventory if it was full
* When going to Inventory Management from Girl Details screen, it would select the girl based on the name, so it could choose incorrectly if you had any girls with identical names
Fixed:
* animated images would get stuck on the image surface, where it couldn't then be changed to a non-animated one
* new girl packs were not being imported properly when loading a saved game, though the .gam.mast file was being updated
    as a result, for older savegames, you'll need to manually edit the .gam.mast file to delete out any files which you know aren't really loaded in order to get them to actually import at this point; new savegames should have no problem
* girls get the week off when they give birth
* injury system reworked slightly; injuries can now potentially result in unintended abortion if pregnant, which is distressing for the girl in question
* when girls buy stuff in their free time, it now indicates everything they bought in their Turn Summary info

Also, fixed by docclox:
* Gallery mode no longer shows pregnant images in the profile slot
* tweaked the bar working enjoyment


The r415 update with the above changes is available here (http://pinkpetal.org/index.php?topic=351.msg7126#msg7126).
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 02, 2010, 06:08:05 AM
Actually, I think I mildly messed up the bar working code - I hadn't realised +3 was standard throughout the jobs. It's not going to hurt anything much - just means that girl's enjoyment will grow slower for bar work than other activities.

I might take a look at it tonight - I'd quite like to turn the four bar jobs into separate activities, anyway.
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on June 02, 2010, 11:01:08 AM
There seems to be a problem with the new girls going off work for birth and girls with the incorporeal trait. After more than 4 weeks I had to manually change the old jobs in new ones and then back again to have her work again instead of taking time off even if the old jobs where selected
Title: Re: Bugs: 1.30 Alpha
Post by: Tempies on June 02, 2010, 02:07:02 PM
I'm wondering if there was a way to have a single button to click through the Week turn end news/event and even getting a Filter option on the type of events/news that are shown?

Title: Re: Bugs: 1.30 Alpha
Post by: FurryFanatic on June 02, 2010, 03:14:27 PM
Is there any way we can see the girls' libido stat? I have several girls who I have to keep off duty for weeks on end because they just don't "feel in the mood."
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 02, 2010, 05:54:22 PM
There seems to be a problem with the new girls going off work for birth and girls with the incorporeal trait. After more than 4 weeks I had to manually change the old jobs in new ones and then back again to have her work again instead of taking time off even if the old jobs where selected

... What exactly is happening, now? You're saying girls with the Incorporeal trait who give birth are somehow getting stuck doing nothing each week, or what?


I'm wondering if there was a way to have a single button to click through the Week turn end news/event and even getting a Filter option on the type of events/news that are shown?

Maybe I'm just too tired lately, but I can't really make sense of this one either. Can you clarify?


Is there any way we can see the girls' libido stat? I have several girls who I have to keep off duty for weeks on end because they just don't "feel in the mood."

Not currently, no. We might add display of that along with other hidden stats at some point. As for them not feeling in the mood, it doesn't actually hurt anything other than a very minor -2 happiness drop. Libido does probably need to be reworked a little so that it's boosted more in certain situations (if the girl really enjoys it, or if she has certain traits, or similar) and likewise not dropped as much in certain situations.
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 02, 2010, 06:48:26 PM
Maybe I'm just too tired lately, but I can't really make sense of this one either. Can you clarify?

I think it's a request to change the way the turn summary screen works. What he'd like is a message pane with a forward and back buttons that cycled through every message in the list, along with a drop down box that lets you filter the sort of messages you see. It's not a bad idea, but it'd mean rewriting the screen, and probably half the message recording code.

Might I suggest you take a bit of a break? Maybe play something instead of developing? We don't want you burning out on this, and it's easy to do  :)
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on June 03, 2010, 01:45:22 AM
I'll try to be clearer:
Incorporeal girl ives birth and has week off
For the next 2-3 weeks she just rests bith shifts so by the go to selected on the summary screen I go to check her
The work tabs indicated that she has work to do and as expected health is 100 and tiredness 0 so I leave without doing anything
I advance to the next week and check the girl again, she still is only resting
I go to her screen again and this time I try changing what work she has and the going back to the old one (example. whore in bar is selected, I click on, say, Barmaid and the back on whore in bar)
Advance to next week
The girl is working again
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 03, 2010, 02:45:55 AM
I think it's a request to change the way the turn summary screen works. What he'd like is a message pane with a forward and back buttons that cycled through every message in the list, along with a drop down box that lets you filter the sort of messages you see. It's not a bad idea, but it'd mean rewriting the screen, and probably half the message recording code.

Ah, sounds like a decent enough request to look into at some point. The Turn Summary screen could indeed do with an overhaul. I was planning to do a little something to improve it eventually when I switch it to XML layout.


  Might I suggest you take a bit of a break? Maybe play something instead   of developing? We don't want you burning out on this, and it's easy to   do  :)
 

  Nah, I'm good. I just haven't gotten much sleep much the past few days, and I've only done marginal coding for WM during that time.


I'll try to be clearer:
Incorporeal girl ives birth and has week off
For the next 2-3 weeks she just rests bith shifts so by the go to selected on the summary screen I go to check her
The work tabs indicated that she has work to do and as expected health is 100 and tiredness 0 so I leave without doing anything
I advance to the next week and check the girl again, she still is only resting
I go to her screen again and this time I try changing what work she has and the going back to the old one (example. whore in bar is selected, I click on, say, Barmaid and the back on whore in bar)
Advance to next week
The girl is working again

Thanks, understood. Strange. I can't figure off the top of my head how that might be happening based on the code. Can you post a savegame? I don't have any with Incorporeal girls at the moment.
EDIT: nevermind, I think I just found it... yeah, I was tired. :P  This probably calls for another quick bugfix release.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 03, 2010, 07:09:42 AM
Since I'm releasing r416, here are the major included changes since the last release (r415):

* Now all extra "hidden" stats for girls are shown on More Details for debugging/reference data
* girls were getting stuck on Free Time after giving birth  (pretty serious bug, the reason I went ahead and released r416 already)


The r416 update with the above changes is available here (http://pinkpetal.org/index.php?topic=351.msg7137#msg7137).
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on June 04, 2010, 12:27:03 AM
Now that I can see the numbers, whoring seems to be driving down libedo to an unreasonable degree.  In fact, it's clearly going into negatives as I have several girls with 0 libedo despite having several items with +libedo.  Buying new items with +lidebo does not increase it past 0.  The problem here is that famous girls getting 4+ customers a shift are taking small happiness hit for each customer due to having 0 libedo.  In some cases, they're losing over 10 hapiness a turn from one whoring shift.  The happiness value stabilizes so long as you have Free Time as the other shift, but if you have her try to do two actions happiness starts dropping fast.  In all cases, these girls 'Love working as a whore', yet from the numbers clearly do not love working as a whore.  It doesn't make much sense that someone pleasing 7 customers a day has no sex drive whatsoever.  A couple changes I'd suggest here:

-Libedo, and really any stat, should not go below 0.  How can you have a negative attritute or skill?  You're so bad at something that you make the people around you less skilled just by being in the room?  I didn't really like the rebelliousness change to go into negatives either.  To me 0 rebelliousness means that person will not refuse anything, yet 0 rebeliousness in game is still somewhat high.
-Whoring job satisfaction should negate and eventually reverse the libedo loss for each sex act.
Title: Re: Bugs: 1.30 Alpha
Post by: GonDra on June 04, 2010, 11:28:54 AM
Bug in 1.30 alpha r416: It is still possible to resurrect DEAD girls with some healing item, by giving it to them through the item menu.

Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on June 05, 2010, 10:30:23 AM
A matron that has a week off due to birth still keeps taking other girls off work if they are too tired
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 05, 2010, 11:05:15 AM
Now that I can see the numbers, whoring seems to be driving down libedo to an unreasonable degree.  In fact, it's clearly going into negatives as I have several girls with 0 libedo despite having several items with +libedo.  Buying new items with +lidebo does not increase it past 0.  The problem here is that famous girls getting 4+ customers a shift are taking small happiness hit for each customer due to having 0 libedo.  In some cases, they're losing over 10 hapiness a turn from one whoring shift.  The happiness value stabilizes so long as you have Free Time as the other shift, but if you have her try to do two actions happiness starts dropping fast.  In all cases, these girls 'Love working as a whore', yet from the numbers clearly do not love working as a whore.  It doesn't make much sense that someone pleasing 7 customers a day has no sex drive whatsoever.  A couple changes I'd suggest here:

-Libedo, and really any stat, should not go below 0.  How can you have a negative attritute or skill?  You're so bad at something that you make the people around you less skilled just by being in the room?  I didn't really like the rebelliousness change to go into negatives either.  To me 0 rebelliousness means that person will not refuse anything, yet 0 rebeliousness in game is still somewhat high.
-Whoring job satisfaction should negate and eventually reverse the libedo loss for each sex act.

Having looked into the Libido situation...
It appears the game track original stats (m_Stats), permanent stat modifications (m_StatMods, not limited to +/-100), and temporary stat modifications (m_Stats, doesn't appear to be used much). Whenever the game checks a stat, it combines those three values for the stat. With libido, whoring just keeps piling more and more negative points to m_StatMods; I don't know about the other stats, though a few of the numbers look way out of whack. As an example for libido, I had a girl with 20 base libido, -320 permanent stat modification for libido, and +16 temporary stat modification, so for all intents and purposes the game sees that as 0 libido.
Hmm.
I'll dig a bit deeper to see if other currently permanent stat changes are appropriate or not; a few of the other numbers I'm seeing look quite out of whack as well. Libido should certainly only be changed temporarily by whoring rather than permanently. As for the temporary stat changes, they currently normalize towards zero by 1 point per week; I'm thinking it might be better to have it chop off 30-50% (or 1, if 30-50% < 1) of each temporary stat change value each week.


Bug in 1.30 alpha r416: It is still possible to resurrect DEAD girls with some healing item, by giving it to them through the item menu.

Thanks for the report, I'll fix that.


A matron that has a week off due to birth still keeps taking other girls off work if they are too tired

Hmm, true... I think I'll leave that one alone, though, since it's a minor convenience (:P) and would be a bit of a nuisance to fix by piling on some extra code.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 05, 2010, 12:31:18 PM
Committed:
* permanent stat modifications should now be limited to +/- 100 in almost every case
* temporary stats changes now normalize towards 0 by 30% each week instead of by 1 point each week
* most libido changes are now temporary (largest portion from doing jobs), not permanent

EDIT: and:
* dead girls can no longer equip or use any items (no more resurrecting by giving a healing item)
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 06, 2010, 01:29:18 PM
* new item category "Small Weapon", covering daggers and whips and such; small weapons are considered concealable or acceptable for normal carry and are never automatically unequipped unlike regular weapons; max equipped: 1
* code for girls buying items in their free time is rewritten further to consolidate otherwise re-re-re-re-repeated code
* Starting a new "Test" (cheat) game no longer gives you Ayanami Rei; not sure why that was there, since you can Walk Around Town infinite times in cheat mode
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on June 06, 2010, 06:53:33 PM
Any chance we could get an 'Underwear' category while you're making changes to items?  Right now we're forced to set them as Armour to avoid conflicts with clothing, but this of course prevents them from using actual armour and underwear at the same time.
Title: Re: Bugs: 1.30 Alpha
Post by: ChaosKishin on June 07, 2010, 06:12:10 PM
This might be related to the whole Libido thing, and it's probably not a bug, but I've noticed that my girls that are really 'tough' (ex: they don't tire as easily and so don't take free time as often) are taking huge happiness hits.  It might be a good idea to have the Matron take girls off work when they hit a certain threshold of happiness.
Title: Re: Bugs: 1.30 Alpha
Post by: dalmedya on June 08, 2010, 03:08:19 AM
It seems like MILF and Lolita are getting randomly applied to girls of certain ages if nothing is specified in the rgirlsx file.  While this is intended and understandable for girls at the minimum age, and women in their 30s, Lolita is showing up on 20 year olds.
Considering the game is hard-coded to display girls as being 17+, and the term 'lolita' is typically applied to ages 8-14, I think it's fine.
I'm more concerned with the inaccurate text; 'sexually active' isn't quite right. Perhaps 'flirtatious' would fit better.

Quote
A bug I just noticed in my current game; the 'Have X monster girls' mission isn't actually checking for the Not Human trait.  X girls of any sort will meet the conditions.
Actually, the error there is the 'monster' part of the text, there are two separate missions with that same text, one for normal girls and one for monster girls. The second one does actually check for monster girls correctly.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 08, 2010, 07:43:05 PM
Any chance we could get an 'Underwear' category while you're making changes to items?  Right now we're forced to set them as Armour to avoid conflicts with clothing, but this of course prevents them from using actual armour and underwear at the same time.

Underwear is clothing, so it could be classified as such. If you are considering them as wearing it under clothing, how then is it applying changes to how they look with it being effectively hidden? Perhaps if I did add an underwear category I should then have girls unequip regular clothes for some activities then; how else would the other person even see them to be affected by them, with them being hidden under regular clothing?  ::)
You're not "forced" to set them as armour, that's a hack which you choose to do. It is not done in the core included items file, so I assume it's affecting an items file you're working on.
If you want to have your girls walk around in just underwear, perfect, they can be made as regular "dress" type items like our core included items file by LordShame does it.

I'm not adamantly against an underwear category or anything like that, though. I'll add it if there's enough outcry for it. Feel free to create a topic discussing it; this one is mainly for reporting actual bugs and for update notes.


This might be related to the whole Libido thing, and it's probably not a bug, but I've noticed that my girls that are really 'tough' (ex: they don't tire as easily and so don't take free time as often) are taking huge happiness hits.  It might be a good idea to have the Matron take girls off work when they hit a certain threshold of happiness.

Fair enough thing for the Matron to handle, I guess. In the meantime, you might try not working your girls 24 hours a day until they nearly collapse from exhaustion or despair.  :D


It seems like MILF and Lolita are getting randomly applied to girls of certain ages if nothing is specified in the rgirlsx file.  While this is intended and understandable for girls at the minimum age, and women in their 30s, Lolita is showing up on 20 year olds.

I'll check into the age ranges for these.


A bug I just noticed in my current game; the 'Have X monster girls' mission isn't actually checking for the Not Human trait.  X girls of any sort will meet the conditions.
Actually, the error there is the 'monster' part of the text, there are two separate missions with that same text, one for normal girls and one for monster girls. The second one does actually check for monster girls correctly.

I'll check on this one as well.


Girls in this build are unequipping armour regardless of whether it is harmful to them or not.  Considering all underwear type items are currently 'armour', this is kind of a problem.

See above for discussion on your special underwear armor.
Armor is indeed always unequipped for doing most jobs not related to combat (assuming the girl doesn't refuse). A change to have them only remove armor if it's "harmful" in any way was considered, but I haven't made it yet and it's not a high priority for me.
Title: Re: Bugs: 1.30 Alpha
Post by: ChaosKishin on June 08, 2010, 07:50:57 PM
Fair enough thing for the Matron to handle, I guess. In the meantime, you might try not working your girls 24 hours a day until they nearly collapse from exhaustion or despair.  :D

You're probably right, but I very rarely put girls on more then a single shift of whoring. Usually, it's whore during the day and practice at night.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 08, 2010, 09:23:31 PM
a) if underwear and dresses are meant to compete for the same item slot, you might as well delete all the underwear because they're now completely redundent items
 
By that logic, you might as well delete all but one dress. They're all redundant and variety of items in the same category is pointless, right?


b) there are real weapons and armour (generally more expensive or catacomb only) that are not bad for whoring stats at all, thus it is not helpful at all to have the game keep removing them for you.
 
The items are of the sort that it would be considered unacceptable or at least very strange to have them equipped for doing normal (non-combat) jobs.


Not to mention moving 'okay for the girl' weapons to Small Weapon to avoid the auto-unequip means you can now have two weapons which wasn't intended.
   
Wasn't intended by who? The game already allowed 2 large weapons to be equipped. I considered lowering that to 1 due to the new Small Weapons category, but didn't bother. I could go back and do that. Stuff in the small weapon category is generally just that, small and easily carried, unlike for instance a sword or axe.


You imply it's an exploit to have a dress and lingere both take effect, yet there are plenty of rings, amulets, misc items, and consumables that boost stats that I can have unlimited of per girl.
     
All of the other equippable items would be visible with clothes on, unlike underwear.


IMO, the whole automatic equip thing just causes a lot of gameplay problems by removing choices from the player's hands.  The issue it was designed to correct - girls buying a sword and losing some charisma without the player knowing - was already resolved with GirlBuy%!  Swords and plate mail never get purchased in the first place without my consent, so why do I need the game to unequip the sword I know the girl has in her inventory?

Besides the issue of a whore buying a sword or armor and equipping it and lowering valuable skills or stats, there is also the issue of making it so that the player no longer has to micromanage such things either; it's handled automatically and (largely) sensibly. Along with the already covered matter of combat gear being out of place when doing non-combat jobs.


Now again, would you mind taking this discussion to a new topic if you wish to continue it, since it doesn't belong here?


EDIT: tell you what, though, I'll add in a config option to disable automatic combat equip/unequip just for you.
Title: Re: Bugs: 1.30 Alpha
Post by: dcb42 on June 10, 2010, 12:55:28 AM
r416 - when your daughters grow up and are put in the dungeon, their "house percentage" is set to 60% - the rate for a free girl - but, as they are automatically enslaved their house percentage needs to be changed to 100% manually.

Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 10, 2010, 11:34:44 AM
r416 - when your daughters grow up and are put in the dungeon, their "house percentage" is set to 60% - the rate for a free girl - but, as they are automatically enslaved their house percentage needs to be changed to 100% manually.

Noted, I'll look into it.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 10, 2010, 11:36:11 AM
committed earlier:
* updated WMEdit by Solo761, to support "Small Weapon" category
* updated items file by LordShame

Just committed:
** new Slider control for selecting numerical values
* You now set each brothel's advertising budget on the Brothel Setup screen.
* Girls who do the advertising job now boost the effectiveness of your advertising budget by a certain percentage, based on Service skill, a few stats, and some traits, as described below.
    Foremost is the girl's Service skill. A distant second are Charisma and Intelligence. Third, Beauty and Fame. Several traits can further increase her effectiveness on par with 100% Beauty or Fame: Psychic, Cool Person, Sexy Air, Charismatic, and Charming. Some traits on the other hand reduce effectiveness: Nervous and Clumsy are minor reductions, while Retarded and Malformed are major ones.
* You can see what percentage a girl boosted your advertising effectiveness in her Turn Summary info, and you likewise get a breakdown of what brought in customers on the brothel's Turn Summary info
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 10, 2010, 02:32:50 PM
* new option in config.xml to disable feature which auto-equips and auto-unequips combat gear for different jobs
* fixed mission description for "have total of X girls" in Player House screen
* slave daughters now correctly have house percentage set at 100
* raised threshold for matron cheering up unhappy girls from 20 happiness to 40
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 10, 2010, 06:12:11 PM
last for the day:
* switched "House Percentage" on Girl Details screen to use new slider control

(http://img63.imageshack.us/img63/74/houseperc.png)
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 12, 2010, 02:30:27 PM
Ran into a bug with "deposit all" into the bank. works like this.

1. Deposit all funds into bank.
2. Hit Next week.
3. If you have a random event where your guards are defeated by a rival and you lose money you GAIN money instead.

Specific number was in the 32k range.
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 13, 2010, 02:28:35 AM
Not sure if this is intentional or not but sometimes the gangs don't increase their stats at all when training and if they are training there should be some improvement no matter how small.
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on June 13, 2010, 03:18:02 AM
I had a "you must have -1 gangs in 10 weeks" mission, that is impossible to lose
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 13, 2010, 04:12:31 AM
Ran into a bug with "deposit all" into the bank. works like this.
...
I had a "you must have -1 gangs in 10 weeks" mission, that is impossible to lose

Noted, I'll check into these.


Not sure if this is intentional or not but sometimes the gangs don't increase their stats at all when training and if they are training there should be some improvement no matter how small.

Intentional. The more skilled the gangs are, the less they gain from training. Once they're highly skilled, they can indeed hit the point where they don't always gain anything from training. Gangs don't need 100 in every stat to be powerful, you know.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 13, 2010, 10:47:34 AM
Bug in the summary screen this time.

From the turn summary screen if you select "Go to selected" girl and then hit next or back on that screen you will go to the first girl on the list for that brothel and won't be able to use the next and back buttons to view other girls.

Also, if you back out of the selected girls screen while in the turn summary screen you will auto select the first girl on the list. (not as annoying as the above but most likely related)

Girl status piloting works as intended if you select girl management from the main screen however.
Title: Re: Bugs: 1.30 Alpha
Post by: Zeus on June 13, 2010, 11:16:15 AM
try to navigate with the Arrow Keys... its work much better ^^''
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 13, 2010, 11:32:27 AM
try to navigate with the Arrow Keys... its work much better ^^''

If by work better you mean "completely crash the game" then yeah.. It works better. :D

Didn't know that about the arrow keys, thanks for that. It actually works correctly from Girl management from the main screen.

However, from the Turn summary screen, clicking a girl then clicking "Go to selected" is bugged. More so now that you brought that up. I tried 5 times to pilot through the girls status screens using the left and right keys and 5 times it crashed.

Once again though, this is only from the turn summary screen. Girl management from the main screen works as intended.  :)
Title: Re: Bugs: 1.30 Alpha
Post by: Zeus on June 13, 2010, 12:00:24 PM
strange...
in the Turn Summery, Left / Right switches through the Brothels... up down switch through girls... if i click on a girl i selected via the Arrow keys, and then click on "Back" I'm Back in the Turn summery on the position of the girl...
Played this over 3 or 4 Hour on a row with the only crash are when i go on the Slave market or something ... but never with navigating via Arrowkeys....
(hoa... i think my english getting every post worst than befor o_O... sorry)



Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 13, 2010, 01:00:36 PM
However, from the Turn summary screen, clicking a girl then clicking "Go to selected" is bugged. More so now that you brought that up. I tried 5 times to pilot through the girls status screens using the left and right keys and 5 times it crashed.

I'd actually noted that "Go To Selected" on a girl in the Turn Summary screen could lead to screwy Prev/Next functionality on the Girl Details screen, but I'd set it back a bit on my list since it didn't seem too serious. Looks like it's more serious than I thought; I'll be sure to fix it before the next update.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 13, 2010, 01:09:08 PM
Edit:

I'd   actually noted that "Go To Selected" on a girl in the Turn Summary   screen could lead to screwy Prev/Next functionality on the Girl Details   screen, but I'd set it back a bit on my list since it didn't seem too   serious. Looks like it's more serious than I thought; I'll be sure to   fix it before the next update.

Realized I didn't need to reword the problem since Dagoth was on top of it. Was thinking for a sec that I wasn't expressing myself correctly.

Still want to thank Zeus for the Arrow key tip though  ;)
Title: Re: Bugs: 1.30 Alpha
Post by: Zuul on June 13, 2010, 01:52:43 PM
strange...
in the Turn Summery, Left / Right switches through the Brothels... up down switch through girls... if i click on a girl i selected via the Arrow keys, and then click on "Back" I'm Back in the Turn summery on the position of the girl...
Played this over 3 or 4 Hour on a row with the only crash are when i go on the Slave market or something ... but never with navigating via Arrowkeys....
(hoa... i think my english getting every post worst than befor o_O... sorry)

I think you're misunderstanding Lorde. The game crashes if you try to navigate between the girls on the detail screen which you accessed from the turn summary screen. So if you try to go to the next girl from there, the game will crash.
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 13, 2010, 02:07:41 PM
Noted, I'll check into these.


Intentional. The more skilled the gangs are, the less they gain from training. Once they're highly skilled, they can indeed hit the point where they don't always gain anything from training. Gangs don't need 100 in every stat to be powerful, you know.
But this happened when they were still in the 40's though.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 13, 2010, 02:51:50 PM
But this happened when they were still in the 40's though.
The lowest stat, or the highest?
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 13, 2010, 04:50:04 PM
highest stat it was the first week actually
Title: Re: Bugs: 1.30 Alpha
Post by: Zeus on June 13, 2010, 04:55:52 PM
mh... not sure this is a bug or just a ... strange feature... in the Shop: when i turn the Mousewheel fast up or Down its randomly sell a Item from the Player inventory... 


um.. yeah... mostly i activatet an item there und forget to klick back on the sections on top to scroll through...
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 14, 2010, 03:40:18 AM
highest stat it was the first week actually

Strange, I can't duplicate that with higher skilled starting gangs, and the code is such that at the very least they should get 2 attempted boosts from training (but on average, 6 attempted boosts), with only a chance for 0 gained from those boosts if they have a high stat they chose to focus on.
Once they reach about 50 in a skill, there starts to be a very very slim chance (less than 1%) of not gaining anything for any given boost of that stat. At 70 in a skill, it's a 50% chance of gaining nothing for a given boost. Also, they do tend to focus training on skills they're good at.
So I don't see how your situation would be possible if they have no skill over 40-something.


mh... not sure this is a bug or just a ... strange feature... in the Shop: when i turn the Mousewheel fast up or Down its randomly sell a Item from the Player inventory...

um.. yeah... mostly i activatet an item there und forget to klick back on the sections on top to scroll through...

Is that with the mouse possibly straying over the transfer buttons while you're scrolling, or with it definitely staying over the listbox? If the former, I have an idea why it might be; scroll wheel movements trigger a click event, and the buttons may not be properly filtering out those events.
Title: Re: Bugs: 1.30 Alpha
Post by: Spacebird on June 14, 2010, 12:42:53 PM
Great game, just started playing with 1.30 yesterday.

Issue I did not see previously reported:  I re-made some custom girls of my own using the included editor. They're fine until I save the game and exit to desktop. When I re-load the game, they're dead. They show up in the brothel, but all their stats are 0. This is apparently JUST the user made girls.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 14, 2010, 01:15:33 PM
Issue I did not see previously reported:  I re-made some custom girls of my own using the included editor. They're fine until I save the game and exit to desktop. When I re-load the game, they're dead. They show up in the brothel, but all their stats are 0. This is apparently JUST the user made girls.

Can you post the girlsx or rgirlsx file(s)?
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 14, 2010, 01:19:35 PM
When I re-load the game, they're dead. They show up in the brothel, but all their stats are 0. This is apparently JUST the user made girls.

That rings a faint bell. I had that happen to me once. Damned if I can remember the cause or the fixing of it, but I remember it happening.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 14, 2010, 01:28:59 PM
Maybe something got corrupted somewhere down the line. Would making a different  rgirlsx file fix it?
I made some girls myself (Have a ton of pics and am too lazy to look through the site for premade girls  :D ) and I haven't run into this problem.
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on June 14, 2010, 02:14:33 PM
That rings a faint bell. I had that happen to me once. Damned if I can remember the cause or the fixing of it, but I remember it happening.

It was in one of the image packs (the one containing Lenalee) that, if I remember correctly, had an extra end line somewhere that screwed them up. But that was corrected long ago by the original maker I think. And anyway it can be corrected by just loading the .girls file and saving it as .girlsx
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 14, 2010, 05:30:46 PM
another couple of updates in the past few days which I'll list as one entry:
* rewrote / cleaned up portions of Slider display code and most of Scrollbar display code for lower memory usage and proper alpha transparency
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 14, 2010, 08:33:44 PM
* Turn Summary screen's "Go To Selected" for brothel girls resulted in broken prev/next on Girl Details screen; fixed
* Turn Summary screen's "Go To Selected" now works for dungeon girls
* When returning to Turn Summary screen from Girl Details screen, last viewed girl on Girl Details screen is now selected
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 14, 2010, 08:44:14 PM
I had a "you must have -1 gangs in 10 weeks" mission, that is impossible to lose

I was just looking into this one, and I can't see how that's even possible based on the code. It should unfailingly give a target of 1-3 more gangs than you have, with the minimum target therefore being 1 gang if you have none.
How many gangs did you have, anyway? None? Did the initial mission message indicate -1, or did you see that elsewhere (the player house screen)?
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 14, 2010, 08:53:16 PM
Ran into a bug with "deposit all" into the bank. works like this.

1. Deposit all funds into bank.
2. Hit Next week.
3. If you have a random event where your guards are defeated by a rival and you lose money you GAIN money instead.

Specific number was in the 32k range.

A bit late to ask, but can you provide a save for this one?
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 14, 2010, 09:24:25 PM
Hmm let me look. My play habits where all over the place, restarting with the same name for brothels is a common play habit of mine.....

Edit: Nope don't have it. If I run into it again I'll save and upload the file.
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on June 15, 2010, 03:00:22 AM
I was just looking into this one, and I can't see how that's even possible based on the code. It should unfailingly give a target of 1-3 more gangs than you have, with the minimum target therefore being 1 gang if you have none.
How many gangs did you have, anyway? None? Did the initial mission message indicate -1, or did you see that elsewhere (the player house screen)?

Both the initial mission and the player house screen indicated -1 (I remember I checked). I also had 4 to 6 gangs (can't really remember the exact number now but I think that's the correct range leaning more on the higher numbers). Based on what you say could it be that I had 6 gangs and it tried to make have 9 thus going over 8 and so giving a -1 instead?
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 15, 2010, 03:45:33 AM
Money loss of around 1 million from a single gang and money in the bank from an all deposit making it negative those are two I have had this past 7 days.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 15, 2010, 09:34:27 AM
Both the initial mission and the player house screen indicated -1 (I remember I checked). I also had 4 to 6 gangs (can't really remember the exact number now but I think that's the correct range leaning more on the higher numbers). Based on what you say could it be that I had 6 gangs and it tried to make have 9 thus going over 8 and so giving a -1 instead?

That is a thought, since I see it doesn't actually check to make sure the target is <= the max number of gangs ( 8 ). I'll fix that, and hopefully that's what you ran into.


Money loss of around 1 million from a single gang and money in the bank from an all deposit making it negative those are two I have had this past 7 days.

Can you provide a save for this, from a turn or two before the bug hit? I've looked through the code a bit based on Lorde's report, but potential causes for it are spread through several different functions. Much easier to track down with a savegame mostly set up ready to reproduce the problem.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 15, 2010, 09:58:21 AM
I'll try to reproduce the results I got with Deposit all today.


As a side note: How does this game calculate how much you made for the week. What it reports on the turn summary and what I have gained in the main screen are always 2 different things. And it's always less. Guess an expense isn't being reported?
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 15, 2010, 11:44:25 AM
no got hit by a virus thursday it deleted some of my save games and i can't remember which it was
Title: Re: Bugs: 1.30 Alpha
Post by: Shinteo on June 15, 2010, 02:35:08 PM
Unsure if this is a bug or not, but I have never seen any custom girls that is a virgin. Random girls, yes. But not custom girl. I looked through the code, but wasn't able to find where this is controlled.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 15, 2010, 03:22:30 PM
Edit: Disregard this post. Girl is accounted for. Instead of being paid by a local business I was given the business owners daughter.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 15, 2010, 05:14:27 PM
Unsure if this is a bug or not, but I have never seen any custom girls that is a virgin. Random girls, yes. But not custom girl. I looked through the code, but wasn't able to find where this is controlled.
Hmm, right you are.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 15, 2010, 05:14:39 PM
* unique girls can be virgins again, based on nearly the same criteria as random girls (basically, young age and/or lack of sex skills)
* objective to get specific number of gangs can no longer go higher than the limit ( 8 )
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 16, 2010, 12:23:25 AM
* reduced happiness / love from giving items to girls 
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 16, 2010, 05:55:18 AM
Try this

Makes no difference if you give them a job and/or advance through a turn or two, first.

I've tracked it down as far as a null selected_girl pointer

[edit]

Nope, that's wrong. It's crashing here:

Code: [Select]
#0  0x081380c5 in cScreenGirlDetails::remove_selected_girl (this=0x8196420)
    at cScreenGirlDetails.cpp:664
#1  0x0813a09d in cScreenGirlDetails::check_events (this=0x8196420)
    at cScreenGirlDetails.cpp:480
#2  0x0813c906 in cScreenGirlDetails::process (this=0x8196420)
    at cScreenGirlDetails.cpp:193
#3  0x0810d4f0 in cInterfaceWindowXML::handler_func (wpt=0x8196420)
    at cWindowManager.cpp:32
#4  0x0810fd62 in cWindowManager::UpdateCurrent (this=0x81995dc)
    at cWindowManager.h:92
#5  0x0810fbe3 in main (ac=1, av=0xbffa0fb4) at main.cpp:391

I've stuck a test for an empty cycle list at the top of the function. Seems to fix it.
Title: Re: Bugs: 1.30 Alpha
Post by: fg109 on June 16, 2010, 10:39:14 PM
Player disposition and suspicion are completely opposed to each other.  I tried playing as a good guy and got Benevolent and Town Scum for disposition and suspicion.  Playing as evil, I got Evil and Town Hero.

You can test this by making a new Test game, then buying and freeing 20 slaves.  And you can also try enslaving all the custom girls.  I tried making a script that only changed my disposition, but the suspicion ended up being affected too.  I haven't tried making a script that only changed suspicion yet.

I'm pretty sure this is a bug, since I don't see what's wrong with trying to be a Benevolent Town Hero.
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 16, 2010, 11:30:59 PM
Yeah same thing here, but i hope that is will be changed so you can get any combo of the four.
that way you can have :
Benevolent  Town Hero
Evil  Town Hero
Benevolent  Town Scum and
Evil  Town Scum
as well as the neutral titles
Title: Re: Bugs: 1.30 Alpha
Post by: Spacebird on June 17, 2010, 03:17:31 PM
Player disposition and suspicion are completely opposed to each other.  I tried playing as a good guy and got Benevolent and Town Scum for disposition and suspicion.  Playing as evil, I got Evil and Town Hero.

You can test this by making a new Test game, then buying and freeing 20 slaves.  And you can also try enslaving all the custom girls.  I tried making a script that only changed my disposition, but the suspicion ended up being affected too.  I haven't tried making a script that only changed suspicion yet.

I'm pretty sure this is a bug, since I don't see what's wrong with trying to be a Benevolent Town Hero.

It worked that way in 1.29 as well. I thought it was intentional irony since it IS a criminal world.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 17, 2010, 03:25:02 PM
I noticed this as well, and thought I was just particularly sneaky  :D

Just started playing a nice guy game and this explains why the authorities are taking a mighty big interest in me all of a sudden.

Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 17, 2010, 04:38:12 PM
As far as I know, it should be possible to any of the four possible combos. If disposition and suspicion are linked, that's probably a bug.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 17, 2010, 05:43:17 PM
Yeah, I'm not sure on that one. I've never really tried that hard to affect either of those much, beyond using bribes to keep suspicion from getting too low to prevent official raids. I'd think at least being benevolent an giving moderate bribes to Town Hall should result in being a benevolent town hero.
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 17, 2010, 06:18:36 PM
In my games I average 95 % influence but it considers my as a evil town hero
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 17, 2010, 06:27:42 PM
That's the thing. My "Lock every girl I get in the dungeon and torment them till their spirit and confidence are 0" playthrough had 0 number of visits from the cops.

And, just to be as spiteful as possible Any customer who couldn't pay got followed home, his family kidnapped, enslaved and sold for extra cash.

I killed any rival dumb enough to show up at my brothel.

If you had a "kick a puppy first thing in the morning" option I probably would have used that as well.

All this and I was an Evil | Town hero.

I thought it just involved what your gangs where doing. Like Kidnapping or Theft. (My goons where always Acquiring territory or sabotaging my rivals. Thought that didn't clock in on the radar so kept with it.)  With a few choice slaves exploring catacombs (Though with my PC's temperament, he probably just let them down there cause monster rape amused him.)

And never did I once bribe anyone.

Ya know, I never really thought about it till I read this thread but I should have had the crossgate equivalent of the national guard on my doorstep. Either that or Been bribing a small countries GNP worth of gold to city hall. 
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 17, 2010, 06:29:46 PM
My gangs were doing nothing but catacombs and somehow I became an evil town hero from selling slave I gained from the catacombs
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 17, 2010, 06:48:59 PM
New bug: Very Minor

When in gang management screen the first time you click on autobuy on potions then back out (may need to click next week) causes the box to uncheck. Checking it again afterwords has expected result. (Check mark stays.)
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on June 17, 2010, 10:50:43 PM
umm, something else with the auto buy, when I click the auto buy and then buy some potions it will some times come off (I think it has to be under a certain number), the same with nets. I usually don't have this happen if I have more then 80 potions.
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 18, 2010, 06:27:24 AM
I just tried a "total bastard" game (as opposed to my usual "mild bastard" approach), branding and  torturing every girl I get into total submission. On day 25 the authorities raided me. Hard.

Still had town hero as disposition, however.  Which leads me to think that the problem is that the player's disposition is not being displayed correctly.

I haven't got time to chase it down further right  now - might take a look tonight.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 18, 2010, 10:47:59 AM
That's funny. I never get raided. Ever.

Only time I recall getting raided was during a "nice guy" game.
Title: Re: Bugs: 1.30 Alpha
Post by: sgb on June 18, 2010, 05:42:03 PM
Yeah, now that it has been mentioned I've always seen disposition and suspicion rating be opposite to each other.  In my current game I've been branding everyone, letting people die, and my gangs rampage through the town.  Currently I'm Mean/Lawful.  Wut?
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 18, 2010, 07:15:58 PM
When in gang management screen the first time you click on autobuy on potions then back out (may need to click next week) causes the box to uncheck. Checking it again afterwords has expected result. (Check mark stays.)
umm, something else with the auto buy, when I click the auto buy and then buy some potions it will some times come off (I think it has to be under a certain number), the same with nets. I usually don't have this happen if I have more then 80 potions.

Noted. I'll look into it.


Currently I'm Mean/Lawful.  Wut?

So you have a Lawful Evil character?  :D
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 18, 2010, 09:16:58 PM
Currently I'm Mean/Lawful.  Wut?

As far as the cops can tell you've broken no laws. Like many a mob boss before you, you can claim to be a "respectable businessman".

It's just that in private you've got a bit of a nasty streak. That's all.
Title: Re: Bugs: 1.30 Alpha
Post by: Samu on June 18, 2010, 10:25:03 PM

So you have a Lawful Evil character?  :D

lol D&D/NWN  ::) 8)
Title: Re: Bugs: 1.30 Alpha
Post by: drake on June 19, 2010, 12:44:56 AM
Hi, I have been following this game for a few weeks now, LOVE IT.  I thought I'd say hi and let you know bout a few bugs I noticed.  First, are the already talked about autobuy health potions coming unclicked, and the disposition/suspicion inversion.  There are two others that I haven't seen you talk about.  One of the more annoying ones has happened to me twice, although I don't know what causes it.  Sometimes after the game crashes, and you load the game, it seems to reset the unque girls so you start getting copies.  To be clear, it acts as if you are in a new game as far as which girls have already been acquired, so you can end up with 2 of each.  A second bug, the comment in "the dead" about the Deepthroat of Death reminded me.  On accident when I wasn't paying attention I killed a girl in the dungeon girl details screen and the game crashed.  On further inspection I figured out that it only does this if you are in the details screen of the last girl on the list and she dies, either from torture or force.  If it is another girl it just switches the screen to another girl.  Third, and minor is that the sort by column seems to reset to the chronological order one when you enter the detail screen in the dungeon.
 
Sorry for the long post, I really enjoy the game.
 
P.S. Any time frame on the next build after 417, you seem to have squashed a few bugs, including the libido one and I would like to check it out.  Hope I didn't sound ungrateful or anything cause this game is really cool.
Title: Re: Bugs: 1.30 Alpha
Post by: megamanx on June 19, 2010, 12:49:19 AM
drake you just sound grateful and curious to me and I am sure the dev team thanks you for helping them find any bugs.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 19, 2010, 01:11:28 PM
Sometimes after the game crashes, and you load the game, it seems to reset the unque girls so you start getting copies.  To be clear, it acts as if you are in a new game as far as which girls have already been acquired, so you can end up with 2 of each.
 
I'll note it down to look into it, though I'm not sure whether I'll be able to track it down.


On accident when I wasn't paying attention I killed a girl in the dungeon girl details screen and the game crashed.  On further inspection I figured out that it only does this if you are in the details screen of the last girl on the list and she dies, either from torture or force.  If it is another girl it just switches the screen to another girl.
 
I think Doc fixed the cause of that one a few days ago.


Third, and minor is that the sort by column seems to reset to the chronological order one when you enter the detail screen in the dungeon.

I couldn't initially reproduce this one, but I've got it now; it only happens if you click the View Details button. As a workaround for the time being, you can just double-click the name of the girl you want to view the details of, which is what I always use anyway. I'll see about fixing it for the next version, though.


P.S. Any time frame on the next build after 417

Pretty soon. A few more fixes, and maybe a bit more Lua scripting support from Doc, and I'll go ahead and release another version. I didn't feel like there was as much of a rush for this next one since there are finally almost no commonly occurring game-breaking bugs in the last one (r416).


Sorry for the long post, I really enjoy the game.
 
No worries, and welcome aboard.  :)
Title: Re: Bugs: 1.30 Alpha
Post by: Samu on June 19, 2010, 05:19:01 PM

I couldn't initially reproduce this one, but I've got it now; it only happens if you click the View Details button. As a workaround for the time being, you can just double-click the name of the girl you want to view the details of, which is what I always use anyway. I'll see about fixing it for the next version, though.


I would like that the effect remains somewhere since i like to have my girls listed in cronological order.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 19, 2010, 05:53:56 PM
I would like that the effect remains somewhere since i like to have my girls listed in cronological order.

Same, first time I discovered the sort function I panicked a little. Happy It was undoable.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 19, 2010, 06:24:05 PM
I would like that the effect remains somewhere since i like to have my girls listed in cronological order.

There's an un-sort button to the far right of the column headers.
Title: Re: Bugs: 1.30 Alpha
Post by: Lorde on June 19, 2010, 09:44:25 PM
Less of a Bug issue and more of a gameplay issue. But may count as a bug if this was an oversight.  Level: annoyance.

When having a girl explore the catacombs and having a matron working in her brothel. There is a point where the girls health is low enough that she gets continually monster ravaged every week. Yet her health isn't low enough to trigger the matron to take her off work for rest. Eventually her health will dip down low enough for the matron to take her off. But that was a few weeks of that girl only being raped by monsters and no loot.

The "fix" obviously would be for me to take her off work myself, then put her back on when she is healthy. Or give her healing salves. But I did hire a matron for the express purpose of alleviating those micromanagement concerns. Also, when the matron takes the catacomb girl off, she puts her back to work with her health is in the 80's thus shortening the amount of time before there will be an episode of La Blue Girl down there. 


So I humbly ask that you take a look at matrons specifically for catacomb girls. Have the matrons take them off work the first time they get Monster ravaged and not put them back to work till they are 100% health. My sanity thanks you in advance  :)


Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on June 20, 2010, 01:15:03 PM
Quote   from: drake on June 18, 2010, 11:44:56 PM (http://pinkpetal.org/index.php?topic=352.msg7516#msg7516)<blockquote>Sometimes after the game crashes, and you   load the game, it seems to reset the unque girls so you start getting   copies.  To be clear, it acts as if you are in a new game as far as   which girls have already been acquired, so you can end up with 2 of   each.
</blockquote> 
I'll note it down to look into   it, though I'm not sure whether I'll be able to track it down.


Something similar happened to me some time ago, but I didn't report it because it was more me messing things up. I currently have all girls in a single .girlsx file, so when a new pack came out I added the girls to the file, started a new game and then tried to manually edit the save file of the previous game. Saving the now edited file messed up the formatting so the game loaded but the game didn't recognize any info (brothel name, week\month, money and all that stuff, didn't check the girls). So i quitted and loaded the autosave and in that instance it re-loaded the girlsx file thus inserting in the girls twice.
I must point out that this was the only instance where loading the autosave also re-parsed the girlsx file, but also it was the only time I didn't start a new game when I had new girls.
Title: Re: Bugs: 1.30 Alpha
Post by: Zeus on June 20, 2010, 02:09:34 PM
um.. the newest version (416) load automaticly new girl files... 
i made alle girl files to one too yesterday and it worked fine in my running game.
Title: Re: Bugs: 1.30 Alpha
Post by: Nalkyr Maloth on June 20, 2010, 02:15:17 PM
problem is (or was) when you add new girls to an existing girls file
Title: Re: Bugs: 1.30 Alpha
Post by: xhui on June 20, 2010, 03:07:42 PM
i found that the girls even wight no rebelliousness and Obedience at 100 still refuse stuff a lot actually  also i give the girls disguised slave bands and it docent make them slaves or gives them controlled trait only increases a little obedience not the amount it says i might add which again seems to no be doing its job sry if its been said i tried checking dint find it so
Title: Re: Bugs: 1.30 Alpha
Post by: Wispowill on June 21, 2010, 06:37:27 PM
I think the "Town Hero" matter is related to the fact you kept all your girls. I generally try to play "good guy" type of games. I've noticed before that freeing and firing girls tends to make your reputation drop like a rock. I generally fire most of the random type girls I end up with, so end up being Town Scum in very little time. I haven't yet seen any obvious way to raise it again once it has fallen. This is somewhat like the Disposition matter where letting a debtor go free doesn't raise disposition but putting him into a dungeon for a reasonable time does. I guess being Mean in Moderation seems to affect the underlying stats more than being a Nice Guy.
 
I've also had problems with the mouse wheel selecting stuff in the inventory screens when I haven't clicked on anything. I was definitely in the lists. I stopped using the mouse wheel as I assumed it more or less hadn't been programmed for it.
Title: Re: Bugs: 1.30 Alpha
Post by: drake on June 21, 2010, 07:17:42 PM
perhaps I hadn't been clear about the duplication of girls, I hadn't touched the girls file when it happened.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 21, 2010, 07:47:03 PM
perhaps I hadn't been clear about the duplication of girls, I hadn't touched the girls file when it happened.

Here's a thought. Did you delete the .gam.mast file, or load the autosave (which doesn't have one)? It now occurs to me that that might have it load up every .girlsx file. If that's what is happening, I could add in an exception where it doesn't load any girls if the .gam.mast file is just plain missing.
Title: Re: Bugs: 1.30 Alpha
Post by: fires_flair on June 21, 2010, 08:44:01 PM
I've had the same thing happen with the money, I figure that the text isn't accounting for gang activity, which
I usually have set to catacombs.

I was wondering, has anyone looked at how the file names are handled? 'cause I remember that in 1.29 people were having trouble making bdsmpreg images.
Title: Re: Bugs: 1.30 Alpha
Post by: Spacebird on June 21, 2010, 09:17:17 PM
Here's a thought. Did you delete the .gam.mast file, or load the autosave (which doesn't have one)? It now occurs to me that that might have it load up every .girlsx file. If that's what is happening, I could add in an exception where it doesn't load any girls if the .gam.mast file is just plain missing.


I've also experienced duplication of non-random girls, especially when they're obtained from the Slave Market. This is after combining all the girls into one *.girlsx file, checking carefully for any repeated names, and removing all but the one main girls file, and restarting (since I've noted modifying the girlsx files during a game causes my game to crash).


Is it possible that the game is also reading the backup files?
Title: Re: Bugs: 1.30 Alpha
Post by: d31r3x on June 22, 2010, 06:27:25 PM
I'm not sure if this is a bug or not, but I have girls losing the "masochist" trait that they previously gained by means of torture. I don't know if this trait wears off if you don't keep torturing the poor girls from time to time (that's mean) or something like that.
I just realized, so I don't know if it happens when reloading a game or when hitting "next week". I'll test it.

Cheers.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 22, 2010, 08:39:10 PM
Is it possible that the game is also reading the backup files?

Here's exactly what the game does. It stores a list of all .girlsx files which it has loaded in the .gam.mast file (stored by filename, not contents or anything like that). It then scans the Characters folder for a list of all files with a name that end in .girlsx, checks to see if that filename is already loaded in .gam.mast, and if not, it loads that .girlsx file.
So, if you have "backups" in that folder which end in .girlsx, yes, they will be imported. Likewise, if you rename a file, the game will of course see it as a new file and again import it.

I'm not sure if this is a bug or not, but I have girls losing the "masochist" trait that they previously gained by means of torture.

I can guess why, added traits default to being temporary unless specified as permanent. I'll check into it and fix it.
Title: Re: Bugs: 1.30 Alpha
Post by: Spacebird on June 22, 2010, 11:04:48 PM
Here's exactly what the game does. It stores a list of all .girlsx files which it has loaded in the .gam.mast file (stored by filename, not contents or anything like that). It then scans the Characters folder for a list of all files with a name that end in .girlsx, checks to see if that filename is already loaded in .gam.mast, and if not, it loads that .girlsx file.
So, if you have "backups" in that folder which end in .girlsx, yes, they will be imported. Likewise, if you rename a file, the game will of course see it as a new file and again import it.


When I say Back-up I mean the girlsx.bak file the editor creates. As these screenshots show, I have only one .girlsx file in the charachters folders. At this point in the game I have two copies of Konan and Lina Inverse, who are definitely only listed once each.  The game log and saves are in the archive file.
Title: Re: Bugs: 1.30 Alpha
Post by: Spacebird on June 22, 2010, 11:26:54 PM
Separate issue: I keep getting this error when closing the game down. The actual .exe is shut down, but the .svn window hangs up.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 23, 2010, 03:37:18 AM
Yeah, the crash on exit happens pretty often. I haven't been able to pin it down myself even after looking into it a couple of times; the best I can tell, it's crashing when trying to clear an image from memory (specifically a girl image, I think) which was already cleared from memory. I couldn't figure out how that was happening, particularly since it seems to happen completely randomly.
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 23, 2010, 03:38:30 AM
Yeah, there's a crash-on-exit bug lurking in there somewhere. Seems to be a double-free in the resouce manager. I've taken a couple of pops at finding it, but no luck so far

PS. Dagoth beath me to it :)

[edit]

I think what happens is that a girl image gets freed by the girl destructor, and then the resource manager tries to free it again. valgrind tells me it's a double free crash, and reports the location as the resource manager.

I'm just not clear on how to stop it from happening.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 24, 2010, 04:48:10 AM
Fixes committed:
* some controls (buttons, edit boxes, checkboxes) were responding to mouse scroll wheel movements as regular clicks, which they now ignore; this showed up most in the Inventory Management screen
* "auto buy" checkboxes are no longer displayed unless you have some of the item in question, to allay confusion based on it not staying checked when you have 0 of that item; setting it to auto-buy 0 of something makes no sense
* traits gained from torture in the dungeon (Broken Will, Masochist, and Mind Fucked) are no longer incorrectly set as temporary
* un-sort header on far right of listboxes could be incorrectly triggered by clicks a bit to the right of the listbox (leading to "View Details" button in dungeon sometimes additionally unsorting dungeon girl list)
* if the .gam.mast file couldn't be read (missing or otherwise) when loading a game, it will now assume you have all existing character packs (.girlsx files) loaded, instead of re-loading all of them and resulting in duplicate unique girls
Title: Re: Bugs: 1.30 Alpha
Post by: DocClox on June 24, 2010, 04:55:36 AM
Fixes committed:
* some controls (buttons, edit boxes, checkboxes) were responding to mouse scroll wheel movements as regular clicks, which they now ignore; this showed up most in the Inventory Management screen

Ah, good! Im glad you got that one. I was starting to think it was the trackpad on my laptop acting up. :)
Title: Re: Bugs: 1.30 Alpha
Post by: ker on June 25, 2010, 11:55:49 AM
Sounds like there's been alot of bug fixes since 416.  Any way we could have those put together and released?  The Lib bug in particular is annoying.
Title: Re: Bugs: 1.30 Alpha
Post by: Dagoth on June 26, 2010, 05:26:27 AM
Since I've released 1.30.1 beta r450 over here (http://pinkpetal.org/index.php?topic=417.0), below is the main changelist since 1.30.0 alpha r416:

* permanent stat modifications should now be limited to +/- 100 in almost every case
* temporary stats changes now normalize towards 0 by 30% each week instead of by 1 point each week
* most libido changes are now temporary (largest portion from doing jobs), not permanent
* dead girls can no longer equip or use any items (no more resurrecting by giving a healing item)
* new item category "Small Weapon", covering daggers and whips and such; small weapons are considered concealable or acceptable for normal carry and are never automatically unequipped unlike regular weapons; max equipped: 1
* code for girls buying items in their free time is rewritten further to consolidate otherwise re-re-re-re-repeated code
* Starting a new "Test" (cheat) game no longer gives you Ayanami Rei; not sure why that was there, since you can Walk Around Town infinite times in cheat mode
* updated WMEdit by Solo761, to support "Small Weapon" category
* updated items file by LordShame
** new Slider control for selecting numerical values
* You now set each brothel's advertising budget on the Brothel Setup screen.
* Girls who do the advertising job now boost the effectiveness of your advertising budget by a certain percentage, based on Service skill, a few stats, and some traits, as described below.
    Foremost is the girl's Service skill. A distant second are Charisma and Intelligence. Third, Beauty and Fame. Several traits can further increase her effectiveness on par with 100% Beauty or Fame: Psychic, Cool Person, Sexy Air, Charismatic, and Charming. Some traits on the other hand reduce effectiveness: Nervous and Clumsy are minor reductions, while Retarded and Malformed are major ones.
* You can see what percentage a girl boosted your advertising effectiveness in her Turn Summary info, and you likewise get a breakdown of what brought in customers on the brothel's Turn Summary info
* new option in config.xml to disable feature which auto-equips and auto-unequips combat gear for different jobs
* fixed mission description for "have total of X girls" in Player House screen
* slave daughters now correctly have house percentage set at 100
* raised threshold for matron cheering up unhappy girls from 20 happiness to 40
* switched "House Percentage" on Girl Details screen to use new slider control
* rewrote / cleaned up portions of Slider display code and most of Scrollbar display code for lower memory usage and proper alpha transparency
* Turn Summary screen's "Go To Selected" for brothel girls resulted in broken prev/next on Girl Details screen; fixed
* Turn Summary screen's "Go To Selected" now works for dungeon girls
* When returning to Turn Summary screen from Girl Details screen, last viewed girl on Girl Details screen is now selected
* unique girls can be virgins again, based on nearly the same criteria as random girls (basically, young age and/or lack of sex skills)
* objective to get specific number of gangs can no longer go higher than the limit ( 8 )
* reduced happiness / love from giving items to girls
* some controls (buttons, edit boxes, checkboxes) were responding to mouse scroll wheel movements as regular clicks, which they now ignore; this showed up most in the Inventory Management screen
* "auto buy" checkboxes are no longer displayed unless you have some of the item in question, to allay confusion based on it not staying checked when you have 0 of that item; setting it to auto-buy 0 of something makes no sense
* traits gained from torture in the dungeon (Broken Will, Masochist, and Mind Fucked) are no longer incorrectly set as temporary
* un-sort header on far right of listboxes could be incorrectly triggered by clicks a bit to the right of the listbox (leading to "View Details" button in dungeon sometimes additionally unsorting dungeon girl list)
* if the .gam.mast file couldn't be read (missing or otherwise) when loading a game, it will now assume you have all existing character packs (.girlsx files) loaded, instead of re-loading all of them and resulting in duplicate unique girls

Of course, there's also partial support for using Lua event scripts added by DocClox, with the first example script being a meeting script for Chun Li when you're walking around town.


I'm locking this bug report topic and creating a new one for organizational purposes, since the new release is a more officially supported beta, rather than an alpha.