What string means?
It's a line of code, I didn't find one declared as string (str(), "", '') but all it does is dividing mcs charisma by 2 and running dice function with a result (which is our case is not widely accepted dice x out of y but a kind of percentage where dice(100 and above are always true), dice(0 or below are always false), dice(10) means 10% chance of occurring, dice(0.1) means 1 in a 1000 chance of occurring and etc.)
Are strings like still correct?
Yeap, these lines are still valid.
- Since we use permanent traits as occupations, that interaction #8 in GM - chat.rpy where you ask a girl to change occupation cannot be used anymore in its current condition. If you want to rewrite it somehow to work with non permanent classes traits, go ahead. Otherwise I'll delete it (probably the best option, it's too simple to change even non permanent class via one dialogue).
I'll rewrite this one myself, removing class traits is not a good idea but talking a girl into accepting a new one shouldn't be a big deal but that would require a good amount of changes and code.
- GM - go out.rpy contains Cherry's basic developments for dates in real time. I'm not sure how to build dates system (there are many ways), but that file is not enough to make something based on it. Just ignore it for now.
As you like, we'll stick a pin in it
![Smiley :)](https://www.pinkpetal.org/Smileys/DarkB/smiley.gif)
I am still in favor of AA2 type of dates btw, maybe with exceptions if someone likes coding them, because the last date scenario I've coded was a disaster (imo, I recall someone saying they liked it) and just changing background, fading to black and displaying a quick result would have been faster/smarter.
- In GM - proposition.rpy the label #3 handles hiring heavily based on occupations, giving an error for unknown ones. I fixed it for now based on existing occupations types, but it will give us more headache in the future. It should be changed to be based on level and social status (I don't know how
).
I half expected that. Occupations have generalization fields like "SIW", "Warrior", "Servicer". I'll make check occupation work with them in the future in some smart way where we check these generalizations only for one or two base class traits and exact match for rest.
- Finally, I can't test stuff because
That file is up to you to maintain, so one developer does not mess up testing for everybody else but as a result, when core code is adjusted, some thing may no longer be valid...
Like Gismo said, just comment our all of those lines. I'll attach my own testing file just in case.