So what is the "cannonical SVN version" of the game?

[some_loli_catgirl]

What version should I be basing modifications on, and releasing patches against?

[crazy]

What version should I be basing modifications on, and releasing patches against?

There is about 3 modded version floating around that have all done different things.  I would say combine them by picking out the best parts of what they have done but I guess you could do it however you want.  Ill link them up for you.
http://pinkpetal.org/index.php?topic=845.0
http://pinkpetal.org/index.php?topic=929.0
http://pinkpetal.org/index.php?topic=950.0

[Xela]

 If you have skill/time, it would be a great call to release a separate patch combining elements from other patches that simply improve the game but do not impose a new model for mechanics.

 Improvements like:

 - Displaying a corresponding image after interaction.
 - Adding 'Withdraw all'/'Release all' Buttons.
 - Removing game crashing bugs (torturer bug maybe others).
 - Allowing users to modify what stats are displayed on brothel screen through xml.

Maybe more... basically anything that plainly improves game experience but doesn't change the game itself.

BTW, if you're good with graphics, developing a new skin might be a good call. One Russian guy made a cool looking skin for WM on Russian forums but is unwilling to share

[some_loli_catgirl]

So when is it "Imposing a new model of mechanics" and when is it "fixing bugs"?

For example, pregnancy is supposed to give a +10 bonus chance to getting pregnant if the girl is a virgin, but due to the order things happen, it clears the virgin flag before it does that check, but it works correctly if a customer is having sex with the girl.  There's also a "good sex factor" that doubles the chance of pregnancy, but there is no way to trigger that except for customers.  Not even getting the "Make Love" option sets that flag.
So I fixed those two issues.

Also, giving gifts is bugged.  If you give a gift, Love and Happiness increase.  If you remove a gift, Happiness decreases.  This means you can constantly give and take away the exact same gift repeatedly until the girl loves you.
I changed it so that taking away gifts decreases Love so you can't do that anymore.

And of course, I added in getting pictures when using the Interact feature.  It's a no-brainer to add that.

[fires_flair]

I don't want to change how pictures are handled completely, I'm fine with categories reverting to sex pictures. But would it be possible to make it so that if there are no sex pictures (IE you deleted a girl file but missed their name in the .girlx file), to make it grab that categories generic picture from the generic file (forget what it's called atm).

also if you do a compilation of all the patches could you add the one that allows for unlimited interactions.

[some_loli_catgirl]

If you want unlimited interactions, enter your brothel name as Test.

[some_loli_catgirl]

I think most of the crashes of the game are from the Random function sometimes returning the max value, when the limit should be max value - 1.

[crazy]

So when is it "Imposing a new model of mechanics" and when is it "fixing bugs"?

For example, pregnancy is supposed to give a +10 bonus chance to getting pregnant if the girl is a virgin, but due to the order things happen, it clears the virgin flag before it does that check, but it works correctly if a customer is having sex with the girl.  There's also a "good sex factor" that doubles the chance of pregnancy, but there is no way to trigger that except for customers.  Not even getting the "Make Love" option sets that flag.
So I fixed those two issues.

Also, giving gifts is bugged.  If you give a gift, Love and Happiness increase.  If you remove a gift, Happiness decreases.  This means you can constantly give and take away the exact same gift repeatedly until the girl loves you.
I changed it so that taking away gifts decreases Love so you can't do that anymore.

And of course, I added in getting pictures when using the Interact feature.  It's a no-brainer to add that.

Sounds to me those things should be fixed.  But what I meant was

There is about 3 modded version floating around that have all done different things.  I would say combine them by picking out the best parts of what they have done but I guess you could do it however you want.  Ill link them up for you.
http://pinkpetal.org/index.php?topic=845.0

Turned alot of the screens into xml so anyone could make changes.  Added a new way to sort girls where you could do it by show or what have you.

http://pinkpetal.org/index.php?topic=929.0

Added clinic and movies to the game

http://pinkpetal.org/index.php?topic=950.0

Fixed alot of the jobs added sleazy counter parts to the bar and casino.

I just think combing those things would give a great place to start working from.  All that work is done I see no point in letting it go to waste and really feel someone should be able to combine them.  But if you don't feel like doing that I welcome any work done to the game cause I've played the game to death and any change is good to see at this point.  Good luck and hope to hear what you have planed soon

[Xela]

So when is it "Imposing a new model of mechanics" and when is it "fixing bugs"?

For example, pregnancy is supposed to give a +10 bonus chance to getting pregnant if the girl is a virgin, but due to the order things happen, it clears the virgin flag before it does that check, but it works correctly if a customer is having sex with the girl.  There's also a "good sex factor" that doubles the chance of pregnancy, but there is no way to trigger that except for customers.  Not even getting the "Make Love" option sets that flag.
So I fixed those two issues.

Also, giving gifts is bugged.  If you give a gift, Love and Happiness increase.  If you remove a gift, Happiness decreases.  This means you can constantly give and take away the exact same gift repeatedly until the girl loves you.
I changed it so that taking away gifts decreases Love so you can't do that anymore.

 All of the above are 'Fixing bugs' obviously

 By mechanics I meant changes like in WM EX or Anon's Catacombs that change the way game is played. Also annoying stuff like changing 'Incoporeal' to 'Incorporeal' like Anon did... That meant we had to fix items/girls or get error messages that bugged the hell out of me. Kind of ruined his mod...

 

And of course, I added in getting pictures when using the Interact feature.  It's a no-brainer to add that.

 Yeah... one would think it was a no-brainer but so many modders overlooked such a great, simple and obvious improvement.