I was checking tags in various places, and a place I have most issues with is the rest job. It uses some trait based selection of lines and pictures, which is not a bad idea, but in current implementation it results mostly in just showing profile pics (due to lacks such pics) to a point, where "rest" tag category (which is made for this) is only very scarcely used - and that just doesn't look very good.
There are some great texts (but some weird too) and situations, but I would like to achieve a bit better matching with pictures somehow.
Also some of rest pics have things that could never be trait dependable, like taking a walk in a park, sleeping... so adding some picture based texts can work there. (and, if girl have "reading" a book picture, why she have to be smart to display text that she is reading a book?)
Maybe we could use some sort of reverse technique, randomly selecting a "rest" picture first and then display text based on what other tags that selected picture have...
I would like to put some effort into this, but figuring out a good logic for this is probably a bit too much for me...
May I ask about your option there?
Ghhm... I wouldn't say that I vividly remember that code, it's very old but maybe we could pick one of this solutions if you believe that there's a problem:
- Set self.img to rest picture at start of a job and perform checks before setting it to anything else but that (or maybe even running the traits checks).
- Perform tag checks at the same time as we check for matched trait
- Create a variable named tags and set it to the required tag instead of picking the image. Then:
default = self.girl.show("rest", resize=(bla, bla))
self.img = self.girl.show(tags, resize=(bla, bla), DEFAULT=default)
(basically a variation of first option)
There are other ways to go I expect...
I studied jobs further:
Blowjob pics are not used at all, because deepthroat, footjobs and handjobs are taking priority over them (titfuck is not used at all). As normal blowjobs pics are the majority for most girls, this leads to displaying only very few pictures repeatedly.
Problem is, that for standard"blowjob" pics.,there is no subtag to select them by it, so the game is taking then as leftovers, and never display them unless there is nothing else.
This is, more and less, repeated everywhere, for example "les" pics without secondary tags (imagine a pic with 2 girls close to each other but not doing anything yet example) are also not used.
So the question is, should we change the way we tag pictures (putting subtags everywhere? I do not mind, but I'm not the one with most girls) or could solution for this be coded in?
If not "read" tags, then maybe something alike .has_image but with option to select tags that must not be there (and excluding them later in show)?
Really? I rushed that part... but I thought that was fixed! The simplest way of fixing that issue is to add the default action to the list. The way it works is as this:
- Game checks availability of images for a number of actions.
- If a picture for an action is available, that action is added to the list.
- Game randomly picks an action from the list and adds texts/picture based on that action.
So if a default action like just "les" is added to the list (maybe even two or three times), it will make improve the situation. It's obviously not a perfect solution but it will do for now. This might get better after we create a better version of how images are tagged...
========
Otherwise, the biggest problem with this is obviously that we check images inside of the jobs method
It was simpler to code but it should be moved elsewhere and done once, at the game start. There is a very early version of that in Girls class.
