General Discussion

[Xela]

Xela, there is school_pyt in you db. It's alpha of new schools that refuses to work, most likely because I used fields for images tags as you advised.
Since Thewlis never mentioned them, I figured tags are your part after all.

I'll take a look.

*For once:
... that json file is messed up, it doesn't pass validator.

[DarkTl]

I fixed and reuploaded all my packs with untagged images. You can just delete them if you don't want to download again, it's not a big deal.

Also I added text color for elements, like "font_color": "mediumslateblue". I can't test it of course until you use it in be log.

[Xela]

I fixed and reuploaded all my packs with untagged images. You can just delete them if you don't want to download again, it's not a big deal.

Oki, I've saved validated version in my DB over your file. It should be working (courses appear but i didn't check ND images). Descriptions got messed up by the validator because you've had an missing string ".

Also I added text color for elements, like "font_color": "mediumslateblue". I can't test it of course until you use it in be log.

Oki, I'll take a look at that later. My work PC seems to be dieing so I need to figure out part for a new one before I can work on the game with clear conscience.

[Xela]

Xela, there is school_pyt in you db. It's alpha of new schools that refuses to work, most likely because I used fields for images tags as you advised.
Since Thewlis never mentioned them, I figured tags are your part after all.

This will not work properly:

Code: [Select]

            "Kunoichi": {
                "desc": "Thiscoursefocusesontrainingattackandagility.Mayalsoimproveexploration.",
                "imageTags": [
                    "ninja",
                    "battle",
                    "exercising"
                ],
                "noImageTags": [
                    "rest",
                    "sex",
                    "nude"
                ],
                "primary": [
                    "attack",
                    "agility"
                ],
                "secondary": [
                    "exploration"
                ]
            },

You either need to set mode to "any" OR:

Code: [Select]

            "Kunoichi": {
                "desc": "Thiscoursefocusesontrainingattackandagility.Mayalsoimproveexploration.",
                "imageTags": [
                    "sfx",
                    "ninja",
                    "battle",
                    "exercising"
                ],
                "primary": [
                    "attack",
                    "agility"
                ],
                "secondary": [
                    "exploration"
                ]
            },
It will do almost the same thing in both cases.

[Xela]

We'll prolly need more checks for courses... it should be easier to add now that they are objects. Slaves should not be able to do Kunoichi training but we do not have automatic system setup to prevent it.

[DarkTl]

While running game code:
  File "game/library/screens/pyt - screens - nextday.rpy", line 12, in script
    python:
  File "game/library/screens/pyt - screens - nextday.rpy", line 167, in <module>
    TrainingJob(choice(girls), school, girls)
  File "game/library/classes - jobs.rpy", line 3024, in __init__
    self.do_course(self.course.doNum)
  File "game/library/classes - jobs.rpy", line 3264, in do_course
    self.girl.stats.max[statmod] += 1
KeyError: u'dancing'

...

The very same error that was before Thewlis "fixed" schools. I conclude that he did not test the code.

[Xela]

The very same error that was before Thewlis "fixed" schools. I conclude that he did not test the code.

By his own admission, he isn't much of tester I'll take a look at it myself in 5 mins. If it is not intertwined with other code, this shouldn't be hard to fix.

*Try it now. I'll take a look at the gallery.

[DarkTl]

Well... No more errors, but schools take so much money while giving nothing... Day 48, act group 1, trn. group 2. All these days the girl was in group school.

Anyway, I pushed what I did today. The next step tomorrow is classes traits json.

[DarkTl]

        "skillPrimary": [
            10,
            50
        ],
        "skillSecondary": [
            4,
            25

These are ranges in school json. Primary skills should get from 10 to 50. Secondary from 4 to 25.
Yet

                        if self.girl.stats.is_skill(statmod):
                            setattr(self.girl, statmod.capitalize(), 2) # Training
                            setattr(self.girl, statmod.lower(), 1) # Action

Here we have +2 to training and +1 to action. Just like I had after 48 days.

Then we have actually

                # Self primary
                self.course.primary(self.girl, random=(1,20), chance=self.girl.AP*2, mult=self.course.get_scaling(self.girl), girlmod=self.girlmod)
               
                # Self secondary
                self.course.secondary(self.girl, random=(1,10), chance=self.girl.AP, mult=self.course.get_scaling(self.girl), girlmod=self.girlmod)

but I don't see them working.

I don't even want to test stats after what I've seen with skills 

[Xela]

They should get that per course or per day or per AP or per what? Skills should not gain more than 5 per day tops. It would be close to impossible to manage them otherwise.

The bit I fixed is the "super-duper" bonus, which is supposed to be very rare and requires a really good teacher to increase chances of getting it.
===
I didn't look at the stats or normal skills increases. Those ranges could not be related to "pure" skill increases at all. Did Thewlis document/explained the behavior?

***
I just got behind my laptop, going to take a look at gallery first.

[DarkTl]

As far as I see in the game, you gain nothing per day and something after the whole course. This is so expensive and useless...

 Numbers are "The amount that each primary skill changes in a lesson".  It's in school_example_json.ry.
APs don't matter, it seems, since girls have all APs in the world when I test them.

[Xela]

Update gallery screen, gonna see if a testing screen can be added before I fall asleep.

[Xela]

Pushed the updated version of gallery screen with the background and auto-resizing dark requested. This is it for tonight.

[Thewlis]

Well my internet was dead for the last 4 days. Such boredom...

I expect that it was, it would not be hard to add a

"random_images": [1, 2, n...]
or
"folder": "path"

to it if needs be.

Yes, thats where the random image thing came from. I can add in the option to set a folder to pull from as well.

Also I looked over my last changes I made a mistake with how its handling the chances to change stats/skills. I'll be fixing that now that I can actually go online again.

[Xela]

Damn (sucks about your net), Dark is trying to fill in schools with new content and testing them, at least that looked like fun