devolution

Author Topic: Fun game, but I seem to have some issues with it..  (Read 12249 times)

0 Members and 1 Guest are viewing this topic.

Offline Sarabada

  • Newbie
  • *
  • Posts: 30
Fun game, but I seem to have some issues with it..
« on: October 06, 2016, 09:18:14 PM »
Hello,

First off, I am glad to see that development on this game appears to be ongoing judging by recent posts. I previously played a bit of Blue Wind's brothels.im (as far as I can tell, both version 1 and the version 2 revamp) but eventually wanted to try something else because I felt I had 'beaten' the game. It's been quite some time since then, so perhaps it's worth revisiting, but on a whim I did some searching a few days ago and came across PyTFall here. I grabbed the v0.45 alpha off the stickied thread and went off to see how it was.

At present, it's pretty fun, and despite the similarities, I enjoyed the wider 'cast' of characters I could employ, though Blue Wind's writing and story is somewhat more immersive.

However, as I continued playing, I noticed some issues that seemed to strike me as strange: I never seemed to have enough money, and the taxes would almost always very nearly bankrupt me. I wasn't sure why, but perhaps that was simply this game being 'difficult' and I searched for ways of generating more money to cover it. I felt like doing the chain battles in the arena every day was almost the only reason I could stay afloat. I checked the balance sheet for the whole-game summary, and it did show that the arena (and item sales from that) were a large part of my income - around 2x what I got from the Brothel.

Discovering this, I wanted to try and make the Brothel itself more profitable, so I spent about two in-game months sending virtually my entire cast into training programs to dramatically boost their stats, relying on the daily arena fights as sole income during this time frame to keep me afloat until the 'investment' was done.

When everyone returned, the income generation was definitely noticeable - gross income went from about 9-12k per week up to around 30-40k per week. Still, for some reason I felt like after the taxes hit, I was only enjoying about 3k net profit every week, which seemed even less than the amount I'd make in the arena in 7 days, though still better than struggling at about 1k a week initially.

At some point, I decided to just load up all the library files in SublimeText so I could do whole-folder searches and do some digging. The first shock was that the income tax would shoot up to an astounding 45%! The second is that it seems to be 10-45% of your total income, completely ignoring all the expenses you incur naturally, which explains why there was never any real profit week to week.

To confirm my suspicions, I decided to run a test just now: I kept track of my income and expenses for one week in order to doublecheck how the numbers worked out.

In my current (first) game, I'm coming up on the end of the first year, so I tracked the last week of the year. It's Day 366 right now and I have 260k gold on hand, and enough items to push over 300k if I sold them, but I'm holding on to them as 'emergency' cash.

I also own the 10-person Brothel, the House in the City. My current staff consists of 6 prostitutes, all rank 3, 1 guard, 2 service girls and 1 stripper.

Over the course of the week I ran 1 chain fight in the arena each day (Amazon Tribe) which nets me an average of 2100 gold a day.

By the end of the week, I was informed that my taxable income for the week was 65,730, which meant I had the 30% tax rate, deducting 19,719 gold. This leaves me with 46,011 gold of revenue. The next part is property taxes of the brothel and slaves, which came to a total of 4,974 gold (3k for the house since it's 4% of 75k.) I'm now down to 41,037 gold revenue, which is still not too bad... except that doesn't take into account the expenses: In that week, my total expenses (consisting of Wages, Upkeep and Pro Cleaners) came to 35,664 gold. Once that is also deducted, I'm left with a meager net profit of 5,373 gold for the week. Even if we don't count the Pro Cleaners (since it's a service, perhaps that makes sense to pay out of your own pocket) that only comes to a total of 4,166 gold added to that net profit stat (which I'd still have to pay anyway.)

In running the calculations, it also appears that (contrary to what I had thought,) the gold you get from the arena is not taxed, as it's not considered here as part of your taxable income. The total amount of gold I got from running 7 days of Amazon Tribes fights came to 14,773 gold, not including extra gold that would come from selling the items they reward. This disparity is a bit...insane. I earned almost triple what I got from the brothel just running that chain fight. For a brothel simulator, it's strange that the best way of generate wealth is to....not run a brothel.

If I do a quick extrapolation to a higher income (say, double this data to 131k) you would still end up with roughly the same weekly profit, if not less, due to the higher tax rate then, along with the higher wage and upkeep costs you incur to presumably generate that much revenue (based on the numbers, you would have roughly another 10-13 members of staff running at an average 'upkeep' cost of ~350 gold each, which also means slightly higher property tax from using the first mansion to fit them all.)

Apologies for the length of that story, but I'm simply wondering how the heck I need to be playing this game to actually feel like I'm getting ahead with the investments I make, because it feels like the game is designed to keep you at a specific level of income no matter how well you do. The majority of my income is currently still coming from the arena and sales of the items I get there.

On this point, part of me is wishing to try and mod this income tax to make more sense: I don't want to simply reduce the tax rate, but rather have it apply the tax on the net income after taking into account expenses. On the other hand, I feel kind of stubborn in thinking 'I can make this "hard mode" work!' particularly because I am still generating gold... just really slowly. However, there are a number of other issues I want to 'fix' and considering its been over a year at least (it looks like) since v0.45 alpha was released, I doubt the next version/beta will be coming anytime soon to alleviate these issues. At the same time, I don't want to have simply 'made it easier.'

At the least, I feel like if the 'taxable income' value was first deducted by the amount of wages + upkeep paid (we can leave pro cleaners out, I guess) before applying the tax rate, it would make a lot more sense, and simultaneously be not as punishing. Alternatively, you could even exempt upkeep from this step, and only deduct wages as a way of encouraging the hiring of 'free' characters - they may cost more to 'maintain,' but they mean you pay less taxes.

Using the data from my previous week, with a 65,730 gold gross income, if we deduct the 35,664 in expenses first, we end up with 30,066 net income that, if taxed at 30%, leaves us with a more reasonable 21,046.2 gold. From there, deducting property tax as normal would leave us with 16,072.2 gold - slightly better than one week of arena fights in raw gold. If we also throw in the arena income as taxable in this way, we would end up with 65,730 + 14,773 = 80,503 - 35,664 = 44,839 * 0.7 = 31,387.3 - 4974 = 26,413.3 gold net income (as opposed to 16k + 14k = ~30k using this proposal if it wasn't taxed, and 14k + 5k = ~20k in the existing system.) As it stands, it really feels like I might as well just shut everything down, live alone in the shack that I only have to pay 200 gold a week for, generate income through the arena, and basically end up about the same as currently with a brothel.

I could theoretically push the rank 3's up to rank 4 and even rank 5, but my brothel currently does not have enough reputation to draw in the higher ranking customers, and I'd end up starting to turn the beggars away, which based on the code, will tank reputation quickly as they badmouth us for turning them away. The text in the code claims the damage would be 'insignificant' but it looks like it's a 50% chance to reduce reputation. It's only by 1, but this leads to the next issue: I can't reliably raise the brothel's reputation.

Fame is apparently quite easy to do, but reputation... So far I've only found that service girls working the bar will boost it randomly by +1. The problem, though, is the stripper, and the amount of fatigue the combined workload causes. I have two service girls (each with over 80 Charisma and Service, as well as 20-40 agility, which are the breakpoints I found in the code) trying to share the load, but the single stripper (75 Charisma/Strip, maxed reputation, unknown fame since that stat isn't listed) completely inundates both of them with 40+ clients. The very moment I set them to service alongside the stripper, both immediately max out on fatigue. Sure, Sakuya can handle most of them and even get something like 3k gold all at once, but then they're out of commission for the next 2-3 days recovering fatigue while I pay her 600 gold a day in wages. This means my reputation is stuck at like 15. This is also the reason I have to rely on the Pro Cleaners so much: my service girls are literally never available to clean. I'm scrambling to find more service girls, but none exist in all the girls I've talked with, so I'm going to just have some of the prostitutes change jobs over to service girl when I move to the first of the three mansions. This also means that 50% chance of -1 reputation is terrible for me.



Logic and theorycrafting aside, I would like to ask if it would be okay to ask here for some help when it comes to making these changes. I'm sure you guys have already gone over balancing for the next version of the game, but I imagine it's a long way away still, so I want to make what changes I can to 0.45a so I can enjoy it more in the meantime. (I poked at the character pack stickies, but I'm under the impression that they won't work for this version? Some are also missing data files.)

I assume I can simply edit/make changes to the *.rpy files in the library folder. Unfortunately, I don't really know Python and its syntax, so that's where most of the help I'll need is. I've made mods for Civilization V which uses Lua instead; I never did anything for Civilization IV which I believe used Python. The gist is that I can figure out the logic and rough code, but I'll need some guidance on the proper syntax, and what data I can call from the game.

Alongside this, I feel I want to 'fix' a few other niggling issues I have with the game's numbers, in no particular order:

  • Guards are... very awkward. They hardly earn any experience for what is supposed to be a very important task. They have some gains, but pretty much only when they manage to successfully put down an aggressive customer. This doesn't seem to happen anymore in my game when my security rating is at 1000, so they end up just twiddling their thumbs forever gaining 20 experience every couple days.
    • For a task like security, I feel they should get some experience for every customer that arrives in the brothel - they have to presumably clear everyone before they can head inside, and then patrol routinely, rather than sit in a cubicle until someone calls for help.
    • Optionally, they could have a very small chance of 'confiscating' illicit items from customers, to act as a perk for getting a guard early on - This chance would decrease per-customer as brothel reputation rises (I imagine it as people take the establishment more seriously.) This guard activity could also provide a bonus to said reputation.
    • Additionally, when their assistance is required by the staff, they should be able to try and peacefully defuse the situation first: A check of their Charisma + Character (+ Intelligence + Refinement?) should have a chance of talking them out of it. If that fails, a check of their Character + Constitution should have a chance of getting them to back down as well before they resort to checking for a fight. This would allow the raising of stats on a guard to be meaningful (as right now my guard is just a walking attack+defense stat.) They could then apply a hefty fine to the customer for causing issues when they are successfully defused, similar to how you get gold when the guard 'wins' the fight.
  • Strippers also feel like they get the shaft for experience gain. Their primary purpose here is to attract customers into the brothel, so I feel their success should be measured largely in how many people they managed to draw, long with their satisfaction, but if I'm reading the code correctly, their experience is currently only calculated with respect to their own stats.
    • Their tips I feel could also use some adjustment to account for client satisfaction divided by their reputation/fame. (In other words, people should tip a bit more if they weren't expecting anything due to low rep/fame but got a very good show, but on the other hand, they won't be as generous if the stripper is known for putting on great performances regularly anyway.) This probably isn't quite as important considering their role, though, as they're mainly there to draw people into the other services.
  • Service girls apparently have a bonus to the number of clients they can manage depending on their agility, but that stat seems to not really be used anywhere else.
    • Agility should not only be the measure of how swift one is, but also how well they can weave through crowds - For this, I feel agility should additionally reduce the amount of fatigue they generate servicing each customer. As it currently stands, I think I kind of shot myself in the foot because raising their agility to rake in more gold/customers means their fatigue instantly goes from zero to 300.
    • At the same time, refinement should reduce the amount of dirt generated - more grace means less spilling...maybe? Or perhaps roll these two together into a single modifier for both fatigue and dirt.
    • Along these lines, I feel agility should help Strippers too (since it is a dance-related skill) but their fatigue generation seems quite low compared to the service girls, so perhaps only dirt reduction..
    • In terms of cleaning, since service girls are also responsible for that, it looks like agility already factors into how much they can clean, but as above, it should also reduce the overall fatigue generated by this (presumably, being more agile and dexterous, you would have an easier time reaching certain places.)
  • Constitution should be a factor in determining how much fatigue the girls recover when they rest, alongside the garden upgrades and such.
  • For the rank disparity check, I feel rather than it being a flat penalty, it should scale depending on the amount of the disparity, and the customer's own rank.
    • For slaves, instead of a flat -10 Joy, it would be less if it was 'only' 1 rank beyond what they want, but get worse as the rank disparity grows.
    • For girls rejecting the customers, instead of a random 50% chance to lower the brothel's reputation, I feel it should be a 1-in-4 chance of -1 for the beggars, 1-in-5 for peasants, 1-in-6 for merchants, etc. as higher ranks would probably have too much pride to want to tell people they were turned down at a brothel. At the same time, it might also have the same chance to provide +1 instead, as people may recognize that your establishment is kind of exclusive.
    • I haven't quite figured out how I want to scale the customer-rejecting-the-girl bit, though.
Sorry for the super long post, but I had a lot of comments I wanted to put down, lol.



As an aside, I did notice that the main hall upgrade is broken in the code, assuming I'm reading it correctly:
Code: [Select]
elif self.brothel.upgrades['mainhall']['2']['active']:Is written twice in the logic, so I believe if you only build the first main hall upgrade, it will never provide the prostitution payout bonus of 1.1, as you can only ever get 1.2 at the earliest with two upgrades.
« Last Edit: October 06, 2016, 09:43:30 PM by Sarabada »

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6881
  • "It's like hunting cows"
Re: Fun game, but I seem to have some issues with it..
« Reply #1 on: October 06, 2016, 09:41:27 PM »
As an aside, I did notice that the main hall upgrade is broken in the code, assuming I'm reading it correctly:
Code: [Select]
elif self.brothel.upgrades['mainhall']['2']['active']:Is written twice in the logic, so I believe if you only build the first main hall upgrade, it will never provide the prostitution payout bonus of 1.1, as you can only ever get 1.2 at the earliest with two upgrades.

It's possible. The trouble is that this code has been completely rewritten and I can't even revert to it because we went from mercurial to git at some point with part of project history lost.

=======================>>>>
To play without arena grinding, you need a good girl (usually a slavegirl) to start with. With a lot of constitution... She should get 3AP per day instead of two. If she doesn't, a couple of days in school should fix that. With that she should start earning a bit of cash. Decent items, training dummy till it's no longer useful and stuff like that will gradually increase profit, in the meanwhile a free girl can be talked into joining the brothel.



Most of the other stuff is no longer applicable to the working dev version, game looks similar but there is too much new logic with parts of the game completely rewritten for anything from the Alpha release to matter for upcoming Beta.
Like what we're doing?

Offline Sarabada

  • Newbie
  • *
  • Posts: 30
Re: Fun game, but I seem to have some issues with it..
« Reply #2 on: October 06, 2016, 09:56:21 PM »
Oh wow, didn't think I'd get a response so quickly, haha.

I was wrestling with this forum's formatting to make that wall of text slightly more readable, but it looks like you snuck in a response while I was doing that.

I understand that most of these points and balance issues are no longer applicable to your development, but I can't gauge when we'd be able to play said beta, so in the meantime I was thinking of tweaking up the alpha to fix some of these issues I have - some of the stuff really bugs me since it doesn't make much sense, or isn't very fair. If the beta is only a couple days or weeks away, I'll probably wait, but if it'll be months or another year, I'd probably just edit the alpha until then so I have something to play in the meantime.

As far as the starting suggestion goes, I'm quite far from that point right now.
It's Day 366, so I just completed the first year of gameplay, and am ready to move on to the first of the large mansions, but I felt it's taking a lot longer than it should be due to the income tax rivaling my upkeep on 10 girls leaving me with very little if I don't spam the arena.

FWIW, every single one of my girls right now has enough constitution for 3 AP, with two having 4 AP already. 8 of 10 are also slaves, Sakuya and a random Leafa character being the only two 'free' girls I've hired so far. I do, however, have 5-6 other 'free' girls at maxed disposition waiting for me to hire them when I make the move to the mansion, though. The slave market no longer has any attractive options (too high upkeep cost for too low stats.)

Also, one thing that I haven't been able to track down: The random Leafa character is and has been my only guard for a long time now. The problem is that very randomly she will just end a day with less than 5 health, even though she was not involved in any guard events. It doesn't even appear in the section that details what the girls did each day - it just suddenly appears in the summary page when it lists the wage she was paid. I've gotten used to just assuming she accidentally stabbed herself and needs another potion at this point, but it's aggravating that I have no idea why it's happening. Could it be the 'silly' trait she has?

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6881
  • "It's like hunting cows"
Re: Fun game, but I seem to have some issues with it..
« Reply #3 on: October 07, 2016, 02:08:27 AM »
Also, one thing that I haven't been able to track down: The random Leafa character is and has been my only guard for a long time now. The problem is that very randomly she will just end a day with less than 5 health, even though she was not involved in any guard events. It doesn't even appear in the section that details what the girls did each day - it just suddenly appears in the summary page when it lists the wage she was paid. I've gotten used to just assuming she accidentally stabbed herself and needs another potion at this point, but it's aggravating that I have no idea why it's happening. Could it be the 'silly' trait she has?

They do try to train if everything is quite in the building, there should be a report about that. I don't recall any Silly trait having such an effect.
Like what we're doing?

Offline Sarabada

  • Newbie
  • *
  • Posts: 30
Re: Fun game, but I seem to have some issues with it..
« Reply #4 on: October 07, 2016, 11:18:12 AM »
They do try to train if everything is quite in the building, there should be a report about that. I don't recall any Silly trait having such an effect.

Right, that makes sense, but I can't figure out why it's happening.

According to the code, the function post_job_activities() says at the bottom, when I have no guard buildings:
Code: [Select]
                    if dice(50):
                        self.txt.append("She spent time relaxing. \n")
                        #display rest only if they did not fight
                        if not self.girl.guard_relay['bar_event']['count'] and not self.girl.guard_relay['whore_event']['count']:
                            self.img = "rest"
                        self.girlmod['fatigue'] = self.girlmod.get('fatigue', 0) - random.randint(7, 12) * self.girl.AP
                        self.girl.AP = 0
                    else:
                        self.txt.append("She did some rudamentory training. \n")
                        self.girlmod['attack'] = self.girlmod.get('attack', 0) + random.choice([0,0,0,0,0,1])
                        self.girlmod['defence'] = self.girlmod.get('defence', 0) + random.choice([0,0,0,0,0,1])
                        self.girlmod['magic'] = self.girlmod.get('magic', 0) + random.choice([0,0,0,0,0,1])
                        self.girlmod['joy'] = self.girlmod.get('joy', 0) + random.choice([0,1])
                        self.girlmod['exp'] = self.girlmod.get('exp', 0) +  random.randint(2*self.girl.level + self.girl.AP*2, self.girl.AP*2 + 4*self.girl.level)
                        self.girlmod['fatigue'] = self.girlmod.get('fatigue', 0) + random.randint(15, 20)
                        self.girl.AP = 0

None of that deals with health at all, so I'm stumped as to how to prevent her from, uh, stabbing herself.

It just happened again, too. I attached two screenshots of what I see, and these are the only two places she even appears in. Nothing hints at her being damaged in any way, yet her summary page tells me she just randomly lost 111 health for no reason, leaving her with 2 left. Curiously, she is the only character I've had such issues with. Whether it's just her, or related to guards somehow, I'm not sure yet. I'm currently training a second warrior to help her guard in preparation for the move to the Mansion on the Main Road, so whenever she's ready I can have her guard as well and see if she gets afflicted with the same tendency to randomly stab herself.

For reference, the game claims my security rating is 1000 out of 1000 with just her guarding at 20% presence. Also, her traits are currently: Not Human, Puffy Nipples, Long Legs, Abnormally Large Boobs, Magic Gift, Silly, and Well-Mannered.

I guess for now I'll toss her another potion...

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6881
  • "It's like hunting cows"
Re: Fun game, but I seem to have some issues with it..
« Reply #5 on: October 07, 2016, 03:30:08 PM »
Looks like she's been through hell... Noone reported anything like that and we got all sorts of bug reports from like 7 different forums.
Like what we're doing?

Offline Sarabada

  • Newbie
  • *
  • Posts: 30
Re: Fun game, but I seem to have some issues with it..
« Reply #6 on: October 08, 2016, 10:35:12 AM »
No kidding. But then I guess historically I have been one to run into these seemingly-random or edge-case issues/bugs. I've done lots of testing for other things (both other games as well as my own mods) so I sometimes try to push things past what is reasonable... Unfortunately, I don't think I remember actually trying to do that here. It's still happening even after restarting the game, and I have not yet modified anything as I'm still looking over what I would change and continuing to play it as-is, so I'm at a loss. I think I'll just have to accept it as the game making me play 'extra-hard mode' with an additional line of expense of potions strictly for Karen-the-self-stabbing-guard. I tried to track it but I couldn't find any pattern to it yet.


On that note, as more of my brothel workers finally hit 4 AP (5 out of 6 of them do now) my gross income managed to hit over 100k (and being slapped with the new 40% tax rate as well) but leaving me with slightly more since my upkeep hasn't changed drastically for them. I'm in a strange position now where I have 550k gold, but I'm still "preparing" for the 175k mansion because the new workers are taking forever to train through the school courses. I could probably skip right to the 500k mansion at this point, but I currently don't even have enough total workers hired (let alone trained) to fill 25 slots, much less 45. This will be interesting...

Offline Sarabada

  • Newbie
  • *
  • Posts: 30
Re: Fun game, but I seem to have some issues with it..
« Reply #7 on: October 09, 2016, 12:05:35 AM »
Well, so much for running unmodified; I ended up having to make an edit to fix a bug in order to continue playing.

I moved into the 175k mansion, sold the 75k house, transferred all my staff over and began operations. I'm not sure if that was the catalyst, or if i was simply checking more closely because of the new brothel, but I noticed at this point that the staff were no longer getting the bonus message about guests being crazed from the stripper. Poked at the code and found a bug (or more likely, an oversight) in the function, so I inserted a statement to print out the value of the 'satisfaction' rating it was trying to use.

Turns out the value was 108 (152 at some point) and the code had no 'else' clause to deal with it - the function's logic 'ended' at an 'elif <= 100' check, with no way to deal with values larger than 100. I'm not sure if the intention was to add in another higher tier/multiplier beyond 1.5x, but for now, changing that condition to simply '> 75' has it applying the 1.5x multiplier I'm used to again. Also fixed the mainhall thing while I was there.

I think for now I'll keep plugging along while I look over the code to see how to add my desired changes. I probably got too used to it, but I am kind of missing Civ 5's Firetuner utility which let me run isolated chunks of code live, along with giving me a way to traverse through tables to see what data I had to work with. For one, each girl appears to have a 'fame' value, but I can't be sure if it's as simple as mirroring reputation and adding 'chr.fame, chr.get_max("fame")' in order to reveal this value.

And a final note on Karen the emo guard: I can't figure it out and I've completely given up. I relieved her of guard duty and simply let her rest when I moved into the new mansion and placed Alice Margatroid in her place. Alice has so far not had any issue with stabbing herself, while Karen has...somehow managed to stab herself while she's resting in the gardens..twice.

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6881
  • "It's like hunting cows"
Re: Fun game, but I seem to have some issues with it..
« Reply #8 on: October 09, 2016, 06:51:57 AM »
The version presently posted was not build by us but I checked it (long time ago) and it looked like the final, patched Alpha release. We've spent two or three weeks re-balancing and fixing bugs after the initial release until there were none reported. Some people claimed to play for over 1k days till they had all buildings and beaten everything there was possible to beat.

You can post your fixes to Alpha thread, it will be some time till we can release again so it could be useful to others.
Like what we're doing?

Offline Sarabada

  • Newbie
  • *
  • Posts: 30
Re: Fun game, but I seem to have some issues with it..
« Reply #9 on: October 09, 2016, 11:16:27 PM »
When you say it was not built by you, do you mean you took over development after the alpha was released by someone else?

I'll probably look at doing that, but right now I'm going through and adding some quality-of-life additions for myself before I do so. In addition to fixing the reversed values for brothel fame and reputation gained via advertising and some of the more commonly-seen typos, I've been going through the code to highlight the important pieces of information I want readily visible from the next-day summary screens with colors.

For example, having to go through 24 pages currently of "guest wanted someone with so-and-so trait but did or didn't find one" it's difficult to do quickly when it's in a huge chunk of other text, especially when more pages are coming. I've gone through the text and created highlighting where the requested trait (or no preference) text is cyan, and then the text that says they found someone is green, while the text that says they didn't is in pink, so as I'm flipping through the pages, I can very rapidly see which traits I need to look for.

I've made similar highlights to other pieces of data I want to quickly look for (whether I overpaid or underpaid girls appear in different colors, etc) but I am wondering if there is any particular restriction or limitation with this system. I ask because I did just run into an issue that caused the game to crash repeatedly. Through testing, I narrowed it down to this one line of code/text that prints when a course a girl is taking ends.

The relevant section of the code is this:
Code: [Select]
            # End courses and remove girls
            for course in self.active_courses:
                if course['Days Left'] <= 0:
                    for girl in girls:
                        if girl.mech_relay['courseid'] == course['id']:
                            txt += "Course that %s is attending is at it's end! "%girl.name
                            girl.mech_relay['courseid'] = None
                            girl.action = None
                            girl._location = hero
                    self.active_courses.remove(course)

With the relevant line being this one inside the second for-loop:
Code: [Select]
txt += "Course that %s is attending is at it's end! "%girl.name
When I tried to add coloring to that line, the game gave me a 'string index out of range' error.

The line in question with edit:
Code: [Select]
txt += "{color=[royalblue]}The course that{/color} {color=[lawngreen]}%s{/color} {color=[royalblue]}is attending has ended!{color}\n "%girl.name
I thought perhaps it was sending too many color changes all at once and perhaps it couldn't handle it, so I simplified it to the following to just make the entire line blue:
Code: [Select]
txt += "{color=[royalblue]}The course that %s is attending has ended!{color}\n "%girl.name
Unfortunately, this also caused the string index out of range error.

After a bunch more testing and trial and error, I have this line:
Code: [Select]
txt += "\nThe {color=[royalblue]}%s{/color} that {color=[lawngreen]}%s{/color} was attending {color=[royalblue]}has ended!{/color}"%(course["action"], girl.name)
This line has a few changes, notably that I added a second string replacement to give me the name of the course, rather than just the generic word 'course.' However... THIS seems to work, even though it has just as many color codes as my first attempt, while the previous one with one color code gave me an error. Unfortunately, I have no idea why this is, and would love for some feedback as to what exactly I ran into, and how to avoid it in the future.

Edit:
I should note that that final line looks a bit ugly because of the random breaks with 'uncolored' text, but it seems like they must be there. If I try to expand the surrounding navy blue coloring sections to cover them, as with the first attempt, I once again get the string index out of range error.

For reference, on the screen that this was to display to when I was testing, 8 girls' courses were ending, so it had to print that line 8 times (with different names, of course.)
« Last Edit: October 10, 2016, 12:32:06 AM by Sarabada »

Offline oratorio

  • Newbie
  • *
  • Posts: 7
Re: Fun game, but I seem to have some issues with it..
« Reply #10 on: October 10, 2016, 09:12:47 AM »

The line in question with edit:
Code: [Select]
txt += "{color=[royalblue]}The course that{/color} {color=[lawngreen]}%s{/color} {color=[royalblue]}is attending has ended!{color}\n "%girl.name
Code: [Select]
txt += "{color=[royalblue]}The course that %s is attending has ended!{color}\n "%girl.name


In both of these, you are missing a "/" to end the last color section. (Shouldn't it be "{/color}?)

Offline Sarabada

  • Newbie
  • *
  • Posts: 30
Re: Fun game, but I seem to have some issues with it..
« Reply #11 on: October 10, 2016, 09:39:35 AM »
You know, I could have sworn that I double and triple checked that all the tags were closed properly; I even loaded it up in WinMerge so I could check against the diff versus the original. But, as you say, there it is in my code sections I posted. I guess that's what I get for trying to do this after midnight while I'm sleepy, on top of there being a lot of color tags I added to the various text lines. At the least I'm glad I'm not perhaps running into any sort of 'maximum color codes' limitation, but I still feel quite dumb, haha.

Thanks for the catch!

Offline Xela

  • Global Moderator
  • *****
  • Posts: 6881
  • "It's like hunting cows"
Re: Fun game, but I seem to have some issues with it..
« Reply #12 on: October 10, 2016, 02:24:56 PM »
do you mean you took over development after the alpha was released by someone else?

No. We've released through mega at first. Even after all of the brilliant efforts of our own tester Jaeke at that time, loads of errors and imbalances were reported, we've fixed them by releasing patches through DropBox. After there were no more errors reported, we went on with the development as someone released a torrent with the original code + the latest patch. After a while Mega went down, either as a service or just the account so there was no version to play at all. Someone came up with a new release claiming that it was a version with the final patch, that is also a version that we host at the moment but it wasn't patches by us so there is no sure way of knowing cause all of that was happening like an year after release and we didn't pay that much of attention to it.


- Dev version comes with a complete overhaul and single style of GUI
- New complex module called SimPy to handle Jobs and Businesses.
- Loads more skills for BE
- Complete BE rewrite (we're no longer using Jake's BE design)
- Loads more interaction options
- Simulated Exploration module
- Classes for Characters
- Auto-Buy/Equip for Character
- More story/quests/events
- More locations
- More items
- More ways to earn money
- Loads of new logic and I prolly forgot a few things...

We need to wrap up a few things, finish the new Simulated Exploration module and turn the whole thing into a coherent game design. I recon at least a couple of month of work... I am still hopeful we can get it done asap but that just keeps kicking as in the butt :D Dark for example decided (out of nowhere) to add a simple fishing minigame... we tend to do sh!t like that out of blue which doesn't help progress :D
Like what we're doing?

Offline Sarabada

  • Newbie
  • *
  • Posts: 30
Re: Fun game, but I seem to have some issues with it..
« Reply #13 on: October 10, 2016, 03:12:22 PM »
Ah, thanks for the explanation. That seems a bit of a crazy development cycle, haha. Those new features sound pretty interesting, and yeah I can see how it may take a while longer. I've run into the same situation developing my Civ mods as new ideas keep popping up -- and I'm the sole developer!

On request though: Let us double-click to equip items!

Either way, hopefully that means my updates to the alpha won't be completely useless or lost that quickly. We can probably enjoy them for at least a couple months more.

With that, after some trial and error (I really hat that I don't know/understand how to look up table data in Python as compared to the relative ease I can do so in Lua) I have a working prototype of the next quality of life change I wanted: Updating that stupid PyTFall course list to actually differentiate between the different courses when multiple duplicates appear. I'm still tweaking it, and the code is a bit messy because I don't know how to streamline it much, but here are some screenshots.

Differentiation is a bit basic right now, but I think it should suffice for now. I'll post the code for help streamlining when I test it a bit more for stability and unintended side effects.
« Last Edit: October 10, 2016, 03:17:36 PM by Sarabada »

Offline oratorio

  • Newbie
  • *
  • Posts: 7
Re: Fun game, but I seem to have some issues with it..
« Reply #14 on: October 10, 2016, 04:27:15 PM »
No. We've released through mega at first. Even after all of the brilliant efforts of our own tester Jaeke at that time, loads of errors and imbalances were reported, we've fixed them by releasing patches through DropBox. After there were no more errors reported, we went on with the development as someone released a torrent with the original code + the latest patch. After a while Mega went down, either as a service or just the account so there was no version to play at all. Someone came up with a new release claiming that it was a version with the final patch, that is also a version that we host at the moment but it wasn't patches by us so there is no sure way of knowing cause all of that was happening like an year after release and we didn't pay that much of attention to it.


Is the version you are sharing the one I provided? If not, what I have was obtained from your Mega share before it went down. I remember the search for a copy when it went down.


The version I have has a file name:
PyTFall-0.45-Alpha-pre-patched.zip
and date (from the log.txt file in the zip):

Thu Mar 27 15:03:04 2014
Windows-7-6.1.7601-SP1
Ren'Py 6.17.3.327
PyTFall 0.45 Alpha