Review is to improve readability, ensure possibility of future development and fix rookie mistakes. Not for rewriting the game.
As far as I understand, we talking about texts here mostly, not actual code. And not even all texts, but only some of them.
Even I probably could rewrite them a bit (providing that I know where are they).
I will not be around for the better part of the day, can you guys discuss and tell me what you think about the min/max range for stats based on "main" traits mechanism? I am only gonna go that way if one of handles the xml/json.
I gave it some thought. While it solves several problems, it gives us a new one.
For example, silly limits it to 100. Let's say, an average girl reaches 100 int by lvl50. And that's it, there is little point in gaining more levels if by 50lvl she will have max possible int anyway, because she is not genius and will never be.
Same could be said about any stat, except refinement.
Thus, maybe we should somehow adapt stats to this system. Maybe even use Cherry's idea about limiting levels.
Or never, ever limit skills by that system, so at least you could continue to gain levels for them and have 1000 sex by lvl 200 or something like that.
For races, we just need them for reasons I've mentioned above, if Dark wants to make them matter beyond that, I don't mind. Like mentioned before, to me it seems redundant.
I like Cherry's idea about effects. They don't have to be hardcoded and do something very unusual, like traits effects (it would be too much mess), I'll just create a json. Like elven blood or celestial origin effects, for example.
What required from you is a field in girls data files for these effects, and some place for them in gui, probably just with other effects.